Printable View
@simon1066, your analysis is spot-on. There was apparently some reason, historically, that the clause was added but I can't justify it. I see no reason to exclude image-generation from products that can't be added to the cart.
GitHub issue created for tracking: https://github.com/DivaVocals/zen_Im...ler/issues/170
Me neither, I'll comment out that code. Thanks.Quote:
Originally Posted by lat9
Check the change I posted on GitHub; it's not sufficient to just comment that code out, since the results are passed to that function and will generate (at a minimum) a PHP Notice for a missing variable.Quote:
Originally Posted by simon1066
Got it. Will do.
I've just submitted v5.1.4 of IH-5 for review by the plugin moderators and will post back here once it's available for download.
This release contains changes associated with the following GitHub issues:
#133: Correcting various PHP Notices.
#161: Correct undefined-constant warning on initial install.
#163: Admin edit-product link broken on zc156.
#168: Correct "Unable to determine the page link" after adding an image.
#169: Correct handling of the "Force canvas" setting.
#170: Correct admin image-generation for products that can't be placed into the cart.
Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2169Quote:
Originally Posted by lat9
ZC v1.5.6c
Fresh Install
Mods: MySql Backup / IH 5.1.4 / CK Editor / Zen Magnific
Everything is working fine, but I'm getting the following error on the log: :lookaroun
Code:[20-Jul-2019 18:09:35 America/Chicago] Request URI: /ADMIN/keepalive.php?_=1563663915332, IP address: XX.XX.XX.XXX
#1 require(/home/ACCOUNT/public_html/ADMIN/includes/languages/english/extra_definitions/image_handler_extra_definitions.php) called at [/home/ACCOUNT/public_html/ADMIN/includes/init_includes/init_languages.php:48]
#2 require(/home/ACCOUNT/public_html/ADMIN/includes/init_includes/init_languages.php) called at [/home/ACCOUNT/public_html/includes/autoload_func.php:48]
#3 require(/home/ACCOUNT/public_html/includes/autoload_func.php) called at [/home/ACCOUNT/public_html/ADMIN/includes/application_top.php:171]
#4 require(/home/ACCOUNT/public_html/ADMIN/includes/application_top.php) called at [/home/ACCOUNT/public_html/ADMIN/keepalive.php:9]
--> PHP Warning: Use of undefined constant IH_VERSION - assumed 'IH_VERSION' (this will throw an Error in a future version of PHP) in /home/ACCOUNT/public_html/ADMIN/includes/languages/english/extra_definitions/image_handler_extra_definitions.php on line 25.
When you navigate to Tools->Image Handler5, does the version display properly (and without that warning generated)?
Image Handler5
Version: 5.1.2
The search box is not working. It is coming back with the admin template but blank where you would expect something to be.
The edit product button is not working. Same condition as above.
Also, I have a picture (ref:10233) that appears valid but is showing up with the new Image(s) as invalid. Is it possible to clear the cache for one image instead of all to see if the problem gets fixed?
The most recent version is 5.1.4. Give that a shot to see if your issue(s) have been resolved in that release.