Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Originally Posted by qhome
I also got the add to cart stuff fixed up. cleaned up a little.. but still needs a final cleaning.
Hey Q-
Can you detail what has been fixed and which are outstanding issues and/or on the latest to do list? Unless the issue of the add to cart box not showing up within an assigned tab is really repaired I wiill hold off installing the new beta as I have done extensive changes to the template file and merging can be a very time consuming ordeal.
With the new version is it also possible to render the Add to Cart box ABOVE the tabs? I think this is where I need it to go for some products. So I actually need the option of putting it on a tab or above the tabs).
Quote:
Originally Posted by qhome
Woody, I have been workin on your "Global Products Description Tab" for a few hours now and I'm really close but it's a real sunavagun. I will try to release it with the next beta
Can you explain exactly what you plan for that tab. That is, how does the logic work?
The ovearll tabs logic is getting advanced with all the nested if else logic it is difficult to test all the possible permutations. That is understanding what happens if the tab is a integrated into the system (core), or it is set by hardcoding a tag, and at the same time what happens if global is set for the core tabs. Observing some unexpected results on v.3.1b.
Quote:
Originally Posted by qhome
For style data, I will try to help you re-position that qty box as I dont have that on my site so im not sure what it looks like by default.
So the quantity box is not included in the "Add To Cart box"? (the add to cart button and the qty box makes up the Add To Cart box). The Qty box is really a must have.
If you happen to get it figured out and put up a demo with the Qty box included please let me know the URL.
Woody
Re: Tabbed Products ''LITE'' version - Delimiter based
ghome,
I still get the same errors in IE even with the new jscript. The error in product page disappeared after i uploaded the new tpl_product_info. The error in the index page is still there even will all the new files.
Re: Tabbed Products ''LITE'' version - Delimiter based
OK I see readme history shows:
Quote:
07/17/2006 - v3.1(beta 2) - qhome
- fixed javascript null errors.
- fixed and merged Add to cart, Attribute Options, Product details (Stock, Model, etc), and Qty Discounts. Now all on same tab.
With this known I will redefine my question a bit.
I don't use the product details or qty discounts. And only my softgoods (downloadable products) have attributes (and just a single attribute).
So if I understand the updated readme correctly, in my case, the Add To Cart button would display all alone by itself on one tab? (I think you recently stated the quantity box does not show up correctly yet with the Add to Cart button, in the new beta anyway).
Or can the Add To Cart box (with quantity edit field) be placed on the first tab along with some product description text?
And/or can the Add To Cart box be placed above the tabs?
Need to know above before I decide or not to install/merge new beta version template file.
Did you receive the PM with code and javascript to insert into /admin/product.php file?
Woody
Re: Tabbed Products ''LITE'' version - Delimiter based
LOL .. i see i've thoroughly confused you all! And in my haste to get this out before noon (I had a half day at work and wanted to get this out) I seem to have forgotten to upload the new javascript file. So lets see if we can straighten this mess out.....
Quote:
Originally Posted by Woodymon
Can you detail what has been fixed and which are outstanding issues and/or on the latest to do list? Unless the issue of the add to cart box not showing up within an assigned tab is really repaired I wiill hold off installing the new beta as I have done extensive changes to the template file and merging can be a very time consuming ordeal.
The add to cart stuff is totally fixed. THe "cleaning up" was in reference to general tabbing and commenting, but for the most part that is also pretty good. Keep in mind tho that these are betas and you shouldn't be doing too much to merge them around or use them on live store. I am first trying to get a feel for what the majority wants in terms of features and straighten them all out first.
Quote:
Originally Posted by Woodymon
With the new version is it also possible to render the Add to Cart box ABOVE the tabs? I think this is where I need it to go for some products. So I actually need the option of putting it on a tab or above the tabs).
As you mentioned above, the Zen-cart team commented their code pretty good and I've left their comments in. So its really more of a personal customization, not related to the tabs. If you want to move the <!--bof Add to Cart box--> contents around then feel free to do so. Simply disable it from being on the tabs and it will spawn in its normal core spot. Then move that code to the top by the main image and it will be up there. If you need help with that, I can show you, and I've done it myself to test it.
Quote:
Originally Posted by Woodymon
Can you explain exactly what you plan for that tab. That is, how does the logic work?
Based on what you mentioned previously, I set it so that if you set the Global Products Description variable to TRUE, then it autocreates a Product Description tab and puts the product description in that tab. I have it working fine, its just the combination of that and image inside the tabs and add to cart in the tabs that needs to be tweaked.
Quote:
Originally Posted by Woodymon
The ovearll tabs logic is getting advanced with all the nested if else logic it is difficult to test all the possible permutations. That is understanding what happens if the tab is a integrated into the system (core), or it is set by hardcoding a tag, and at the same time what happens if global is set for the core tabs. Observing some unexpected results on v.3.1b.
Not sure what you are seeing on your site. But the only "odd feature" was this:
If there IS at least one custom tab, and the Add to Cart variable is true, then it will add that add to cart button to the first tab automatically. If there is NOT at least one custom tab, then the Add to cart stuff will autocreate its own tab, and it will always be the first tab, since the main product description will not be in a tab and will be above the tabs. By custom tabs i mean you actually put <!--%Tabname%--> into the actual product description in the admin area. This was done so that no matter what, customers could see your add to cart button without having to navigate around.
Quote:
Originally Posted by Woodymon
So the quantity box is not included in the "Add To Cart box"? (the add to cart button and the qty box makes up the Add To Cart box). The Qty box is really a must have.
I really confused you here.. the "Quantity Discount" box is what styledata is talking about. See his site has a table that shows if you buy larger quantities, you get more of a discount on price. so 1-5 for $5 each, 6-10 for $4 each, 11+ for $3.50 each. he wants that table to be at the top so I told him I'd help him put it there as a side item, but the actual TabbedLite contrib would keep all "Add to Cart" functionality as a whole including the Add to cart button, the Product details (model #, stock, etc), the Attribute options, and the Quantity Discount table just as they are laid out in the core Zen-Cart.
Quote:
Originally Posted by Woodymon
I don't use the product details or qty discounts. And only my softgoods (downloadable products) have attributes (and just a single attribute).
So if I understand the updated readme correctly, in my case, the Add To Cart button would display all alone by itself on one tab?
Yes.. its the exact layout that Zen-Cart core uses. So if you ahve them disabled in the normal admin area, then they will be disabled here as well.
You can see it at my demo site.
--------
I've attached the updated javascript changes to fix the errors in IE.
Re: Tabbed Products ''LITE'' version - Delimiter based
Forgot one...
Quote:
Originally Posted by Woodymon
Or can the Add To Cart box (with quantity edit field) be placed on the first tab along with some product description text?
Yes this has been possible since verstion 2.0.. read up above where i mention the "odd feature" to see how it behaves.
Re: Tabbed Products ''LITE'' version - Delimiter based
ghome,
Thanks for the new jscript. The error in the index page is no longer there, but in the product page it still show up when the header is FALSE. If you turn this header to TRUE, it disappear. I don't know why it errors when false but i would prefer to hide this header (extra image to load). Can this be deleted in the jsript or css?
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Originally Posted by Berserker
ghome,
Thanks for the new jscript. The error in the index page is no longer there, but in the product page it still show up when the header is FALSE. If you turn this header to TRUE, it disappear. I don't know why it errors when false but i would prefer to hide this header (extra image to load). Can this be deleted in the jsript or css?
Its just a logic check to see "if exists.. then do it".. Currently it doesnt check if it exists first and it just tries to do it. I will add some logic to check on all jscript parts to verify they are there first in the next release.
Re: Tabbed Products ''LITE'' version - Delimiter based
here is a fix if u dont want to wait.
find:
Code:
if ($bShowHeaders != true) {
// Hide tab header if JavaScript is available/active but they are set to false
echo ("<script type=\"text/javascript\">
<!--
document.getElementById('ProductDescriptionHeader').style.display = \"none\";
document.getElementById('DetailedSpecsHeader').style.display = \"none\";
document.getElementById('AddToCartHeader').style.display = \"none\";
document.getElementById('AdditionalImagesHeader').style.display = \"none\";
document.getElementById('ProductDetailsHeader').style.display = \"none\";
-->
</script>");
}
Replace with:
Code:
if ($bShowHeaders != true) {
// Hide tab header if JavaScript is available/active but they are set to false
echo ("<script type=\"text/javascript\">
<!--
if (document.getElementById('ProductDescriptionHeader') != null) {
document.getElementById('ProductDescriptionHeader').style.display = \"none\";
}
if (document.getElementById('DetailedSpecsHeader') != null) {
document.getElementById('DetailedSpecsHeader').style.display = \"none\";
}
if (document.getElementById('AddToCartHeader') != null) {
document.getElementById('AddToCartHeader').style.display = \"none\";
}
if (document.getElementById('AdditionalImagesHeader') != null) {
document.getElementById('AdditionalImagesHeader').style.display = \"none\";
}
if (document.getElementById('ProductDetailsHeader') != null) {
document.getElementById('ProductDetailsHeader').style.display = \"none\";
}
-->
</script>");
}
Re: Tabbed Products ''LITE'' version - Delimiter based
ghome,
The errors all gone now :) Thanks a lot!!!!!!!!
Re: Tabbed Products ''LITE'' version - Delimiter based
Hi got a strange problem and not sure if it is this or the css flyout addon.
With the css flyout menu it places the submenu links under the window of the tabs(floats under). If no tabs are used the flyout menu is fine. So it is as if the tabs have priority of display (on top) and the rest renders under.
Any ideas ?