line 35: remove commas from description (or replace with dashes).
line 34-36: insert NOW() for date_added.
line 34: change now() to NOW() for last_modified.
After those fixes to googlefroogle.sql the DB successfully patched.
Printable View
line 35: remove commas from description (or replace with dashes).
line 34-36: insert NOW() for date_added.
line 34: change now() to NOW() for last_modified.
After those fixes to googlefroogle.sql the DB successfully patched.
Attached is repaired googlefroogle.sql (for GoogleFroogle v.1.3.1)
Thanks. Fixed.
Thanks for updating Andrew.
1. So everyone should now use googlefroogle.sql in Andrew's latest version (disregard my attachment above... forum moderator please delete that post).
UPDATE:
2. However I continue to have issue with the new googlefroogle.sql
Specifically:
Note that configuration_description above contains two commas and a semi-colon, which produces errors on importing into the database (at least it does for me).Code:(NULL, 'Expiration Date Base', 'GOOGLE_FROOGLE_EXPIRATION_BASE', 'now', 'Expiration Date Base:<ul><li>now - add Adjust to current date;</li><li>product - add Adjust to product date (max(date_added, last_modified, date_available))</li></ul>', @t4, 2, NOW(), NULL, 'zen_cfg_select_option(array(\'now\', \'product\'),'),
The commas act as delimiters to separate the dB fields, and the semi-colon identifies the end of the SQL command. Maybe these characters need escaped? Maybe others don't have this issue?
I'm not SQL expert so I may be wrong on the above but the new SQL does not work for me.
If I remove the semi-colon and change the two commas to dashes, as in above description, then all is ok. At least it works for me.Code:'Expiration Date Base:<ul><li>now - add Adjust to current date </li><li>product - add Adjust to product date (max(date_added - last_modified - date_available))</li></ul>'
Not criticism just want to ensure all is ok with sql patch ;-)
3. Also if installing this new version of mod everyone be sure to upload the new /googlefroogle.php file. Although version id tag in the php file header remains the same, inspection of the file identified a new line of code (line 61):
WoodyCode:echo "Processing: Feed - " . (isset($_GET['feed']) && $_GET['feed'] == "yes" ? "Yes" : "No") . ", Upload - " . (isset($_GET['upload']) && $_GET['upload'] == "yes" ? "Yes" : "No") . NL;
When I process the SQL, I observe errors with those commas and the semi-colon. When I remove the commas and semi-colon it imports fine. But no biggy. Just thought I'd report a workaround if others observed the same issue.[/QUOTE]
Andrew, I suppose we have a language/communication barrier. Sorry if my words were confusing. I was not meaning to say there was any issue with the line of code. I was pointing out to everyone that the new version included a new line of code and thus people should be aware, to ensure they upload the new file. That was all. I have no idea why my comment would prompt you to now remove that new line of code ;-)
Sorry that I was not or cannot be any more clear. Happy holidays!
Woody
a_berezin,
Thanks for a great contribution. I've added the model number to the feed because I needed it when I use the feed for other things. I also attached the changed file.
Pete
Oops goofed I put in model (which is reserved for car stuff) instead of model_number, its changed now.
iI have just upgraded Zen from 1.3.2 to 1.3.6 and noticed that my Google Froogle feeder SQL file that had been used to install 1.3.2 was 1_2_6. I have downloaded the latest version of this MOD but I am having problems.
I have not seen an upgrade path in this thread or in the instructions and doing what I thought was obvious did not work. (Replace the old files with the new and run the SQl scripts)
When I run 1_2_9 SQl script I get the following error:
1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'id', 'model', 'false'),' WHERE configuration_key='GOOGLE_FROOGLE
in:
[UPDATE configuration SET configuration_title='Offer ID', configuration_description='A unique alphanumeric identifier for the item - products_id code.
Based on products_id or products_model', set_function='zen_cfg_select_option(array('id', 'model', 'false'),' WHERE configuration_key='GOOGLE_FROOGLE_OFFER_ID';]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.
and something similar on the 1_3_1 scripts.
Any help is appreciated.
ZEN 1.3.6
PHP 4.4.3
MySQL 4.1.14 on Windows 2003
CBO, you only get SQL errors when you do this, can I see the old sql file, I don't know where to find the old versions of googlefroogle.
Pete