Printable View
Hello,
I've installed OPC v2.5.3 on ZC 2.1.0-alpha2 with ZCA bootstrap template v3.7.3.
On one page checkout page, when no coupon is used and the coupon field is empty, I click on "Apply" and order gets created.
Is this a known issue and I've missed something in the installation process?
Thank you.
It's neither a known issue nor something you've missed. Thanks for the report. I've created this (https://github.com/lat9/one_page_checkout/issues/423) GitHub issue for tracking the change required.Quote:
Originally Posted by pishkus
... and the correction is staged for OPC's 2.5.4 release; see the issue noted above for the changes required.Quote:
Originally Posted by lat9
zencart v1.5.7d, OPC 2.4.6. Guest checkout enabled.
I just noticed that on the create_account page, the state drop-down menu is displayed, but the state field is also displayed at the same time, even US is selected as the country.
If I select another country, which does not have any states defined, then the drop down menu with the "Type a choice below..." and the state field displays, as intended.
If I then select US again, then only the state drop down menu is displayed, as it should be.
So, the first time US is selected as country, then both the state drop down menu and the state field are displayed, but the second time I select US as country its not.
Is this a known issue? Any ideas for a fix?
Attachment 20769
Attachment 20770
Attachment 20771
That's a base Zen Cart issue with the javascript/jQuery handling of the state vs. state-dropdown selection. That's been corrected in zc200 and it's difficult to see the changes from 1.5.7d since that address-handling jscript file is now consolidated for use on all the various address-gathering pages.
PHP8.1, zc 1.58a, OPC 2.5.3
I received the following intermittent warning.
Line 1644 is the followingPHP Code:[22-Oct-2024 16:11:52 America/New_York] Request URI: /ajax.php?act=ajaxOnePageCheckout&method=validateAddressValues, IP address: xxxx, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /includes/classes/OnePageCheckout.php(1644): ctype_digit()
#2 /includes/classes/OnePageCheckout.php(1456): OnePageCheckout->validateUpdatedAddress()
#3 /includes/classes/ajax/zcAjaxOnePageCheckout.php(227): OnePageCheckout->validateAndSaveAjaxPostedAddress()
#4 /ajax.php(85): zcAjaxOnePageCheckout->validateAddressValues()
--> PHP Deprecated: ctype_digit(): Argument of type null will be interpreted as string in the future in /includes/classes/OnePageCheckout.php on line 1644.
if (!ctype_digit($country)) {
Line 1643 is the followingPHP Code:[22-Oct-2024 16:11:52 America/New_York] Request URI: /ajax.php?act=ajaxOnePageCheckout&method=validateAddressValues, IP address: xxxx, Language id 1
#0 /includes/classes/OnePageCheckout.php(1643): zen_debug_error_handler()
#1 /includes/classes/OnePageCheckout.php(1456): OnePageCheckout->validateUpdatedAddress()
#2 /includes/classes/ajax/zcAjaxOnePageCheckout.php(227): OnePageCheckout->validateAndSaveAjaxPostedAddress()
#3 /ajax.php(85): zcAjaxOnePageCheckout->validateAddressValues()
--> PHP Warning: Undefined array key "zone_country_id" in /includes/classes/OnePageCheckout.php on line 1643.
$country = zen_db_prepare_input($address_values['zone_country_id']);
A few days back, I received the following warning (not from OPC). Not sure if it is related.
I changed the following codePHP Code:[24-Sep-2024 08:57:51 America/New_York] Request URI: /index.php?main_page=checkout_shipping_address, IP address: xxxx, Language id 1
#0 /includes/modules/checkout_new_address.php(47): zen_debug_error_handler()
#1 /includes/modules/pages/checkout_shipping_address/header_php.php(45): require('/home/...')
#2 /index.php(35): require('/home/...')
--> PHP Warning: Undefined array key "zone_country_id" in /includes/modules/checkout_new_address.php on line 47.
$country = zen_db_prepare_input($_POST['zone_country_id']);
To
$country = zen_db_prepare_input($_POST['zone_country_id'] ?? '');
I'm getting recurrent error logs that say the welcome email is not being created - validation failure.
And I've had several folks say they are hitting a 404 error in paypal checkout (yes, I still have the new paypal installed).
The site has been slammed with bots recently and occasionally the server in general slows down under stress. Trying to untangle this is dang difficult.
Any ideas?
When you're posting that you're receiving error logs, it helps me to help you by posting the log's contents.Quote:
Originally Posted by delia
If the PayPal/RESTful issue is happening a lot, I'll suggest turning on the payment module's logging to gather some 'breadcrumbs' through which the cause of that issue can be determined.
Hello,
I am having an issue with minimum order which is set at $100.00. If the order is below the messageStack appears indicating that it is below the minimum, however checkout is not being disabled and the order can be processed. if I disable this plugin it works correctly. Running 2.0.1 php 8.2.
Thanks in advance
Where did the minimum-order code come from?Quote:
Originally Posted by allmart
Minimum order pluginQuote:
Originally Posted by lat9
As I surmised, the Minimum Order plugin (version 7) doesn't 'know' OPC. You'll need to edit /includes/classes/observers/class.minimum_order_amount.php in two spots.
First, on line 24, add the highlighted fragment:
Second, add that notification to the list in the section that starts on line 67:Code:$zco_notifier->attach($this, array('NOTIFY_HEADER_END_SHOPPING_CART', 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING', 'NOTIFY_HEADER_START_CHECKOUT_PAYMENT', 'NOTIFY_HEADER_START_CHECKOUT_CONFIRMATION', 'NOTIFY_HEADER_START_CHECKOUT_ONE'));
Code:case 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING':
case 'NOTIFY_HEADER_START_CHECKOUT_PAYMENT':
case 'NOTIFY_HEADER_START_CHECKOUT_CONFIRMATION':
case 'NOTIFY_HEADER_START_CHECKOUT_ONE':
Works! You are the best lat9 ... thanks!!!
v2.5.4 of One Page Checkout is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2095
This release contains changes associated with these GitHub issues:
#420: $_SESSION['opc_saved_order_total'] might not be set.
#421: Correct variable name used during PPEC processing; PHP warnings were being logged.
#422: Removed non-array language files; initial installation now requires zc158 or later.
#423: Clicking on a credit-class total's "Apply" button without supplying a value submits the form
Quote:
Originally Posted by lat9
the error is [12-Nov-2024 02:06:25 UTC] ERROR: Failed sending email to: "" <0> with subject: "[CREATE ACCOUNT] Welcome to xxxxxxxxxx (failed validation)
Also have customers complaining of hitting a 404 when checking out with paypal. Restful is still installed but I'm getting the client reset up with paypal pro and express to see if those issues stop. So far I've not been able to tell when or how they are hitting bad links as I don't talk to them directly. So I figure if I ask you what could possibly be happening you won't have clue. (stop laughing - I can hear you now!)
I did just turn on logging to see if that will give me any more info.
First, that error is issued when a customer is creating an account. The PayPal/RESTful payment module only comes into play during the checkout process.Quote:
Originally Posted by delia
If you're getting 404's using PayPal RESTful, it could be that the ppr_webhook_main.php isn't present in the root-directory of the site. You can tell more by inspecting the site's raw-access logs to see what page/file the 404's being issued for.
Zen Cart 2.0.1
PHP 8.3.13
I didn't see this in the thread nor the GitHub issues, so not sure where the issue lies.
Orders placed via the Guest Checkout do not contain a Shipping Address (https://screenrec.com/share/pGTIfwv618)
The settings are for the 'Shipping Address, Same as Billing' to be checked so they are technically not filling it in. But shouldn't it be pre-filled based upon that checkbox so it is populated on the order?
What version of OPC? What shipping module was used for the order? Did the order contain only 'virtual' products?Quote:
Originally Posted by jeking
OPC 2.5.3Quote:
Originally Posted by lat9
Not virtual products
But I did select Local Pickup for my shipping forgetting that removes the shipping.
However, the customer order without a Shipping address used UPS Ground from the current UPS oauth module.
I did another test using UPS Ground and got a shipping address, so not sure what the issue was. We've written it off as a fluke for now. If it happens again, we'll dig in. For now, I know the answer to my original question "But shouldn't it be pre-filled based upon that checkbox so it is populated on the order?" is yes, it does.
Duh, I know the error is from creating an account. This is a 2.0.1 with a minimal template and one page is the only mod.Quote:
Originally Posted by lat9
And duh, I bow to your wisdom. Was missing that dang file. Feeling stupid. Thanks!
Hi Lat9
I have been testing the latest version of OPC with Zen Cart 2.1.0 and have noticed a couple of minor issues with the CSS.
1) On mobile devices the shipping method column is displaying approximately half the width it should be.
2) The whole checkout is a bit too close to the left edge of the screen. Line 43 of the responsive classic stylesheet.css should apply padding:0.8em to .centerColumn – for some reason when OPC is turned on the padding is not applied.
Please see the screenshots which show both issues.
I’m unsure which version of OPC or Zen Cart introduced these minor bugs – they don’t seem to be present on an older version (2.3.9 running on ZC 1.5.7c).
It would be much appreciated if you could advise best way to fix these issues.
Many thanks
Richard
Attachment 20807
Attachment 20808
Thanks for the report, I'll give that a look ... eventually.
Note that the majority of my testing with OPC is with the Bootstrap template, so some of these visual wonky bits with responsive_classic have been overlooked.
hello all,
How can make the "Confirm Order" button bigger?
I look into the css stylesheet but for ZC2.0.1 , everything is completely different from what I am used too.
I also find this in /templates/tpl_modules_opc_submit_block
but I have not idea how to inline css to it.Code:<span id="opc-order-confirm"><?php echo zen_image_button(BUTTON_IMAGE_CHECKOUT_ONE_CONFIRM, BUTTON_CHECKOUT_ONE_CONFIRM_ALT); ?></span>
Any help would be appreciated
Thank you
While the actual CSS used will depend on the active template for the site, but there should be a checkout_one.css file present in includes/templates/royal_fleur/css.
To the bottom of that stylesheet, you can add:
That, essentially, emulates Bootstrap's btn-lg class. See the w3schools docs for additional information: https://www.w3schools.com/bootstrap4...ap_buttons.aspCode:#opc-order-confirm btn {
padding: .5rem 1rem;
font-size: 1.25rem;
line-height: 1.5;
border-radius: .3rem;
}
It didn't work for me. i am on bootstrap template as well.Quote:
Originally Posted by lat9
Somehow I am having issues with the site specific stylesheet.
i ended up adding
margin-bottom:20px;
font-size:1.5rem;
to line 457 of stylesheets_zca_color.php right afterHTML Code:button.button_confirm_order {
Hi, is possible to stop the account being created for 'Guest' with the two entries in the address book, here's what's up. I have an existing store with One Page Checkout installed and the Guest entry is already in the customers table. To upgrade I have a test site with the latest 2.1.0 on the responsive_classic template with One Page Checkout installed. When I empty the customers table, customers info table and address_book table from the test site, then import the tables from the existing active store with the Guest account info in all three tables it creates a new Guest account leaving two Guest accounts, 4 entries in the address book and 2 in the customer info tables having all the same data, except the user id of course. Should I delete the old entry in all three tables so I don't have a conflict later in life, not worry? Thanks
You're taking a non-standard approach to your upgrade that led to this issue. See these docs for the suggested method: https://docs.zen-cart.com/user/upgra...ing-approaches
One-page checkout's admin initialization script checks to make sure that the customer- and address-id values that it has stored to point to the guest-checkout records are still intact and re-creates them if not ... that's what's happened on your test site.
You can safely remove the older guest-customer record and the address-book records associated with that now-defunct customer record.
zen 210 and php8.0 with many mods and im getting this error every time i click a payment or shipping method, and page does not refresh with either selection,
shipping
paymentCode:[22-Dec-2024 20:10:55 America/New_York] Request URI: /ajax.php?act=ajaxOnePageCheckout&method=updateShippingSelection, IP address: 35.139.236.145
--> PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /includes/classes/order_total.php:140
Stack trace:
#0 /includes/classes/ajax/zcAjaxOnePageCheckout.php(428): order_total->output()
#1 /includes/classes/ajax/zcAjaxOnePageCheckout.php(92): zcAjaxOnePageCheckout->createOrderTotalHtml()
#2 /ajax.php(77): zcAjaxOnePageCheckout->updateShippingSelection()
#3 {main}
thrown in /includes/classes/order_total.php on line 140.
[22-Dec-2024 20:10:55 America/New_York] Request URI: /ajax.php?act=ajaxOnePageCheckout&method=updateShippingSelection, IP address: 35.139.236.145
--> PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /includes/classes/order_total.php:140
Stack trace:
#0 /includes/classes/ajax/zcAjaxOnePageCheckout.php(428): order_total->output()
#1 /includes/classes/ajax/zcAjaxOnePageCheckout.php(92): zcAjaxOnePageCheckout->createOrderTotalHtml()
#2 /ajax.php(77): zcAjaxOnePageCheckout->updateShippingSelection()
#3 {main}
thrown in /includes/classes/order_total.php on line 140.
Code:[22-Dec-2024 20:13:18 America/New_York] Request URI: /ajax.php?act=ajaxOnePageCheckout&method=updatePaymentMethod, IP address: 35.139.236.145
--> PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /includes/classes/order_total.php:140
Stack trace:
#0 /includes/classes/ajax/zcAjaxOnePageCheckout.php(428): order_total->output()
#1 /includes/classes/ajax/zcAjaxOnePageCheckout.php(369): zcAjaxOnePageCheckout->createOrderTotalHtml()
#2 /ajax.php(77): zcAjaxOnePageCheckout->updatePaymentMethod()
#3 {main}
thrown in /includes/classes/order_total.php on line 140.
[22-Dec-2024 20:13:18 America/New_York] Request URI: /ajax.php?act=ajaxOnePageCheckout&method=updatePaymentMethod, IP address: 35.139.236.145
--> PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /includes/classes/order_total.php:140
Stack trace:
#0 /includes/classes/ajax/zcAjaxOnePageCheckout.php(428): order_total->output()
#1 /includes/classes/ajax/zcAjaxOnePageCheckout.php(369): zcAjaxOnePageCheckout->createOrderTotalHtml()
#2 /ajax.php(77): zcAjaxOnePageCheckout->updatePaymentMethod()
#3 {main}
thrown in /includes/classes/order_total.php on line 140.
You don't indicate what version of OPC is in use, nor do you identify within those many mods what additional order-total and/or payment modules are in use. Please supply that missing information.
I'll suggest also, for debugging, to try disabling OPC to see if the built-in 3-page checkout operates correctly.
ZC 2.1.0, OPC 2.5.4, Bootstrap 3.7.4.
I don't see an Guest Checkout option on the index.php?main_page=login page, even its enabled in Admin. Does this need anything else enabled to show up?
Attachment 20848
Attachment 20849
Attachment 20850
The current not-logged-in customer needs to have something in their cart.Quote:
Originally Posted by DML73
Yes I did make sure there were products in the cart before continuing to checkout
Any debug logs? There's something amiss with your installation.Quote:
Originally Posted by DML73
No debug logs in regards to this problem, but I re-installed the plugin and now it seems to be working, so I guess I must have missed some of the files the first time.
Thanks for the update; missed files will "bite' you!Quote:
Originally Posted by DML73
Would you ever consider utilizing the GUEST CHECKOUT enabled feature, but having the One Page Checkout feature turned off?
We love the one page functionality, but we have so many modules (Reward Points, Coupons, Gift Certificates, Shipping Insurance) that it can make the one page look "busy."
We considered disabling it and returning to the three step checkout (to have less information crammed into one page). The problem is that when you turn off the OPC module, it also disables the ability of Guests to checkout (which we require).
Previously, there was the COWOA module but that is no longer maintained. Since OPC is so robust, I was wondering if this feature would be a benefit to others as well (enabling the Guest Checkout feature even if the One Page Checkout was turned off).
I'll note that there's a change-request present in OPC's GitHub: https://github.com/lat9/one_page_checkout/issues/407Quote:
Originally Posted by Jeff_Mash
The more I've thought about this, the more it feels like a huge effort.
The 3-page (standard) checkout relies on the address_book_id values set into the billto and sendto session variables and regularly interrogates the database to retrieve the associated address values. For OPC's guest checkout, there's a single temporary 'holder' address_book_id that's used by all guests checking out.
When I've got more time, I'll review the processing of the checkout_shipping, checkout_payment and checkout_confirmation pages to see if there are additional notifications that could reduce the effort required.
hello, can I enable the password option on the checkout_one so that customers can enter the password directly on this page?
Update:Quote:
Originally Posted by richard7315
Potential fixes for issues 1 and 2 shown below:
1)
In the responsive_mobile.css find
/*bof checkout*/
#checkoutConfirmDefault .forward, #checkoutPayment .forward, #checkoutShipping .forward{float:right;width:auto !important;}
Removing float:right; seems to fix the display problem.
2)
The stylesheet.css has a minor bug. Around line 42 find:
.centerColumn, #bannerOne, #bannerTwo, #bannerThree, #bannerFour, #bannerFive, {padding:0.8em;}
The comma after #bannerFive should be deleted.
I have tested the fixes with OPC turned on/off and did not notice any issues. Please can the Zen Cart team check and apply these fixes to the core code.
Many thanks
Richard
There is no such option. Customers who have previously created accounts with a site need to go through the login page's processing.Quote:
Originally Posted by ikirin
Thanks for those updates for the built-in responsive_classic template. I've created a GitHub issue (https://github.com/zencart/zencart/issues/6928) to identify this change-request.Quote:
Originally Posted by richard7315
meta_tags.php does not exist in my template's version of /includes/languages/english/ should i create one?Quote:
One last item to "tidy up" ... registering the two new checkout pages into the ROBOTS_PAGES_TO_SKIP value. I don't think this is a high-priority item since the pages' names don't appear on any menus and include it only for completeness! If you want to make sure that robots aren't indexing the checkout_one and checkout_one_confirmation pages, you'll need to edit your template's version of /includes/languages/english/meta_tags.php and add those two page-names to the end of that constant's comma-separated-list.
Just copy /includes/languages/english/meta_tags.php to /includes/languages/english/YOUR_TEMPLATE/meta_tags.php and make your edits there.Quote:
Originally Posted by TamyA
I'll also suggest adding comments to identify which language constants are changed.
Oh, i see it now, i was looking for meta_tags.php and i could not find it, it is called lang.meta_tags.phpQuote:
Originally Posted by lat9
zencart 2.1
php 8.2
template - ZCA Bootstrap template
OPC 2.5.4
Lat 9
I am having the same issue as #2608 in this thread
"Customer enters there address. Moves to change the country from United States to say Canada and the menu for Canada does not load in. It leaves the US states and just says:
"Please select a state from the States pull down menu."
Where should I look to fix this issue?
Seems to work if the international area has a dropdown for province. But leaves a input line which should not be there
Attachment 20939
Just to be clear if it has a state or province like Canada all is good. When it does not have a state/province is when the issue occuurs as showed in the image aboveQuote:
Originally Posted by chadlly2003
disregard it was a setting on my end
... and what setting was that?Quote:
Originally Posted by chadlly2003
Back in April 2020 it was established that customers checking out as a guest, without already having an account, would receive a text-only checkout email (https://github.com/lat9/one_page_checkout/issues/244).
Has anything changed in the interim or does that restriction still apply?
Nothing has changed.Quote:
Originally Posted by simon1066
Just noticed a strange thing, I was looking on the website checking listings for an order, and got an error 500 on every page. Or refresh. In private session or another browser I could access the site. But not in the affected browser session. Only other thing is I Was logged into admin at the same time. I could only see several logs like this:-
I turned off one page checkout for now in case its that, though got a feeling it might be due to ip address logged into admin and somehow its blocking in same session on existing browser. I didn't see anyone else with same issue, I saw a code edit I applied to make this log disappear though. In case that helps.Quote:
PHP Fatal error: Uncaught Error: Call to a member function guestCheckoutEnabled() on int in /includes/classes/observers/class.checkout_one_observer.php:216
That method (guestCheckoutEnabled) in the OnePageCheckout.php class-file was introduced in OPC v2.5.0. It sounds like your version of that file and OPC's observer-class file have somehow gotten out-of-sync.Quote:
Originally Posted by HeathenMagic
To what code-edit do you refer?
I found post #2838 and your fix after suggested, I amended that line as you recommendedQuote:
Originally Posted by lat9
What is the Bottom instructions for?