Printable View
This was a quick fix. I think there may be a more elegant way to accomplish this. Edit Orders and Super Orders share the following file common_orders_functions.php which contains a send email function which can probably be used thus saving a few lines of code in the edit_orders.php file.Quote:
Originally Posted by DivaVocals
I'll do some more checking and see what can be done.
I got that..:smile:Quote:
Originally Posted by clydejones
I guess what I am still not clear on is what exactly was fixed.. I apologize if I appear dense here, but in all of our testing of Edit Orders we had no issue with the comments functions behavior. So what exactly was "wrong" is what I am trying to understand..:P With the multiple back to back to back to back posts (versus one or two CONCISE posts which stated what the problem was), all I managed to cobble together is something about the e-mail template not working??
Given our testing had no issues I am still a lot unclear about the issue and the solution.. A clear summary would help me get a grasp on what just transpired in FOUR pages of posts..:laugh:
Though I'd have to look at old Zen Cart code to confirm this, I think that somewhere after SO was first released, that the default orders.php on which it was based on changed, and super_orders.php did not change with it.. So some items like comments were done differently in SO than in it's default cousin. They BEHAVED the same, but the coding for each was different..Quote:
Originally Posted by clydejones
The comments code in Edit Orders was similar/identical to the Super Orders comments code. Hence the reason we common_orders_functions.php file.
The next release of Super Orders will no longer use the common_orders_functions.php file. In the name of finishing up the re-synchronization of the default orders.php with super_orders.php that was a part of SO3, I've fully aligned the comments code in super_orders.php with the code from orders.php. The benefit for doing this is that it will make it MUCH easier for shopowners to translate orders.php modifications from other modules to super_orders.php as it will look more like it's default cousin. This will make is EASY PEEZY for those using COWOA for example to integrate with Super Orders..
I would like to eventually get the Edit Orders comments code to look and act like the default orders.php comments as well and eliminate the need for this common_orders_functions.php file for Edit Orders as well.
It wasn't that the e-mail template wasn't working; the thing was that it (the email) wasn't being formatted using the email_template_order_status.html instead it was using email_template_default.html.Quote:
Originally Posted by DivaVocals
It also was not sending an extra copy of the e-mail to admin.
All I did was copy the email section from orders.php to edit_orders.php so that it now uses email_template_order_status.html when sending emails and also sends an extra copy of the email to admin.
Okay now that's CLEAR.. thanks for the explanation.. I'll have a looksee (& test out) at what you modified this weekend.. if I can free up some time....Quote:
Originally Posted by clydejones
Posted via Mobile Device
Okay I took a looksee at this, and Clyde, you are right.. This wasn't so much a "fix" to a "problem" (which implies the comments were not working -- they in fact WERE working) as it was a modification to the e-mail template used.. Thanks for the clear explanation!:bigups:
Quote:
Originally Posted by clydejones
One thing I have been wanting to tackle is implementing the FULL alignment of the comments code in edit_orders.php to match up to the comments code used in orders.php and eliminate the need for the common_orders_functions.php file altogether. (common_orders_functions.php contains the send email functions used by both Super Orders and Edit Orders)Quote:
Originally Posted by clydejones
I have already done the same thing to a new version of Super Orders (not submitted yet). I spent a little time this past weekend doing the same for Edit Orderst, and I think I've got it working along with some other MINOR tweaks:
- Remove more of the hardcoded text in Edit Orders (the default shipping tax value can be entered in the admin versus having to be hardcoded into the edit_order.php file)
- Add an order navigation feature like the one in Super Orders
To be clear the reason for making this change is NOT because there is an issue with comments in Edit Orders at all.. The current comments functionality work just fine.. The reason for the change is so that IF the default orders.php is modified in an upcoming release of Zen Cart (as it did in the 1.38 vs 1.39 flavors of this file), the path to update Edit Orders will be CLEARER to see.. IMHO this is a LOT more difficult to see when the methods used between the two are different. So now the comments code between the two is the same.. I've been testing it and it is working with or with out the Ty Package integration. (Super Orders integration works as always as these changes do not affect this)
I've posted this in Super Orders thread because it relates to both modules:
So I figured out why I was getting the blank screen when selecting SO from the Customer drop down. I didn't upload the Edit Orders batch for Super Orders.
Now I have a different problem. When I installed the patch I got this message when uploading the SQL:
1 statment ignored. See "upgrade_exceptions" table for additional details.
Now I get the SO screen; however if I click on the details of an order I get this message:
1146 Table 'ddandlam_znc1.TABLE_CUSTOMERS_ADMIN_NOTES' doesn't exist
in:
[select * from TABLE_CUSTOMERS_ADMIN_NOTES where customers_id = '8']
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.
Please help!
In case you need a link ddandlamber dot com
No it actually doesn't.. This is a Super Orders issue..
Because we made it easy to use both together it is assumed that issues with one module is somehow related to the other.. This is a false assumption..
The code in Super Orders that allows you to use Super Orders with Edit Orders doesn't affect Edit Orders AT ALL.
Quote:
Originally Posted by ddandlamber
Hi All,
I am having some issues with this Modification. I have Super Orders 3.0 installed and works great (thank you). However I wanted to take it further by adding the Edit Orders 3.0 to my site. I modified all folders per instruction as well as merged mod files with current files on server using winmerge. No problems there. I also saved copies of the unmodified files on server by renaming the originals to filename_ORIGINAL.php. After uploading all files and folders to my site, when I tried to access the admin section I received an HTTP 500 error in IE8 and in FF I got a blank screen. So I went and removed all files that were uploaded, renamed originals and all worked again. I then uploaded one file at a time and check my admin section after each file and found that the file common_orders_functions was the problem so far. I know on line which has this code -is different then what is on my server and mine isCode:'" .zen_db_input($comments) . "')");
I am not sure why this is causing me not able to access the admin section at all even for log in, but it is. I have searched for my issues and am unable to find anything related to this.Code:'" . $comments . "')");
Zen Version 1.3.9h
Site hasn't been upgraded
Addons are Super Orders 3.0 and other not related to the ordering system.
Thank you for your time and understanding as well as your help.
Check your cache folders for error logs (blank page = error). You are getting errors because your install method is causing problems.
As has been posted in this thread several times you can't keep originals and backups together. (there's actually a fairly extended conversation on this very subject with someone who like you had errors after installing Edit Orders -- a quick search of this thread would have turned up this very post and the follow-up advice given)
Keep your backups OFFLINE and load ONLY the files needed to run the mods.. You are getting errors because your renamed original files are interfering with the ones required by the module. In other words unless the install instructions say to do this, DON'T. It's a bad habit to get into, and as you have discovered causes issues..
If you want to back up your store file in case you need to rollback when installing modules, do a proper backup of your store.
Quote:
Originally Posted by KeystoneAirsoft
after i adding products am pressing update button it shows blank page, am using 1.3.9h.... help me anybody... thanks in advance.....