Printable View
Diva, I was so excited to see this because I have such a thing happening when writing reviews and then being redirected to that page when done---I am trying to get a confirmation placed within the body and not the header.
I do not have TPP installed at all.
sadness---it did not work for me:(
so I added a bandage to your bandage...LOL I removed
<span class="smallText">[' . $review->fields['products_model'] . ']</span>
Attachment 12967
Do I understand this correctly then, you don't have TPP installed, but you do have what, Zen Lightbox installed? And with Zen Lightbox active or inactive are you getting the extra model info as a result of $reviews->fields['products_model'] having data in it? Is the show products_model option off in the associated template's product type description? I can't say that I've used the review option, so not sure what settings are offered by default for control of what is passed on.Quote:
Originally Posted by DarkAngel
I'm not sure I understand what you are saying here.. I dunno what you mean by "being redirected to that page when done---I am trying to get a confirmation placed within the body and not the header."Quote:
Originally Posted by DarkAngel
The code I have will not remove the product model number unless you have TPP installed. IF you are saying that the issue with the model number exists EVEN when you DO NOT have TPP installed, then the code I posted won't work, and your "bandage" is not the right fix. (You'll need to look at the code I posted to see why.. hint: the code I posted says If TPP is installed do this, else do this)
In any case please confirm that the model number display issue IS an issue if you have Zen Lightbox installed and DO NOT have TPP installed..
Here's the deal.. Reviews are a built in Zen Cart feature.. You "turn on" the reviews features by either activating the reviews sidebox or by showing the reviews buttons on the product information page by turning them on in the admin (Catalog > Product Types > [Product Type])Quote:
Originally Posted by mc12345678
The Show Model Number option On/Off from the Catalog > Product Types > [Product Type] applies to whether or not the the model number will be displayed in the product details section of the product info page.
Code:<!--bof Product details list -->
<?php if ( (($flag_show_product_info_model == 1 and $products_model != '') or ($flag_show_product_info_weight == 1 and $products_weight !=0) or ($flag_show_product_info_quantity == 1) or ($flag_show_product_info_manufacturer == 1 and !empty($manufacturers_name))) ) { ?>
<ul id="productDetailsList" class="floatingBox back">
<?php echo (($flag_show_product_info_model == 1 and $products_model !='') ? '<li>' . TEXT_PRODUCT_MODEL . $products_model . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_weight == 1 and $products_weight !=0) ? '<li>' . TEXT_PRODUCT_WEIGHT . $products_weight . TEXT_PRODUCT_WEIGHT_UNIT . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_quantity == 1) ? '<li>' . $products_quantity . TEXT_PRODUCT_QUANTITY . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_manufacturer == 1 and !empty($manufacturers_name)) ? '<li>' . TEXT_PRODUCT_MANUFACTURER . $manufacturers_name . '</li>' : '') . "\n"; ?>
</ul>
<br class="clearBoth" />
<?php
}
?>
<!--eof Product details list -->
The issue I was reporting was that on the products review pages the model number was not displaying correctly.. It's not extra information and there is no option to turn the model number off/on on the product reviews pages. The reviews pages will display the model number based on whether or not the model number field is NOT null.. I always thought that the issue with the model number display was cause by a combination of TPP and Zen Lightbox being installed.. Based on Dark Angel's post, it sounds like this issue occurs even when TPP is not installed.. (I need her to confirm this)
No TPP installed
Lightbox is installed
model is set to show in product page
I did chck your code Diva and saw the difference --- it was like what mine has so i just remved the bit about the model and then tried to write a review again.... code to right of image was gone
when I click write a review button, write a review, submit I then I click submit button and it takes me to index.php?main_page=product_reviews&products_id=followed by the number that is where it showed the code in the image I put into my post. That is why i said I was trying to get a confirmation of the review being successfully submitted. The code I got for it was a header code and I need the Thanks to show up in the body not header.
I thought it was due to installing the plugin called dgreviews but then I saw Diva's post and thought it must be something to do with lightbox.
I have just recently started using the reviews again but have LB installed in other shops I have set up also without TPP and tested it there and yes the code showed up there too.
I forgot to say that when I removd the code I checked the product pages and the model was still visible there just not when writing the review and submitting it. Also on the reviews page it appears right below the title just like to the right of the image I posted. It only removed the bit that was to the left.
also noticed that the code--in part--is in 2 places so I just edited the part you posted about.
It is not TPP but in fact Zen Lightbox and the issue has been their since I can remember :smile:Quote:
Originally Posted by DivaVocals
Well, I certainly feel at a loss at the moment, not being in front of a device that would allow me to look up code. So, sounds like the Zen Lightbox installation adds the ability to show additional information based on the model number of the reviewed product being filled in; however, doesn't offer any additional flag(s) to prevent display of that additional information. (Thought the additional info was model number data, but I think I was corrected on that above by Diva Vocals). Other than allowing ZLB to work on the reviews page, I am not sure why there would be a need for everyone to have code that would show this "errant" data. It may have been something that just got slipped in when packaging the update.
As I said I'm not in front of a device that works with code, but was wondering how that header compared to the default header. It may be that the header just needs to have that logic check undone and restored to the default version.
It may also be that an option should be added to the ZLB configuration area to allow showing the model info when it is present for the product. I say that because if the option isn't in the default files, and only appears in ZLB, then it should be controlled by ZLB, otherwise a similar option could be added to the template style, but then that would have to be carried over with ZC upgrades.
If you used the code snippet I posted to fix the errant model number display, and made the change you made, this is not the RIGHT way to do it.. That's why I asked.. You could have simply NOT used my recent code and commented out lines 43-44 in the original header_php.php file.. (which is the fix I posted originally)Quote:
Originally Posted by DarkAngel
However, that said, mc12345678 got me to thinking that I need to look closer at all the page header module files for the reviews.. I noticed that the issue appears on the "reviews" page (index.php?main_page=product_review), but not the write reviews page (index.php?main_page=product_reviews_write).. This gave me a clue that the key to the RIGHT answer is in the "write reviews" page header_php.php file regardless as to whether or not you have TPP or Zen Lightbox or Zen Colorbox installed..
In other words, the issue is not really a Zen Lightbox , Zen Colorbox or TPP issue, but an issue in the default Zen Cart files that is "aggravated" by Zen Lightbox, and Zen Colorbox (and possibly Fual Slimbox, though I have not tested that module specifically)
So undo the change I posted earlier and your hack to it and standby.. I am testing something that should work. But I need to test it on a store that is ONLY running Zen Colorbox without TPP.. and I also need to make sure that when Zen Colorbox is turned off or not installed that the code doesn't break anything because if this is right, I am going to suggest it as core code change to the Zen Cart admins..
Nothing to do with this or the Zen Colorbox module, and not even close to being part of the issue I am trying to fix/address.. I am simply trying to fix the way that the product model number is called for and displayed on the reviews page.. This has NOTHING to do with how the reviews confirmations are displayed, and it's unlikely that the lightbox module is affecting this either..Quote:
Originally Posted by DarkAngel
Quote:
Originally Posted by rbarbour
Quote:
Originally Posted by mc12345678
My code was meant to go in a very specific location and nowhere else.. You need to undo everything you did.. your hack to my code is not right or even needed.. (see my post just above this one..)Quote:
Originally Posted by DarkAngel
Not a ZLB issue or TPP issue.. See my post above this.. It's a Zen Cart core code issue which is "aggravated" by ZLB..Quote:
Originally Posted by rbarbour
Zen Lightbox doesn't add any additional anything to the model number on the reviews page. The ONLY thing that Zen Lightbox does on the reviews page is to display the product image inside a lightbox.. Zen Lightbox MANGLES the model number, and that's the ONLY issue I am trying to address..Quote:
Originally Posted by mc12345678