Printable View
Yes Seeing that is what prompted my query. I had visited and quickly scanned the GH page, and also downloaded the zip. However, for the likes of me such wonders are cursed with "many a slip between cup and lip".Quote:
Originally Posted by mc12345678
Are the files on GH the updated and newest files?
If so, their seems to be allot of unnecessary code copied from the slimbox.php file from google groups that is not needed and may cause issues.
That file is generic and the custom options may/may not override options.php (ADMIN Configurations).
I thought the discussion of GH and Zen LightBox got moved to elsewhere. My understanding is that one person setup GH, another had posted the update here on ZC, so not sure (without comparing the two filesets) if they are/were the same. That said, the GH files are there for mod/continued improvement if an issue has/will be identified. Please feel free to evaluate for the issues of concern and contribute back the changes/suggestions.Quote:
Originally Posted by rbarbour
I have used this lightbox for a very long time and the only real problems that have been written about are when the user accidently installs both lightbox and slimbox together, they do not play nice so only one is needed for the store.Quote:
Originally Posted by rbarbour
Aside from that and the occasional corrupt file or missing file I have not had any problems with this mod at all...in my own store or the ones I have installed it on.
Darkangel, if I understand correctly, you are indicating that the Zen LightBox as provided here in ZC has been good; however, in the last couple of days, a "solution" for it working better on mobile devices was proposed. The result of incorporating that appears to have been the incorporation (in full?) of a file into the package. What rbarbour was indicating was that perhaps the included file contains more code than necessary, and may (or may not) be fully compatible with options.php. That is something still to be determined, unless those that proposed the change(s) have already addressed that issue.Quote:
Originally Posted by DarkAngel
Btw, where's that other thread to discuss things like this further?
I did not see a link to another thread or I would have posted their.Quote:
Originally Posted by mc12345678
However, the same code exists in the latest version uploaded to the plugins.
Just making a mere suggestion that this should be re-evaluated. That's all.
You are absolutely right about the extra unnecessary code.Quote:
Originally Posted by rbarbour
I took the zip file posted here, and the comments from others that said "It works!" and blindly committed it to the project.
While it does "work", I do not want to use the eval() method that was used in the responsive "fix".
Today I have been manually un-minifying that code so that I can use basic minified JS instead.
GH has been updated just now, with some code & structure updates. Proceed with caution though, it still needs some testing
Is there a discussion forum or such on GH where we can continue the discussion of GH and Zen LightBox???Quote:
Originally Posted by niestudio
"Issues" I think can be brought up with comments (discussion) associated.Quote:
Originally Posted by DivaVocals
Quote:
Originally Posted by DivaVocals
Check out: https://github.com/niestudio/zen_lightbox/issues/3Quote:
Originally Posted by mc12345678