Big Royal Mail 3.0

Hello there,
I get the following error, which weirdly only gives blank page when using shipping estimator on shopping cart page, so far only United States and Canada upon testing:-

Quote:

---

PHP Fatal error: Uncaught TypeError: Unsupported operand types: float + string in /includes/modules/shipping/BigRoyalMail/quote.php:151

---

Its fine in php 7.x , the issue only occurs on php 8.x . I guess its something to do with rest of world zones. I read on google that it just needs parentheses adding at certain points, but that was for a different system to zencart. I swtiched back to php 7.x for now, trying to suss it out but the code seems to spread over 2 lines that it refers to.

I assume you are using the latest version 3.9.
I have it on my site working with php 8.2.

Can you check your handling fee is numeric, if zero, make sure it's not letter o.

if it is numeric try changing line 151 from

Code:

---

            $shipping_cost = ($shipping * $shipping_num_boxes) + (defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) : 0) +
                (defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') : 0);

---

to

Code:

---

            $shipping_cost = ($shipping * $shipping_num_boxes) + (float)(defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) : 0) +
                (float)(defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') : 0);

---

If that works do you have strict mode set? Let me know what happens.

Quote:

---

Originally Posted by brittainmark

I assume you are using the latest version 3.9.
I have it on my site working with php 8.2.

Can you check your handling fee is numeric, if zero, make sure it's not letter o.

if it is numeric try changing line 151 from

Code:

---

            $shipping_cost = ($shipping * $shipping_num_boxes) + (defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) : 0) +
                (defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') : 0);

---

to

Code:

---

            $shipping_cost = ($shipping * $shipping_num_boxes) + (float)(defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING_' . $dest_zone) : 0) +
                (float)(defined('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') ? constant('MODULE_SHIPPING_' . $module . '_ZONES_HANDLING') : 0);

---

If that works do you have strict mode set? Let me know what happens.

---

Thanks that worked great! I am testing rest of the world countries and it is working as on 7.4 php.

I do have this one, is this the database strict on you meant?

innodb_strict_mode ON

Thanks again!

Forgot to say yes I am on latest module version, 1.58a. I think it must be strict server sql settings in my case, have had similar issues before and had to change code somewhat.

I cannot replicate the issue unless I put a letter into the handling fee. Check your world zone 3 handling fee to see if any of them have a non numeric entry. The letter 'o' is most likely instead of zero.

Quote:

---

Originally Posted by brittainmark

I cannot replicate the issue unless I put a letter into the handling fee. Check your world zone 3 handling fee to see if any of them have a non numeric entry. The letter 'o' is most likely instead of zero.

---

I did double check the fields and even deleted and re-entered and it was still the same. But I just checked the two modules I disabled for airmail (standard airmail), and the handling fees are a minus fee, i.e -2.50. I did this I recall a while ago, as we are on business Royal Mail account and it was two to three pounds cheaper on average than the normal prices. Sorry, I didn't think to check disabled modules, it must be looking up all entries if installed, it was just set to false instead of uninstalled.

Interesting I have never tried negative handling fees. You know you can alter the rates to suit your situation. I know most of the other shipping modules don't allow -ve fees. Do you want me to leave this ability as I was thinking of adding validation to force fees to be greater than or equal to zero. I'll test with a -ve fee to see if it replicates you issue.

Hi Mark. I think maybe keep as it is, just that airmail has such a lot of band rate prices, I did a bodge job fix lol. Of course only need to edit if on the account system for lower prices in some cases. I will probably alter each price in future, so yes maybe do the validation thing I say. I didn't realise php 8 was so picky, it was fine for the last year or so.

Version 3.9.1 has just been released. I have submitted it to zen cart. In the mean time it is available on git hub.
Changes:

Update to rates.php and rVersion.php for April price rise
Update insuramce rates
Change max values to match net insurance max values
Corrected attribute pricing for Royal Mail Tracked 24 and 48.
PrintedPapers.sql updated for April 2025 prices rise
apr2024Update.sql created for April 2025 prices rise
Created wiki for documentation

Latest version now available. https://www.zen-cart.com/downloads.php?do=file&id=190