Re: Image Handler 5 (for v1.5.5) Support Thread
Quote:
Originally Posted by
meksicus
Are you sure ?
Making md5 from same path + image name gives same result ... i think so.
md5 is made from target filename, not from source.
protected function getCacheName($data, $ext='')
{
$md5 = (IH_CACHE_NAMING == 'Hashed') ? md5($data) : $data;
$file = $GLOBALS['bmzConf']['cachedir'] . '/' . $md5{0} . '/' . $md5 . $ext;
:
What I'm saying is (performance issues aside) that files with the same names in different sub-directories aren't overwritten using the 'hashed' method.
Re: Image Handler 5 (for v1.5.5) Support Thread
Yes, you are right. I found naming difference.
I made this change in bmz_image_handler.class.php (5.0.0 line 286)
// $image_dirname = basename($image_path['dirname']);
$image_dirname = str_replace(DIR_WS_IMAGES,'',$image_path['dirname']);
It seems its ok now - i dont have conflicts, file names are readable, performance great.
I will put it now in my production envs.
Re: Image Handler 5 (for v1.5.5) Support Thread
Quote:
Originally Posted by
meksicus
Yes, you are right. I found naming difference.
I made this change in bmz_image_handler.class.php (5.0.0 line 286)
// $image_dirname = basename($image_path['dirname']);
$image_dirname = str_replace(DIR_WS_IMAGES,'',$image_path['dirname']);
It seems its ok now - i dont have conflicts, file names are readable, performance great.
I will put it now in my production envs.
Thanks, @meksicus, I'll give that a look-over!
Re: Image Handler 5 (for v1.5.5) Support Thread
Hi Mekicus , Lat9.
I store my Images like /Images/[Model Number]/[Model Number].jpg , _1.jpg etc. For the sake of organisation it has been great.
Current problem is I have had 2 product imports both produced by the same script. The first was 8000 line and next 2000. So the first 8000 works fine with IH5 but the next does not. I had a look within phpadmin to see if I could see a difference between imports but it looked all normal. Thinking of a third import to see what happens.
Will play with it some more today.
Re: Image Handler 5 (for v1.5.5) Support Thread
Hello!
If I am upgrading this module from v. 5.1.2 to the current version should uninstall the whole thing and then reinstall as new or just overwrite the files (I do not have any mods to merge in)?
Thanks for any advice!
Re: Image Handler 5 (for v1.5.5) Support Thread
Your question indicates that you may be going about this the wrong way. Best practice is to not touch the current site and create a new test site.
Since many of your current mods might not work with the newer version, might be totally different versions, or may have been incorporated in the latest version; it's recommended to create a whole new test site.
If you have cPanel, there are instructions at https://docs.zen-cart.com/user/first...t-using-cpanel
Re: Image Handler 5 (for v1.5.5) Support Thread
Quote:
Originally Posted by
dbltoe
Your question indicates that you may be going about this the wrong way. Best practice is to not touch the current site and create a new test site.
Since many of your current mods might not work with the newer version, might be totally different versions, or may have been incorporated in the latest version; it's recommended to create a whole new test site.
If you have cPanel, there are instructions at
https://docs.zen-cart.com/user/first...t-using-cpanel
Thanks for this. This is a test site. I created this a year ago for a client to test some things but just realized that there was a newer version of this plug in. Are you suggesting that I create a third copy of the the entire store just to upgrade this one plug in?
As I mentioned, I have not made any mods to the files involved in this plug-in.
Re: Image Handler 5 (for v1.5.5) Support Thread
You may want to wait a few days for 1.5.7 but, I would never consider changes without "new" case being the number one consideration. There were lots of changes between 1.5.# And 1.5.6. Many more in the upcoming 1.5.7.
Re: Image Handler 5 (for v1.5.5) Support Thread
Quote:
Originally Posted by
dbltoe
but, I would never consider changes without "new" case being the number one consideration
I'm sorry if I am being dense, but I don't understand what you mean by this. Can you explain?
Thanks!
Re: Image Handler 5 (for v1.5.5) Support Thread
Quote:
Originally Posted by
dbltoe
You may want to wait a few days for 1.5.7 but, I would never consider changes without "new" case being the number one consideration. There were lots of changes between 1.5.# And 1.5.6. Many more in the upcoming 1.5.7.
Also, I'm confused about your statement about version 1.5.6 and waiting for 1.5.7. The version I just downloaded from the plug-ins section is version 1.5.8 according to the read me.