Tabbed Products ''LITE'' version - Delimiter based

Good News!!

I must have slept well last night.. Fighting with this Global Product Description Tab had initially been a logic nightmare the last time I tried it, and then again most of last night. Finally this morning my brain opened up! Instead of trying to fake the tab, and having to add more logic checks and chase variables all over the place and make a whole new coding abortion, I simply made a few line change and it works perfectly!

Instead of me forcing the data to be a hardcoded tab, I simply prefix a variable I set the product description to with the global product description tags on the fly and let the existing code work as normal. If only my genius moments weren't so brief and occured more often :P

Anyways, There was very little to change after I started over from scratch so I will drop the beta version here for you guys to test and since it was so simple I even included a simple 4-step guide to let you make the changes easily to your current modified version of 3.11 so you don't have to make heavy modifications to a whole new file.

Also, the code is smart enough to check if you already have a custom Product Description tab, it will not auto-create another one, it will just load that one as normal. Remember my code is genius :P

Give it a whirl!

Ok one guinea pig stepping right up :)
I followed your steps in your readme and got the following... see subtle screenshot :wink2:
I left the relevant part in English for the screenshot for you Q as I guess your Japanese isnt great.
I was wondering if its poss to put a line feed in under the title in the cross sell tab so its the same as the also purchased module, ive been staring at that part of the code and its the same as the other tabs... I dont get it :blink:

edited to say, I removed the <br> in the tab name and its now fine....
Answers on a postcard....

Quote:

---

Originally Posted by Reesy

Ok one guinea pig stepping right up :)
I followed your steps in your readme and got the following... see subtle screenshot :wink2:
I left the relevant part in English for the screenshot for you Q as I guess your Japanese isnt great.

---

heh yea its a tough call for me to decide how I should leave the defaults. Even tho most people I've seen tend to use the non-wrapped style, I tend to like all my tabs on one line and IMO it looks neater that way if you have a lot of tabs so I tend to default to including the word wrap. But Im glad it is easy enough to figure out. I had toyed with the idea of making it a language file for all of them.. but then thats more files to maintain and more for you guys to edit if needed. So Im still on the fence about that.

Quote:

---

Originally Posted by Reesy

I was wondering if its poss to put a line feed in under the title in the cross sell tab so its the same as the also purchased module, ive been staring at that part of the code and its the same as the other tabs... I dont get it :blink:

---

Ah yes, I was wondering if anyone else was going to notice this. This is actually a Cross Sell issue, unrelated to the tabs. You can open up templates_default/templates/tpl_modules_also_purchased_products.php and compare it to templates_default/templates/tpl_modules_xsell_products.php

The Xsell module adds the header name to the template file, the customers also purchased module adds it from modules/also_purchased_products.php. Perhaps because the require is outside of the template load in the also purchased products, but inside the template loading of the xsell module.. You might be able to add <br /> tags after the </h2> tag in the xsell module to get it to look the same. or move the Cross sell header name to the modules file to be more like the rest.

@Reesy, just to try it, I moved the title tag to the xsell module file to make it look more like the also purchased module, but had no luck, it just removed the title all together. So instead I added the <br /> under the </h2> tag in the xsell template file and it worked fine there. Its a hack, but it looks fine when rendered.

Hi Q!
Kewl, that hack works fine. Thanks for helping out there.
In the screenshot above you will notice that when the tab name was on 2 lines it didnt render correctly and there was a small gap under the tab. ie the tabs were not all sitting on the same line.
I made a language file for mine, as its only 1 tiny extra file.
:smile:

Quote:

---

Also, the code is smart enough to check if you already have a custom Product Description tab, it will not auto-create another one, it will just load that one as normal. Remember my code is genius

---

Sure it is. :smartass: Works perfectly.

Quote:

---

Originally Posted by Reesy

Hi Q!
Kewl, that hack works fine. Thanks for helping out there.

---

Good to hear :)

Quote:

---

Originally Posted by ideasgirl

Sure it is. :smartass: Works perfectly.

---

:)

Well no bug reports so far :) Looks like its good for release. I'll add it to the Downloads area.

So here's some ideas that have been going through my head. The use of AJAX to pull tab data on the fly, instead of loading it all at page load.

The idea would be to have things like Additional Images, Customers Also Purchased, and Cross Sell tab data. Also.. for new tabs planned like the Reviews, Ask a Question, and Tell a friend forms right inside the tabs instead of a link to the form also might be good candidates for AJAX style instead of loading it all at once.

Any thoughts?

I know I also said I'd look into porting it across to the other product types like music and freeshipping. I was waiting for all the ideas and bugs to be worked out of this version first before doing that. So it's still in the plans.

Quote:

---

I know I also said I'd look into porting it across to the other product types like music and freeshipping.

---

I did the freeshipping type, if you want to add it to your files, let me know.

I just noticed css right column weirdness in IE 6. I use Firefox and hadn't noticed this until a customer told me:
http://www.bowak.co.uk/jangro/jangro...or-p-2113.html
Fine in firefox, broken in IE.

Any ideas? Thanks!