Westminster New

Printable View

Show 100 post(s) from this thread on one page

8 Jan 2015, 02:56 PM
picaflor-azul

Re: Westminster New

Quote:

Originally Posted by DivaVocals

I found two more files that need this same fix:
includes/templates/westminster_new/common/tpl_home_slider.php
Line #41 :

Code:

<script src="<?php echo $template->get_template_dir('',DIR_WS_TEMPLATE, $current_page_base,'jscript') . '/jquery.flexslider.js' ?>" type="text/javascript"></script>

Should be:

Code:

<script src="<?php echo $template->get_template_dir('jquery.flexslider.js',DIR_WS_TEMPLATE, $current_page_base,'jscript') . '/jquery.flexslider.js' ?>" type="text/javascript"></script>

includes/templates/westminster_new/common/tpl_main_page.php
Line #93 :

Code:

<script src="<?php echo $template->get_template_dir('',DIR_WS_TEMPLATE, $current_page_base,'jscript') . '/back_to_top.min.js' ?>" type="text/javascript"></script>

Should be:

Code:

<script src="<?php echo $template->get_template_dir('back_to_top.min.js',DIR_WS_TEMPLATE, $current_page_base,'jscript') . '/back_to_top.min.js' ?>" type="text/javascript"></script>

Great. I am currently working on a major package update and will be sure to include these changes. Thank you for posting!

Thanks,

Anne
11 Jan 2015, 07:48 PM
picaflor-azul

Re: Westminster New v 1.3 UPDATE

I just submitted an update to the template package:

* installed the Zen Lightbox plugin
* Added styles for quantity discounts on the product info page
* add code for jqurey core to html_header.php and deleted jscript_jquery.min.php
* removed non functioning sorter from specials all page
* updated flexible footer menu to latest version
* updated font awesome to latest version
* add footer_images folder to images
* replaced all "ad" in image names and css classes, etc. so ad blocker does not block them
* fixed home page slide show banner sort order in tpl_home_slider.php
* Bugfix: http://www.zen-cart.com/showthread.p...12#post1268812
* Bugfix: http://www.zen-cart.com/showthread.p...59#post1237359
* Bugfix: http://www.zen-cart.com/showthread.p...25#post1268325
* Bugfix: http://www.zen-cart.com/showthread.p...87#post1268987
* Bugfix: http://www.zen-cart.com/showthread.p...97#post1268797
* Bugfix: http://www.zen-cart.com/showthread.p...12#post1266212

Thanks,

Anne
11 Jan 2015, 09:11 PM
DivaVocals

Re: Westminster New v 1.3 UPDATE

Quote:

Originally Posted by picaflor-azul

I just submitted an update to the template package:

* installed the Zen Lightbox plugin
* Added styles for quantity discounts on the product info page
* add code for jqurey core to html_header.php and deleted jscript_jquery.min.php
* removed non functioning sorter from specials all page
* updated flexible footer menu to latest version
* updated font awesome to latest version
* add footer_images folder to images
* replaced all "ad" in image names and css classes, etc. so ad blocker does not block them
* fixed home page slide show banner sort order in tpl_home_slider.php
* Bugfix: http://www.zen-cart.com/showthread.p...12#post1268812
* Bugfix: http://www.zen-cart.com/showthread.p...59#post1237359
* Bugfix: http://www.zen-cart.com/showthread.p...25#post1268325
* Bugfix: http://www.zen-cart.com/showthread.p...87#post1268987
* Bugfix: http://www.zen-cart.com/showthread.p...97#post1268797
* Bugfix: http://www.zen-cart.com/showthread.p...12#post1266212

Thanks,

Anne

This sounds awesome.. but if I may make a suggestion..

If you are going to bundle in a lightbox contribution, you should consider using Zen Colorbox instead of Zen Lightbox.. Zen Colorbox is maintained by the SAME author as Zen Lightbox. Anyone using Zen Lightbox with a responsive theme SHOULD upgrade/update/replace Zen Lightbox with Zen Colorbox..

More info:

Quote:

Originally Posted by niestudio

Slimbox, which is what ZLB is based on is no longer in active development, so it's unlikely that a true responsive version will come along. I will compare it to ZCB to see if there is a simple fix I could add, but don't hold your breath :)

Quote:

Originally Posted by davewest

Slimbox is a very slimed down lightbox... doesn't have code for anything other then images.. where colorbox is a full lightbox and can display anthing... I use it to dispaly images, help, privacy, contact-us form and such... easy to setup, degrades back to a standard popup... responsive, no problems. create the standard popup, add zen colorbox code, set a class, set a watch for the class in DOM, done...
12 Jan 2015, 01:03 PM
Thannaree

Re: Westminster New v 1.3 UPDATE

"If you are going to bundle in a lightbox contribution, you should consider using Zen Colorbox instead of Zen Lightbox.. Zen Colorbox is maintained by the SAME author as Zen Lightbox. Anyone using Zen Lightbox with a responsive theme SHOULD upgrade/update/replace Zen Lightbox with Zen Colorbox.."

Is there a demo where we can see it in action ?
12 Jan 2015, 03:35 PM
DivaVocals

Re: Westminster New v 1.3 UPDATE

Quote:

Originally Posted by Thannaree

"If you are going to bundle in a lightbox contribution, you should consider using Zen Colorbox instead of Zen Lightbox.. Zen Colorbox is maintained by the SAME author as Zen Lightbox. Anyone using Zen Lightbox with a responsive theme SHOULD upgrade/update/replace Zen Lightbox with Zen Colorbox.."

Is there a demo where we can see it in action ?

Download Zen Colorbox and test it if you like.. The responsive bits are found in this file: 1_Installer_Files/includes/templates/YOUR_TEMPLATE/jscript/jquery.colorbox-min.js. (commits for this change can also be found here: https://github.com/daniel-hopkins/ze...2b35a5048bf79f)

The code that makes Zen Colorbox responsive is found in the underlying Colorbox library which Zen Colorbox is based on. http://www.jacklmoore.com/colorbox/. Here's the reference to the Colorbox library updates to make it responsive: https://github.com/jackmoore/colorbo...mment-42039671

Slimbox which Zen Lightbox is based on IS NOT RESPONSIVE and has not been updated in over 5 years.. So EVEN IF Zen Lightbox was responsive (which it is not) the library it's based on is not being maintained, and therefore Zen Lightbox is OBSOLETE (which is why the active maintainer is NOT making any further updates to it).. Out of respect for this support thread, any additional discussion about Zen Lightbox or Zen Colorbox should be posted on the appropriate support forums for these modules..
12 Jan 2015, 04:26 PM
picaflor-azul

Re: Westminster New v 1.3 UPDATE

Quote:

Originally Posted by DivaVocals

Download Zen Colorbox and test it if you like.. The responsive bits are found in this file: 1_Installer_Files/includes/templates/YOUR_TEMPLATE/jscript/jquery.colorbox-min.js. (commits for this change can also be found here: https://github.com/daniel-hopkins/ze...2b35a5048bf79f)

The code that makes Zen Colorbox responsive is found in the underlying Colorbox library which Zen Colorbox is based on. http://www.jacklmoore.com/colorbox/. Here's the reference to the Colorbox library updates to make it responsive: https://github.com/jackmoore/colorbo...mment-42039671

Slimbox which Zen Lightbox is based on IS NOT RESPONSIVE and has not been updated in over 5 years.. So EVEN IF Zen Lightbox was responsive (which it is not) the library it's based on is not being maintained, and therefore Zen Lightbox is OBSOLETE (which is why the active maintainer is NOT making any further updates to it).. Out of respect for this support thread, any additional discussion about Zen Lightbox or Zen Colorbox should be posted on the appropriate support forums for these modules..

Thank you so much for your comment ;) I will definitely consider switching over to color box. I was not aware that slimbox was defunct.

But, zen lightbox is responsive:

http://durl.me/829uxy

Thanks,

Anne
12 Jan 2015, 05:54 PM
DivaVocals

Re: Westminster New v 1.3 UPDATE

Quote:

Originally Posted by picaflor-azul

Thank you so much for your comment ;) I will definitely consider switching over to color box. I was not aware that slimbox was defunct.

But, zen lightbox is responsive:

http://durl.me/829uxy

Thanks,

Anne

Well in none of my testing was Zen Lightbox responsive particularly on smartphones which is why I switched over to Zen Colorbox. I discovered that there was an issue on responsive templates testing one of Raymonds EARLY responsive template framework prototypes.. Switching to Zen Colobox was the suggestion of the Zen Colorbox (and Zen Lightbox) author when I inquired about responsive behavior and Zen Lightbox. He was the one who made me (and the support thread) aware that the underlying library that Zen Lightbox is based on (Slimbox) is outdated, and because of this he would not be doing any additional updates to Zen Lightbox. He was recommending that people switch to Zen Colorbox instead..

Personally if I use this template again and Zen Lightbox is bundled in I would be removing it anyway because of the Slimbox deal, and the fact that Daniel (the author of both modules) will not be updating this module anymore... Everybody will not agree with me on this, and I know that there are still some Zen Lightbox fans out there.. I'm just not one of them for all the reasons mentioned..
12 Jan 2015, 05:57 PM
picaflor-azul

Re: Westminster New v 1.3 UPDATE

Quote:

Originally Posted by DivaVocals

Well in none of my testing was Zen Lightbox responsive particularly on smartphones which is why I switched over to Zen Colorbox. This was the suggestion of the Zen Colorbox and Zen Lightbox author when I inquired about responsive behavior and Zen Lightbox. He was the one who made me and the support thread aware that the underlying library that Zen Lightbox is based on is outdated, and because of this he would not be doing any additional updates to Zen Lightbox. He was recommending that people switch to Zen Colorbox instead..

Personally if I use this template again and Zen Lightbox is bundled in I would be removing it anyway because of the Slimbox deal, and the fact that Daniel (the author) will not be updating this module anymore... Everybody will not agree with me on this, and I know that there are still some Zen Lightbox fans out there.. I'm just not one of them for all the reasons mentioned..

Yes, I agree. I just wanted to link to the emulator that is showing the plugin working on mobile devices.

Thanks,

Anne
12 Jan 2015, 06:32 PM
DivaVocals

Re: Westminster New v 1.3 UPDATE

Quote:

Originally Posted by picaflor-azul

Yes, I agree. I just wanted to link to the emulator that is showing the plugin working on mobile devices.

Thanks,

Anne

Yes I do acknowledge that the emulator does appear to show it's working.. This wasn't my experience with Zen Lightbox when testing Raymonds early responsive framework, and because of that (and the author's suggestion) I PERSONALLY don't use the Zen Lightbox module anymore.. But yes it does appear to be working..

Anyway.. Whatever you bundle into the template is your call :smile:.. Just looking forward to the new version with the other updates in place.. just wanted to throw in my three cents regarding the differences between the two modules..
13 Jan 2015, 03:27 AM
RixStix

Re: Westminster New v 1.3 UPDATE

Is it safe to guess that responsive support for android tablets just isn't going to happen? Samsung galaxy tab 3 both 8 & 10" versions are the ones I can test.

Show 100 post(s) from this thread on one page