Printable View
This sounds like the meat of the problem. I have not edited these files.Quote:
Originally Posted by Woodymon
When I downloaded the contribution and decompressed it, I found a readme.txt file with 3 simple instructions, none of which mentions editing these files. Did I miss other instructions in this download?
I'll try looking back through this thread and see if I can find those instructions.
Thanks again for your help.
Feeling like an idiot here:
What core files need to be edited to include lightbox code?
You are correct. The readme is over simplified and does not include the code snippets which were merged into the core Zen Cart files provided in the mod package. (Unfortunately the developer assumes you will on your own compare the provided files with your installed versions. But many new to Zen Cart just blindly upload. This is why it is is best practice for developers to document such code snippets in the mod readme...but some mod developers are in just too much of a rush or just forget or just don't care).Quote:
Originally Posted by izonmedia
At any rate this mod works with Zen Cart 1.37 but it has NOT been updated for Zen cart 1.37. Compare with the ZC 1.37 core files and you will observe differences in ZC 1.37 version of /includes/modules/additional_images.php that do not show up in the mod version of the same file.
Note the Lightbox 1.3 mod was last updated over six months ago, well before the release of ZC 1.37. Hopefully Alex will take this in consideration with next update.
So I just compared the two core ZC files provided in the Zen Lightbox 1.3 mod distribution with the Zen Cart 1.37 version core files.
My findings:
(1) \includes\templates\YOUR-TEMPLATE-FOLDER\templates\tpl_modules_main_product_image.php
in the mod package is still current with ZC 1.37
(2) But I cannot say the same for:Code:* @version $Id: tpl_modules_main_product_image.php 3208 2006-03-19 16:48:57Z birdbrain $
\includes\modules\YOUR-TEMPLATE-FOLDER\additional_images.php
Latest Zen Cart 1.37 version:
Older IH2 version in Zen Lightbox:Code:* @version $Id: additional_images.php 5369 2006-12-23 10:55:52Z drbyte $
(keep in mind that cboylan integrated code from the last version of ImageHandler 2 into the Lightbox version of the file. Last version of IH2 was released in the early days of ZC 1.3x and the IH2 mod is no longer developed by the author).Code:* @version $Id: additional_images.php,v 1.3 2006/05/01 12:20:31 tim Exp $
Comparing this file I noted one specific line is for Lightbox and all the other changes are for IH2.
In the latest ZC 1.37 version of the file multiple instances of the ereg_replace() function has been replaced by str_replace() function.
For example, the following:
Was changed in Zen Cart 1.37 to :PHP Code:$products_image_base = ereg_replace($products_image_extension . '$', '', $products_image);
If you want to understand why see:PHP Code:$products_image_base = str_replace($products_image_extension, '', $products_image);
See http://us2.php.net/ereg_replace
http://us2.php.net/str_replace
So for this specific file if you don't use IH2 (and it appears you don't) it might be best to just open a copy of the default ZC 1.37 core version (if you have no other edits) and edit the one line difference yourself and then upload.
For the future I think it best if the lightbox mod was released in two separate versions, one for base Zen Cart and another for IH2 (just include alternative files in the same package but in different option directories, and also document the different code snippets in readme).
Also I am uncertain if non-IH2 users need to upload
includes/functions/extra_functions/zen_image_lightbox_IH2_url.php
It appears it is only needed for IH2 installs but I myself use IH2 so I have file uploaded.
I suspect some of this stuff may have been previously documented further back in this thread. Search on cboylan for more info.
As a reminder for all...
I'm not saying that uploading those files is your current issue (and it is likely not) but any time you install a mod you should not overwrite core files or upload overrides, without first checking if those files provided in the mod match your Zen Cart version. That applies to Lightbox also.
And before overwriting you should check to see if you will be overwriting files you have previously edited/customized.
Install a compare/merge tool (e.g. WinMerge or BeyondCompare) to compare the mod files with the Zen Cart core versions and also compare with the back ups of your versions (before you uploaded the mod versions).
Woody
Hi
can some one direct me to where i can find instruction on how to put more than one picture,
i install the zen lightbox and it working perfect
am also using zen 1.37
i only know it can do it whan i saw one of my pic say on top next and 1/2 but i dontknow how it heppen , and i like to post more pics for same product
Ty
Well thats pretty nifty...never looked at that before and didn't look at the source code. Will have to check that out more...:smartalec: Thanks, learn something everyday on here.Quote:
Originally Posted by Woodymon
Motti,
Find the Images folder where your product images are, and add images to it as follows:
If your main product image is productA.jpg , then additional images can be
productA_01.jpg
productA_02.jpg
etc...
As a matter of fact, you put anything you want after the underscore.
If you already have an underscore in the image name, then...., oh nooooo, it's kryptonite.
Make sure you have additional images turned ON in admin.
I was hoping for a better solution to the large image pop-up and then I ran into the Zen Lightbox!!
Beautiful thing.
It seems to work in unison with IH2 and haven't seen any problems there.
I also have the CSS horizontal drop down menu.
Question:
Regardless of whether it's an IH2 zoom image being displayed, or the faded out background with lightbox, the menu text behind shines right thru!!
Before I go off to kill another day experimenting with the code, does anyone know why this might be the case and how to change it??
Thanks!
[FONT=Times New Roman]Sorry but I can’t find where is the additional images in my admin, I read line by line in my configuration/images among other places.[/FONT]
[FONT=Times New Roman] Possible I install it wrong?[/FONT]
[FONT=Times New Roman][/FONT]
[FONT=Times New Roman]Thank you [/FONT]
motti,
admin>configuration>images>Product Info - Number of Additional Images per Row
make sure this is set to something besides 0
admin>catalog>product types>product general......edit layout (right sidebox)Show Product Additional Images......set to 1
[FONT=Times New Roman][/FONT]Quote:
Originally Posted by barco57
[FONT=Times New Roman]Right to the point, fund it. [/FONT]
[FONT=Times New Roman]Thank You Barco [/FONT]