Sales report 2.0

Using 139h with SuperOrders, I applied the optional rollover edits to admin/includes/general.js, as per the following snippet, but cannot see what it does.

Did I add the code rightly?

What am I supposed to see happen?

Code:

---

function rowOverEffect(object) {
  if (object.className == 'dataTableRow') object.className = 'dataTableRowOver';
// start Sales_report
        if (object.className == 'totalRow') object.className = 'totalRowOver';
        if (object.className == 'lineItemRow') object.className = 'lineItemRowOver';
// end Sales_report
// start Super Orders
        if (object.className == 'paymentRow') object.className = 'paymentRowOver';
        if (object.className == 'purchaseOrderRow') object.className = 'purchaseOrderRowOver';
        if (object.className == 'refundRow') object.className = 'refundRowOver';
// end Super Orders
}

function rowOutEffect(object) {
  if (object.className == 'dataTableRowOver') object.className = 'dataTableRow';
// start Sales_report
        if (object.className == 'totalRowOver') object.className = 'totalRow';
        if (object.className == 'lineItemRowOver') object.className = 'lineItemRow';
// end Sales_report
// start Super Orders
        if (object.className == 'paymentRowOver') object.className = 'paymentRow';
        if (object.className == 'purchaseOrderRowOver') object.className = 'purchaseOrderRow';
        if (object.className == 'refundRowOver') object.className = 'refundRow';
// end Super Orders
}

---

Thanks in advance

I went into the admin-inc-lang-eng-stats_sales_report.php file to change some of my column headings on the Sales Report. Now NONE of the headings even show up on the report when I print. Reuploaded backup of the file, but still no headings printing, so the problem is coming from somewhere else. Is there somewhere else I can check or fix?
I seem to have problems with my new FileZilla. I don't know how this happened. Appreciate any help. Thanks.

Please ignore last message! Problem due to new computer/printer. Problem solved. :clap:

I just installed Version 2.3.1 and after requesting report it defaults to the admin login screen despite turning on/off the new window option.

Using ver 1.3.9h

Thanks

I just wanted to say a big thank you for that mod. It installed so easily and works like a charm.

From #471 above, and since having just installed Super Orders 3:

Or do I do this in admin/includes/general.js:

Code:

---

function rowOverEffect(object) {
  if (object.className == 'dataTableRow') object.className = 'dataTableRowOver';
}

function rowOutEffect(object) {
  if (object.className == 'dataTableRowOver') object.className = 'dataTableRow';
}

// BEGIN Super Orders3 edit
function rowOverEffect(object) {
        if (object.className == 'dataTableRow') object.className = 'dataTableRowOver';
        if (object.className == 'paymentRow') object.className = 'paymentRowOver';
        if (object.className == 'purchaseOrderRow') object.className = 'purchaseOrderRowOver';
        if (object.className == 'refundRow') object.className = 'refundRowOver';
}

function rowOutEffect(object) {
    if (object.className == 'dataTableRowOver') object.className = 'dataTableRow';
        if (object.className == 'paymentRowOver') object.className = 'paymentRow';
        if (object.className == 'purchaseOrderRowOver') object.className = 'purchaseOrderRow';
        if (object.className == 'refundRowOver') object.className = 'refundRow';
}
// end Super Orders3

// start Sales_report2
function rowOverEffect(object) {
        if (object.className == 'totalRow') object.className = 'totalRowOver';
        if (object.className == 'lineItemRow') object.className = 'lineItemRowOver';
}
// end Sales_report2

// start Sales_report
function rowOutEffect(object) {
        if (object.className == 'totalRowOver') object.className = 'totalRow';
        if (object.className == 'lineItemRowOver') object.className = 'lineItemRow';
}
// end Sales_report

---

Thanks

Not a javascript pro, but I'd think the first example is more straightforward - overloading a function with the same parameters - does that even compile?

All this is for is to make the report a little more functional - highlights the line your mouse is over by specifying a different background color via the CSS sheets

Quote:

---

Originally Posted by carlvt88

Not a javascript pro, but I'd think the first example is more straightforward - overloading a function with the same parameters - does that even compile?

All this is for is to make the report a little more functional - highlights the line your mouse is over by specifying a different background color via the CSS sheets

---

I agree especially since this file did not change at all in the new Super Orders v3.0 release.. If the previously posted proposed changes work no reason they won't continue to work with Super Orders v3.0 and the lates version of the Sales Report..

Quick question. The Sales Report works fine, but since i installed it, i do not receive the invoices anymore. I only see the paypal message. Is there something i missed?

Can you say a little more? I'm not sure what you mean. What invoices? SalesReport doesn't send invoices. What paypal message? Is this an email?