Glad I could help you.
Printable View
Glad I could help you.
The solution for me was similar. I move the style and it worked fine. I also found this was in a <br> tag not a div just after <!-- Add page break for print out -->.
When I moved the style to the first <table> I also deleted the <br> where the style was originally located.
One slightly annoying thing is that the addon has always chucked out a blank page before printing the invoices. After the change it does the same but after the invoices are printed. Any ideas why this could be happening? I have found this since the very first version that I have installed and on different printers using different operating systems (currently Windows 7 Ultimate) and different browsers (currently IE 11. Given all these facts I would say it would be a coding issue rather than system, software or printer problem.
I heavily modified this report but what I can tell you is there is something making it generate that blank page. So there is some content after the page break. I'm assuming this is after every invoice so if you are printing 10 invoices you are getting 10 blank pages and not 10 invoices with 1 blank page at the end. The fact that you say it went from a blank page before to blank page after confirms this.
I've checked the default version of All Invoices on a 17-page printout on the most recent version of both FireFox and IE11 and I don't see the extra-page issue.
no issues here!
Thanks for the update!
hi,
i just started looking at this module for a specific need. while it does get installed on the admin side; i would still cleanse the $orderStatus variable prior to its use. from:
toPHP Code:
$orderStatus = $_GET['status'];
or perhaps making use of the bindVars instead.PHP Code:
$orderStatus = zen_db_prepare_input($_GET['status']);
i have a need to print a range of invoices; i am not sure if others have a need for that. which seems like easy enough to do. however, on first glance, this does look to be like a valuable module. thanks!
Good point, carlwhat, I'll add that to the plugin's change-list. I'm not as concerned about the sanitizing since it's on the admin side.
lat9,
which one was the good point: adding an invoice range? or sanitizing the $_GET variables?
i agree, the sanitizing is not as big a concern as it is on the admin side. the invoice range is for what i needed the module. i suppose the tricky part is what invoices to include, as we have a cancelled order status which we do not want to see; but then all of other statuses we do.
i suppose the selection process could go on and on...
in addition, we implemented the super_orders and super_invoices module, so i needed to modify the formatting of the invoice to match that...
that said, a very helpful starting point for me. thanks again for this contribution.
best.
carlwhat, I was responding to the need to sanitize the $_GET variable (just using a simple integer-cast is sufficient).
I'll add the order-range specification as a change-request to the plugin.