-
Re: FEEDBACK ON BETA of v1.5.5
STATUS UPDATE:
As you know, we rarely give a "date", but we're in final testing and unless we discover things that need code changes, we're anticipating releasing v155 on Tuesday or Wednesday next week. Until then we're in "code freeze" mode save for fixing any discovered bugs or updating release docs.
I'm mentioning this in case you have time between now and then to test some upgrades (esp from as old as v139).
Any feedback about bugs which need fixing before release would be appreciated.
-
Re: FEEDBACK ON BETA of v1.5.5
I can upgrade fine to 155 and the 155 store defaults to Anne's pick some flowers fantastic responsive template.
Thanks to all who contributed to v155.
Once I import the old db though, the store reverts to the classic money green zc template with the old store products. Not an issue.
The auto renamed admin site then shows "WARNING: An Error occurred, please refresh the page and try again".
I have compared config files. Somehow the admin is not connecting to the newly populated DB. Please advise.
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
downloaded 2016 03 11:
admin initial setup wizard is under the footer (Win10/Ffox latest/on a laptop).
Attachment 16097
-
Re: FEEDBACK ON BETA of v1.5.5
Hi,
I am thorougly testing the 1.5.5.
I have installed the FEC from Numinix and the CSSJs loader.
It works fine but only in the desktop version.
If you browse the site with a smartphone (or with an agent switcher from a PC) when you go to the login page you get a full blank page.
Test if you want at www.aupgrade . acquatua.it (it is a test site so do not watch at the missed parts or bad looking style)
I browsed the page source and I can not find any difference in the code generated when swithched to mobile or tablet, but again the rendered page is blank and if the switch is set "desktop" the page is rendered normally.
I have no error log files thrown, so I am lost.
I think it is a css problem, but I have no idea on how I can fix it.
I set the CSSJs loader to false for both css and js but no change.
Can someone help please?
Ciao from Italy
enzo
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
enzo-ita
Hi,
I am thorougly testing the 1.5.5.
I have installed the FEC from Numinix and the CSSJs loader.
It works fine but only in the desktop version.
If you browse the site with a smartphone (or with an agent switcher from a PC) when you go to the login page you get a full blank page.
Test if you want at
www.aupgrade . acquatua.it (it is a test site so do not watch at the missed parts or bad looking style)
I browsed the page source and I can not find any difference in the code generated when swithched to mobile or tablet, but again the rendered page is blank and if the switch is set "desktop" the page is rendered normally.
I have no error log files thrown, so I am lost.
I think it is a css problem, but I have no idea on how I can fix it.
I set the CSSJs loader to false for both css and js but no change.
Can someone help please?
Ciao from Italy
enzo
I just tested with a blackberry 9930 was able to access the site although there were two security warnings regarding certificates that were expired or issued for another site... Was delivered to the mobile template and not a desktop view based on the look of the page.
Considering that the issues identified are related to one or more plugins to ZC 1.5.5, may I suggest taking this to a separate discussion/the developer. As the issues are not directly a problem with ZC 1.5.5.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
I just tested with a blackberry 9930 was able to access the site although there were two security warnings regarding certificates that were expired or issued for another site... Was delivered to the mobile template and not a desktop view based on the look of the page.
Considering that the issues identified are related to one or more plugins to ZC 1.5.5, may I suggest taking this to a separate discussion/the developer. As the issues are not directly a problem with ZC 1.5.5.
I am very sorry, I simpy forgot to say that the problem comes out only if you go to http://www.aupgrade . acquatua.it/index.php?main_page=login
I apologize if I made you wasting your time.
You are right that the problem is related to a plug-in but I though it may be more related to the responsive system introduced in 1.5.5 since the plug in works well if you browse with a PC
Thanks
enzo
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
I just tested with a blackberry 9930 was able to access the site although there were two security warnings regarding certificates that were expired or issued for another site... Was delivered to the mobile template and not a desktop view based on the look of the page.
Considering that the issues identified are related to one or more plugins to ZC 1.5.5, may I suggest taking this to a separate discussion/the developer. As the issues are not directly a problem with ZC 1.5.5.
I found it. It was the html header in the common dir. It needs to be modified ina different way then what suggest by the plugin author.
Thanks
enzo
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
enzo-ita
I am very sorry, I simpy forgot to say that the problem comes out only if you go to
http://www.aupgrade . acquatua.it/index.php?main_page=login
I apologize if I made you wasting your time.
You are right that the problem is related to a plug-in but I though it may be more related to the responsive system introduced in 1.5.5 since the plug in works well if you browse with a PC
Thanks
enzo
Enzo, no problem, everyone here supports ZC because they have chosen to do so. Like a program, good/valid input ought to lead to a good result. My point was that the program (ZC) worked for login without a plugin, and therefore when the plugin was added and there was an issue, that the issue is/was with the compatibility of the plugin with ZC.
Part of this overall feedback on this change is to notify developers of the status so that they can independently test their code and offer changes either to a plugin or to the core code. It's all good. :)
Quote:
Originally Posted by
enzo-ita
I found it. It was the html header in the common dir. It needs to be modified ina different way then what suggest by the plugin author.
Thanks
enzo
I think I retested after the above change, but had no issue in accessing the login page. Thanks for providing the direct link to where the issue was to support helping you. :)
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
webskipper
I can upgrade fine to 155 and the 155 store defaults to Anne's pick some flowers fantastic responsive template.
Thanks to all who contributed to v155.
Once I import the old db though...
This 'once I import the old db though" comment suggests that your mention of "upgrade" above was actually just a "new install", and not an upgrade including your actual db data and letting zc_install do its necessary steps to transform the old database data to the new structure.
Quote:
Originally Posted by
webskipper
the store reverts to the classic money green zc template with the old store products.
That's to be expected.
You still need to run zc_install and choose "Upgrade Database".
-
Re: FEEDBACK ON BETA of v1.5.5
Don't know if relevant - I run my test site 1.5.4 and 1.5.5 earlier git release on WAMP/Windows 10 - I had to make everything http - no https - to avoid error.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
soxophoneplayer
Don't know if relevant - I run my test site 1.5.4 and 1.5.5 earlier git release on WAMP/Windows 10 - I had to make everything http - no https - to avoid error.
Unless you've got a fully-certified SSL certificate installed on your local WAMP, it's completely expected that you would get SSL errors. That's not a Zen Cart issue.
-
Re: FEEDBACK ON BETA of v1.5.5
ZC 1.5.5, downloaded "today" (headers reflect full version non-beta).
Created a new database, pointed my configure.php files to the new database including updating the prefix.
Imported ZC 1.3.8 database into the blank database (although it had the applicable drop/truncate commands)
Admin table already had some issues as some admin_level fields had a zero, one had a one.
Username/password was definitely expired.
Used the How do I change or reset my Admin Password? (I lost it) to establish a username to support the database upgrade.
Upgrade only on ZC 1.3.8 database.
PHP 5.6 (Zend 2.6.0)
Server OS: Linux 3.2.61-grsec-modsign
PHP Memory Limit: 128M
Database: MySQL 5.6.25-log
No issues to report with the upgrade.
Database upgrade was performed in one "step", there are a few log errors from the install but wouldn't have been known if I hadn't gone to look for/at them out of curiosity:
Code:
[13-Mar-2016 00:54:42 America/New_York] MySQL error 1091 encountered during zc_install:
Can't DROP 'page_accessed'; check that column/key exists
ALTER TABLE admin_activity_log DROP INDEX page_accessed;
---------------
[13-Mar-2016 00:54:42 America/New_York] MySQL error 1091 encountered during zc_install:
Can't DROP 'access_date'; check that column/key exists
ALTER TABLE admin_activity_log DROP INDEX access_date;
---------------
[13-Mar-2016 00:54:42 America/New_York] MySQL error 1061 encountered during zc_install:
Duplicate key name 'idx_page_accessed_zen'
ALTER TABLE admin_activity_log ADD INDEX idx_page_accessed_zen (page_accessed);
---------------
[13-Mar-2016 00:54:42 America/New_York] MySQL error 1061 encountered during zc_install:
Duplicate key name 'idx_access_date_zen'
ALTER TABLE admin_activity_log ADD INDEX idx_access_date_zen (access_date);
---------------
-
Re: FEEDBACK ON BETA of v1.5.5
Logged into admin with mobile device.
Nearly the entire lower half of the screen is taken up by logo, copyright, etc... Be nice if that could be turned off in some way.
Menu button on upper right corner doesn't work.
Only options are the log viewer and currently the gift certificate queue because the database did have a gift certificate to get validated from back when it was backed up. Once I clicked on one of these, the half screen problem section disappeared, so at least it does go away eventually, but if I go back to my admin directory /index.php the "popup" appears again. Further, pretty much have to know all of the commands (or use alt_nav.php) to navigate...
Have seen conversations about the grid framework, etc... Don't really care as long as it works.. I do think that having one on one side and the other on the other side offers an opportunity and method to see/choose what it would take for one or the other. So, how does one turn off this admin template thing or what is needed to "correct" the issue?
-
Re: FEEDBACK ON BETA of v1.5.5
Is there a reason that the admin load of the jQuery library (from /admin/includes/header.php) is done with the defer attribute:
Code:
<script defer src="//ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script>
<script defer src="//maxcdn.bootstrapcdn.com/bootstrap/3.3.6/js/bootstrap.min.js"></script>
It's currently wrecking havoc on an admin tool that I'm developing, making it "very difficult" to get my jQuery helper and its initialization loaded without error. If I simply remove the defer attributes, all is well.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
Logged into admin with mobile device.
Nearly the entire lower half of the screen is taken up by logo, copyright, etc... Be nice if that could be turned off in some way.
There was a pending PR that hadn't been merged yet ... to deal with that footer issue. Should be okay now.
Quote:
Originally Posted by
mc12345678
Menu button on upper right corner doesn't work.
Which mobile device are you using? Screen resolution dimensions?
Quote:
Originally Posted by
lat9
Is there a reason that the admin load of the jQuery library (from /admin/includes/header.php) is done with the defer attribute:
Code:
<script defer src="//ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script>
<script defer src="//maxcdn.bootstrapcdn.com/bootstrap/3.3.6/js/bootstrap.min.js"></script>
It's currently wrecking havoc on an admin tool that I'm developing, making it "very difficult" to get my jQuery helper and its initialization loaded without error. If I simply remove the defer attributes, all is well.
I have no preference. I think the defer has it place, but may not be necessary in this context.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
There was a pending PR that hadn't been merged yet ... to deal with that footer issue. Should be okay now.
Will take a look-see about merging the PR for that.
Quote:
Originally Posted by
DrByte
Which mobile device are you using? Screen resolution dimensions?
Blackberry 9930, 640 x 480 pixels... While it is touch screen, it does have single mouse button click capability like a macintosh basically.
Button responded as if moused over, correction, but when clicked no change, not in screen not in response; no action occurred..
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
There was a pending PR that hadn't been merged yet ... to deal with that footer issue. Should be okay now.
Which mobile device are you using? Screen resolution dimensions?
I have no preference. I think the defer has it place, but may not be necessary in this context.
If possible, could it be removed? I haven't gone back to my other jQuery-using admin plugins, but I know that removing the defer made my under-development plugin go from not-working to working.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
lat9
If possible, could it be removed? I haven't gone back to my other jQuery-using admin plugins, but I know that removing the defer made my under-development plugin go from not-working to working.
I have a new pending PR which includes the removal of `defer` along with other fixes for the admin nav area.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
Will take a look-see about merging the PR for that.
Blackberry 9930, 640 x 480 pixels... While it is touch screen, it does have single mouse button click capability like a macintosh basically.
Button responded as if moused over, correction, but when clicked no change, not in screen not in response; no action occurred..
I hope when today's commits are merged (tomorrow) those issues will be resolved.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
I hope when today's commits are merged (tomorrow) those issues will be resolved.
The four commits up to commit: 7145bb6061c2b6cc3863c3ef71fd201aed14f3e1
Seemed to fix things.. I saw that there were a few PRs in the queue. I didn't try to apply them to see what would change, but the work done Saturday to Sunday did resolve the mobile in admin navigation issue.
I did notice one thing that still looked a little off, the button to accept related to gift certificate queue, overlaps the ZenCart logo slightly. There isn't much room to move. To the right, because the button for the activity log is adjacent. That second button does have some room to move right, but I find it difficult to provide clear coding direction.
With regards to the overlap of the first button, the lower left part of the button itself begins half way up from the a n the logo. The text description beneath it is somewhat lost at the beginning within the logo. The C in Certificate is position over the lower part of the t in ZenCart. Two fixes come to mind, either move over the Gift Certificate Queue button and hopefully the second button also would move or reduce the size of the logo in this setup...
-
2 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
Admin Edit Product->Preview screen strips slashes.
This is simply opening the edit product page, then continuing to Preview. At this point the image will be missing as the slashes have been removed from the path, saving the changes will save the now-incorrect paths as shown.
Before:
Attachment 16102
After
Attachment 16103
Server OS: Windows NT E5540 6.2 build 9200 (Windows 8 Business Edition) i586
HTTP Server: Apache/2.4.12 (Win32) OpenSSL/1.0.1l PHP/5.6.8
PHP Version: 5.6.8 (Zend: 2.6.0)
Database: MySQL 5.6.24
-
Re: FEEDBACK ON BETA of v1.5.5
Some observations while doing the spanish language pack.
ADMIN
english.php
define('WARNING_SESSION_AUTO_START', 'Warning: session.auto_start is enabled - please disable this PHP feature in php.ini and restart the web server.');
Misleading. True I must restart my local server to apply php changes, but it's not necessary to restart my hosting's web server, nor can I do that.
Suggest
define('WARNING_SESSION_AUTO_START', 'Warning: session.auto_start is enabled - please disable this PHP feature in php.ini. It may be necessary to restart the web server to apply this change.');
admin_activity.php
1) the "Interpretation of the log data" section is one paragraph with a child ul which is not valid html:
https://developers.whatwg.org/groupi...#the-p-element
2)Nested ul missing closing li
<li><strong>WARNING</strong> is assigned to CRITICAL things such as removal of payment modules or deletion of admin users. These are activities which might suggest pending trouble if not caught quickly. These should be reviewed very frequently; recommended daily.</li>
</ul></li><!-- steve added /li-->
suggest
define('TEXT_INTERPRETING_LOG_DATA', '<p><strong>Interpretation of the log data</strong></p><ul>
<li><strong>Severity</strong> - The standards for logging generally describe severities as follows:<ul>
<li><strong>INFO</strong> refers to general activity. This may or may not contain remarkable details.</li>
<li><strong>NOTICE</strong> refers to activity which indicates higher privilege was used, and may include things like creating new admin users or adding new payment modules. It also highlights when any data submitted on the web page includes potentially risky content such as script tags or embedded iframes, where malicious content is being added to your products/categories/pages by unhappy employees or an intruder on your site. These should be reviewed regularly for any anomalies such as unauthorized activity.</li>
<li><strong>WARNING</strong> is assigned to CRITICAL things such as removal of payment modules or deletion of admin users. These are activities which might suggest pending trouble if not caught quickly. These should be reviewed very frequently; recommended daily.</li>
</ul></li>
<li><strong>admin_user</strong> - This will show the admin user ID number followed by their admin username. If not logged in, it will show 0.</li>
<li><strong>page_accessed</strong> - This will indicate the name of the page visited, thus giving hints to the kind of activity taking place.</li>
<li><strong>parameters</strong> - This is the rest of the URI of the page visited, and gives further indication of the kind of activity being attempted by the visitor.</li>
<li><strong>flagged</strong> - If this is set to 1, that indicates that you should inspect the content recorded in the "postdata" field for unauthorized entry of script or iframe or other potentially dangerous content. An explanation of suspicious content will be listed in the "attention" field.</li>
<li><strong>attention</strong> - This will contain suggestions related to the kind of suspicious activity which should be reviewed in the "postdata" field if flagged. </li>
<li><strong>logmessage</strong> - This contains any messages recorded by the system about the activity taking place, such as installation of a certain module.</li>
<li><strong>postdata</strong> - This contains the raw POST data (with some sensitive information scrubbed) for easy review in case malicious activity is suspected.</li>
</ul>');
attributes_controller.php
define('TABLE_TEXT_MAX_DAYS', 'Expiry days: (0 = unlimited)');
colon should be at end of text
define('TABLE_TEXT_MAX_DAYS', 'Expiry days (0 = unlimited):');
coupon_restrict.php
are these extra spaces necessary?
define('TEXT_INFO_ADD_DENY_ALL', '<strong>For Add all Category Products, only Products not already set for restrictions will be added.<br />
For Delete all Category Products, only Products that are specified Deny or Allow will be removed.</strong>');
modules.php
define('WARNING_MODULES_MISSING_KEYS', '<span class="alert">Missing keys - Save, Remove, Install and Reconfigure</span>');
I assume this means database entries are missing. "Save" would be pointless/misleading as "Remove" will remove whatever has been saved.
Suggest "Note down any configuration values and Remove, Install and reconfigure the module.".
email
email_template_coupon.html
email_template_direct_email.html
email_template_gv_mail.html
email_template_gv_queue.html
email_template_newsletters.html
email_template_order_status.html
email_template_product_notification.html
have hard-coded "Dear" in the templates
CATALOG
includes\languages\english\responsive_classic\button_names.php
missing new constant
define('BUTTON_VIEW_ALL_ALT', 'View All');
\includes\languages\english\shopping_cart.php
define('TEXT_INFORMATION', 'You may proceed with your purchase by clicking the Checkout button below. Shipping and Taxes and Discounts will be handled on subsequent pages.');
Suggest
define('TEXT_INFORMATION', 'You may proceed with your purchase by clicking the "' . BUTTON_CHECKOUT_ALT . '" button below. Shipping and Taxes and Discounts will be handled on subsequent pages.');
-
Re: FEEDBACK ON BETA of v1.5.5
And this also happens with the url, according to your images.
Quote:
Originally Posted by
torvista
Admin Edit Product->Preview screen strips slashes.
This is simply opening the edit product page, then continuing to Preview. At this point the image will be missing as the slashes have been removed from the path, saving the changes will save the now-incorrect paths as shown.
Before:
Attachment 16102
After
Attachment 16103
Server OS: Windows NT E5540 6.2 build 9200 (Windows 8 Business Edition) i586
HTTP Server: Apache/2.4.12 (Win32) OpenSSL/1.0.1l PHP/5.6.8
PHP Version: 5.6.8 (Zend: 2.6.0)
Database: MySQL 5.6.24
-
Re: FEEDBACK ON BETA of v1.5.5
May have problems with slashes in other places as well then, product's name, product's description, product's uri, and product's image. They either have stripslashes( or htmlspecialchars(stripslashes( wouldn't/shouldn't be an issue if something in advance added slashes, or it was processed in some other way, but as is, looks like slashes that are purposefully entered as a single slash are removed in the processing.
-
Re: FEEDBACK ON BETA of v1.5.5
More minor stuff:
ADMIN
Initial Setup Wizard
Suggest postcode is also asked for to avoid shipping module message stack error, but not as a compulsory field.
menu.css
main menu items font size was far too big (on my laptop) and overflowed to the next line.
Ok, when commented out:
.navbar-nav li>a.dropdown-toggle {
/*font-size: 1.3em; steve*/
color: #333;
}
The padding around the menu items was already too much, and far too much with the smaller font size.
I changed to:
@media (min-width: 768px) {
.navbar-nav>li>a {
padding-top: 3px;
padding-bottom: 0;
}
ADMIN
english.php
define('HEADING_TITLE_SEARCH_DETAIL_REPORTS', 'Search for Product(s) - Delimited by commas');
this is used only in stats_products_purchased.php
It is not clear that this refers to product ids, so suggest:
define('HEADING_TITLE_SEARCH_DETAIL_REPORTS', 'Search for Product IDs (delimited by commas)');
and maybe this constant should not be in english.php
banner_manager.php
The legend has titles over each of the icons. The status icons are is titled "Status off" as it uses TEXT_LEGEND_STATUS_OFF.
<td class="smallText" align="center" width="100"><?php echo TEXT_LEGEND_STATUS_OFF . '<br />' . zen_image(DIR_WS_IMAGES . 'icon_red_on.gif', IMAGE_ICON_STATUS_OFF) . ' ' . zen_image(DIR_WS_IMAGES . 'icon_green_on.gif', IMAGE_ICON_STATUS_ON); ?></td>
They should be titled "Status" and so could use the same constant from that page: TABLE_HEADING_STATUS.
Additionally it would be logical to change the icon order to green-red/enabled-disabled, as the other two icons are in yes-no/enabled-disabled order.
<td class="smallText" align="center" width="100"><?php echo TABLE_HEADING_STATUS . '<br />' . zen_image(DIR_WS_IMAGES . 'icon_green_on.gif', IMAGE_ICON_STATUS_ON) . ' ' . zen_image(DIR_WS_IMAGES . 'icon_red_on.gif', IMAGE_ICON_STATUS_OFF); ?></td>
whos_online.php
Still has hard-coded text:
<td class="smallText" colspan="8"><?php echo sprintf(TEXT_NUMBER_OF_CUSTOMERS, $total_sess); print "<br />Duplicate IP Addresses: $total_dupes<br />Total Unique Users: $total_cust.";?></td>
And I note that in the graph produced by banner_statistics (phplot) multi-byte/utf-8 Titles have corrupted characters. But I read somewhere this is slated for replacement anyway.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
I did notice one thing that still looked a little off, the button to accept related to gift certificate queue, overlaps the ZenCart logo slightly. There isn't much room to move. To the right, because the button for the activity log is adjacent. That second button does have some room to move right, but I find it difficult to provide clear coding direction.
With regards to the overlap of the first button, the lower left part of the button itself begins half way up from the a n the logo. The text description beneath it is somewhat lost at the beginning within the logo. The C in Certificate is position over the lower part of the t in ZenCart. Two fixes come to mind, either move over the Gift Certificate Queue button and hopefully the second button also would move or reduce the size of the logo in this setup...
I think maybe you're looking at it without all the latest changes ... cuz I have no clue what you're talking about, without a visual. :)
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
I think maybe you're looking at it without all the latest changes ... cuz I have no clue what you're talking about, without a visual. :)
Attachment 16105
Probably way too small, but the above is what I was seeing on my cell phone but has been collected by desktop. Looks the same (using the updates of up to the commit I referenced before.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
Quote:
Originally Posted by
DrByte
I think maybe you're looking at it without all the latest changes ... cuz I have no clue what you're talking about, without a visual. :)
Attachment 16105
Probably way too small, but the above is what I was seeing on my cell phone but has been collected by desktop. Looks the same (using the updates of up to the commit I referenced before.
Okay, yes, that's prior to the merging of code fixes yesterday.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
torvista
Admin Edit Product->Preview screen strips slashes.
This is simply opening the edit product page, then continuing to Preview. At this point the image will be missing as the slashes have been removed from the path, saving the changes will save the now-incorrect paths as shown.
Before:
Attachment 16102
After
Attachment 16103
Server OS: Windows NT E5540 6.2 build 9200 (Windows 8 Business Edition) i586
HTTP Server: Apache/2.4.12 (Win32) OpenSSL/1.0.1l PHP/5.6.8
PHP Version: 5.6.8 (Zend: 2.6.0)
Database: MySQL 5.6.24
Quote:
Originally Posted by
Design75
And this also happens with the url, according to your images.
Quote:
Originally Posted by
mc12345678
May have problems with slashes in other places as well then, product's name, product's description, product's uri, and product's image. They either have stripslashes( or htmlspecialchars(stripslashes( wouldn't/shouldn't be an issue if something in advance added slashes, or it was processed in some other way, but as is, looks like slashes that are purposefully entered as a single slash are removed in the processing.
Hi
Have done a PR https://github.com/zencart/zencart/pull/870/files
which should fix this.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
torvista
And I note that in the graph produced by banner_statistics (phplot) multi-byte/utf-8 Titles have corrupted characters. But I read somewhere this is slated for replacement anyway.
Yes, the banner-stats tool has been fully-rewritten with a more modern tool, for v160, but has dependencies on other changes that aren't present in v155.
As for your other suggestions, we've incorporated most of them. Some will be deferred until later, mostly due to dependencies.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
Okay, yes, that's prior to the merging of code fixes yesterday.
Downloaded updated files about an hour ago. That issue has been rectified, though I kinda liked the look above better... For those that didn't go through the beta testing won't know any different. :)
A few of the screens though open with the ability/need to scroll slightly right in order to see all of the presented content or to zoom out (zooming out is only possible to a certain/small extent)
Pages on which this has been seen:
admin_activity.php
orders.php (basically a full screen/typical viewing of the orders with the small/mobile menu option button). The buttons for order management are located on the right side of the list.
configuration.php edit buttons located at the bottom instead of on the right side like "historical" or in the orders.php area. On this screen the only thing that is really off to the right causing the "need"/"ability" to scroll slightly right is the Gift Certificate Queue button is now slightly off the right side of the screen after initial opening and "resizing".
Okay, I somewhat resign, looks like there are various arrangements/setups of the menus in the mobile view depending on some sort of design consideration... The odd thing in my opinion is that after every change of screen the "size" remains the same but on some can "scroll" or slide, on others no such movement needed.
Something hadn't noticed before, but now if a sub-category exists in a category, the dropdown to even possibly add a product whether the category is active or not is not possible... Further, in the bottom left corner in such a condition there is a listing showing the number of categories and the number of products. Is this second part intended to be a sort of "second/cross" check if a product does happen to become associated with such a category? The other thing is that this seems backwards to how some have been requesting/using ZC. Now it is very obvious that products can not be colocated with sub-categories at least on the admin side... Seems like there will be more plugins/modifications suggested to address this or threads in the forum about how some aspects of ZC are working backwards. I *do* have a feeling though that there is an existing thought about how one could relatively easily implement such a result and not potentially foul the database, but it does not yet seem apparent... :)
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
Something hadn't noticed before, but now if a sub-category exists in a category, the dropdown to even possibly add a product whether the category is active or not is not possible.
That's not new
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
That's not new
Ohh, right, I forgot the method to approach and obtain a mix of product and sub-category.
First create a product in a category, disable the product, add the category/sub-category (disables the ability to add additional product but can add additional sub-categories), then re-enable the product(s) (category can no longer be added) and would have both a product and sub-category in the category and the ability to further add product..
Sort of a "bypass" in operation, but is a "built-in" method that permits the condition of a product and sub-category existing at least on the admin side.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
mc12345678
Ohh, right, I forgot the method to approach and obtain a mix of product and sub-category.
First create a product in a category, disable the product, add the category/sub-category (disables the ability to add additional product but can add additional sub-categories), then re-enable the product(s) (category can no longer be added) and would have both a product and sub-category in the category and the ability to further add product..
Sort of a "bypass" in operation, but is a "built-in" method that permits the condition of a product and sub-category existing at least on the admin side.
Sigh.
Mixing products and categories at the same level can result in miscalculations of pricing and sale calculations, and other anomalies with product and category handling. (Most of those are inherited from the osC architecture, and can't be fully resolved without changing a lot of code, and breaking plugins. Planned for a future version.)
That's why those protections are there to make it difficult to break it. But, if you're really bent on breaking the site, you can still do it, as you just showed. Naturally we don't recommend doing that.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
That's to be expected. You still need to run zc_install and choose "Upgrade Database".
Fixed corrupted table and upgraded to v155 successfully. Thanks for your help Doc and Kobra!
Few bugs:
Desktop: Main page categories set to 3 categories per row, every other row shows as less than 3. Tried 1 per row and cleared cache. Didn't fix 3 across issue.
Desktop: Unable to add certain products to cart.
Desktop: Unable to delete products from cart at times. (Maybe delayed response?)
Mobile: categories show as 1 per row.
Mobile: unable to add to cart.
I do not want to customer to have to log in to buy, can just use PP Express.
Thanks in advance.
-
Re: FEEDBACK ON BETA of v1.5.5
Is there someplace that we can see these issues? :lookaroun
-
Re: FEEDBACK ON BETA of v1.5.5
That will help :blush: The site is RC101.com
Is there an admin control for mobile cart?
Also, will using a background image slow/ruin a responsive design or is that the point, don't use one for speed and fitment?
-
Re: FEEDBACK ON BETA of v1.5.5
On the Admin, why are you asking? What are you trying to control?
Is there a difference if you turn off Image Handler?
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
Ajeh
On the Admin, why are you asking? What are you trying to control?
Is there a difference if you turn off Image Handler?
Just wanting to fix it myself. I cleared the Image Handler4 Image Cache. Didn't fix anything this time.
I cannot add anything to cart on desktop or mobile. I'll take a break and go to happy hour :cheers:
-
Re: FEEDBACK ON BETA of v1.5.5
I cannot add anything either ... but once I got something to go in the cart and now I cannot delete it ...:cry:
-
Re: FEEDBACK ON BETA of v1.5.5
For you pretty lady, I give you discount. :)
-
Re: FEEDBACK ON BETA of v1.5.5
Javascript error in browser console:
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) trying to load: http://www.rc101.com/includes/templa...olorbox-min.js
-
Re: FEEDBACK ON BETA of v1.5.5
You have force cookie usage on ... you might turn it off to see if it changes anything ...
-
Re: FEEDBACK ON BETA of v1.5.5
All cookie related options are off now.
-
Re: FEEDBACK ON BETA of v1.5.5
I can add to cart again.
Cannot checkout with PP Express
Wholly schnikees!
Error 10006
Version error
Version is not supported
I overwrote the Payment directory with v155 Payment Directory during the 151 to 155 upgrade.
-
Re: FEEDBACK ON BETA of v1.5.5
I could add a few more things and delete things but it is still pretty on again/off again ...
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
webskipper
I can add to cart again.
Cannot checkout with PP Express
Wholly schnikees!
Error 10006
Version error
Version is not supported
I overwrote the Payment directory with v155 Payment Directory during the 151 to 155 upgrade.
There were changes made today to v155 to handle this issue with PayPal changing things on the version...
-
Re: FEEDBACK ON BETA of v1.5.5
[QUOTE=webskipper;1306041][QUOTE=DrByte;1305608]That's to be expected. You still need to run zc_install and choose "Upgrade Database".
Quote:
Fixed corrupted table and upgraded to v155 successfully. Thanks for your help Doc and Kobra!
Few bugs:
Desktop: Main page categories set to 3 categories per row, every other row shows as less than 3. Tried 1 per row and cleared cache. Didn't fix 3 across issue.
Desktop: Unable to add certain products to cart.
Desktop: Unable to delete products from cart at times. (Maybe delayed response?)
Mobile: categories show as 1 per row.
Mobile: unable to add to cart.
I do not want to customer to have to log in to buy, can just use PP Express.
Thanks in advance.
I just submitted the fix for categories boxes alignment.
The rest are not issues with the template package.
On mobile categories do show one per row.
Thanks,
Anne
-
Re: FEEDBACK ON BETA of v1.5.5
@webskipper,
A number of fixes have been committed today. You can see them in date-order here:
https://github.com/zencart/zencart/commits/v155
As of this moment the most recent is the fix you need for your categories box. You will also see the fix for your PayPal issue there too.
-
Re: FEEDBACK ON BETA of v1.5.5
FYI, we've found some display issues related to produce-pagination that we want to fix before release. Hopefully will sort that out tomorrow. Since it's St Paddy's day maybe we'll get lucky :)
-
Re: FEEDBACK ON BETA of v1.5.5
Thanks I'm still applying those fixes. I uploaded and overwrote the v155 Payment Directory with v154. It works on another site of mine. Not on this 155 site.
Admin > Tools > Flexible Footer Menu
[FONT=Verdana, sans-serif]Where are the little images supposed to reside, and what are they named, please?[/FONT]
<td class="dataTableContent">Shop<img src="http://www.mysite/images/" border="0" alt=""></td>
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
webskipper
Thanks I'm still applying those fixes. I uploaded and overwrote the v155 Payment Directory with v154. It works on another site of mine. Not on this 155 site.
You'll need the payment modules directory from the latest v155 zip, or apply those fixes manually.
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
admin password changing fields mis-aligned. Screen fully maximised.
Attachment 16115
-
1 Attachment(s)
Re: FEEDBACK ON BETA of v1.5.5
While examining admin orders.php
1) these form urls have quotation marks and spaces. Are these not considered unsafe characters and so should be encoded?
Attachment 16117
embedded image will not popup so here is an example:
(Note this image is a gif and named as such but the forum software insists on naming it as a jpg)
2) This page has a lot of changes. Why not change the current admin doctype to a valid html5 one to allow the new ids, datatypes etc?
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
torvista
admin password changing fields mis-aligned. Screen fully maximised.
That was resolved in one of yesterday's commits.
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
torvista
While examining admin orders.php
1) these form urls have quotation marks and spaces.
Oops. The class was added as a URL param instead of a form param.
Commits completed.
Quote:
Originally Posted by
torvista
2) This page has a lot of changes. Why not change the current admin doctype to a valid html5 one to allow the new ids, datatypes etc?
... cuz the rest of the page is still full of HTML4 markup and will blow up in your validator :D
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
DrByte
You'll need the payment modules directory from the latest v155 zip, or apply those fixes manually.
Checkout success is still random using v155 PP Express files as of 3/16. Usually only mobile checkout works.
Ability to add/delete products from cart or reduce number of products in cart doesn't work.
Does define('SQL_CACHE_METHOD', 'database'); OR define('SESSION_STORAGE', 'reserved for future use'); affect the process?
Main Page categories per row fix worked. Thanks.
Client Email login works and Forgot My Password does not trigger the error bar /index.php?main_page=password_forgotten
Error: Sorry, there is no match for that email address and/or password.
[/COLOR]
-
Re: FEEDBACK ON BETA of v1.5.5
Quote:
Originally Posted by
webskipper
Ability to add/delete products from cart or reduce number of products in cart doesn't work.
Really bizarre. Can't replicate.
Quote:
Originally Posted by
webskipper
Does define('SQL_CACHE_METHOD', 'database'); OR define('SESSION_STORAGE', 'reserved for future use'); affect the process?
The only thing relevant there is:
a) whatever you're using on the admin side you need to also use on the non-admin side.
b) if you've set it to 'file' and the directory is not writable then nothing can be written. But if you're using 'database' then this is moot.
Quote:
Originally Posted by
webskipper
Checkout success is still random using v155 PP Express files as of 3/16. Usually only mobile checkout works.
Not sure what you mean by "random".
I'm inclined to think whatever you're talking about is related to whatever is causing your particular site to not allow adding products to cart.
-
Re: FEEDBACK ON BETA of v1.5.5
Checkout success is random. Meaning sometimes it works.
Both config files the same. I do not have ssl true at the moment so I'm not using https just http
-
Re: FEEDBACK ON BETA of v1.5.5
webskipper,
We've released the official v1.5.5 this afternoon.
After updating your site to the latest official version, if problems continue, please start a discussion thread for those specific issues.
I'm closing this "beta discussion" thread.
-
Re: FEEDBACK ON BETA of v1.5.5
Hi everyone.
Thanks for all your feedback and participation.
v1.5.5 has been released: https://www.zen-cart.com/showthread....1-5-5-released!