Re: Image Handler 2 Support
Quote:
Originally Posted by
DivaVocals
His (my) lightbox and IH2 touch the same product page files. Since he did not merge these changes, his lightbox wiped out the IH2 code on his product page.
What product page files are you referring to? I just double-checked a directory compare of the two add-ons, and could find no overlapping files. (I was incorrect in what I said about main_product_image.php above.)
Re: Image Handler 2 Support
Quote:
Originally Posted by
nigelt74
Actually come to think of it, have you perchance turned off error/warning reporting, as the functions are still in PHP (I Believe/think), but if the warnings are turned off they should work fine
however when the functions are removed Possibly next version of php it will fail,
as itys a local test server, would you mind trying step 2B here
https://www.zen-cart.com/tutorials/index.php?article=82
I might try it later but i have 2 preschoolers assisting me and until the ZenCart developers pull finger and ###### Bob the Builder to zencart i can't try it yet
if you got this after the 1.3.9 upgrade then go to your cche folder and set its permissions to 777 or 755 on some servers
then go to the page again to see the blank page.
go back to the cache folder and open the file in there to see the error message, it may tell you what or where to start looking.
post it here for help.
Re: Image Handler 2 Support
Quote:
Originally Posted by
stellarweb
To be honest, <wearing my heart on my sleeve> I have "worried" and even taken offense by your posts and because of that I will most certainly not submit updates any other mods to work with 1.3.9 other than the ones I have already submitted HOPING to help the community. I will leave it to others like you to do this and keep my 1.3.9 updated files on my computer and not share them with anyone other than my immediate clients in the future. :(
Sorry you were offended.. Not my intent at all.. I was simply expressing an opinion about how I thought things were handled. There was no anger or malice behind anything I wrote.. (though some might assume otherwise) Again, my concerns centered around the fact that the two mods being out there REALLY would have been a cause for confusion. Surely you can see that right?? (hence why this flurry of posts over the last few days..)
It's too bad you will walk away from this not wanting to share with the community as a result.. I personally think that is an extreme response to this whole situation, but certainly your prerogative to do so if you feel strongly about it..:huh:
Re: Image Handler 2 Support
Quote:
Originally Posted by
mzimmers
What product page files are you referring to? I just double-checked a directory compare of the two add-ons, and could find no overlapping files. (I was incorrect in what I said about main_product_image.php above.)
I am not at my home computer, but here it is in a nutshell.. Somewhere between installing the lightbox and Zen Cart, something is not working on your product page.. It doesn't appear to be a setting, so that leads me to believe it's in the install of the lightbox add-on.. It's possible that it could be another add-on that is causing the problem.. Whatever it is, there is clearly code missing on the product pages that IH2 needs to display the watermarks properly on that page.
Re: Image Handler 2 Support
Quote:
Originally Posted by
DivaVocals
I am not at my home computer, but here it is in a nutshell.. Somewhere between installing the lightbox and Zen Cart, something is not working on your product page.. It doesn't appear to be a setting, so that leads me to believe it's in the install of the lightbox add-on.. It's possible that it could be another add-on that is causing the problem.. Whatever it is, there is clearly code missing on the product pages that IH2 needs to display the watermarks properly on that page.
OK, I can believe that, but again, what exactly do you mean by "the product pages?"
If I have to, I'll delete all the remote copy of both add-ons and re-install, but I'd like some evidence that this will do anything. And, my directory compares reveal no such evidence.
Re: Image Handler 2 Support
Quote:
Originally Posted by
DarkAngel
if you got this after the 1.3.9 upgrade then go to your cche folder and set its permissions to 777 or 755 on some servers
then go to the page again to see the blank page.
go back to the cache folder and open the file in there to see the error message, it may tell you what or where to start looking.
post it here for help.
Opps sorry for wasting your time but I am not getting an error,
What i was referring to was Clyde Jones saying that image handler was working on php 5.3 which it should if error reporting is turned off, however image handler contains depreciated functions specifically ereg_replace and possibly others, i haven't had a chance to look, which means that if error reporting is turned on, your site will be showing warnings at the top of the page, saying something like
Deprecated: Function ereg_replace() is deprecated in blabla
Turning on error reporting would help to find what those errors are, should make it easy to fix image handler to be compatible with php 5.3, unfortunately i don't have access to a php 5.3 server, although I am as we speak downloading one
Re: Image Handler 2 Support
Quote:
Originally Posted by
nigelt74
Opps sorry for wasting your time but I am not getting an error,
What i was referring to was Clyde Jones saying that image handler was working on php 5.3 which it should if error reporting is turned off, however image handler contains depreciated functions specifically ereg_replace and possibly others, i haven't had a chance to look, which means that if error reporting is turned on, your site will be showing warnings at the top of the page, saying something like
Deprecated: Function ereg_replace() is deprecated in blabla
Turning on error reporting would help to find what those errors are, should make it easy to fix image handler to be compatible with php 5.3, unfortunately i don't have access to a php 5.3 server, although I am as we speak downloading one
Some of those ereg_replace() functions have been corrected in some of the files that need to be compared/merged with IH2.
So after doing the comparing/merging I'm not getting the deprecated error(s)
Re: Image Handler 2 Support
Would you like to look at the version I am working on to check for any functions I may have missed??
Quote:
Originally Posted by
nigelt74
Opps sorry for wasting your time but I am not getting an error,
What i was referring to was Clyde Jones saying that image handler was working on php 5.3 which it should if error reporting is turned off, however image handler contains depreciated functions specifically ereg_replace and possibly others, i haven't had a chance to look, which means that if error reporting is turned on, your site will be showing warnings at the top of the page, saying something like
Deprecated: Function ereg_replace() is deprecated in blabla
Turning on error reporting would help to find what those errors are, should make it easy to fix image handler to be compatible with php 5.3, unfortunately i don't have access to a php 5.3 server, although I am as we speak downloading one
Re: Image Handler 2 Support
Quote:
Originally Posted by
mzimmers
OK, I can believe that, but again, what exactly do you mean by "the product pages?"
The page where the watermarks are NOT working. The product detail page (the page with the product pictures, description, attributes, pricing etc).
Quote:
Originally Posted by
mzimmers
If I have to, I'll delete all the remote copy of both add-ons and re-install, but I'd like some evidence that this will do anything. And, my directory compares reveal no such evidence.
You are looking at the evidence.. The image which shows on the product detail page is the medium size image, and there is NO watermark. The large image (which shows when you click the image on the product page) has NO watermark
On the other hand, the product listing page (which contains a LIST of products) has watermarks on the small images, and when you hover over them the MEDIUM images display WITH watermarks..
So clearly the issue is in something being installed wrong.. I suspect that something which affects the product image display on the product detail page is MISSING code which IH2 needs to display the watermarks.. Now I can't tell you WHAT is missing, but I can tell you based on what I see what the issue likely is. It's not a IH2 setting.. Your settings are fine.. The INSTALL is the issue.. and I don't know if it's IH2, the lightbox module or another module you've installed.. but something is not installed properly and is causing the watermarks to not work..
Re: Image Handler 2 Support
Quote:
Originally Posted by
clydejones
Some of those ereg_replace() functions have been corrected in some of the files that need to be compared/merged with IH2.
So after doing the comparing/merging I'm not getting the deprecated error(s)
And a few aren't which is the change I was going to submit.. It's not a BIG change at all..