Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Originally Posted by michaelhl
Hi qhome,
really a great work, you are genial.
But one thing I not really miss, but it can make it better at all. It will be a switch (e.g. a checkbox) on the product.php in admin-area to choose if this article use tabs or not. But I think this is not to realize without doing changes to the core-code.
Also useable may be buttons on the html-editor to insert the soft-tabs.
But now, it a fine contribution and I will use it. THANK YOU.
Michael
:) ya every change i make I keep telling myself "just put this in the admin to make it easier". And now that I have it separate, I can easily put some logic in there to check if the database is set to true for displaying tabs. so I think that will be the next step.
Re: Tabbed Products ''LITE'' version - Delimiter based
The thing is they aren't showing at all. I also just tried your instructions to edit the template and it gives an error as well (even from the original 1.3.5 template code) I tried it twice...
I'm inserting the AaQ code just like on my previous version (no, not between any tabbed code or loops). But I'm guessing has to do with the details not showing up as well. :unsure:
I will love to have the template organized like you did before. :yes:
1 Attachment(s)
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Originally Posted by ideasgirl
The thing is they aren't showing at all. I also just tried your instructions to edit the template and it gives an error as well (even from the original 1.3.5 template code) I tried it twice...
I'm inserting the AaQ code just like on my previous version (no, not between any tabbed code or loops). But I'm guessing has to do with the details not showing up as well. :unsure:
I will love to have the template organized like you did before. :yes:
Ok, well I would advise that you don't follow the Ask A Question directions because the author bundled the AAQ button with the Product Details. If you have product details disabled, then it will also disable the AAQ button.
However, if you are sure you don't have the Product details disabled, You should see them fine. Regardless, I have updated my demo site with the custom version I made that puts the Product Details at the top by the main image.
I've attached is my custom template files with the product details up by the main image and the ask a question actually ABOVE the product details as its own <div>. I also will show the code changes here.
In the tpl_product_display_info.php file (and the music and freeship ones as well)
FIND:
Code:
<!--eof free ship icon -->
RIGHT AFTER THAT PASTE:
Code:
<!-- bof AAQ Link -->
<div id="productQuestions" class="biggerText">
<b><?php echo '<a href="' . zen_href_link(FILENAME_ASK_A_QUESTION, 'products_id=' . $_GET['products_id']) . '">' . ASK_A_QUESTION . '</a>'; ?></b>
</div>
<!-- eof AAQ Link -->
<!--bof Product details list -->
<?php
if ( (($flag_show_product_info_model == 1 and $products_model != '') or ($flag_show_product_info_weight == 1 and $products_weight !=0) or ($flag_show_product_info_quantity == 1) or ($flag_show_product_info_manufacturer == 1 and !empty($manufacturers_name))) ) { ?>
<ul id="productDetailsList" class="floatingBox back">
<?php echo (($flag_show_product_info_model == 1 and $products_model !='') ? '<li>' . TEXT_PRODUCT_MODEL . $products_model . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_weight == 1 and $products_weight !=0) ? '<li>' . TEXT_PRODUCT_WEIGHT . $products_weight . TEXT_PRODUCT_WEIGHT_UNIT . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_quantity == 1) ? '<li>' . $products_quantity . TEXT_PRODUCT_QUANTITY . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_manufacturer == 1 and !empty($manufacturers_name)) ? '<li>' . TEXT_PRODUCT_MANUFACTURER . $manufacturers_name . '</li>' : '') . "\n"; ?>
</ul>
<?php }
?>
<!--eof Product details list -->
<br class="clearBoth" />
<div></div>
Then on Line 165 Find & Delete:
Code:
<!--bof Product details list -->
<?php if ( (($flag_show_product_info_model == 1 and $products_model != '') or ($flag_show_product_info_weight == 1 and $products_weight !=0) or ($flag_show_product_info_quantity == 1) or ($flag_show_product_info_manufacturer == 1 and !empty($manufacturers_name))) ) { ?>
<ul id="productDetailsList" class="floatingBox back">
<?php echo (($flag_show_product_info_model == 1 and $products_model !='') ? '<li>' . TEXT_PRODUCT_MODEL . $products_model . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_weight == 1 and $products_weight !=0) ? '<li>' . TEXT_PRODUCT_WEIGHT . $products_weight . TEXT_PRODUCT_WEIGHT_UNIT . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_quantity == 1) ? '<li>' . $products_quantity . TEXT_PRODUCT_QUANTITY . '</li>' : '') . "\n"; ?>
<?php echo (($flag_show_product_info_manufacturer == 1 and !empty($manufacturers_name)) ? '<li>' . TEXT_PRODUCT_MANUFACTURER . $manufacturers_name . '</li>' : '') . "\n"; ?>
</ul>
<br class="clearBoth" />
<?php
}
?>
<!--eof Product details list -->
THEN in the tpl_tabbed_products_lite.php file
FIND:
Code:
<!--eof free ship icon -->
RIGHT AFTER THAT PASTE:
Code:
<!-- bof AAQ Link -->
<div id="productQuestions" class="biggerText">
<b><?php echo '<a href="' . zen_href_link(FILENAME_ASK_A_QUESTION, 'products_id=' . $_GET['products_id']) . '">' . ASK_A_QUESTION . '</a>'; ?></b>
</div>
<!-- eof AAQ Link -->
Thats it.
The location I put the AAQ link in works good for both text link and image button link.
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Ok, well I would advise that you don't follow the Ask A Question directions because the author bundled the AAQ button with the Product Details. If you have product details disabled, then it will also disable the AAQ button.
I'm not using swguy's AaQ module, I'm using Marg's one (so I just have to insert the code). Your new template it's perfect, I just took off your AaQ code and added mine where I wanted it. Worked perfect. Thanks for your great support and genious contribution. :smartass:
BTW, you DO need to take a look to your latest template code, because these aren't showing at all, and when following instructions from your "How To Port Your Template" file, gives an error.
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Originally Posted by ideasgirl
BTW, you DO need to take a look to your latest template code, because these aren't showing at all, and when following instructions from your "How To Port Your Template" file, gives an error.
When you say "These" what are you referring to? the Product Details stuff?
I'll take another look, but I was pretty sure my step by step guide was working. I used it to make the freeshipping and music templates so I figured going through it a few times would have caught any problems but maybe there was something I didnt think of.
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
Originally Posted by qhome
When you say "These" what are you referring to? the Product Details stuff?
I'll take another look, but I was pretty sure my step by step guide was working. I used it to make the freeshipping and music templates so I figured going through it a few times would have caught any problems but maybe there was something I didnt think of.
If you are referring to the product details, thats because like i said above, my version assumed that they were always off the tabs.. but when i went back to default zc core product info file, they were within the add to cart chack range. So if you had add to cart on your tabs, you wouldn't have them under the tabs.. and that inludes add to cart, attribs, qty discount, and prod details. However, the tabbed data only included Add to cart, attribs, and qty discount.. No more prod details since 2.x.
So yea there is a slight problem there whether or not to just force people to have the prod details up top which IMO looks best. Or make it a separate call so people can still leave them at the bottom. It might be necessary to do that if people want to merge the tabs into their custom product info and leave the prod details where they are by default. Maybe I'll just make them separate.
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
When you say "These" what are you referring to? the Product Details stuff?
Yes, product details list (model, weight, manufacturer, etc.)
Quote:
I'll take another look, but I was pretty sure my step by step guide was working. I used it to make the freeshipping and music templates so I figured going through it a few times would have caught any problems but maybe there was something I didnt think of.
Yes, I did it twice from clean/unedited 1.3.5 template_default file, without adding the AaQ code, and was giving the error.
Quote:
If you are referring to the product details, thats because like i said above, my version assumed that they were always off the tabs.. but when i went back to default zc core product info file, they were within the add to cart chack range.
Yes, you are right. (Maybe this is causing the error on you step by step edit?)
Quote:
So yea there is a slight problem there whether or not to just force people to have the prod details up top which IMO looks best.
IMO too.
Re: Tabbed Products ''LITE'' version - Delimiter based
ok.. just tested the HOW TO PORT file again.. and you are kraaaaazy :P
It ports it perfectly.. still doesn't show the product details of course, but it doesnt give any errors at all.
One question.. are you copying the
Code:
=========================
part too? cuz u should NOT be. I was using those as dividers in that file only. That would cause a php error if u were.
No matter.. i think i will just update it to force people to move the product details stuff up top there. And maybe Ill put the PORT document into Word format so I can color code what you should and shouldn't copy so there are no extra parts being copied.
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
One question.. are you copying the
:laugh: No, I'm not.
Quote:
and you are kraaaaazy
:unsure: I will try again and will report.
Re: Tabbed Products ''LITE'' version - Delimiter based
Quote:
I will try again and will report.
No, I was VERY carefull to add/edit as per instructions (I'm talking of your included file with the zip, haven't looked to your instructions, if any, on the thread).
Parse error: syntax error, unexpected $end in /home/***/public_html/***/includes/templates/burgandy/templates/tpl_product_info_display.php on line 269
***used to cover my directory
I checked for extra/unwanted empty lines at the end of the code, and there's any.