Image Handler Rev 8 - Almost done testing
So here's the deal.. I'm almost done with my testing of the Rev 8 files. Ckosloff has finished testing the Rev 8 files against PHP 5.3, and has indicated to me that Rev 8 is PHP 5.3 compatible. I have been testing against PHP 5.2.x and have no issues there either.
I have tested the new files with Nigel's updated Javascript in IE8, Chrome, Safari and Firefox, and all works wonderfully..:clap: Now that said there are a few significant changes for Rev 8 that I wanted to note before I finalize my testing and bundle this up and submit it.
- No more hotzones - The feature adds no real value to IH2, and it has been removed. The been settings for hotzones have also been removed from Admin > Configuration > Images. In case anyone is wondering, the hover feature works JUST FINE without hotzones.:smile:
- The IH zoom medium images settings has also been removed from Admin > Configuration > Images. This feature HAS NEVER worked because the code required for it to work was NEVER IMPLEMENTED in any IH2 release. I have long suspected that this is largely due to the likely conflicts between the various lightbox contributions and any hovering/zooming code. No matter why, the code is not there, and so the configuration settings code has been removed.
What this means for anyone upgrading to Rev 8 is that you MUST run the uninstall for the version you are currently running BEFORE applying the new Rev 8 files. Otherwise you will get errors!!
Let me say that again, if you are upgrading from ANY version PRIOR to Rev 8 you MUST uninstall the version you are currently running, then copy over the new IH2 files, and then run install to re-activate IH2 Rev 8.
Here's the link to my test site so you can see the newest version of IH2 in action:
http: // zen138 . overthehillweb . com/index.php?main_page=product_info&cPath=1&products_id=1
Re: Image Handler 2 Support
you testing site looks fine. Can't wait to see the new version! thanks!
Re: Image Handler 2 Support
Also let me be PERFECTLY clear.. I take NO CREDIT whatsoever for this new release.. I am only the author of the IH2 readme document..
The REAL credit belongs to ckosloff, and Mano for graciously (and merfifully taking the files I tried to "upgrade" and not only upgrading IH2, but cleaning up and streamliing the code.
Of course an undying thanks also goes to Nigel for toiling away at (finally) full cross browser compatibility for the IH2 javascript..
The real heavy lifting was done by these three gentlemen, and I have made sure that the readme CLEARLY reflects that.:clap:
Re: Image Handler Rev 8 - Almost done testing
Quote:
Originally Posted by
DivaVocals
[*]The IH zoom medium images settings has also been removed from Admin > Configuration > Images. This feature HAS NEVER worked because the code required for it to work was NEVER IMPLEMENTED in any IH2 release. I have long suspected that this is largely due to the likely conflicts between the various lightbox contributions and any hovering/zooming code. No matter why, the code is not there, and so the configuration settings code has been removed.[/LIST]
The zoom medium images DID work with the additional optional extras folder before it was removed for the last update.
I liked the zoom medium images behaviour, whether it worked with lightbox is another thing, i did not have lightbox installed but on it's own it worked just fine and i tested it on all the main browsers.
It's a shame zoom medium images has not been worked on and enabled as the ability to hover over the medium sized image on the page without clicking was in my opinion a very useful feature.
So while you are half right about medium image zoom i can say there was an option and it was available at one point, yes i know you and Ckosloff didn't like it thus removed it but it was a working option at one point.
Is there a reason Medium image zoom does not work or cannot be made to work. ?
Re: Image Handler Rev 8 - Almost done testing
Quote:
Originally Posted by
Mal2809
The zoom medium images DID work with the additional optional extras folder before it was removed for the last update.
I liked the zoom medium images behaviour, whether it worked with lightbox is another thing, i did not have lightbox installed but on it's own it worked just fine and i tested it on all the main browsers.
It's a shame zoom medium images has not been worked on and enabled as the ability to hover over the medium sized image on the page without clicking was in my opinion a very useful feature.
So while you are half right about medium image zoom i can say there was an option and it was available at one point, yes i know you and Ckosloff didn't like it thus removed it but it was a working option at one point.
Is there a reason Medium image zoom does not work or cannot be made to work. ?
The joy of open source...
solution:
take the code, add your own bits to make that feature you like work again. Rename, for example "Mal2809's version of Image Handler2". zip it, submit it... but be prepared for
a) needing your own support thread
b) a million or so support request
c) DivaVocals repeatedly kicking off at you for your version
Re: Image Handler 2 Support
Anybody can take open source and concoct an ugly kludge.
A so-called updated version was causing a support nightmare so I (reluctantly) decided to update IH2, mostly for my own usage.
Guess what? It worked and solved many problems.
Some people like to have huge images popup on medium (main product) images and clutter the page, while at the same time breaking all gallery mods, matter of taste.
But, PLEASE, don't start a war of conflicting versions and add to confusion.
What Diva has said after thoroughly testing the new version makes perfect sense, stick to that and be trouble-free.
BTW, Diva, in the jscript_imagehover.js be sure to include Nigel's correction on lines 87 & 88, 2000 px should be a negative value -2000.
Re: Image Handler Rev 8 - Almost done testing
As I just explained, the code for medium images zoom was never included in Tim Kroeger's original contribution or any subsequent update.
The introduction of the "optional extras" which added this feature was poorly documented/supported, and did not explain that the use of this code would disable any lightbox or jquery contributions rendering them non workable.
The decision to remove the "optional extras" folders from Rev 7 wasn't just because ckosloff and I "didn't like" the feature. It was removed because, based on the posts in the support thread after it's introduction, the "optional extras" created more problems for store owners. The number of support posts related to problems caused by the optional extras made it clear that these folders should not be included in Rev 7. (the version in which the optional extras was removed from the download package)
To answer your question fully, I suspect that the reason Tim did not include this ability (zoom on medium images) in the codebase had everything to do with managing compatibility between zoom on medium images functionality with the MANY contributions which affect product image behavior. For example:
- Attribute image replaces main product image on selecting attribute
- Attribute Pop-up (Large Images)
- External Product Images
- Fual Slimbox (Lightbox)
- Zen Lightbox
In our analysis we realized that the best way to add zoom on medium images and still provide those store owners who like/want lightbox features (and other similar product image effects) would probably require incorporating these features directly to the IH2 codebase. To maintain full store owner control and flexibility, the codebase would have to include the following features:
- Admin configurable zoom on medium images
- Admin configurable lightbox effects
- The ability for zoom on medium images to work if lightbox features are activated.
The work required to add zoom on medium images AND lightbox effects required a lot more coding work than ckosloff and Mano were willing to invest on a volunteer basis.
So in the end this work is left to anyone else in the open source community who wants to tackle a re-write of IH to fully incorporate (and hopefully SUPPORT) the addition of these features. Sure anyone can add a hack to cobble in zoom on medium images, but IH is a well written contribution, and if the feature is going to be added, then it should be done in the smae careful manner IMO.. In the meantime I will include in the readme links to the thread which shows how to add zoom on medium image along with the appropriate cautions about incompatibility with lightbox and other similar contributions.
The intent of the Rev 7 version of IH2 was to cleanup IH2. The intent of the Rev 8 release was to further that code cleanup along with incorporating PHP 5.3 compatibility. I am grateful for the efforts of the three gentlemen who volunteered their efforts to that end!:smile:
IH2 at the heart of it's code is really meant to ease the management of product images (particularly the management of additional product images), and to help improve page performance by optimizing the product images. Fancy image functions such as zooming are really just extra features. Nice to have features for sure, but IMO they are not "the reason" to use IH2.
Quote:
Originally Posted by
Mal2809
The zoom medium images DID work with the additional optional extras folder before it was removed for the last update.
I liked the zoom medium images behaviour, whether it worked with lightbox is another thing, i did not have lightbox installed but on it's own it worked just fine and i tested it on all the main browsers.
It's a shame zoom medium images has not been worked on and enabled as the ability to hover over the medium sized image on the page without clicking was in my opinion a very useful feature.
So while you are half right about medium image zoom i can say there was an option and it was available at one point, yes i know you and Ckosloff didn't like it thus removed it but it was a working option at one point.
Is there a reason Medium image zoom does not work or cannot be made to work. ?
Re: Image Handler 2 Support
Quote:
Originally Posted by
ckosloff
Anybody can take open source and concoct an ugly kludge.
Yes... why not...
do you have a problem with someone taking your open source code and playing with it to suit their needs... so long as it is well documented on what it does, doesn’t do and what it breaks/doesn’t break etc, and that decision should be taken by the ppl who authorise mods for download.
If you do have that problem, why allow it to be open source?
id say 70% of the mods on this site are ugly broken mods...
I personally used to think IH2 was great, until my host upgraded to php5.3 and watermarks stopped working.. i got sick of waiting for an update so paid for image mod based on IH2. does everything IH2 does but slightly better, i can add multiple images directly from the product listing page without having to click around the admin to add multiple images.. Etc...
my point being, IH2’s beauty of code is subjective and you have no right to tell someone what they can and cannot do with open code… if he wants to creat a fork of IH2.. Let him.. What difference does it make to you, if my memory is right, I seem to remember you semi-jumping ship to join/start a ZC fork.
Each to their own... let him do what he wants without you chirping on
Re: Image Handler 2 Support
Quote:
Originally Posted by
ckosloff
BTW, Diva, in the jscript_imagehover.js be sure to include Nigel's correction on lines 87 & 88, 2000 px should be a negative value -2000.
Yes sir!:smile: The latest version of Nigel's script is what's on my test site.. Made the change last week when Nigel posted the change..
Re: Image Handler 2 Support
Just a quick note to Diva, CKoslof and all others working on the IH2 mod to say thanks for working on this and I appreciate the time you are taking to do this in your 'spare' time. I am redesigning my site for 139 and am patiently awaiting the final IH2 r8 package to finish it off. You guys are awesome!
