Re: Edit Orders v4.0 Support Thread
Looking for some community feedback
In an effort to make using Edit Orders easier to use (and more intuitive) a few changes have been proposed to the handling of products and attributes. Additional ideas / thoughts are welcome.
Background
Currently product and attribute fields in Edit Orders always override any automatic calculations. This behavior allows store owners to change / alter names, prices, taxes, onetime charges, etc. However if a store owner changes an attribute, price changes (onetime and total) are not updated to reflect the change (because they are overridden by the editable fields).
Proposal #1
- Only allow editing the quantity, name, and tax, and attributes on products by default.
- Do not allow editing of price and onetime charges.
Proposal #2
- Allow editing everything by default.
- Add a "checkbox" to indicate charges should be recalculated (ignoring the input fields).
Proposal #3
- Only allow editing the quantity, name, and tax, and attributes on products by default.
- Add a "checkbox" to enable editing of price and onetime charges.
- Save the preference to a new database field (remember for the customer + order + product).
Initial Thoughts
Proposal #1 would be the easiest to implement and continues the process of moving Edit Orders towards mimicking the customer facing experience. Store owners can still manipulate the overall price of the order using the included "ot_onetime_discount" order total module. Use of a separate order total module provides additional data for the creation of reports on margin erosion and discounting (and supports auditing).
Proposal #2 would require a little more coding, but retains the current behavior of Edit Orders (while optionally allowing "recalculation" of pricing according to product / attribute rules). One of my great dislikes about this proposal: allowing direct edits by default encourages store owners to be lazy and just edit product pricing (without entering auditing information). Generating a report of margin erosion and discounting becomes much more difficult (and in some cases will provide less data). I feel if prices need to be changed frequently after an order has been placed the price of the product (or attributes) should be changed instead.
Proposal #3 would require additional database and PHP coding. This proposal is a compromise between Proposal #1 and Proposal #2. By default store owners are not allowed to change product pricing. By requiring store owners to check another checkbox (per product), hopefully it would at the least spark the thoughts: "Why is this not the default? Can it cause issues? Is there another (better) way?".
Re: Edit Orders v4.0 Support Thread
FWIW, my choice would be Proposal #1 for the reasons you stated.
Re: Edit Orders v4.0 Support Thread
Quote:
Originally Posted by
lat9
FWIW, my choice would be Proposal #1 for the reasons you stated.
**nods in agreement** :yes:
Re: Edit Orders v4.0 Support Thread
I keep getting a "The webpage cannot be found" when I click the Edit button on the order page. The URL is "myadmin/FILENAME_ORDER_EDIT.php?oID=1013".
I have Super Orders 4.0.4 installed and also had Edit Orders 4.0.4 installed. It worked fine. Then I wanted to update Edit Orders to version 4.1.4. It installed fine without errors, the only problem is when I click the Edit button.
I tried completely uninstalling Edit Orders and reinstalled again, but same problem happens.
What am I doing wrong?
Re: Edit Orders v4.0 Support Thread
Quote:
Originally Posted by
DML73
I keep getting a "The webpage cannot be found" when I click the Edit button on the order page. The URL is "myadmin/FILENAME_ORDER_EDIT.php?oID=1013".
I have Super Orders 4.0.4 installed and also had Edit Orders 4.0.4 installed. It worked fine. Then I wanted to update Edit Orders to version 4.1.4. It installed fine without errors, the only problem is when I click the Edit button.
I tried completely uninstalling Edit Orders and reinstalled again, but same problem happens.
What am I doing wrong?
Missing a define for FILENAME_ORDER_EDIT. Either file not uploaded, not uploaded completely.
Re: Edit Orders v4.0 Support Thread
This is also common when the "install" step of Edit Orders 4.1.x (inside Zen Cart) is skipped (or does not complete successfully and displays a warning)... Or Super Orders is installed after Edit Orders and the Edit Orders "install" step has not been run again.
Basically the constant changed in Edit Orders 4.1.x (and the installer automatically fixes the constant name for older versions of Super Orders).
Re: Edit Orders v4.0 Support Thread
Quote:
Originally Posted by
lhungil
This is also common when the "install" step of Edit Orders 4.1.x (inside Zen Cart) is skipped (or does not complete successfully and displays a warning)... Or Super Orders is installed after Edit Orders and the Edit Orders "install" step has not been run again.
Basically the constant changed in Edit Orders 4.1.x (and the installer automatically fixes the constant name for older versions of Super Orders).
Thanks, the problem is that I did do the install step and it did say that the installation was successful. Also, Super Orders was installed before I installed Edit Orders. I carefully followed all installation instructions.
When I check admin/orders.php then I can see that all instances of FILENAME_ORDER_EDIT has not been replaced with FILENAME_EDIT_ORDERS as I believe it should. Any ideas why?
Re: Super Orders + Edit Orders
Quote:
Originally Posted by
DML73
... When I check admin/orders.php then I can see that all instances of FILENAME_ORDER_EDIT has not been replaced with FILENAME_EDIT_ORDERS as I believe it should. Any ideas why?
So when you RERUN the "install" step of Edit Orders you only see a "success" message, no other messages? Very curious! A preg_replace is run over the contents of the file checking for FILENAME_ORDER_EDIT and replacing with FILENAME_EDIT_ORDERS. If unable to write the contents of the changed file to disk the installer then reports a warning message...
Unless of course you have a version of Super Orders 4.0.6+ installed and manually changed the "orders.php" included with Super Orders (to make it work with Edit Orders 4.0.x)... Another possibility could be left over database entries from a failed attempt to install a newer version of Super Orders... Versions of Super Orders >= 4.0.6 already include the necessary changes to work with Edit Orders 4.1.x. So when the Edit Orders installer detects a newer version of Super Orders (from the database), the installer does not run the above check / replace against "orders.php"...
NOTE: If you have a development copy of the site somewhere exhibiting this behavior I would be interested in taking a further look at the database and files... Feel free to send me a PM with applicable information and when I get some time I will take a look.
Re: Super Orders + Edit Orders
Quote:
Originally Posted by
lhungil
So when you RERUN the "install" step of Edit Orders you only see a "success" message, no other messages? Very curious! A preg_replace is run over the contents of the file checking for FILENAME_ORDER_EDIT and replacing with FILENAME_EDIT_ORDERS. If unable to write the contents of the changed file to disk the installer then reports a warning message...
Unless of course you have a version of Super Orders 4.0.6+ installed and manually changed the "orders.php" included with Super Orders (to make it work with Edit Orders 4.0.x)... Another possibility could be left over database entries from a failed attempt to install a newer version of Super Orders... Versions of Super Orders >= 4.0.6 already include the necessary changes to work with Edit Orders 4.1.x. So when the Edit Orders installer detects a newer version of Super Orders (from the database), the installer does not run the above check / replace against "orders.php"...
NOTE: If you have a development copy of the site somewhere exhibiting this behavior I would be interested in taking a further look at the database and files... Feel free to send me a PM with applicable information and when I get some time I will take a look.
That is correct, I have run the "install" step several times and every time I get a green successful message, without any error or warning messages.
The current version of Super orders I have is 4.0.4, I installed that long time ago, and I don't recall that I have manually changed the orders.php or have any failed attempts to install Super Orders.
Could the problem be that my current version of Super Orders is 4.0.4?
Should I try and uninstall Super Orders and then install version 4.0.9?
Re: Super Orders + Edit Orders
Ok I removed Super Orders 4.0.4. I removed it instead of upgrading just to be sure everything is removed. Then I installed Super Orders 4.0.9 and it installed and works without errors or problems. Then I ran the install step for Edit Orders and got the following error when I click the "Admin home" link in Admin:
Filesystem Error: Unable to access 'myadmin/includes/init_includes/init_eo_remove.php'. Please make sure the file exists on the webserver and the webserver has access to read the file!
Error Edit Orders installation / upgrade failed!
As far as I can see then init_eo_remove.php is not a part of the Edit Orders module, I can't find that file in the 4.1.4 version installation folder, so why is the installation asking for that file?? and what can I do to solve the problem ? :blink:
