[Done 155b] Shipping tax not added in order confirmation - possible bug??

Quote:

---

Originally Posted by mmcculli

I have moved the line down and it seem to have worked. Taxes on Shipping are now showing up as they did before I upgraded to 1.5.5a. So this very small change looks to have fixed the issue.

So what are the side-effects of this change?

---

Hi

Currently hoping there aren't any. I updated our functional test suite recently, just to test this. The changes did not break any of the tests relating to tax calculations.

I am not really sure of your internal process with bugs. I assume you need to run the change through some regression test units. So do I wait for an official patch or will you just reply to this thread if it looks ok for me to move live.

At this point our internal tests are showing no obvious ill side effects.

If it were my site I'd go live with it now ... and keep a careful eye on order traffic and any errors in the /logs/ folder, etc.

Maybe this could/should be added to the "Known Bugs (and fixes) with v1.5.5" tread, so people know why the have tax issues?

Quote:

---

Originally Posted by rued

Maybe this could/should be added to the "Known Bugs (and fixes) with v1.5.5" tread, so people know why the have tax issues?

---

Are you saying you've been encountering this same issue yourself?

Several people have, including me on several sites, yes.
Have disabled most countries and turned of zone restrictions for now in a few sites, but most are pending updating because of this bug.

Quote:

---

Originally Posted by rued

Several people have, including me on several sites, yes.
Have disabled most countries and turned of zone restrictions for now in a few sites, but most are pending updating because of this bug.

---

I wish I could reproduce it. Particularly because I want to understand why it wasn't an issue in v154, especially since the code in the proposed fix didn't change between versions.

Beyond reproducing it I'd be even more interested in knowing exactly what's caused the change between versions.

Oh, I'll make you a test site then, after my holiday - or on a rainy day. :)

Hi all,

I can confirm the same issue happened to me upgrading from v1.5.1 to v1.5.5a. I thought I had corrupted something, but then found this post. I turned off the zone on the shipping module as suggested by Ajeh and it started to work as expected. So I've just implemented Dr Byte's suggested code change and all working again with a zone specified in the shipping module. I'll update you all if there are any logs or side effects appearing.

Thanks!

Hi all,

As an update to the fix DrByte mentioned. It works fine for my worldpay payment, however when a customer pays 'on account' using the invoice mod from the add ons the shipping is once again calculated without tax on the shipping. I can rectify the issue by removing the zone from the shipping module again.

Is anyone else able to re-produce this error?

It is worth noting that the invoice mod is only officially compatible with v1.5.1, however I can't see where in its code it would effect the shipping tax? And if it happens with this payment add on, how many others may be affected?


If anyone else could offer any ideas, they'll be much appreciated.

Thanks all!