The latest version 1.2 is for 1.3.5 but it should work on 1.3.x as well... Haven't done much testing on that...Quote:
Originally Posted by azrahn
If you don't have 1.3.5, I would recommend to update...
Printable View
The latest version 1.2 is for 1.3.5 but it should work on 1.3.x as well... Haven't done much testing on that...Quote:
Originally Posted by azrahn
If you don't have 1.3.5, I would recommend to update...
Quote:
Originally Posted by djimmy
I must have been hungry or tired... or both... Of course you mean VAT-mod version 1.2 :D We will look in to it! see what might have gone wrong... We'll get back...Quote:
Originally Posted by Beez
I think I found the bug, the fix was really simple:Quote:
Originally Posted by Beez
--- includes/modules/order_total/ot_shipping.php.sav 2006-09-22 03:18:27.015818936 +0200
+++ includes/modules/order_total/ot_shipping.php 2006-09-22 03:26:02.403589472 +0200
@@ -94,7 +94,7 @@
}
}
$calculated_tax = zen_calculate_tax($order->info['shipping_cost'], $shipping_tax);
- if(!$tva_tax){
+ if($tva_tax){
$order->info['tax'] += $calculated_tax;
$order->info['tax_groups']["$shipping_tax_description"] += $calculated_tax;
$order->info['total'] += $calculated_tax;
(aka: remove the "not" from the second 'if(!$tva_tax){' in the file includes/modules/order_total/ot_shipping.php)
With this change the calculations look correct to me.
Have fun,
- Haegar
That's fine !!
Thanks.
Hello Beez,
thanks for the update.
I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"
Also, the error "your VAT ID does not match the Country" is not showing up as well
Dimi
Hi developer,
I think I found a bug. After rechecking the mod 3 times I do not think it is a copy/paste error.
Into the adminsection the admin is able to change customer details.
When the customer details contains a VAT number, then with the update action the screen becomes blank. This is ONLY when VAT check is on in the parametersettings of this mod.
However the customer can change his details from the frontend without problem.
I have searched for a solution in the code but was not able to determine where the problem is.
I gues it should be in /admin/customers.php there where a check is done if the check should be done or not, arround line 116
if ( ENTRY_TVA_INTRACOM_CHECK == 'true') {
if (strlen($entry_tva_intracom) != 0) {
if ($entry_country_id != false) {
$countries_array = $db->Execute("select countries_iso_code_2 from " . TABLE_COUNTRIES . " where countries_id = '" . (int)$entry_country_id . "'");
if ( (array_search($countries_array->fields['countries_iso_code_2'], array_keys(zen_get_tva_intracom_array())) === false) || (array_search(substr(strtoupper(trim($entry_tva_intracom)),0,2), zen_get_tva_intracom_array()) === false) ) {
$error = true;
$entry_tva_intracom_error = 'true';
Thanx haegar!Quote:
Originally Posted by haegar
I'll try it too and add it to the next version.
That is correct, it doesn't work! And it's not a copy/paste error, at least not from you :)Quote:
Originally Posted by Janneman
To fix this copy the file: /includes/functions/extra_functions/functions_vatmod.php
To: /admin/includes/functions/extra_functions/functions_vatmod.php
That should do it, we just forgot that file :smile:
What the f***! :shocking: this is strange! We'll look in to it as soon as we can!Quote:
Originally Posted by pivey
Anybody els having this problem with the latest version (1.2)?
Cheers Mates!
You are right, it still doesn't work! I'll try to fix this upcoming week, when vike gets back...Quote:
Originally Posted by pivey
Ok, I've fixed it... Stupid me, when I "fixed" it last time I only fixed it in the address book, under My Account... :eek:Quote:
Originally Posted by pivey
The Fix: In the file /includes/modules/create_account.php on line 125-126 change:
To:Code:$country_code = zen_get_countries_with_iso_codes($country);
if ( (array_search($country_code['countries_iso_code_2'], array_keys(zen_get_tva_intracom_array())) === false) || (array_search(substr(strtoupper(trim($tva_intracom)),0,2), zen_get_tva_intracom_array()) === false) ) {
At least that works for me :smile: Could you please try it out before I upload it to the download section...Code:$country_code =zen_get_countries_with_iso_codes($country); $intracom_array=zen_get_tva_intracom_array();
if(substr(strtoupper(trim($tva_intracom)),0,2) != $intracom_array[$country_code['countries_iso_code_2']]){
There are some other things that have been moved from admin/includes/functions/general.php to the new file admin/includes/functions/functions_vatmod.phpQuote:
Originally Posted by Janneman
And in the latest install-file the changes for admin/includes/functions/general.php were missing. But I think the files were correct.
Please download the latest version of the VAT-mod (1.2.1) from here
NOTE: This is just a temporary package, the real one will be uploaded shortly to the download section. This package contains all fixes mentioned in this thread so far. But I haven't haegar's fix yet, though it's in the package. Just so you know...