Re: Image Handler 2 Support - PHP5 breaks it
In don't know if anyone's aware, but PHP5 seems to break the png aspect of IH2.
I got an error with png images, and found this thread: which appears to be the fix, but I can't find the right code in IH2.
Perhaps someone else with da skillz might take a look!
I got round it by switching back to php4 in .htaccess, but I'd rather run 5 as it seems quicker.
Re: Image Handler 2 Support
hi guys,
I need some help here:
I've installed image handler, both in zencart on my box and the one that's going to be the production server.
However, when I upload an image, the resized versions are diplayed only in image handler section in admin, not elsewhere (and not in the catalog). The original images are shown instead.
Now, I think I've seen a post with a solution to this or a post linking to a solution, but I wasn't able to find it so far :(
safe_mode off, btw.
Thanks for any help on this :)
Re: Image Handler 2 Support
Quote:
Originally Posted by GazLuvsStace
I am just about to install this module and I am conerned about overwriting existing PHP files. In the past, addons that simply overwrite existing files, usually break the code. I have noticed that the following files will be overwritten:
admin/includes/modules/category_product_listing.php
includes/functions/html_output.php
includes/modules/additional_images.php
includes/modules/main_product_image.php
includes/modules/pages/popup_image/header_php.php
includes/modules/pages/popup_image_additional/header_php.php
includes/template_default/popup_image_additional/tpl_main_page.php
Is it safe to overwrite these files? How can I be sure that a more recent update to Zen-Cart did not change any of these files (and would therefore be broken if I overwite them)? just wondering it would still work if i pur them in template folder (as in the locations they need to be tho)
FIRST BACKUP!
No overides in admin. So overwrite.
Same with includes/functions
Theory says you should be able to override /includes/modules by using /includes/modules/YOUR_TEMPLATE.
But that does not always work. So for IH2 Final I suggest overwriting files in /includes/modules (that's what I did).
And also overwrite the two files in 'pages' subdirs. Did I say backup first?
But use overrides for all templates.
includes/YOUR_TEMPLATE/popup_image_additional/tpl_main_page.php
IH2 Final was released AFTER Zen Cart 1.3.0.1. Tim always uses latest Zen Cart files in his updates. But you should always compare files with a compare utility to before overwriting. (e.g. Beyond Compare or WinMerge). To ensure you will not be overwrite your own customizations and ensure you have correct Zen Cart code revision.
Woody
Re: Image Handler 2 Support
Quote:
Originally Posted by Woodymon
FIRST BACKUP!
No overides in admin. So overwrite.
Same with includes/functions
Bzzt! Warning!
html_output not only gets over-written, but it is a core file which several other (I can think of at least 3) plugins modify.
I've seen certain contribs lately that have renamed copies of the file in the folder, so the cart owner can make the choice to rename and wipe the original, or merge it in.
(Another reason for full over-rides!)
Re: Image Handler 2 Support
Hi Tim & others,
i just noticed that one of the fuctions i used on the previous version of image handler seems to be missing on 2.0
when added a new product / editing on i no longer have the ability to indicate that the image i am uploading is an additional product - is this functionality removed?
Thanks,
Kevin
>> i can't seem to figure out how to upload an additional image at all
did i miss a file upload?
Re: Image Handler 2 Support
Quote:
Originally Posted by kelvyn
html_output not only gets over-written, but it is a core file which several other (I can think of at least 3) plugins modify.
I've seen certain contribs lately that have renamed copies of the file in the folder, so the cart owner can make the choice to rename and wipe the original, or merge it in.
(Another reason for full over-rides!)
Off the top-of-your-head which three mods modify html_output.php?
Yes full overrides is the eventual goal. Until that time...
BACKUP and always run the files through a compare utility. And when testing mods of course this should not be done on a production shop. Hello. If having troubles with mods working correctly then a good testing method is to NOT include ANY code from other customizations/mods. I recommend creating a clean image of a pre-configured Zen Cart installation (fresh db too) which can be uploaded and quickly updated to test a specific mod. This is best scenario when having issues. Then you can install other needed mods to test if for negative interactions/reactions.
Yes renaming a file rather than overriding can sometimes be a safeguard but does not work all the time. You do not want to leave non-working files in some directories as that will cause havoc.
Most folks who ask questions on the mod forums should understand if they have previously installed/uploaded mods or customized their code. And they would know this if following the golden rule of documenting all modifications. Then overwriting (again after backing up) should be a low risk issue.
But again as a rule I run a compare before over writing.
I maintain a spreadsheet documenting files uploaded by each contribution or patch I install and document each time I customize a,file including core files. Then I check against this document whenever installing or updating mods or when modifying code, including official Zen Cart patches.
Would be cool if a "community DB" could be maintained documenting the core files modified by third party mods. Of course checking in changes, keeping it up-to-date and correct could be a daunting mangement task.
Woody
Re: Image Handler 2 Support
Quote:
Originally Posted by Woodymon
Off the top-of-your-head which three mods modify html_output.php?Yes full overrides is the eventual goal. Until that time...
Of the ones I've just installed, and off the top of my head:
IH2, any of the SEO / SEFU contribs and "ask a product question".
So in fact, 25% of all the mods I've installed mess with html_output.
Completely agree with your points, there, too!
Re: Image Handler 2 Support
Quote:
Originally Posted by kelvyn
Of the ones I've just installed, and off the top of my head:
IH2, any of the SEO / SEFU contribs and "ask a product question".
So in fact, 25% of all the mods I've installed mess with html_output.
I don't see that file gets modified very often in 1.3x. Ask a question (Marge) does not modify html_output. You may be referring to another similarly named mod?
On one shop I have 25 mods installed and many other customizations. Of these mods IH2 is the only one to modify /includes/functions/html_output.php
Woody
Re: Image Handler 2 Support
Quote:
Originally Posted by Woodymon
I don't see that file gets modified very often in 1.3x. Ask a question (Marge) does not modify html_output. You may be referring to another similarly named mod?
Ask A Question for Zen-Cart v1.3.0
Created by: Marg Davison marg AT marg-art DOT com
Code:
====[ ALTER FILES ]===================================================================
Open - includes\functions\html_output.php - Add the following to the end before the ?>
/*
* Output a ASK-A-QUESTION form input field
*/
function zen_draw_input_field_ask_a_question($name, $value = '', $parameters = '', $type = 'text', $size = '22',
$reinsert_value = true) {
$field = '<input type="' . zen_output_string($type) . '" size="' . zen_output_string($size) . '" name="' .
zen_output_string($name) . '"';
if ( (isset($GLOBALS[$name])) && ($reinsert_value == true) ) {
$field .= ' value="' . zen_output_string(stripslashes($GLOBALS[$name])) . '"';
} elseif (zen_not_null($value)) {
$field .= ' value="' . zen_output_string($value) . '"';
}
if (zen_not_null($parameters)) $field .= ' ' . $parameters;
$field .= ' />';
return $field;
}
Yes, you're right, I must be looking at the OTHER ask a question contrib by the other marge ;)
Quote:
Originally Posted by Woodymon
On one shop I have 25 mods installed and many other customizations. Of these mods IH2 is the only one to modify /includes/functions/html_output.php
Woody
I'd be interested to know what you use for your URL rewrites!
Re: Image Handler 2 Support
Quote:
Originally Posted by kelvyn
Ask A Question for Zen-Cart v1.3.0
Yes, you're right, I must be looking at the OTHER ask a question contrib by the other marge ;)
Been running the Ask A Question for 1.30 from same author. The readme says version 1.0 and is dated 04-06-06. Does not mention anything of editing html_output.php. Strange. And I did not see announcment of updated version. This I just re-downloaded ask_a_question_v1.3.0.zip and the mod readme still shows version 1.0. However the template file and the readme in the latest package are indeed diff from my version and readme now suggests editing html_output as you quoted. But no new features are indications the mod was updated is in readme. The previous v1.0 mod I downloaded works fine for me. Thanks for the update. Wonder what is different in the new version and why Marg did not announce anywhere?
Quote:
I'd be interested to know what you use for your URL rewrites!
No URL rewriting implemented. I have quality search rankings/PR's and don't want to mess them up, even if for the short term.[/QUOTE]
@Tim - Apologies for hijacking the IH2 thread. Moving the Ask A Question discussion to http://www.zen-cart.com/forum/showthread.php?p=206085
Woody