Printable View
Turns out, the correction can be made by adding the following block to the bottom of /admin/stats_sales_reports.php's additional CSS block:Quote:
Originally Posted by lat9
Code:<?php
if (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR > '1.5.6') {
?>
#spiffycalendar { left: 10px!important; }
<?php
}
?>
Thanks for the fix carlwhat. I checked most of the places I could remember that use the SpiffyCal (Specials, SaleMaker, Featured Products) and your fix doesn't seem to adversely affect the ability to select a date, however on the Featured Products admin page it does push the calendar off the page to the right, but at least the browser can scroll over to select a date on that one.
I will try lat9's fix instead.
!important => i hate !important.... almost as much as i hate globals.... but a topic for another day.Quote:
Originally Posted by lat9
i'm going to investigate using datepicker. seems in use for collect info on the admin/product. and is part of the jquery ui library. might be a better solution and would make sense to be consistent through out.
best.
Yes, I try to avoid !important, but when it's the only option (other than carving up a core-file:yuck:) ...Quote:
Originally Posted by carlwhat
Like carlwhat mentioned, I do think using the datepicker from jQuery UI would be better choice at this point.
As this bug is NOT only in your plugin... it affected literary any plugins that use the SpiffyCal.
Even the "E-Mail Archive Manager" face exact same bug problem!
Therefore, it would be best if the Zen Cart's core file and/or the plugins migrated to jQuery's datepicker instead.
(In fact, on my custom form used datepicker already... gotta test it out to see if I can substituted on SpiffyCal codes.)
So many Zen Cart's admin pages are using SpiffyCalendar!
https://i.imgur.com/Qq8TLqZ.png
Sadly, that's not really good calendar to be use anymore.
But, does not Zen Cart already implement Bootstrap?
Then I suppose we can also use the Bootstrap's Datepicker!
https://bootstrap-datepicker.readthedocs.io/en/latest
https://buildmedia.readthedocs.org/m...datepicker.pdf
---
However, it seems those two datepickers have to be in the "form."
For example, in my custom "Rental Form," I have the following codes for the rental date ranges.
https://i.imgur.com/gbVJvWj.png
In this form, I set the end date based on starting date and starting date must be today or future's dates.
Hence the reasons I have to have hidden fields to check on date values.
In a separate JavaScript file...HTML Code:<input type="hidden" id="rental_startdate_temp" value="<?php echo isset($_POST['rental_startdate']) ? $_POST['rental_startdate'] : ''; ?>" />
<input type="hidden" id="rental_enddate_temp" value="<?php echo isset($_POST['rental_enddate']) ? $_POST['rental_enddate'] : ''; ?>" />
<label class="inputLabel">Rental Dates:</label>
<div id="two-column">
<div id="left">
<label class="inputLabelA" for="rental_startdate">Delivery</label>
<input type="text" id="rental_startdate" name="rental_startdate" />
</div>
<div id="right">
<label class="inputLabelB" for="rental_enddate">Return</label>
<input type="text" id="rental_enddate" name="rental_enddate" />
</div>
</div>
<br class="clearBoth" />
The "Keyword Capturing Dashboard" plugin is also using jQuery's datepicker.Code:$(function() {
//Datepicker's on "Rental Starting Date" field.
$( "#rental_startdate" ).datepicker({
minDate: 0,
changeMonth: true,
numberOfMonths: 3,
onSelect: function( selectedDate ) {
$( "#rental_enddate" ).datepicker( "option", "minDate", selectedDate );
$( "#rental_enddate_temp" ).val(selectedDate);
}
});
//Datepicker's on "Rental Ending Date" field.
$( "#rental_enddate" ).datepicker({
minDate: 0,
changeMonth: true,
numberOfMonths: 3,
onSelect: function( selectedDate ) {
$( "#rental_startdate" ).datepicker( "option", "maxDate", selectedDate );
$( "#rental_startdate_temp" ).val(selectedDate);
}
});
// If user had put rental starting date, data will be retrieved from hidden field.
if ($("#rental_startdate_temp").val()!= '') {
var rentStartDateText = $("#rental_startdate_temp").val();
$("#rental_startdate").val(rentStartDateText);
}
// If user had put rental ending date, data will be retrieved from hidden field.
if ($("#rental_enddate_temp").val()!= '') {
var rentEndtDateText = $("#rental_enddate_temp").val();
$("#rental_enddate").val(rentEndtDateText);
}
});
https://i.imgur.com/szb76jT.png
So I am positive that datepicker can be completely replace the SpiffyCalendar.
However, it seems that codes were optimized around it and hence it is not simply just replace SpiffyCalendar into the datepicker one... There has to be some dependencies that possibly have to ensure the replacement is properly done.
I've just submitted v3.3.0 of Sales Report to the Zen Cart moderators for review and will post back when it's available for download.
This release contains changes associated with the following GitHub issues:
#5: zc156, calendar displays off-screen
#6: Correct various PHP Notices.
#8: Correct error when specific products/customers indicated, but no list supplied.
#9: Add a setting to exclude orders-status values.
#10: "Remember" the admin's selection for 'Open report in new window'.
#11: Convert javascript to jQuery.
#12: Convert HTML to HTML5.
#13: Use the customer's name from the order, not the customers table.
Now available for download!Quote:
Originally Posted by lat9
Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=9Quote:
Originally Posted by lat9