Sales report 2.0

Quote:

---

Originally Posted by bbsbcastle

I know this is a bit old, but I was running into the same problem. The issue is, the report is deducting the sales tax from the product sales, which it should not.

In admin/includes/classes/sales_report.php line 385, I changed it from

$product_price_inc_tax = (zen_add_tax($final_price, $tax) * $quantity) + zen_add_tax($onetime_charges, $tax);

to

$product_price_exc_tax = ($product_price_inc_tax - $product_tax);

Now it calculates correctly. It's a quick hack, but it works. Someone could take the time to make a more elegant solution. I don't understand why it's doing this since Sales Tax is clearly additive to the total.

---

...so the zen_add_tax( function (see admin/includes/functions/general.php) only adds the price in, if you have DISPLAY_PRICE_WITH_TAX_ADMIN set...

so if you have your zen-cart set-up so that DISPLAY_PRICE_WITH_TAX_ADMIN is 0 or off, your sales tax will appear to be deducted twice, when in fact it was just never really added in admin/includes/classes/sales_report.php line 385

Code:

---

$product_price_inc_tax = (zen_add_tax($final_price, $tax) * $quantity) + zen_add_tax($onetime_charges, $tax);

---

I changed line 385 to the following

Code:

---

$product_price_inc_tax = zen_round($final_price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']) + zen_calculate_tax($final_price, $tax);
$product_price_inc_tax += zen_round($onetime_charges, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']) + zen_calculate_tax($onetime_charges, $tax);

---

Now I get VALID instead of DON'T MATCH and my tax revenue does not appear to be missing from the report.

Quote:

---

Originally Posted by bseller

I just installed SALES REPORT Version 2.3.2. I have the same problem with Goods Value subtracting sales tax. Isn't this a basic bug that can be fixed?

I am curious if your changes are working properly and if you ever received feedback?

I appreciate your help.

---

While I see that this question has got no response to it, it did work for me. Thanks.

Hi,

Can the "order date" be added to the report listing easily? Maybe between ID and Customer.

I've just submitted v3.2.0 of the "Sales Report" to the plugins for review; I'll post back here once it's available.

This version contains the following changes/bugfixes:

[CHANGE] Updated class selector for use under PHP 7.0 and later
[BUGFIX] Column-count "off" for CSV output when taxes are included.
[BUGFIX] Manufacturer filter was not being honored
[CHANGE] Applied PSR-2 styling to the various modules.
[BUGFIX] Correct year display for "Last Year" selection.

Hi

My customer has asked if I can produce a CSV report that has the following data:

Product Ordered
Number Of Products
Price of each product
Price of postage
Destination country of order

Is Sales Report capable of doing this?

Thanks

Dene

Quote:

---

Originally Posted by Deno

Hi

My customer has asked if I can produce a CSV report that has the following data:

Product Ordered
Number Of Products
Price of each product
Price of postage
Destination country of order

Is Sales Report capable of doing this?

Thanks

Dene

---

With custom modification, yes. It's not something that the plugin does out-of-the-box.

Quote:

---

Originally Posted by lat9

With custom modification, yes. It's not something that the plugin does out-of-the-box.

---

That sounds good. Is there any documentation I could get that would guide me in that direction?

Thanks

Dene

Quote:

---

Originally Posted by Deno

That sounds good. Is there any documentation I could get that would guide me in that direction?

Thanks

Dene

---

Unfortunately, the plugin's documentation is sparse at best. You'll be looking to make changes to the plugin's class-file (/admin/includes/classes/sales_report.php) to add the columns that your customer desires.

Thanks for the heads up, i'll check it out...

Dene

Quote:

---

Originally Posted by Deno

Thanks for the heads up, i'll check it out...

Dene

---

Is there anyone on here that can help me put this together as it's above my head?

I'll like it customizing to prepare a report like above. If this is possible please let me know how much it would cost.

Thanks

Dene

Quote:

---

Originally Posted by lat9

I've just submitted v3.2.0 of the "Sales Report" to the plugins for review; I'll post back here once it's available.

This version contains the following changes/bugfixes:

[CHANGE] Updated class selector for use under PHP 7.0 and later
[BUGFIX] Column-count "off" for CSV output when taxes are included.
[BUGFIX] Manufacturer filter was not being honored
[CHANGE] Applied PSR-2 styling to the various modules.
[BUGFIX] Correct year display for "Last Year" selection.

---

v3.2.0 is now available for download.

Just installed this mod but when I go to the report link I get a white page with the words "Illegal Access" at the top left of the screen. Zen vrs 1.5.5c

Quote:

---

Originally Posted by Congerman

Just installed this mod but when I go to the report link I get a white page with the words "Illegal Access" at the top left of the screen. Zen vrs 1.5.5c

---

That "Illegal Access" usually means that the plugin was being used outside of the Zen Cart environment (the IS_ADMIN_FLAG definition is used for the determination). The only place in the Sales Report's distribution that the message is used is in /YOUR_ADMIN/includes/functions/extra_functions/stats_sales_report.php.

Unfortunately, the plugin has historically included multiple files of the same name, i.e. stats_sales_report.php. Make sure that you didn't "finger-check" and copy that extra_functions version of the file to the /YOUR_ADMIN directory.

Quote:

---

Originally Posted by lat9

That "Illegal Access" usually means that the plugin was being used outside of the Zen Cart environment (the IS_ADMIN_FLAG definition is used for the determination). The only place in the Sales Report's distribution that the message is used is in /YOUR_ADMIN/includes/functions/extra_functions/stats_sales_report.php.

Unfortunately, the plugin has historically included multiple files of the same name, i.e. stats_sales_report.php. Make sure that you didn't "finger-check" and copy that extra_functions version of the file to the /YOUR_ADMIN directory.

---

All I did was put all the files, in the supplied structure, into my admin folder. Not sure what you mean by "finger-check" are you saying that I should put all the files except the extra functions one?

Quote:

---

Originally Posted by Congerman

All I did was put all the files, in the supplied structure, into my admin folder. Not sure what you mean by "finger-check" are you saying that I should put all the files except the extra functions one?

---

Nope, that extra-functions one is what adds the link to the report itself. What happens if you edit that /extra_functions/sales_report.php, changing

Code:

---

<?php
/**
 * SALES REPORT 3.1
 *
 * @author    Frank Koehl (PM: BlindSide)
 * @author    Conor Kerr <[email protected]>
 * @updated by stellarweb to work with version 1.5.0 02-29-12
 * @copyright  Portions Copyright 2003-2006 Zen Cart Development Team
 * @copyright  Portions Copyright 2003 osCommerce
 * @license    http://www.gnu.org/copyleft/gpl.html  GNU Public License V2.0
*/


if (!defined('IS_ADMIN_FLAG')) {
    die('Illegal Access');
}

if (function_exists('zen_register_admin_page')) {
    if (!zen_page_key_exists('stats_sales_report')) {
        // Add Monthly Report link to Reports menu
        zen_register_admin_page('stats_sales_report', 'BOX_REPORTS_SALES_REPORT','FILENAME_STATS_SALES_REPORT', '', 'reports', 'Y', 17);
    }
}
?>

---

to

Code:

---

<?php
/**
 * SALES REPORT 3.1
 *
 * @author    Frank Koehl (PM: BlindSide)
 * @author    Conor Kerr <[email protected]>
 * @updated by stellarweb to work with version 1.5.0 02-29-12
 * @copyright  Portions Copyright 2003-2006 Zen Cart Development Team
 * @copyright  Portions Copyright 2003 osCommerce
 * @license    http://www.gnu.org/copyleft/gpl.html  GNU Public License V2.0
*/


if (!defined('IS_ADMIN_FLAG')) {
    trigger_error('Illegal Access', E_USER_WARNING);
}

if (function_exists('zen_register_admin_page')) {
    if (!zen_page_key_exists('stats_sales_report')) {
        // Add Monthly Report link to Reports menu
        zen_register_admin_page('stats_sales_report', 'BOX_REPORTS_SALES_REPORT','FILENAME_STATS_SALES_REPORT', '', 'reports', 'Y', 17);
    }
}
?>

---

Is a debug-log generated after that change or do you still see the "Illegal access" message? If a debug-log is created, please post it back.

Interesting. I made the change and as dreamweaver was uploading, part of the text kept saying "sales report gives illegal access error. I then went to admin and the report is there ( not fully tested it yet so do not know if working as should be) an error log was created but it is 1723 lines long I am just replacing my admin folder details on it. Would you still like it posted here or PM'd

Quote:

---

Originally Posted by Congerman

Interesting. I made the change and as dreamweaver was uploading, part of the text kept saying "sales report gives illegal access error. I then went to admin and the report is there ( not fully tested it yet so do not know if working as should be) an error log was created but it is 1723 lines long I am just replacing my admin folder details on it. Would you still like it posted here or PM'd

---

PM sent.

Quote:

---

Originally Posted by Congerman

I made the change and as dreamweaver was uploading...

---

Paraphrasing Elmer Fudd, be vewwy, vewwy careful when using dreamweaver for file editing, etc. Unless you are vewwy, vewwy careful, it will add code that will munge things up in a hurry.

I often tell customers that want to use programs like that to open Word, type Hello World!, save it as html, then open it in notepad. You'll be amazed.

Stick to the simple editors. If you've just got to have some bells and whistles, try Ultra-Edit. Like Dreamweaver, it's commercial but it does not add extraneous code.

Or use Notepad++ as a simple txt editor with some whistles, it is free. Or if you want a full IDE editor use something like NetBeans, which is also free

Quote:

---

Originally Posted by dbltoe

Paraphrasing Elmer Fudd, be vewwy, vewwy careful when using dreamweaver for file editing, etc. Unless you are vewwy, vewwy careful, it will add code that will munge things up in a hurry.

I often tell customers that want to use programs like that to open Word, type Hello World!, save it as html, then open it in notepad. You'll be amazed.

Stick to the simple editors. If you've just got to have some bells and whistles, try Ultra-Edit. Like Dreamweaver, it's commercial but it does not add extraneous code.

---

Quote:

---

Originally Posted by dbltoe

Paraphrasing Elmer Fudd, be vewwy, vewwy careful when using dreamweaver for file editing, etc. Unless you are vewwy, vewwy careful, it will add code that will munge things up in a hurry.

I often tell customers that want to use programs like that to open Word, type Hello World!, save it as html, then open it in notepad. You'll be amazed.

Stick to the simple editors. If you've just got to have some bells and whistles, try Ultra-Edit. Like Dreamweaver, it's commercial but it does not add extraneous code.

---

I have been using dreamweaver for 17 years and never had an issue with it. Have you been using free, copied, cut down versions?

Bout the same here. Have thru 2015 version but, the minute I had problems with it computing PHP and XHTML correctly, I dropped it like a hot potato for Ultra-Edit. Doesn't mean it is better than Dreamweaver, JetBeans, etc. It just fits my needs. I would probably not have Dreamweaver were it not in a bundle.

For those the "just gotta", take a look at http://tinyurl.com/y8a3ngrg for some info that just could make a difference in your outcome. Hopefully, it's current.

An old thread but maybe helpful at http://tinyurl.com/yczpfkzr

This is a great plugin and installation went very smoothly indeed. Thank you to all contributors!

I was wondering how hard it would be to change the default YTD to Financial YTD (i.e. a date range of 1 July to current date - instead of 1 Jan to current date). I've been searching the various files to try and pinpoint where the relevant constant is allocated the start date without much luck (am not experienced enough to work out where I should be making this change).

Could anyone please point me in the right direction?

Thanks...and happy new year to all Zenners!

At first glance it looks like your_admin/stats_sales_report.php line 161 to 205 would be where you could amend the desired dates.

Quote:

---

Originally Posted by southshorepizza

At first glance it looks like your_admin/stats_sales_report.php line 161 to 205 would be where you could amend the desired dates.

---

Thanks for responding. I'll see what I can do.

Installed Sales Report v3.2.0 in zc155e. PHP version 5.6.31. I'm getting a PHP warning for a null array argument in in_array. Error message follows:

Quote:

---

PHP Warning: in_array() expects parameter 2 to be array, null given in ...admin/includes/classes/sales_report.php on line 403

---

Existing out-of-the-box code is:

Code:

---

            // check to see if product is unique in this timeframe
            // add to 'diff_products' array if so
            if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
                $this->timeframe[$id]['total']['diff_products'][] = $pID;
            }

            if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
            }

---

Should the code be something like this?

Code:

---

            // check to see if product is unique in this timeframe
            // add to 'diff_products' array if so
            if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
                $this->timeframe[$id]['total']['diff_products'][] = $pID;
            }

            if (is_null($this->timeframe[$id]['orders'][$oID]['diff_products']) || !in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
            }

---

Should a similar change be made to the if clause above the modified one?

Thanks!

Or should the array be initialized somewhere???

The code in function output_csv in admin/includes/classes/sales_report.php sets a filename that includes the report start date and end date, but the variables representing the dates are not set. Original code at line 881:

Code:

---

        $filename = CSV_FILENAME_PREFIX . date('Ymd', $startDate) . "-" . date('Ymd', $endDate);

---

The following code is one fix for the problem:

Code:

---

        $filename = CSV_FILENAME_PREFIX . date('Ymd', $this->sd_raw) . "-" . date('Ymd', $this->ed_raw);

---

Quote:

---

Originally Posted by Dave224

Installed Sales Report v3.2.0 in zc155e. PHP version 5.6.31. I'm getting a PHP warning for a null array argument in in_array. Error message follows:

Existing out-of-the-box code is:

Code:

---

            // check to see if product is unique in this timeframe
            // add to 'diff_products' array if so
            if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
                $this->timeframe[$id]['total']['diff_products'][] = $pID;
            }

            if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
            }

---

Should the code be something like this?

Code:

---

            // check to see if product is unique in this timeframe
            // add to 'diff_products' array if so
            if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
                $this->timeframe[$id]['total']['diff_products'][] = $pID;
            }

            if (is_null($this->timeframe[$id]['orders'][$oID]['diff_products']) || !in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
            }

---

Should a similar change be made to the if clause above the modified one?

Thanks!

---

dave,
you seem to be a smart enough guy, why don't you try it and let us know if it works? the effort required to post your solution seems greater than the effort involved in trying your own solution to see if it resolves the problem.

if you wanted to initialize the arrays, you can do it above the while statement on line 348:

PHP Code:

---

$this->timeframe[$id]['orders'][$oID]['diff_products'] = array();
$this->timeframe[$id]['total']['diff_products'] = array(); 


---

i like that idea more than the modified if statement, mostly because i am not sure the if statement would resolve the warning.

best.

There's a problem in Sales Report version 3.2.0 in file admin/stats_sales_report.php at line 387 where the input date target (purchased date, or status date) and input order status are not output properly. Original code in v3.2.0 is:

Code:

---

    $date_target = PRINT_DATE_TARGET;
    if ($date_target == 'purchased') {
        $date_target .= PRINT_DATE_PURCHASED;
    } elseif ($date_target == 'status') {
        $date_target .= (PRINT_DATE_STATUS . ' (' . $status_key[$date_status] . ')');
    }

---

The above code sets $date_target to the constant PRINT_DATE_CONSTANT in the first line and the subsequent if and elseif tests will never be satisfied.

The following is one approach to fix the problem:

Code:

---

    $date_target = PRINT_DATE_TARGET;
    if ($_GET['date_target'] == 'purchased') {
        $date_target .= PRINT_DATE_PURCHASED;
    } elseif ($_GET['date_target'] == 'status') {
        $date_target .= (PRINT_DATE_STATUS . ' (' . $status_key[$date_status] . ')');
    }

---

In this approach, $_GET['date_target'] is the input date target. Another approach is to revert to the code in a previous version of sales report.

I'm testing an upgrade from Zen Cart 1.54 to 1.55f and PHP 5.6 to PHP 7.0.27. (and our addons)
I look at PHP every few years when I feel guilted into doing an upgrade, so I'm definitely not comfortable making changes.

Thanks, Dave222, for your solution posted in 725 above. That saved me even more grey hair.

I tried the arrays initialization suggested in 728, sadly that removed the Order and Customer data from the report. I put it (just above the while stmt line 348). Perhaps it would be effective somewhere else. But, unfortunately PHP looks like a bunch of symbols to me, so I'm not quite sure where else to try it. Back in the olden days, I programmed in other languages, so I'm a fan of initializing the arrays, but...as much as I stare at this, senior moments aside, I can't really figure it out.

When testing the CSV for Product Line Items (In admin/includes/classes/sales_report.php), I was getting this error:
PHP Warning: Invalid argument supplied for foreach() in ...includes/classes/sales_report.php on line 1043
AND
Argument #1 is expected to be an array or a sort flag in .../includes/classes/sales_report.php on line 1050

Since I don't know what I'm doing, I just copied the if ...null...continue statement from the order level and changed the timeframe to products and that seemed to do the trick. This is about line 1040.

Code:

---

case 'product':
    // sort the products according to requested sort options
    unset($dataset1, $dataset2);
    foreach($timeframe['products'] as $pID => $p_data) {

CHANGED TO

case 'product':
  // sort the products according to requested sort options
  unset($dataset1, $dataset2);
  if (is_null($timeframe['products'])) {
      // Ignore days for which no info exists
        continue;
  }
  foreach($timeframe['products'] as $pID => $p_data) {

---

Quote:

---

Originally Posted by Dave224

Installed Sales Report v3.2.0 in zc155e. PHP version 5.6.31. I'm getting a PHP warning for a null array argument in in_array. Error message follows:

Existing out-of-the-box code is:

Code:

---

            // check to see if product is unique in this timeframe
            // add to 'diff_products' array if so
            if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
                $this->timeframe[$id]['total']['diff_products'][] = $pID;
            }

            if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
            }

---

Should the code be something like this?

Code:

---

            // check to see if product is unique in this timeframe
            // add to 'diff_products' array if so
            if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
                $this->timeframe[$id]['total']['diff_products'][] = $pID;
            }

            if (is_null($this->timeframe[$id]['orders'][$oID]['diff_products']) || !in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
            }

---

Should a similar change be made to the if clause above the modified one?

Thanks!

---

I had same php warning in logs. Report still worked correctly, just produced the log error. I trid the code change as above and now no error is logged when I generate a report. Thanks for posting.

Hi,

When running the report I get the following error:

Quote:

---

[10-Jun-2018 07:03:53 UTC] Request URI: /admin/stats_sales_report.php?start_date=01%2F06%2F2017&end_date=10+%2F06%2F2017&date_t arget=purchased&date_status=1&prod_includes=&cust_includes=&payment_method=&paym ent_method_omit=&current_status=&manufacturer=0&timeframe=year&timeframe_sort=as c&detail_level=order&li_sort_a=oID&li_sort_order_a=asc&li_sort_b=oID&li_sort_ord er_b=asc&output_format=display&new_window=1, IP address: *.*.123.202
#1 mktime() called at [/.../.../admin/includes/classes/sales_report.php:69]
#2 sales_report->__construct() called at [/.../admin/stats_sales_report.php:245]

[10-Jun-2018 07:03:53 UTC] PHP Warning: mktime() expects parameter 4 to be integer, string given in /.../.../admin/includes/classes/sales_report.php on line 69

---

Zen Cart 1.5.5f
PHP Version 7.1.18

Could someone point me in the right direction to fix this please?

Why do I get extended information under "Time Frame" i.e:
IST0JanE_Tue0st+05:300AM2019_TueAM2019

Zencart Ver 1.5.6a
Php 7

Thanks

Quote:

---

Originally Posted by harry2cool

Why do I get extended information under "Time Frame" i.e:
IST0JanE_Tue0st+05:300AM2019_TueAM2019

Zencart Ver 1.5.6a
Php 7

Thanks

---

in the file
YOUR_ADMIN\includes\classes\sales_report.php
at the top of the file at approx line 29 define the date format you use eg

define('DATE_FORMAT', 'd/m/Y'); // this is used for date() // addition for PHP 7

Change the comments at the end of the line to your standard for comments

If using PHP 7.3 the following changes will be required. In the file

YOUR_ADMIN\includes\classes\sales_report.php

for compliance with PHP 7.3 change "continue;" to "continue 2;" at approx line 1000,
for compliance with PHP 7.3 change "continue;" to "continue 3;" at approx line 1014

Always perform changes in a test environment and back up before making changes

We have tried everything, however it's a strange server issue, because on our other website with the newer version the Timeframes show properly.
Any server/php int changes suggested for this particular website ?
This is what I get under TimeFrame column:
The date is not shown;
==============
IST0JanE_Tue0st+05:300AM2019_TueAM2019
IST0JanE_Wed0nd+05:300AM2019_WedAM2019
IST0JanE_Thu0rd+05:300AM2019_ThuAM2019
IST0JanE_Fri0th+05:300AM2019_FriAM2019
IST0JanE_Sat0th+05:300AM2019_SatAM2019
IST0JanE_Sun0th+05:300AM2019_SunAM2019
IST0JanE_Mon0th+05:300AM2019_MonAM2019
IST0JanE_Tue0th+05:300AM2019_TueAM2019
IST0JanE_Wed0th+05:300AM2019_WedAM2019
IST0JanE_Thu0th+05:300AM2019_ThuAM2019
IST0JanE_Fri0th+05:300AM2019_FriAM2019
IST0JanE_Sat0th+05:300AM2019_SatAM2019
IST0JanE_Sun0th+05:300AM2019_SunAM2019
IST0JanE_Mon0th+05:300AM2019_MonAM2019
IST0JanE_Tue0th+05:300AM2019_TueAM2019
IST0JanE_Wed0th+05:300AM2019_WedAM2019
IST0JanE_Thu0th+05:300AM2019_ThuAM2019
IST0JanE_Fri0th+05:300AM2019_FriAM2019
IST0JanE_Sat0th+05:300AM2019_SatAM2019
IST0JanE_Sun0th+05:300AM2019_SunAM2019
IST0JanE_Mon0st+05:300AM2019_MonAM2019
IST0JanE_Tue0nd+05:300AM2019_TueAM2019
IST0JanE_Wed0rd+05:300AM2019_WedAM2019
IST0JanE_Thu0th+05:300AM2019_ThuAM2019
IST0JanE_Fri0th+05:300AM2019_FriAM2019

Got below on the logs:

===========
[25-Jan-2019 22:34:59 Asia/Kolkata] PHP Warning: in_array() expects parameter 2 to be array, null given in /home/harry2co/public_html/admin/includes/classes/sales_report.php on line 403
[25-Jan-2019 22:34:59 Asia/Kolkata] Request URI: /adminname/stats_sales_report.php?date_preset=this_month&start_date=&end_date=&date_target= purchased&date_status=1&prod_includes=&cust_includes=&payment_method=&payment_me thod_omit=&current_status=&manufacturer=0&timeframe=day&timeframe_sort=asc&detai l_level=timeframe&li_sort_order_a=asc&li_sort_order_b=asc&output_format=display, IP address: xxx.yy.26.190
#1 in_array() called at [/home/harry2co/public_html/adminname/includes/classes/sales_report.php:403]
#2 sales_report->build_li_totals() called at [/home/harry2co/public_html/adminname/includes/classes/sales_report.php:259]
#3 sales_report->build_timeframe() called at [/home/harry2co/public_html/adminname/includes/classes/sales_report.php:107]
#4 sales_report->__construct() called at [/home/harry2co/public_html/adminname/stats_sales_report.php:245]
================
Please guide.
Thanks

Please list the Zen cart version and PHP version and version of Sale Report you are using to test this.

Zencart Ver 1.5.6a
Php 7

PHP7.3
Ignore the line about continue 3 in post #735 https://www.zen-cart.com/showthread....73#post1354173. Only the continue 2 is required

Sales Report 2.0 (Version 3.2.0) PHP 7.x

The following changes are required as a minimum. My line numbers are higher than for the original files due to inserted comments for all changes I make.

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at the top of the file approx line 29

Code:

---

define('DATE_FORMAT', 'd/m/Y'); // this is used for date() // BMH addition PHP 7

---

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at approx lines 266, 270 CHANGE

Code:

---

if (count($this->timeframe[$id]['orders']) == 0) {
        $this->timeframe[$id]['orders'] = false;

---

TO

Code:

---

if (empty($this->timeframe[$id]['products'])) {
        $this->timeframe[$id]['orders'] = false;

---

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at approx line 411 CHANGE

Code:

---

if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
      $this->timeframe[$id]['total']['diff_products'][] = $pID;
}

---

TO

Code:

---

if (!empty($this->timeframe[$id]['orders'][$oID]['diff_products']) ) {
                if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                  $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
                }
        }

---

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at approx line 417 CHANGE

Code:

---

if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
      }

---

TO

Code:

---

if (!empty($this->timeframe[$id]['orders'][$oID]['diff_products']) ) {
    if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
          $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
    }
}

---

Perform these changes in a test environment making only one change at a time and review your log files after each test of the report. Add comments to your code.

------
will try and get back.
Thanks

Did the changes, however under date it still shows the same as below, however do not get any error in the logs:

IST0JanE_Tue0st+05:300AM2019_TueAM2019

Sorry for the incorrect file reference.

The date format

Code:

---

define('DATE_FORMAT', 'd/m/Y'); // this is used for date() // BMH addition PHP 7

---

should be placed in YOUR_ADMIN\stats-sales_report.php at approx line 29.

I've got a GitHub update staged that, I believe, addresses this issue: https://github.com/lat9/sales_report/issues/4

Quote:

---

Originally Posted by lat9

I've got a GitHub update staged that, I believe, addresses this issue: https://github.com/lat9/sales_report/issues/4

---

I've just submitted v3.2.1 of Sales Report to the Zen Cart devs for review. Once accepted, it can be downloaded from this link: https://www.zen-cart.com/downloads.php?do=file&id=9

This release contains the changes associated with the following GitHub issue:


#4: zc156 inter-operation due to language-file load-order change.


If you can't wait for the changes to be posted on the Zen Cart link, you can download the report's distribution zip-file from its GitHub repository: https://github.com/lat9/sales_report...ses/tag/v3.2.1

v3.2.1 of Sales Report is now available for download (thanks, @swguy!).

Any idea how to fix the SpiffyCal layout? I'm assuming this has to do with the new Bootstrap based Admin style or the updates to the calendar javascript in 1.5.6a, but when attempting to choose a custom date, the calendar goes off the left side of the screen and browser doesn't allow scrolling to the left.

ZenCart 1.5.6a
PHP 7.1

Tested in Firefox 65, Chrome 72, MS Edge
Attachment 18358

Quote:

---

Originally Posted by gwynwyffar

Any idea how to fix the SpiffyCal layout? I'm assuming this has to do with the new Bootstrap based Admin style or the updates to the calendar javascript in 1.5.6a, but when attempting to choose a custom date, the calendar goes off the left side of the screen and browser doesn't allow scrolling to the left.

ZenCart 1.5.6a
PHP 7.1

Tested in Firefox 65, Chrome 72, MS Edge
Attachment 18358

---

the problem is with the spiffyCal plugin that comes with the base ZC package. it is version 2.1 and dated 2001. i think this is a plugin that needs to be replaced by the ZC team.

this spiffyCal is used in a number of places, so changes here can affect where it is used elsewhere. so use with caution.

if you go here:

YOUR_ADMIN/includes/javascript/spiffyCal/spiffyCal_v2_1.js

lines 1026 and 1037; you will see:

- 250

change that to

-10

not sure how it will affect other dates in your admin.

Code:

---

                if (scIE) {
                    if (this.displayLeft) {
                        scX = getOffsetLeft(document.images[this.btnName]) - 10 + document.images[this.btnName].width;
                    } else {
                        scX = getOffsetLeft(document.images[this.btnName]);
                    }
                    if (this.displayTop) {
                        scY = getOffsetTop(document.images[this.btnName]) - 138;
                    } else {
                        scY = getOffsetTop(document.images[this.btnName]) + document.images[this.btnName].height + 2;
                    }
                } else if (scNN) {
                    if (this.displayLeft) {
                        scX = document.images[this.btnName].x - 10 + document.images[this.btnName].width;
                    } else {
                        scX = document.images[this.btnName].x;

---

Thanks, @carlwhat, for that investigation. I've noted the issue on Sales Report's GitHub repository (https://github.com/lat9/sales_report/issues/5).

Please note that since it's a Zen Cart core-file involved, it's not likely that I'll be including that change with the plugin ... other than to document the anomaly and your fix.

Quote:

---

Originally Posted by lat9

Thanks, @carlwhat, for that investigation. I've noted the issue on Sales Report's GitHub repository (https://github.com/lat9/sales_report/issues/5).

Please note that since it's a Zen Cart core-file involved, it's not likely that I'll be including that change with the plugin ... other than to document the anomaly and your fix.

---

Turns out, the correction can be made by adding the following block to the bottom of /admin/stats_sales_reports.php's additional CSS block:

Code:

---

<?php
if (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR > '1.5.6') {
?>
#spiffycalendar { left: 10px!important; }
<?php
}
?>

---

Thanks for the fix carlwhat. I checked most of the places I could remember that use the SpiffyCal (Specials, SaleMaker, Featured Products) and your fix doesn't seem to adversely affect the ability to select a date, however on the Featured Products admin page it does push the calendar off the page to the right, but at least the browser can scroll over to select a date on that one.

I will try lat9's fix instead.

Quote:

---

Originally Posted by lat9

Turns out, the correction can be made by adding the following block to the bottom of /admin/stats_sales_reports.php's additional CSS block:

Code:

---

<?php
if (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR > '1.5.6') {
?>
#spiffycalendar { left: 10px!important; }
<?php
}
?>

---

---

!important => i hate !important.... almost as much as i hate globals.... but a topic for another day.

i'm going to investigate using datepicker. seems in use for collect info on the admin/product. and is part of the jquery ui library. might be a better solution and would make sense to be consistent through out.

best.

Quote:

---

Originally Posted by carlwhat

!important => i hate !important.... almost as much as i hate globals.... but a topic for another day.

i'm going to investigate using datepicker. seems in use for collect info on the admin/product. and is part of the jquery ui library. might be a better solution and would make sense to be consistent through out.

best.

---

Yes, I try to avoid !important, but when it's the only option (other than carving up a core-file:yuck:) ...

Like carlwhat mentioned, I do think using the datepicker from jQuery UI would be better choice at this point.
As this bug is NOT only in your plugin... it affected literary any plugins that use the SpiffyCal.
Even the "E-Mail Archive Manager" face exact same bug problem!

Therefore, it would be best if the Zen Cart's core file and/or the plugins migrated to jQuery's datepicker instead.
(In fact, on my custom form used datepicker already... gotta test it out to see if I can substituted on SpiffyCal codes.)

So many Zen Cart's admin pages are using SpiffyCalendar!
https://i.imgur.com/Qq8TLqZ.png

Sadly, that's not really good calendar to be use anymore.

But, does not Zen Cart already implement Bootstrap?
Then I suppose we can also use the Bootstrap's Datepicker!
https://bootstrap-datepicker.readthedocs.io/en/latest
https://buildmedia.readthedocs.org/m...datepicker.pdf

---

However, it seems those two datepickers have to be in the "form."

For example, in my custom "Rental Form," I have the following codes for the rental date ranges.
https://i.imgur.com/gbVJvWj.png

In this form, I set the end date based on starting date and starting date must be today or future's dates.
Hence the reasons I have to have hidden fields to check on date values.

HTML Code:

---

<input type="hidden" id="rental_startdate_temp" value="<?php echo isset($_POST['rental_startdate']) ? $_POST['rental_startdate'] : ''; ?>" />
<input type="hidden" id="rental_enddate_temp" value="<?php echo isset($_POST['rental_enddate']) ? $_POST['rental_enddate'] : ''; ?>" />

<label class="inputLabel">Rental Dates:</label>

<div id="two-column">
<div id="left">
<label class="inputLabelA" for="rental_startdate">Delivery</label>
<input type="text" id="rental_startdate" name="rental_startdate" />
</div>

<div id="right">
<label class="inputLabelB" for="rental_enddate">Return</label>
<input type="text" id="rental_enddate" name="rental_enddate" />
</div>
</div>
<br class="clearBoth" />

---

In a separate JavaScript file...

Code:

---

$(function() {
       
        //Datepicker's on "Rental Starting Date" field.
    $( "#rental_startdate" ).datepicker({
                minDate: 0,
                changeMonth: true,
                numberOfMonths: 3,
                onSelect: function( selectedDate ) {
                        $( "#rental_enddate" ).datepicker( "option", "minDate", selectedDate );
                        $( "#rental_enddate_temp" ).val(selectedDate);
                }
    });
       
        //Datepicker's on "Rental Ending Date" field.
    $( "#rental_enddate" ).datepicker({
                minDate: 0,
                changeMonth: true,
                numberOfMonths: 3,
                onSelect: function( selectedDate ) {
                        $( "#rental_startdate" ).datepicker( "option", "maxDate", selectedDate );
                        $( "#rental_startdate_temp" ).val(selectedDate);
                }
        });

                        // If user had put rental starting date, data will be retrieved from hidden field.
                        if ($("#rental_startdate_temp").val()!= '') {
                                var rentStartDateText = $("#rental_startdate_temp").val();
                                $("#rental_startdate").val(rentStartDateText);
                        }
                       
                        // If user had put rental ending date, data will be retrieved from hidden field.
                        if ($("#rental_enddate_temp").val()!= '') {
                                var rentEndtDateText = $("#rental_enddate_temp").val();
                                $("#rental_enddate").val(rentEndtDateText);
                        }
});

---

The "Keyword Capturing Dashboard" plugin is also using jQuery's datepicker.
https://i.imgur.com/szb76jT.png

So I am positive that datepicker can be completely replace the SpiffyCalendar.
However, it seems that codes were optimized around it and hence it is not simply just replace SpiffyCalendar into the datepicker one... There has to be some dependencies that possibly have to ensure the replacement is properly done.

I've just submitted v3.3.0 of Sales Report to the Zen Cart moderators for review and will post back when it's available for download.

This release contains changes associated with the following GitHub issues:

#5: zc156, calendar displays off-screen
#6: Correct various PHP Notices.
#8: Correct error when specific products/customers indicated, but no list supplied.
#9: Add a setting to exclude orders-status values.
#10: "Remember" the admin's selection for 'Open report in new window'.
#11: Convert javascript to jQuery.
#12: Convert HTML to HTML5.
#13: Use the customer's name from the order, not the customers table.

Quote:

---

Originally Posted by lat9

I've just submitted v3.3.0 of Sales Report to the Zen Cart moderators for review and will post back when it's available for download.

This release contains changes associated with the following GitHub issues:

#5: zc156, calendar displays off-screen
#6: Correct various PHP Notices.
#8: Correct error when specific products/customers indicated, but no list supplied.
#9: Add a setting to exclude orders-status values.
#10: "Remember" the admin's selection for 'Open report in new window'.
#11: Convert javascript to jQuery.
#12: Convert HTML to HTML5.
#13: Use the customer's name from the order, not the customers table.

---

Now available for download!

I've just submitted v3.3.1 of Sales Report to the Zen Cart moderators for review; I'll post back here once it's available for download.

This release contains changes associated with the following GitHub issues:


#14: Correct PHP 7.3 warning
#15: Correct custom date-range not remembered

Quote:

---

Originally Posted by lat9

I've just submitted v3.3.1 of Sales Report to the Zen Cart moderators for review; I'll post back here once it's available for download.

This release contains changes associated with the following GitHub issues:


#14: Correct PHP 7.3 warning
#15: Correct custom date-range not remembered

---

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=9

Not sure if I'm just missing something with it, or if the module doesn't support it at all, but I'm trying to get a report listing our top selling products over the course of the past 2 years. As it is, I can go to the Reports->Products Purchased page and it will give me a list of what we've sold, from most to least,ever since we opened, but I'm needing to be able to generate a list for a specific time period, and of a specific selection of product. If this doesn't, is there anything that does?

We're on 1.5.5.

Quote:

---

Originally Posted by Lordzoabar

Not sure if I'm just missing something with it, or if the module doesn't support it at all, but I'm trying to get a report listing our top selling products over the course of the past 2 years. As it is, I can go to the Reports->Products Purchased page and it will give me a list of what we've sold, from most to least,ever since we opened, but I'm needing to be able to generate a list for a specific time period, and of a specific selection of product. If this doesn't, is there anything that does?

We're on 1.5.5.

---

The current version (3.3.1) of the Sales Report supports Zen Carts 1.5.5 and later. Choosing settings like below will yield a timeframe-specific search displaying the products purchased in descending order of quantity:

Displayed information: Products Line Items
Sort products by: Quantity (desc)
Then sort by: Products ID (desc)

I've just submitted v3.3.2 of the Sales Report, and it is now available for download.

This release contains changes associated with the following GitHub issues:

#16: Correct PHP notices during products-purchased CSV output.
#17: (Interoperation) Don't load extra-functions until an admin is logged in.

https://www.zen-cart.com/downloads.php?do=file&id=9

Quote:

---

Originally Posted by lat9

I've just submitted v3.3.2 of the Sales Report, and it is now available for download.

This release contains changes associated with the following GitHub issues:

#16: Correct PHP notices during products-purchased CSV output.
#17: (Interoperation) Don't load extra-functions until an admin is logged in.

https://www.zen-cart.com/downloads.php?do=file&id=9

---

Now available for download.

Quote:

---

Originally Posted by lat9

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=9

---

Thanks for the work. I am looking forward to seeing how it works.

Question. I have installed the plugin to my Admin folder without an issue and since this is the first install, I had no overrides. However, after logging in to Admin and Reports I do not see any sales report option as if it was never installed. Again, I verified that all files transferred over.

I am using v 1.5.5f and I installed the most recent version from github for 1.5.5 and later. I am currently using the Westminster template and have not installed any other report plugins. I am using php 7.2. Not sure if it helps or not but the website is pfcind.com. If you need any other information, please let me know.

Thank you.

Quote:

---

Originally Posted by creyesx6

Thanks for the work. I am looking forward to seeing how it works.

Question. I have installed the plugin to my Admin folder without an issue and since this is the first install, I had no overrides. However, after logging in to Admin and Reports I do not see any sales report option as if it was never installed. Again, I verified that all files transferred over.

I am using v 1.5.5f and I installed the most recent version from github for 1.5.5 and later. I am currently using the Westminster template and have not installed any other report plugins. I am using php 7.2. Not sure if it helps or not but the website is pfcind.com. If you need any other information, please let me know.

Thank you.

---

The plugin, in and of itself, has no overrides! Since it's an admin-only contribution, your store's current template doesn't matter.

Have you looked at the admin's "Reports" dropdown? That's where the "Sales Report" will show up if it's correctly installed.

Make sure that (a) you installed all the files to your site's admin sub-directory and (b) that the file /admin/includes/extra_datafiles/sales_report_filenames.php is present (where /admin is the pseudonym for your 'secret' admin directory).

Thanks for the response.
I checked the Admin Reports menu and have the following: Customer-Orders-Total, Customers Referral, Products Low Stock, Products Purchased, Products Viewed, Search Log. As I understand it, I should see a "Sales Report" option as well. I checked and confirmed that my admin directory does include [myadmin]/includes/extra_datafiles/sales_report_filenames.php. I am going to check each and every file used from GitHub to be sure they each transferred one by one. But I am fairly confident I will find that they have all transferred. I will report the results. Thanks for getting back to me :smile:

I checked and confirmed that 6 files plus Image files were transferred over. If there are more than 6 files to be transferred over, then I am missing files.

What happens if you change your browser's address bar (when you're logged into the admin) to read pfcind.com/admin-dir-name/stats_sales_report.php and press Enter? Does the sales-report display?

Quote:

---

Originally Posted by lat9

What happens if you change your browser's address bar (when you're logged into the admin) to read pfcind.com/admin-dir-name/stats_sales_report.php and press Enter? Does the sales-report display?

---

Yes it absolutely does. I can see Preset Date Range with options, etc....... For some reason, it's just not displaying in the menu. Sounds like a mysql issue?

Quote:

---

Originally Posted by creyesx6

Yes it absolutely does. I can see Preset Date Range with options, etc....... For some reason, it's just not displaying in the menu. Sounds like a mysql issue?

---

That's weird, since the admin-page registration should have been performed by the plugin's /admin/includes/functions/extra_functions file.

If you inspect your database via your webhost's phpMyAdmin and view the admin_pages table, do you see a page_key named stats_sales_report?

Quote:

---

Originally Posted by lat9

That's weird, since the admin-page registration should have been performed by the plugin's /admin/includes/functions/extra_functions file.

If you inspect your database via your webhost's phpMyAdmin and view the admin_pages table, do you see a page_key named stats_sales_report?

---

I just checked and no, it is not there. If I add will it resolve? Can you advise the parameters for this entry? Thanks again for your help.

Quote:

---

Originally Posted by creyesx6

I just checked and no, it is not there. If I add will it resolve? Can you advise the parameters for this entry? Thanks again for your help.

---

That's exactly what the file /YOUR_ADMIN/includes/functions/extra_functions/stats_sales_report.php does. Are you sure you copied that file to your admin's sub-directory?

Quote:

---

Originally Posted by lat9

That's exactly what the file /YOUR_ADMIN/includes/functions/extra_functions/stats_sales_report.php does. Are you sure you copied that file to your admin's sub-directory?

---

Yes, it is absolutely there.
Here is the contents of that file. I copied this over from my server.

<?php
/**
* SALES REPORT 3.3.2
*
* @author Frank Koehl (PM: BlindSide)
* @author Conor Kerr <[email protected]>
* @updated by stellarweb to work with version 1.5.0 02-29-12
* @updated by lat9, supporting zc1.5.5/1/5.6, 2019-06-20
* @copyright Portions Copyright 2003-2006 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.gnu.org/copyleft/gpl.html GNU Public License V2.0
*/
if (!defined('IS_ADMIN_FLAG')) {
die('Illegal Access');
}

// -----
// Bail if an admin isn't logged in, e.g. if a currency-cron is running.
//
if (empty($_SESSION['admin_id'])) {
return;
}

// -----
// If the report's page-key entry doesn't net exist, add it.
//
if (!zen_page_key_exists('stats_sales_report')) {
zen_register_admin_page('stats_sales_report', 'BOX_REPORTS_SALES_REPORT', 'FILENAME_STATS_SALES_REPORT', '', 'reports', 'Y');
}

This makes no sense. Are you sure that the file is in the /admin/includes/functions/extra_functions subdirectory?

Are you receiving any myDEBUG-adm-*.log files in your store's /logs subdirectory? Remember that those files will include references to your site's admin directory name, so if you choose to post some be sure to xxx-out that and use the "CODE" tags (the big # in the menu-bar when you're writing your post) to enclose that log-file content.

Quote:

---

Originally Posted by lat9

This makes no sense. Are you sure that the file is in the /admin/includes/functions/extra_functions subdirectory?

Are you receiving any myDEBUG-adm-*.log files in your store's /logs subdirectory? Remember that those files will include references to your site's admin directory name, so if you choose to post some be sure to xxx-out that and use the "CODE" tags (the big # in the menu-bar when you're writing your post) to enclose that log-file content.

---

Yes, the file is located in the subdirectory as mentioned above. I checked the logs file under public_html/logs and I do not have any errors since it was installed yesterday. I installed a total of 6 files for the plugin from Github and I checked those against my server and they match with the exact same directory names (after I changed to my custom admin directory). I am not aware of any other location of where the error logs may be. I do check for error logs as I run into issues but none in this case. After pulling up the sales report via url provided I did find that the screen view did not work and when downloading the file, I had to change the extension to a .csv to view, but there were no headings, not sure if there was supposed to be any. Not sure if this additional info helps or not.

I did find an error but this was prior to the install of this plugin. It is as follows:

Code:

---

#[28-Oct-2019 09:06:12 US/Central] Request URI: /[myadmin]/categories.php?cPath=10&pID=796&page=3, IP address: 24.173.44.158

[28-Oct-2019 09:06:12 US/Central] PHP Warning:  Creating default object from empty value in /home/xxx/public_html/[myadmin]/categories.php on line 1010

---

@creyesx6, thanks for "sticking with me" on this. After inspection, the issue is that the plugin's menu-bar addition occurs when the 'extra_functions' load ... which is prior to the admin's session initialization.

Unfortunately, that extra_functions processing is checking to see if an admin session is currently active (which it won't be based on the load-point of the processing).

I'll be updating the Sales Report plugin to remove that "is an admin active?" check to allow the menu-bar registration to complete successfully.

Awesome! Thanks so much for your help and resolution. Looking forward to putting it to good use!!

GitHub issue created: https://github.com/lat9/sales_report/issues/18

I'll wait a bit for a new release, just in case other gremlins come to the surface!

Using Zen 1.54
PHP 5.6

Will this sales report work with my set up.

I need a report to show me which products have sold the most in specific time periods.

Quote:

---

Originally Posted by Speak394

Using Zen 1.54
PHP 5.6

Will this sales report work with my set up.

I need a report to show me which products have sold the most in specific time periods.

---

While I've done no testing with zc154, I can't think of a reason why it wouldn't work. The good news is that it's a drop-in contribution, so if it doesn't suit your needs, it's easily removable.

Quote:

---

Originally Posted by lat9

While I've done no testing with zc154, I can't think of a reason why it wouldn't work. The good news is that it's a drop-in contribution, so if it doesn't suit your needs, it's easily removable.

---

I did try this yesterday. Although everything went in place, no errors showed up nor did it crash the site. I could not generate a report. When I clicked on show me the money, it did nothing.

Quote:

---

Originally Posted by Speak394

I did try this yesterday. Although everything went in place, no errors showed up nor did it crash the site. I could not generate a report. When I clicked on show me the money, it did nothing.

---

Did you unclick the "Open the report in a new window"? Otherwise, the report is created in a new tab/window.

Yes, I tried it both ways. Neither way created a report. It was like the button was not working.

Quote:

---

Originally Posted by Speak394

Yes, I tried it both ways. Neither way created a report. It was like the button was not working.

---

Yes, I misspoke. The Sales Report now uses jQuery (loaded for zc155 and later), so it's no longer compatible with prior Zen Cart versions.

Quote:

---

Originally Posted by lat9

@creyesx6, thanks for "sticking with me" on this. After inspection, the issue is that the plugin's menu-bar addition occurs when the 'extra_functions' load ... which is prior to the admin's session initialization.

Unfortunately, that extra_functions processing is checking to see if an admin session is currently active (which it won't be based on the load-point of the processing).

I'll be updating the Sales Report plugin to remove that "is an admin active?" check to allow the menu-bar registration to complete successfully.

---

Hi Lat9,

Last night I upgraded to 1.5.6c from 1.3.9h, after a number of issues with robots creating new accounts and sending SPAM to the emails used in the account creations. The upgrade went well, and I was able to add the reCAPTCHA plugin and that has solved that unwanted activity.

Anyhow, I have used the Sales Report tool on 1.3.9h since 2010. After the upgrade, the tool went away,even though the the files were still there. I decided to move to the latest version, and copied over and replaced the existing files, however, the Sales Report isn't showing in the Reports Section of the Menu Bar.

Looking at the previous threads here, I see that there was some sort of small glitch, that needs to be addressed, but I am trying to figure out what exactly I need to do in the mean time to get the reporting tool to show up.

Is it just a simple matter of adding the a page_key named stats_sales_report to the admin_pages table to resolve the issue?

James

Quote:

---

Originally Posted by a02l1zz

Hi Lat9,

Last night I upgraded to 1.5.6c from 1.3.9h, after a number of issues with robots creating new accounts and sending SPAM to the emails used in the account creations. The upgrade went well, and I was able to add the reCAPTCHA plugin and that has solved that unwanted activity.

Anyhow, I have used the Sales Report tool on 1.3.9h since 2010. After the upgrade, the tool went away,even though the the files were still there. I decided to move to the latest version, and copied over and replaced the existing files, however, the Sales Report isn't showing in the Reports Section of the Menu Bar.

Looking at the previous threads here, I see that there was some sort of small glitch, that needs to be addressed, but I am trying to figure out what exactly I need to do in the mean time to get the reporting tool to show up.

Is it just a simple matter of adding the a page_key named stats_sales_report to the admin_pages table to resolve the issue?

James

---

James, you can replace the contents of /YOUR_ADMIN/includes/functions/extra_functions/sales_report.php with the following contents to correct the issue. That's the version in the forthcoming v3.3.3 of the Sales Report:

Code:

---

<?php
/**
 * SALES REPORT 3.3.3
 *
 * @author    Frank Koehl (PM: BlindSide)
 * @author    Conor Kerr <[email protected]>
 * @updated by stellarweb to work with version 1.5.0 02-29-12
 * @updated by lat9, supporting zc1.5.5/1/5.6, 2019-11-02
 * @copyright  Portions Copyright 2003-2006 Zen Cart Development Team
 * @copyright  Portions Copyright 2003 osCommerce
 * @license    http://www.gnu.org/copyleft/gpl.html  GNU Public License V2.0
*/
if (!defined('IS_ADMIN_FLAG')) {
    die('Illegal Access');
}

// -----
// Bail the required function isn't loaded, e.g. if a currency-cron is running.
//
if (!function_exists('zen_page_key_exists')) {
    return;
}

// -----
// If the report's page-key entry doesn't net exist, add it.
//
if (!zen_page_key_exists('stats_sales_report')) {
    zen_register_admin_page('stats_sales_report', 'BOX_REPORTS_SALES_REPORT', 'FILENAME_STATS_SALES_REPORT', '', 'reports', 'Y');
}

---

Quote:

---

Originally Posted by lat9

James, you can replace the contents of /YOUR_ADMIN/includes/functions/extra_functions/sales_report.php with the following contents to correct the issue. That's the version in the forthcoming v3.3.3 of the Sales Report:

Code:

---

<?php
/**
 * SALES REPORT 3.3.3
 *
 * @author    Frank Koehl (PM: BlindSide)
 * @author    Conor Kerr <[email protected]>
 * @updated by stellarweb to work with version 1.5.0 02-29-12
 * @updated by lat9, supporting zc1.5.5/1/5.6, 2019-11-02
 * @copyright  Portions Copyright 2003-2006 Zen Cart Development Team
 * @copyright  Portions Copyright 2003 osCommerce
 * @license    http://www.gnu.org/copyleft/gpl.html  GNU Public License V2.0
*/
if (!defined('IS_ADMIN_FLAG')) {
    die('Illegal Access');
}

// -----
// Bail the required function isn't loaded, e.g. if a currency-cron is running.
//
if (!function_exists('zen_page_key_exists')) {
    return;
}

// -----
// If the report's page-key entry doesn't net exist, add it.
//
if (!zen_page_key_exists('stats_sales_report')) {
    zen_register_admin_page('stats_sales_report', 'BOX_REPORTS_SALES_REPORT', 'FILENAME_STATS_SALES_REPORT', '', 'reports', 'Y');
}

---

---

Lat9,

Thank you very much. That worked great.

One thing to clear up in relation to your post.

I believe the path is: /YOUR_ADMIN/includes/functions/extra_functions/stats_sales_report.php not /YOUR_ADMIN/includes/functions/extra_functions/sales_report.php, based on what I was seeing in the folder structure.

Also, in the following line, you have a "/" instead of a "." for 1.5.6, not that this really matters.

* @updated by lat9, supporting zc1.5.5/1/5.6, 2019-11-02

Regards

James

James, thanks for the corrections; I'll get that commentary updated for the v3.3.3 release.

I've just submitted v3.3.3 of the Sales Report to the Zen Cart moderators for review; I'll post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#18: Correct "missing" admin menu-entry on initial installations.
#19: Correct incorrect tax calculation
#20: "Suggest" a .csv file extension on CSV downloads
#21: Move menu-name into a language extra-definition (enables translation).
#22: Enable date-formatting overrides.

Quote:

---

Originally Posted by lat9

I've just submitted v3.3.3 of the Sales Report to the Zen Cart moderators for review; I'll post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#18: Correct "missing" admin menu-entry on initial installations.
#19: Correct incorrect tax calculation
#20: "Suggest" a .csv file extension on CSV downloads
#21: Move menu-name into a language extra-definition (enables translation).
#22: Enable date-formatting overrides.

---

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=9

I have been using this plug-in for a long time across many iterations and zc versions. Very Nice.
I didn't have to make any corrections at all for zc1.5.7. Dates are formatted to suit the host system and prints well on A4.

Quote:

---

Originally Posted by OldNGrey

I have been using this plug-in for a long time across many iterations and zc versions. Very Nice.
I didn't have to make any corrections at all for zc1.5.7. Dates are formatted to suit the host system and prints well on A4.

---

That's great news! Thanks for the report.

What is the latest version of the sale report, where can I find the version my store is using?
Our Admin Store report needs updating, the layout is outdated and confusing, its long overdue an update!!

It is written at the top of the file admin\stats_sales_report.php

There is a small bug with respect to the selection of the payment_methods. Here is a fix that could be considered.

diff --git a/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php b/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php
index 7f74a19..1cd7a3d 100644
--- a/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php
+++ b/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php
@@ -222,8 +222,8 @@ if ($date_target == 'status') {
$date_status = false;
}

-$payment_method = (isset($_GET['payment_method']) && in_array($_GET['payment_method'], $payment_key)) ? $_GET['payment_method'] : '0';
-$payment_method_omit = (isset($_GET['payment_method_omit']) && in_array($_GET['payment_method_omit'], $payment_key)) ? $_GET['payment_method_omit'] : '0';
+$payment_method = (isset($_GET['payment_method']) && array_key_exists($_GET['payment_method'], $payment_key)) ? $_GET['payment_method'] : '0';
+$payment_method_omit = (isset($_GET['payment_method_omit']) && array_key_exists($_GET['payment_method_omit'], $payment_key)) ? $_GET['payment_method_omit'] : '0';
$current_status = (isset($_GET['current_status']) && array_key_exists((int)$_GET['current_status'], $status_key)) ? (int)$_GET['current_status'] : 0;
$excluded_status = (isset($_GET['excluded_status']) && array_key_exists((int)$_GET['excluded_status'], $status_key)) ? (int)$_GET['excluded_status'] : 0;
$manufacturer = (isset($_GET['manufacturer']) && in_array((int)$_GET['manufacturer'], $manufacturer_key)) ? (int)$_GET['manufacturer'] : 0;

Quote:

---

Originally Posted by sjsheu

There is a small bug with respect to the selection of the payment_methods. Here is a fix that could be considered.

diff --git a/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php b/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php
index 7f74a19..1cd7a3d 100644
--- a/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php
+++ b/includes/modules/.sales_report-3.3.3/YOUR_ADMIN/stats_sales_report.php
@@ -222,8 +222,8 @@ if ($date_target == 'status') {
$date_status = false;
}

-$payment_method = (isset($_GET['payment_method']) && in_array($_GET['payment_method'], $payment_key)) ? $_GET['payment_method'] : '0';
-$payment_method_omit = (isset($_GET['payment_method_omit']) && in_array($_GET['payment_method_omit'], $payment_key)) ? $_GET['payment_method_omit'] : '0';
+$payment_method = (isset($_GET['payment_method']) && array_key_exists($_GET['payment_method'], $payment_key)) ? $_GET['payment_method'] : '0';
+$payment_method_omit = (isset($_GET['payment_method_omit']) && array_key_exists($_GET['payment_method_omit'], $payment_key)) ? $_GET['payment_method_omit'] : '0';
$current_status = (isset($_GET['current_status']) && array_key_exists((int)$_GET['current_status'], $status_key)) ? (int)$_GET['current_status'] : 0;
$excluded_status = (isset($_GET['excluded_status']) && array_key_exists((int)$_GET['excluded_status'], $status_key)) ? (int)$_GET['excluded_status'] : 0;
$manufacturer = (isset($_GET['manufacturer']) && in_array((int)$_GET['manufacturer'], $manufacturer_key)) ? (int)$_GET['manufacturer'] : 0;

---

Thanks for the report and the required correction! I'll get that updated for the next release of the Sales Report.

I've just submitted v3.4.0 of the Sales Report for the Zen Cart moderators' review; I'll post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#24: Additional discount- and fee-related order totals. (thanks, @swguy)
#25: Correct handling of 'payment_method' and 'payment_method_omit' filters (thanks, @sjsheu).

Quote:

---

Originally Posted by lat9

I've just submitted v3.4.0 of the Sales Report for the Zen Cart moderators' review; I'll post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#24: Additional discount- and fee-related order totals. (thanks, @swguy)
#25: Correct handling of 'payment_method' and 'payment_method_omit' filters (thanks, @sjsheu).

---

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=9