Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
DivaVocals
This is a default Zen Cart file.. it's not a part of the IH4 fileset, but if it is the source of the sizing issues, then it may need to be included with the appropriate modifications...
Well, I see that IH4 modifies the popup_image_additonal version of that file, so I don't know yet if also needs to be included. I do see that there is a problem with jscript_imagehover.js on the problem site. Says line 172, code: 0, char: 1.
In the: includes/templates/custom_template/jscript/jscript_imagehover.js folder/file
I mean, looking at the source code as you probably already have, it looks like it is trying to call a window that will be the size of the image (600x600), but somewhere in the call to the new image, it drops the width for some reason/somehow.. :/
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
mc12345678
Okay, so I finally figured out what you have tried to tell me but I couldn't get into my thick head. Apparently the popup is coming in at a width that is too small and the image is being squashed from the sides. I was able to expand the width of the image and it began appearing as more appropriately expected.
Yureka!! Yes the correct image is displayed, but the popup is not opening up to match the image size.. Yes you can manually resize the popup window, but the point is the popup window should open to the correct size to begin with.
http://eitestsite(dot)eyeitalia(dot)...ge.600x600.jpg
Quote:
Originally Posted by
mc12345678
At the moment, I am only guessing since I have not started with a fresh cart and applied IH4 to it, but one thing I see is that I have the following jscript_main.php file in the includes/modules/pages/popup_image directory, and am wondering if it has an effect because it seems to address some of the size issues described. I tried disabling the file from my site, but the resizing on my side still worked. I haven't experienced a "shrink" of the image and do not know where the value of 250 is coming from for the width. Also, the images that I get to appear on my site, if I were to shrink the window, the image doesn't shrink with it like how yours expands with the window until at least 600x600 and then shrinks again with a shrinking window.
Do you have the following jscript_main.php file installed in the includes/modules/pages/popup_image directory?
Not sure if this was supposed to be a part of the IH4 package or not, or if it was part of another installation, but it appears to handle some of what you are describing.
This file was never a part of the IH4 fileset, and it never had to be since the popup windows were never an issue.. However, if that's what is needed here to resolve the issue, then that's the way it has to be..
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
mc12345678
Well, I see that IH4 modifies the popup_image_additonal version of that file, so I don't know yet if also needs to be included. I do see that there is a problem with jscript_imagehover.js on the problem site. Says line 172, code: 0, char: 1.
In the: includes/templates/custom_template/jscript/jscript_imagehover.js folder/file
I mean, looking at the source code as you probably already have, it looks like it is trying to call a window that will be the size of the image (600x600), but somewhere in the call to the new image, it drops the width for some reason/somehow.. :/
IH4 only modifies the popup_image_additional header_php.php file, not the javascript files in those folders..
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
mc12345678
Well, I see that IH4 modifies the popup_image_additonal version of that file, so I don't know yet if also needs to be included. I do see that there is a problem with jscript_imagehover.js on the problem site. Says line 172, code: 0, char: 1.
In the: includes/templates/custom_template/jscript/jscript_imagehover.js folder/file
I mean, looking at the source code as you probably already have, it looks like it is trying to call a window that will be the size of the image (600x600), but somewhere in the call to the new image, it drops the width for some reason/somehow.. :/
Okay.. My apologies.. I think the popup issue on the EyeItalia site is unrelated to IH4, and may be a javascript conflict coming from my responsive template.. Standby.. Gonna try your new code on the client site where I first spotted the initial popup problem..
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
DivaVocals
You need to ROLL YOUR STORE BACK to a pre IH4 state (you did make a backup as suggested before installing right??) trying to delete and manually replace the files will NOT solve your issue.. Please take my advice and start over..
OK, thank you. I will do as you suggested and report back.
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
DivaVocals
IH4 only modifies the popup_image_additional header_php.php file, not the javascript files in those folders..
Yeah, after a third look at the affected files, you are correct, the header_php.php files are all that are affected. I could have sworn that I saw files with the jscript_main and IH modification names, but I was blatantly wrong. Still, (and I know you're off investigating) the request to show the image is one that indicates it is to have the size desired; however, yeah, something is interacting oddly after the call is made. Look forward to the local test results.
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
EHSI
OK, thank you. I know that something is rotten here. The first installation worked properly with all three images being different.
Tonight, I will re-upload IH4 file by file checking that all sizes of the files in the original folder are the same that the sizes of the files on server. It will take a couple of hours. I will be back. Thank you again for your help.
Do you think I have to uninstall IH4 and install it again or just overwrite the existing files on server one by one?
Diva has already replied; however, would like to say that there is no reason that the files would need to be uploaded one by one. This site identifies at least two ftp applications (names I can not remember at moment) that will upload each file until completion and it is possible to identify all files to be uploaded at once, and it/they will do so. Ie. there are many ftp programs that will hang and basically dump the file(s) or cause other issues with the uploads.
I do recall that I have experienced something similar before as well, though, but couldn't tell you the exact conditions that were in place. What happens if you upload that picture in the standard product entry location such as from the admin panel? The same thing, or do you see results that you were expecting?
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
DivaVocals
Okay.. My apologies.. I think the popup issue on the EyeItalia site is unrelated to IH4, and may be a javascript conflict coming from my responsive template.. Standby.. Gonna try your new code on the client site where I first spotted the initial popup problem..
and..... drumroll please...
IT WORKS!!!
mc12345678 - YOU ARE THE MAN!!!! (I can't tell your gender by your screenname.. :laugh:)
Okay.. my apologies to mc12345678 for the last 5 pages of this thread.. It wasn't until you last post that it finally clicked that my responsive template is the cause of the popup window issue.. Probably a javascript conflict.. when I turned off the responsive template, the issue went away..
I just installed the modified additional_images.php module file on my client's live site (where I first discovered the issue) and BOBS YOUR UNCLE.... IT worked!!!
Before I package this up and submit it as an update, we do need others with the ORIGINAL issue ("no image" product image was displaying in the large image popup), to test and report their findings..
Working here: http://www(dot)consciousink(dot)com/...ies-p-112.html
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
mc12345678
Diva has already replied; however, would like to say that there is no reason that the files would need to be uploaded one by one. This site identifies at least two ftp applications (names I can not remember at moment) that will upload each file until completion and it is possible to identify all files to be uploaded at once, and it/they will do so. Ie. there are many ftp programs that will hang and basically dump the file(s) or cause other issues with the uploads.
I do recall that I have experienced something similar before as well, though, but couldn't tell you the exact conditions that were in place. What happens if you upload that picture in the standard product entry location such as from the admin panel? The same thing, or do you see results that you were expecting?
Given the issue EHSI is having I still suggest a rollback and re-install..
Re: Image Handler 4 (for v1.5.x) Support Thread
Quote:
Originally Posted by
DivaVocals
and..... drumroll please...
IT WORKS!!!
mc12345678 - YOU ARE THE MAN!!!! (I can't tell your gender by your screenname.. :laugh:)
Okay.. my apologies to mc12345678 for the last 5 pages of this thread.. It wasn't until you last post that it finally clicked that my responsive template is the cause of the popup window issue.. Probably a javascript conflict.. when I turned off the responsive template, the issue went away..
I just installed the modified additional_images.php module file on my client's live site (where I first discovered the issue) and BOBS YOUR UNCLE.... IT worked!!!
Before I package this up and submit it as an update, we do need others with the ORIGINAL issue ("no image" product image was displaying in the large image popup), to test and report their findings..
Working here:
http://www(dot)consciousink(dot)com/...ies-p-112.html
I need to add that I remember reporting to ckosloff that the additional images were an issue when IH was updated for 1.3.9.. I also remember that he and had a bit of back and forth on the matter because he didn't think that what I was reporting was an issue.. That is part of the reason the large image popup got rolled back to an old version from a prior version of Zen Cart to begin with.. I had NO IDEA at the time that this would leave the image popups subject to XSS vulnerabilities.. I just knew that the popups and additional images were not working correctly, and I thought I found a solution..
Anyway.. mc12345678 again.. thanks for your tenacity, and patience.. :smile:
