Re: ZCA Bootstrap Template
New install Zen 1.5.8a, PHP 7.3, Bootstrap 3.5.2, OPC 2.4.5 w/o guest checkout enabled.
Error:
[08-Apr-2023 08:32:23 America/New_York] Request URI: /xxxxx/ajax.php?act=ajaxPayment&method=prepareConfirmation, IP address: 134.215.175.155
--> PHP Parse error: syntax error, unexpected '.' in /home/xxxxx/public_html/xxxxx/includes/templates/bootstrap/templates/tpl_ajax_checkout_confirmation_default.php on line 321.
Broken piece
Code:
<div id="checkoutConfirmationDefault-btn-toolbar" class="btn-toolbar justify-content-between confirm-order" role="toolbar">
<?php echo '<strong'> . $title_continue_checkout . '</strong><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?>
<?php echo zen_image_submit(BUTTON_IMAGE_CONFIRM_ORDER, BUTTON_CONFIRM_ORDER_ALT, 'name="btn_submit" id="btn_submit"') ;?>
</div>
Error prevents checkout using PayPal Pro
Re: ZCA Bootstrap Template
Quote:
Originally Posted by
mprough
New install Zen 1.5.8a, PHP 7.3, Bootstrap 3.5.2, OPC 2.4.5 w/o guest checkout enabled.
Error:
[08-Apr-2023 08:32:23 America/New_York] Request URI: /xxxxx/ajax.php?act=ajaxPayment&method=prepareConfirmation, IP address: 134.215.175.155
--> PHP Parse error: syntax error, unexpected '.' in /home/xxxxx/public_html/xxxxx/includes/templates/bootstrap/templates/tpl_ajax_checkout_confirmation_default.php on line 321.
Broken piece
Code:
<div id="checkoutConfirmationDefault-btn-toolbar" class="btn-toolbar justify-content-between confirm-order" role="toolbar">
<?php echo '<strong'> . $title_continue_checkout . '</strong><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?>
<?php echo zen_image_submit(BUTTON_IMAGE_CONFIRM_ORDER, BUTTON_CONFIRM_ORDER_ALT, 'name="btn_submit" id="btn_submit"') ;?>
</div>
Error prevents checkout using PayPal Pro
Move the Quote thus
Code:
<div id="checkoutConfirmationDefault-btn-toolbar" class="btn-toolbar justify-content-between confirm-order" role="toolbar">
<?php echo '<strong>' . $title_continue_checkout . '</strong><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?>
<?php echo zen_image_submit(BUTTON_IMAGE_CONFIRM_ORDER, BUTTON_CONFIRM_ORDER_ALT, 'name="btn_submit" id="btn_submit"') ;?>
</div>
I have submitted a pull request, but it has not been actioned yet.
Re: ZCA Bootstrap Template
I know how to fix it =) I was reporting it so Lat could get it resolved
Re: ZCA Bootstrap Template
Quote:
Originally Posted by
mprough
I know how to fix it =) I was reporting it so Lat could get it resolved
PR has been accepted. I was waiting to see if there are any other issues reported and, if not, I'll get v3.5.3 released this week.
Re: ZCA Bootstrap Template
v3.5.3 of the ZCA Bootstrap Template is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2191
This release contains corrections for the following GitHub issues:
#231: Correct PHP Parse error when payment methods "collect credit card data on-site".
#232: Correct PHP Warning logged by shopping_cart template.
#233: Correct products' model alignment on listing pages.
#234: Add language constant added for zc158 that doesn't exist in zc157.
#235: Add missing text 'lead-in' for products' quantity on listing pages.
3 Attachment(s)
Re: ZCA Bootstrap Template
Not sure if this is bootstrap related, 1.5.8a related, or just something messed up in my settings.
I have a 20% off coupon with restrictions: Only allow on Category A. Category A has one product.
I added that product to my order along with an indifferent item from Category B.
Problem 1: The 20% discount being taken off is MORE than 20%. It's almost like it's factoring in tax or something?
Problem 2: The TOTAL doesn't add up correctly. It's actually shorting me out money since the total should be higher.
This screenshot should help: Attachment 20259
And here is my Coupon Settings which appear to be correct (allowing the 20% discount to only apply to items in that category): Attachment 20260
And here are the settings for the ot_coupon, where I don't have it calculating tax or shipping: Attachment 20261
Can anyone help explain why those two problems are happening?
EDIT: It's definitely related to tax in some way. I did a test with an account that didn't have tax and it calculated fine. So for some reason, the discount is being influenced by the tax, and it's miscalculating the total. Perhaps something to do with the ORDER in which the discount is applied and total is calculated?
Re: ZCA Bootstrap Template
In reference to the issue above, I was able to solve Problem #2 (subtotal being incorrect). This is related to the sorting order of the Order Total Modules. If I had the ot_coupon lower than the ot_tax (on the checkout page), then the ot_total was incorrect.
By changing the Sort Order so that ot_coupon was displayed higher (meaning it has a lower sort order value) than the ot_tax, that seems to have corrected the ot_total calculation.
I still cannot figure out WHY problem #1 is still happening: the coupon discount is being affected by something whenever it's used in a region with sales tax, even though I don't have sales tax being factored into my ot_coupon settings.
1 Attachment(s)
Re: ZCA Bootstrap Template
Quote:
Originally Posted by
Jeff_Mash
I still cannot figure out WHY problem #1 is still happening: the coupon discount is being affected by something whenever it's used in a region with sales tax, even though I don't have sales tax being factored into my ot_coupon settings.
Man, I'm sorry for all these posts, but I find more information after I post something!
So the issue with Problem #1 doesn't seem to be related to tax, because I reproduced it on an order without tax.
Check out this example: Attachment 20262
As you can see, it works fine with the one item (which qualifies for the discount). But when I add a second item which isn't part of the discount category, the 20% value isn't calculated correctly.
Any ideas?
Re: ZCA Bootstrap Template
@Jeff_Mash, you need to post these questions in the "Discounts/Coupons" thread, since they're targeted at ot_coupon's misbehaving.
Re: ZCA Bootstrap Template
how to install this template?