Printable View
Hi,
Just wanted to plug the github repository once more, and also announce that we have pushed code for the new installer in v1.6.
https://github.com/zencart/zencart/c...2277dc009e820e
We have also uploaded a couple of videos to our youtube channel to show off the new installer.
http://www.youtube.com/zencart
disclaimer: v1.6.0 is work in progress. you should not use the 1.6.0 code on github for a live store until it is officially released and merged to master.
Nice job on the installer.
One minor thing, why am I required to enter a database password. On my localhost I don't use a password, because it is not necessary. Of-course production server are required to use one. Now i need to add (and remember) a password to the database.
While it's not necessary, I have a password on my localhost database. I guess we could make the password non-required, given that hosts will definitely set a password.Quote:
Originally Posted by Design75
If you want to remove the requirement yourself, you need to edit zc_install/includes/templates/database_default.php
around line 130 you should see this javascript
and you need to remove the lineCode:$().ready(function() {
$("#db_setup").validate({
submitHandler: function(form) {
ajaxTestDBConnection(form);
},
rules: {
db_host: "required",
db_user: "required",
db_password: "required",
db_name: "required",
sql_cache_dir: {
required: function(element) {
return $("#sql_cache_method").val() == 'file';
}
}
},
messages: {
}
});
});
Code:db_password: "required",
Thank you, I will try.
In the mean time I added a password to the database user, and proceeded.
I encountered a new problem. When the databases are created and being filled with the demo data the installation program stops. The progress bar stay at almost filled, end never proceeds any further.
This happen only on my local install with xampp 1.8.1, winxp, php 5.4.7, Apache/2.4.3, 5.5.27 - MySQL
On a normal productoin server all is okay
As per the previous poster, I tried this on a local install xampp 181, php 5.4.7 but not using the default configurations for php.ini nor apache httpd.conf due to previous problem solving attempts. Also using virtual hosts rather than alias.
I subscribe to the design theory: "Don't make me think" (or rather "...assume I cannot think").
It looks great and very important for first impressions.
Some nitpicking comments:
1) I note tabbing between the input fields requires an extra click every time.
2) Database setup screen: why not check for the existence of the mysql server when entering this page and flag it immediately?
3) Creating database:
I got multiple repeat error messages:
Warning: sha1_file(DIR_FS_CATALOGDIR_WS_INCLUDESconfigure.php): failed to open stream: No such file or directory in D:\My Documents\GitHub\zc-v1-series\zc_install\includes\functions\password_funcs.php on line 118
The read.md says you have to rename the configures, why? They get created and the store works without doing that.
4) I think the labels stating that you must make a note of your password and the new name of the admin folder should be more in your face.
5) There are some minor validation errors (using Total Validator) on each page.
6) Shop: alt-nav looks like the page is broken, no css is loaded.
What about detecting its a localhost install and creating local/configure.php?
Steve
I also could not see the wood for the tree:
"Setup Finshed"
Oh, nice one!:yes:Quote:
Originally Posted by torvista
Do you see any relevant info in the logs directory.Quote:
Originally Posted by Design75
Also helpful would be to install firebug in your browser. That might throw up any Javascript errors that are occuring.
I will try and do a run through with a xampp install when I get a chance.
Thanks for the feedback :)
No error-logs, the installer just stops.Quote:
Originally Posted by wilt
I will try again later this evening, and check on the javascripts
Thanks for the detailed feedback Steve.Quote:
Originally Posted by torvista
I'll address the tab order asap :)
Not sure what you mean here. The system checking code should have already tried to see if there is a live mysql server, and if not informed you on the initial screen.Quote:
2) Database setup screen: why not check for the existence of the mysql server when entering this page and flag it immediately?
Noted: Will check code.Quote:
3) Creating database:
Apologies the read.md is a little out of date, and based on old installer/v1.51Quote:
The read.md says you have to rename the configures, why? They get created and the store works without doing that.
Fair enough :)Quote:
4) I think the labels stating that you must make a note of your password and the new name of the admin folder should be more in your face.
Double fair enough :)Quote:
5) There are some minor validation errors (using Total Validator) on each page.
Assume you mean the admin menu alt-nav. You haven't signed an NDA so I can't tell you that there will be changes coming to the admin menu infrastructure.Quote:
6) Shop: alt-nav looks like the page is broken, no css is loaded.
Nice idea. will ponder. :)Quote:
What about detecting its a localhost install and creating local/configure.php?
I just tried installing again, same result. This time I checked the apache logs, and found the following
Code:[Fri May 10 22:12:17.468750 2013] [:error] [pid 5072:tid 500] [client 127.0.0.1:1050] PHP Warning: fopen(F:\\xampp\\htdocs\\zen4all.nl160beta/logs/progress.json): failed to open stream: Invalid argument in F:\\xampp\\htdocs\\zen4all.nl160beta\\zc_install\\includes\\classes\\class.zcDatabaseInstaller.php on line 330, referer: http://localhost/zen4all.nl160beta/zc_install/index.php?main_page=database
[Fri May 10 22:12:17.468750 2013] [:error] [pid 5072:tid 500] [client 127.0.0.1:1050] PHP Warning: fwrite() expects parameter 1 to be resource, boolean given in F:\\xampp\\htdocs\\zen4all.nl160beta\\zc_install\\includes\\classes\\class.zcDatabaseInstaller.php on line 332, referer: http://localhost/zen4all.nl160beta/zc_install/index.php?main_page=database
[Fri May 10 22:12:17.468750 2013] [:error] [pid 5072:tid 500] [client 127.0.0.1:1050] PHP Warning: fclose() expects parameter 1 to be resource, boolean given in F:\\xampp\\htdocs\\zen4all.nl160beta\\zc_install\\includes\\classes\\class.zcDatabaseInstaller.php on line 333, referer: http://localhost/zen4all.nl160beta/zc_install/index.php?main_page=database
Have not played with the installer yet, So apologies if this already happens during an upgrade....Quote:
Originally Posted by torvista
I'd like to see the first step handling the "configure.php" files rename the originals if present, pull in the variables as needed while installing, write brand new "configure.php" files, and optionally delete the old configure.php when done.
This would ensure the old files are present as a "backup" from before upgrading... Make sure people have the most recent (and a clean) version of the "configure.php" (including any changes such as the automatic "admin folder location" change in 1.5)... And make it easier for people to do a manual "diff" to see what has changed (if anything) between versions.
With mysl server off and my pc disconnected from the internet no page detects the absence of the mysql server...it only gets flagged after entering the db details on Database setup page and pressing Continue.Quote:
The system checking code should have already tried to see if there is a live mysql server, and if not informed you on the initial screen.
Its a small point but I am thinking brand new user here and a bit of psychology, I know I would want the initial inspection page to tell me that all is not well, but would be irritated on being informed only after filling in form fields...which no doubt would time out before I had fixed the problem.
Languages
I see the installer text has been moved to language defines...I created another to see if it would automagically offer the two choices but no!
Maybe it should detect the presence of other language files and offer the choices automatically. Pretty important for world domination I would say.
Since its only one file it should be easy to get a multi-language installer completed by the community once its finalised.
I had a similar problem with Apsona running locally on php 5.4.7. when importing a csv. It was due to php strict warnings (that initially did not appear) that I could not supress.Quote:
When the databases are created and being filled with the demo data the installation program stops. The progress bar stay at almost filled, end never proceeds any further.
I have now tried the installer using the default xampp 1.8.1 php.ini and apache httpd.conf and it works for me using virtual hosts and/or if located in the default xampp \htdocs directory.
/local/whatever
I feel this aspect of zen cart is not well-known and a discussion for another thread which I'll kick-start in due course...
Similar issue and error messages as 'Design75' in posts #5 and #12.
The 'Loading Demo Data' modal window permanently froze as it was near the end.
Local install of Wamp 2.2 running PHP 5.4.3, MySQL 5.5.24 and Apache 2.4.2 on Windows 7 64 bit with Firefox 20.0.1.
Only change made was to remove the password requirement in post #4.
Apache error log attached (as it exceeded the maximum character limit).
Attachment 12484
This is a weird error as the file in question must have been written to before if the main sql progress bar completed.Quote:
Originally Posted by Commentics
When writing the Ajax/Json progress logging initially, I would see some problems myself, but thought I had ironed them out.
It's more than likely a race condition where the attempt to write to the file is blocked by an ongoing read (due to the asynchronous nature of Ajax)
Will put some code in to test the validity of the file resource, which should hopefully mitigate the race condition.
My initial comments (the installer interface looks good!):
System Setup Screen
- Need to determine which 'version' of English is to be used: licence vs license
Database Setup
- I made the change noted in post#4 regarding the database password; I've never set one on my localhost/XAMPP testing
- What happened to SQL cache method: None?
- Database Charset dropdown, is there Latin9 (should be latin1?)
Admin Setup
- Messages regarding initial password (This is your initial temporary password for your Admin Superuser Account. Please ensure you make a note of it.) and initial directory (Your store Admin directory has been automatically renamed. Please ensure you make a note of this directory.) appear below the associated fields; I was confused initially as to which field was associated with the message and think it would flow better if the messages were either above or beside the associated field. I tend to read top->bottom, left->right (that might be different in different cultures).
Setup Finished
- The message (You need to remove the /zc_install folder so that someone can't re-install your shop again and wipe out your database! Warnings will appear until the folder has been removed ) is overly scary.
-The message "warnings will appear" is not quite correct because I can't log into the admin without the rename. A "warning" shouldn't be as insistent; the message should read "A message will appear and you will not be able to log into your admin until the folder has been removed." (or something of the ilk).
Admin main page
- Click the V on General Statistics. TEXT_CANCEL instead of Cancel
Admin Configuration Menu
- Dropdown shows Cowoa Checkout ... shouldn't it be COWOA (all caps)?
- Once in Cowoa Checkout, the page title reads "Guest Checkout" ... shouldn't it be the same as the dropdown title?
- I thought that the zen_trace function was supposed to be included in v1.6.0, but couldn't find it in the Configuration->Logging menu.
Storefront, COWOA checkout
- Some funky formatting going on with the progress bar:
Attachment 12488
Just a couple more questions:
- Looking in /zc_install/sql/updates, it appears that there will be an upgrade path from 1.3.9, 1.5.0 or 1.5.1 to v1.6.0 ... but not any earlier release. I just wanted to note this for confirmation and to provide (yet another) heads-up to those store-owners still running a v1.3.8 or earlier store.
- There's no mysql_latin1.sql file in /zc_install/sql/install; I'm assuming that that's just an oversight ...
There probably will be an upgrade path for older versions, although we have not yet decided how far back we will go with that path. It almost certainly won't go back to 1.2 as the old installer does.Quote:
Originally Posted by lat9
Yes, the latin1 file was overlooked :blush:
K, that's the prob with having core team spread between UK/USA/Canada. :blink:Quote:
Originally Posted by lat9
Ive removed the required option now on the DB password. My bad on missing the None option. Similarly with the latin1/9Quote:
Database Setup
- I made the change noted in post#4 regarding the database password; I've never set one on my localhost/XAMPP testing
- What happened to SQL cache method: None?
- Database Charset dropdown, is there Latin9 (should be latin1?)
Agreed, and othere have pointed this out as well. Will try and rejig that page to make the prompts better.Quote:
Admin Setup
- Messages regarding initial password (This is your initial temporary password for your Admin Superuser Account. Please ensure you make a note of it.) and initial directory (Your store Admin directory has been automatically renamed. Please ensure you make a note of this directory.) appear below the associated fields; I was confused initially as to which field was associated with the message and think it would flow better if the messages were either above or beside the associated field. I tend to read top->bottom, left->right (that might be different in different cultures).
Noted :smile:Quote:
Setup Finished
- The message (You need to remove the /zc_install folder so that someone can't re-install your shop again and wipe out your database! Warnings will appear until the folder has been removed ) is overly scary.
-The message "warnings will appear" is not quite correct because I can't log into the admin without the rename. A "warning" shouldn't be as insistent; the message should read "A message will appear and you will not be able to log into your admin until the folder has been removed." (or something of the ilk).
COWOA and other checkout stuff will be getting a refresh shortly once I finish and merge the new checkout flow infrastructure code.Quote:
Admin main page
- Click the V on General Statistics. TEXT_CANCEL instead of Cancel
Admin Configuration Menu
- Dropdown shows Cowoa Checkout ... shouldn't it be COWOA (all caps)?
- Once in Cowoa Checkout, the page title reads "Guest Checkout" ... shouldn't it be the same as the dropdown title?
- I thought that the zen_trace function was supposed to be included in v1.6.0, but couldn't find it in the Configuration->Logging menu.
Storefront, COWOA checkout
- Some funky formatting going on with the progress bar:
Attachment 12488
Minor grammatical change for the 'htaccess support' help window.
This maybe because you are not using Apache as your Web Server ..
This may be because you are not using Apache as your Web Server ..
Some further info on this. The initial page does some checking on the availablity of MySql, however only tries the actual connection if there is an existing configure.php.Quote:
Originally Posted by torvista
If there is no configure.php. then testing the connection becomes problematic, as we don't know any details about the mysql server. We can asssume that host=localhost, but this is not always the case for some hosting providers. Also, to test the connection I would normally have to pass a user/password. Altough I guess I could pass some nulll parameters for that, and just look at what the error was.
Even then, I would have to make the error a non-fatal one, given that I can't assume localhost.
Still thinking on this one.
This is the "problem" with sticking your head above the parapet and asking for opinions for once, everyone and his dog will nitpick to death on (non) issues that maybe don't deserve the time spent on them, at the expense of progress. Law of diminishing returns.Quote:
Still thinking on this one.
Still, I would say its an indication of how (some) people in the forum really just want to contribute when they can (are allowed to) and want to make the product the best it can be. Do it once and right, where possible.
I think the installer has to be particularly comprehensive/friendly/fault-free as its the first and maybe last contact a new user will have. Helps to alleviate the shock of the classic template.
I guess the whole point of moving the devlopment stuff to Github and the forum posts is to 'stick our head over the parapet'Quote:
Originally Posted by torvista
So far there hasn't been too much 'nitpicking to death', and I am appreciative of the feedback so far. Replies here have been useful and welcome.
Just ran the installer (as downloaded today) and it hung at the end of creating database with this log error
30s is the default setting in php.ini on the current verisons (1.82/1.83) of Xampp.Quote:
PHP Fatal error: Maximum execution time of 30 seconds exceeded in ......\zc160\includes\classes\db\mysql\query_factory.php on line 40
It completed ok when changed to 60s so maybe a
ini_set('max_execution_time', 60);
is required somewhere in the installer.
Maybe just call "set_time_limit(30);" inside ajaxGetProgressValues.php to restart the 30 second timeout each time the progress is refreshed? Maybe combined with a "cancel" button during the install / upgrade process? May be a little spammy, but would ensure no timeout as long as the person installing is sitting on a screen with the install processing....Quote:
Originally Posted by torvista
Just my 5 cents to the new installer:
Had first 'contact' with ZC1.6.0 today. Downloaded using git and followed the commands as outlined by swguy - no problems.
Ran the installer on my local dev server and encountered no problems at all. Just a bit puzzled by the message (not verbatim): '....no .htaccess support, you are either not running Apache...... etc'
I am running a fully fledged LAMP stack on a Linux Mint 15 (alas Ubuntu 13.04) box. That box is hosting several 1.3.9h and 1.5.1 installs - all running w/o .htaccess problems.
Despite the warning about .htaccess ZC 1.6.0 fired up without problems, store side and admin.
Parameters of the dev server:
Server Information
Server Host: Andromeda (127.0.1.1) Database Host: localhost (127.0.0.1)
Server OS: Linux 3.8.0-19-generic Database: MySQL 5.5.32-0ubuntu0.13.04.1
Server Date: 08/22/2013 22:48:14 Database Date: 08/22/2013 22:48:14
Server Up Time: 22:48:14 up 5:35, 1 user, load average: 0.47, 0.34, 0.27 HTTP Server: Apache/2.2.22 (Ubuntu)
PHP Version: 5.4.9-4ubuntu2.2 (Zend: 2.4.0) PHP Memory Limit: 128M PHP Safe Mode: Off
PHP File Uploads: On Max Size: 5M POST Max Size: 8M
Database Data Size: 371 kB Database Index Size: 538 kB
PHP Version 5.4.9-4ubuntu2.2
System Linux Andromeda 3.8.0-19-generic #30-Ubuntu SMP Wed May 1 16:36:13 UTC 2013 i686
Build Date Jul 15 2013 18:03:31
Server API Apache 2.0 Handler
Virtual Directory Support disabled
Configuration File (php.ini) Path /etc/php5/apache2
Loaded Configuration File /etc/php5/apache2/php.ini
Scan this dir for additional .ini files /etc/php5/apache2/conf.d
Additional .ini files parsed /etc/php5/apache2/conf.d/10-pdo.ini, /etc/php5/apache2/conf.d/20-curl.ini, /etc/php5/apache2/conf.d/20-gd.ini, /etc/php5/apache2/conf.d/20-mysql.ini, /etc/php5/apache2/conf.d/20-mysqli.ini, /etc/php5/apache2/conf.d/20-pdo_mysql.ini, /etc/php5/apache2/conf.d/mcrypt.ini
All in all I like the new installer, less fuss and very clear and simple to run.
Still - what's the story with the .htaccess warning?
Thanks / Frank
Now that I am more awake, something like this would need to go into the code performing the upgrade... Maybe between longer steps...Quote:
Originally Posted by lhungil
This check is done by testing to see if your webserver is honoring the restrictions placed in the "/includes/.htaccess". It does this by calling CURL against your webserver to request the file "/includes/filenames.php". If the request does not return a 403 status (forbidden / access denied) the restrictions are probably not taking effect and this error message is displayed...Quote:
Originally Posted by frank18
What happens if you go to that location using your browser? If you get the 403... Can you check what is returned around line 318 / 319 of "/zc_install/includes/classes/class.systemChecker.php"?
If you do not get the 403... Could be because of Apache is not reading .htaccess files (disabled)... Or could be one of the directives is failing (or overrides are not allowed)... Is there anything in the Apache error logs?
Right. We've put it into application_top since all the smaller steps re-run that. And used a higher number too.Quote:
Originally Posted by lhungil
Correct. If the /includes/.htaccess file is working correctly, then it will deny access for any browser to any .php file under the /includes/ folder or subfolders. And that's what the installer is testing when that message is displayed to you.Quote:
Originally Posted by lhungil
Thought so, thanksQuote:
Originally Posted by DrByte
Found nothing in the logs relating to this issueQuote:
Originally Posted by lhungil
The .htaccess testing was added in v1.5.0, and is not unique to v1.6.0.
If you are wanting to discuss the matter further, please use another forum thread for that, since it is off topic.
On the first access into the admin, you are asked to select country and zone.
After selecting Spain I was only offered the zones for the US.
Should the widget be working for the log files?
These should probably be separate threads, especially if you're encountering specific problems with them.
Yes, the dropdown hasn't been made dynamic yet. You're welcome to submit a pull request if you want to tackle that.Quote:
Originally Posted by torvista
It is for me thus far.Quote:
Originally Posted by torvista
Click on the Pencil for the widget settings, then just click on update. I get a popup.Quote:
It is for me thus far.
with a couple of Network Error 500 in the Firebug console and a debug logQuote:
An unknown response was received while processing an ajax call. The action you requested could not be completed.
(WinXP, Xampp, Ffox/Chrome/Opera/IE8)Quote:
[18-Dec-2013 08:55:11 Europe/Berlin] PHP Fatal error: Call to undefined function get_logs_data() in blah-blah\includes\classes\dashboardWidgets\class.zcDashboardWidgetLogs.php on line 22
I think there needs to be a new forum section for 1.60 comments and bugs as
1) 1.6 is not relevant to most people so posts should not be mixed in with bug reports for the current production code of 1.5x
2) people may try out 1.60 but can't figure out how to report bugs via Github, like me, nor be up to fixing and sumitting pull requests, also like me.
Do you have a github account? (it's free)Quote:
Originally Posted by torvista
If so, I'm pretty sure you should be able to create issues by clicking this: https://github.com/zencart/zencart/issues/new
http://www.zen-cart.com/forumdisplay...velopment-BugsQuote:
Originally Posted by torvista
Is there any provision/hooks in the new installer to allow the use of other languages during installation?
The installer trawls though the defines in the existing admin configure.php file to check all is well (existing files in the right place, existing database connections working etc.).
However I note it uses the first instance of the constant it finds, whether in use or commented out (for whatever development reason).
So, if the commented define is first in line, and it is not correct for that installation, it doesn't check out and so no Upgrade is offered.
Not asking for this oddity to be taken into account, but it caught me out (for a good while).
"Why multiple defines" you ask...well I have the development sites files/all my files synced/duplicated across various pc's so I can work at whichever is convenient and although the local pc's virtual hosts definitions can be identical, their filesystem location may not be, so DIR_FS_CATALOG may vary.
So I have this in the file, so it works in any of them.
The installer was picking up $dir1 as the directory.Quote:
$dir1 = 'D:/Documents/some location.../public_html/tienda_155/';
$dir2 = 'D:/My Documents/some other location.../public_html/tienda_155/';
etc...
if ( is_dir($dir1) ) {
define('DIR_FS_CATALOG', $dir1);
} elseif ( is_dir($dir2) ) {
define('DIR_FS_CATALOG', $dir2);
etc...
}
Still, I've learnt how the installer works now!
Well that certainly might explain why someone recently reported having their DIR_WS_IMAGES path set to something non functional and obscure...Quote:
Originally Posted by torvista
In the context of zc_install, not likely. If it were installer-related, then it would affect other things more broadly.Quote:
Originally Posted by mc12345678
Was my thought as well until I saw torvista's post. Seemed like it might explain what was "done", but then again maybe the person posting/installing incorrectly stated how they got the admin/includes/configure.php file that they got. Thread involved.Quote:
Originally Posted by DrByte
Then perhaps it's best to ask them that, in that thread. You'd need to see the old configure.php files to know for certain.Quote:
Originally Posted by mc12345678
Given the nature of the person's posts in that other thread, I doubt they'd customized the configure.php files there.