[Done v1.5.6] PHP Warning: A non-numeric value encountered... - PHP 7 warnings

I have had a couple of these debug warnings with PHP 7.1. No doubt there will be more...

1) in advanced_search_result_header.php

I changed

Quote:

---

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
$pfrom = $_GET['pfrom'] / $rate;
$pto = $_GET['pto'] / $rate;}

---

to

Quote:

---

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
$pfrom = (float)$_GET['pfrom'] / $rate;//steve added float for PHP 7 warning
$pto = (float)$_GET['pto'] / $rate;//steve added float for PHP 7 warning
}

---

Note this was provoked by an url like this
SHOP_ROOT/index.php?main_page=advanced_search_result&keyword=asas&search_in_description=1& categories_id=&inc_subcat=1&manufacturers_id=&pfrom=&pto=&dfrom=&dto=

2) functions_taxes.php

I changed

Quote:

---

// Calculates Tax rounding the result function
zen_calculate_tax($price, $tax = 0) {
$price = $price;
$tax = $tax;
//eof global $currencies;
return $price * $tax / 100;
}

---

to

Quote:

---

// Calculates Tax rounding the result
function zen_calculate_tax($price, $tax = 0) {
$price = (float)$price; //steve added float for PHP 7 warning
$tax = (float)$tax; //steve added float for PHP 7 warning
//eof global $currencies;
return $price * $tax / 100;
}

---

confirmed the problem and solution for advanced_search.

V1.5.5e
PHP v7.1.1
Stirling Grand Template
css_js_loader
Dynamic Price Updater
One page checkout
SBA
User tracking
Zen Magnific
CEON
Elastislide & Responsive Image Gallery
Dynamic Attr. Filter

This might be the place for these errors so,

I have a similar debug error

PHP Warning: A non-numeric value encountered in C:\mylocalserver\www\mydomain.co.uk\includes\classes\categories_ul_generator.php on line 58

said line is:

PHP Code:

---

 $result = sprintf($this->parent_group_start_string, ($submenu==true) ? ' class="level'. ($level+1) . '"' : '' ); 


---

error remedied, with no obvious effect, by changing to:

PHP Code:

---

$result = sprintf($this->parent_group_start_string, ($submenu==true) ? ' class="level'. ($level) . '"' : '' ); 


---

it would be good to know the actual effect that had. The line comes from this block:

PHP Code:

---

function buildBranch($parent_id, $level = 0, $submenu=true, $parent_link='')
    {
        $result = sprintf($this->parent_group_start_string, ($submenu==true) ? ' class="level'. ($level+1) . '"' : '' );
        
        if (($this->data[$parent_id])) {
            foreach($this->data[$parent_id] as $category_id => $category) {
                $category_link = $parent_link . $category_id;
                if (($this->data[$category_id])) {
                    $result .= sprintf($this->child_start_string, ($submenu==true) ? ' class="submenu"' : '');
                } else {
                    $result .= sprintf($this->child_start_string, '');
                }
                $result .= str_repeat($this->spacer_string, $this->spacer_multiplier * 1) . '<a href="' . zen_href_link(FILENAME_DEFAULT, 'cPath=' . $category_link) . '">';
                $result .= $category['name'];
                $result .= '</a>';
                  
                if (($this->data[$category_id]) && (($this->max_level == '0') || ($this->max_level > $level+1))) {
                    $result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '_');
                }
                $result .= $this->child_end_string;
            }
        }
        
        $result .= $this->parent_group_end_string;
        return $result;
    } 


---

I have the original line 58 in
ZC v1.5.4/PHP v5.6.5
ZC v1.5.5a/PHP v5.6.5
both of which worked fine, I suspect it might be a PHP 7 issue.

What do you think?

don't like it. changes what the function is doing. i would change the line to:

PHP Code:

---

$result = sprintf($this->parent_group_start_string, ($submenu==true) ? ' class="level'. ((float)$level+1) . '"' : '' ); 


---

note that this is a warning, and php 7 now issues warnings when attempting arithmetic operations on strings or null values. while it is a change i would hardly call it an issue with php7.

best.

That's great, thank you for clarifying that.

Edit: fixed that, more of the same at:

..\includes\functions\functions_taxes.php on line 172.

torvista was right.

be careful w taxes fix. i think this is the recommended fix:

https://github.com/zencart/zencart/pull/1437/files

Quote:

---

Originally Posted by simon1066

That's great, thank you for clarifying that.

Edit: fixed that, more of the same at:

..\includes\functions\functions_taxes.php on line 172.

torvista was right.

---

The CORRECT way to fix this one is shown here: #18 ... everything else is a bandage.

Thank you, I had forgotten to look at the bug fixes thread.

Had a similar error on a client's site (ZC 1.5.5e) asf:

Quote:

---

[19-Oct-2017 16:33:21 UTC] PHP Warning: A non-numeric value encountered in includes/modules/pages/advanced_search_result/header_php.php on line 368

---

The recommended fix

https://github.com/zencart/zencart/pull/1437/files

made no difference at all.

So, I applied torvista's suggestion which appears to work. Not saying it is the *correct* fix but the cart now runs without errors.

Quote:

---

Originally Posted by frank18

Had a similar error on a client's site (ZC 1.5.5e) asf:

The recommended fix

https://github.com/zencart/zencart/pull/1437/files

made no difference at all.

So, I applied torvista's suggestion which appears to work. Not saying it is the *correct* fix but the cart now runs without errors.

---

the recommended fix deals with tax problems, not with advanced_search_results....

your error log clearly states an issues with advanced search results, which is a different fix than the tax one. so i would recommend applying them both.

i find @torvista s work solid and agree with most things he brings up; certainly in this case, it does address your issue....

best.

Quote:

---

Originally Posted by carlwhat

..... so i would recommend applying them both.

---

Yep, did just that.

Quote:

---

Originally Posted by carlwhat

i find @torvista s work solid and agree with most things he brings up; certainly in this case, it does address your issue....

best.

---

Absolutely, fully agree hence I had no hesitation applying his suggestion.

Cheers

Scenario:
start to add a new product
select "Product Priced by Attributes: - Yes"
Leave price blank/0
Other fields do not matter.

Insert product.
Debug log generated:

Quote:

---

[11-Dec-2017 17:17:48 Europe/Madrid] Request URI: /zc155e_vanilla/admin1/product.php?cPath=1_17&product_type=1&pID=183&action=new_product_preview&page=1, IP address: 127.0.0.1
#1 currencies->format() called at blah-blah\public_html\zc155e_vanilla\admin1\includes\modules\product\preview_info.php :56]
#2 require(blah-blah\public_html\zc155e_vanilla\admin1\includes\modules\product\preview_info.php ) called at [blah-blah\public_html\zc155e_vanilla\admin1\product.php:145]


[11-Dec-2017 17:17:48 Europe/Madrid] PHP Warning: A non-numeric value encountered in blah-blah\public_html\zc155e_vanilla\includes\classes\currencies.php on line 50

---

Line 50 is pretty meaty so I'll leave this for those who seem to enjoy these challenges.......

PHP Code:

---

$format_string = $this->currencies[$currency_type]['symbol_left'] . number_format(zen_round($number * $rate, $this->currencies[$currency_type]['decimal_places']), $this->currencies[$currency_type]['decimal_places'], $this->currencies[$currency_type]['decimal_point'], $this->currencies[$currency_type]['thousands_point']) . $this->currencies[$currency_type]['symbol_right']; 


---

Quote:

---

Originally Posted by torvista

Scenario:
start to add a new product
select "Product Priced by Attributes: - Yes"
Leave price blank/0
Other fields do not matter.

Insert product.
Debug log generated:


Line 50 is pretty meaty so I'll leave this for those who seem to enjoy these challenges.......

PHP Code:

---

$format_string = $this->currencies[$currency_type]['symbol_left'] . number_format(zen_round($number * $rate, $this->currencies[$currency_type]['decimal_places']), $this->currencies[$currency_type]['decimal_places'], $this->currencies[$currency_type]['decimal_point'], $this->currencies[$currency_type]['thousands_point']) . $this->currencies[$currency_type]['symbol_right']; 


---

---

The "Product Priced by Attributes" setting is a red-herring and doesn't matter; the root cause of the debug-log is the fact that the product's price is not entered so it's an empty string ('') and thus non-numeric so that PHP 7.0+'s variable-type-checking steps in.

/admin/includes/modules/product/preview_info.php should ensure that the price value supplied to the currency class is numeric, i.e. an update to line 56 of that file from the ZC 1.5.5e distribution:

Code:

---

<td class="pageHeading" align="right"><?php echo $currencies->format((float)$pInfo->products_price) . ($pInfo->products_virtual == 1 ? '<span class="errorText">' . '<br />' . TEXT_VIRTUAL_PREVIEW . '</span>' : '') . ($pInfo->product_is_always_free_shipping == 1 ? '<span class="errorText">' . '<br />' . TEXT_FREE_SHIPPING_PREVIEW . '</span>' : '') . ($pInfo->products_priced_by_attribute == 1 ? '<span class="errorText">' . '<br />' . TEXT_PRODUCTS_PRICED_BY_ATTRIBUTES_PREVIEW . '</span>' : '') . ($pInfo->product_is_free == 1 ? '<span class="errorText">' . '<br />' . TEXT_PRODUCTS_IS_FREE_PREVIEW . '</span>' : '') . ($pInfo->product_is_call == 1 ? '<span class="errorText">' . '<br />' . TEXT_PRODUCTS_IS_CALL_PREVIEW . '</span>' : '') . ($pInfo->products_qty_box_status == 0 ? '<span class="errorText">' . '<br />' . TEXT_PRODUCTS_QTY_BOX_STATUS_PREVIEW . '</span>' : '') . ($pInfo->products_priced_by_attribute == 1 ? '<br />' . zen_get_products_display_price($_GET['pID']) : ''); ?></td>

---

I'll note that the issue remains on the current ZC 1.5.6 repository.

That was easy.. (for me)!
Thanks!

Hi
I'm getting this warnings with 7.1
I did fix the categories_ul_generator with (int) .... now I was about to fix the taxes, and I understood I could be here doing this all day, so I search for a solution in the forum.

But I see the use of (float) also.... plus the github fix for taxes
Does the zc 1.55f fix this issues , or if not , is it "safer" to use float where ever I get this warnings ?

Thanks

PHP 7.2 support is NOT built-in to v1.5.5f.
But here's a list of the changes required to adapt it: https://github.com/zencart/zencart/pull/1582/files

All of these ARE built-in to v1.5.6

One other issue that I'm facing is :

Code:

---

Uncaught Error: Cannot use string offset as an array in /home/xxx/public_html/includes/modules/tpl_pb/category_row.php:39

---

But, this Error only occurs in the online server with 7.1.13
On my local xampp 7.1.12 it doesn't

This is one, another it's driving me crazy, because it works in my local machine and it doesn't on the online server, and I even don't know what to ask...

Code:

---

Uncaught Error: Cannot use string offset as an array in /home/xxx/public_html/includes/modules/tpl_pb/category_row.php:39

---

After all it does occur in my local machine, but it's related to breadcrumb. And I've update php to 7, zencart to 155f, Ceon URI to php7, and now I'm lost.
Big mistake.
But probably it's related to CEON.... or not.

Quote:

---

Originally Posted by mesnitu

Code:

---

Uncaught Error: Cannot use string offset as an array in /home/xxx/public_html/includes/modules/tpl_pb/category_row.php:39

---

After all it does occur in my local machine, but it's related to breadcrumb. And I've update php to 7, zencart to 155f, Ceon URI to php7, and now I'm lost.
Big mistake.
But probably it's related to CEON.... or not.

---

The Ceon URI Mapping that has been updated to support php 7 addresses the breadcrumb issue and this error has not otherwise been seen. The fact that this file is in a template override directory implies it has been modified in some way to support the template (not a modification made by Ceon URI Mapping), so it would make more sense to provide the code at, around, and before line 39 to try to identify what modification has been made to cause an attempt to use a string offset as an array.

Thanks!!!
Less one problem !
The issue was on the modify file. It had this
$list_box_contents ='';

instead of this
$list_box_contents = array();

... don't know why, probably some update that I miss.
Now it ok !

Quote:

---

Originally Posted by mesnitu

Thanks!!!
Less one problem !
The issue was on the modify file. It had this
$list_box_contents ='';

instead of this
$list_box_contents = array();

... don't know why, probably some update that I miss.
Now it ok !

---

Good. Yes, php is becoming more stringent about properly identifying how a variable is intended to be used and basically validating that the data is the type expected to use as well as other improvements in the language.

Code:

---

[13-Jan-2018 18:24:07 Europe/Lisbon] PHP Warning:  A non-numeric value encountered in /home/xxxxxx/public_html/includes/modules/pages/advanced_search_result/header_php.php on line 370

---

The code:

PHP Code:

---

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
  $pfrom = $_GET['pfrom'] / $rate;
  $pto = $_GET['pto'] / $rate;
} 


---

I did check on git to see if there were updates on this , but I see no changes.
Should I use a float($rate) ?

Thanks

Quote:

---

Originally Posted by mesnitu

Code:

---

[13-Jan-2018 18:24:07 Europe/Lisbon] PHP Warning:  A non-numeric value encountered in /home/xxxxxx/public_html/includes/modules/pages/advanced_search_result/header_php.php on line 370

---

The code:

PHP Code:

---

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
  $pfrom = $_GET['pfrom'] / $rate;
  $pto = $_GET['pto'] / $rate;
} 


---

I did check on git to see if there were updates on this , but I see no changes.
Should I use a float($rate) ?

Thanks

---

Nope, the issue there is that the pfrom/pto values, if not set in the form, come back as '' (a non-numeric value). Try the following instead:

PHP Code:

---

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
  $pfrom = ((float)$_GET['pfrom']) / $rate;
  $pto = ((float)$_GET['pto']) / $rate;
} 


---

Thanks, I'll try that

Quote:

---

Originally Posted by torvista

Line 50 is pretty meaty so I'll leave this for those who seem to enjoy these challenges.......

PHP Code:

---

$format_string = $this->currencies[$currency_type]['symbol_left'] . number_format(zen_round($number * $rate, $this->currencies[$currency_type]['decimal_places']), $this->currencies[$currency_type]['decimal_places'], $this->currencies[$currency_type]['decimal_point'], $this->currencies[$currency_type]['thousands_point']) . $this->currencies[$currency_type]['symbol_right']; 


---

---

I added

if (!is_numeric($number)) $number = 0;

at line 46 in includes/classes/currencies.php

Quote:

---

I added

if (!is_numeric($number)) $number = 0;

at line 46.

---

....in classes/currencies.php, to clarify.

Seen this a couple of times:

[29-May-2018 07:16:10 America/Los_Angeles] PHP Warning: Creating default object from empty value in admin/product.php on line 224

Fix is pretty straightforward - above line 224 in admin/product.php add

if (!is_object($pInfo)) $pInfo = new StdClass();

I am having the same error
PHP Warning: A non-numeric value encountered in ..../public_html/includes/classes/categories_ul_generator.php on line 73

Line 73 is
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '_');
Coming from the block code
if (($this->data[$category_id]) && (($this->max_level == '0') || ($this->max_level > $level+1))) {
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '_');
}
$result .= $this->child_end_string;

What is the fix for this error?
zen cart 1.5.5f

Quote:

---

Originally Posted by TamyA

I am having the same error
PHP Warning: A non-numeric value encountered in ..../public_html/includes/classes/categories_ul_generator.php on line 73

Line 73 is
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '_');
Coming from the block code
if (($this->data[$category_id]) && (($this->max_level == '0') || ($this->max_level > $level+1))) {
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '_');
}
$result .= $this->child_end_string;

What is the fix for this error?
zen cart 1.5.5f

---

Change line 58 of the file from:

Code:

---

$level = $level;

---

To:

Code:

---

$level = (int)$level;

---

Quote:

---

Originally Posted by mc12345678

Change line 58 of the file from:

Code:

---

$level = $level;

---

To:

Code:

---

$level = (int)$level;

---

---

Sorry, more than likely will need to add the above at or around line 58 so that $level will be forced to be an integer. In newer php versions it is/will be possible to cast/expect the value to be an integer, but to maintain the existing backwards compatibility the above was the way chosen.

Quote:

---

Originally Posted by mc12345678

Sorry, more than likely will need to add the above at or around line 58 so that $level will be forced to be an integer. In newer php versions it is/will be possible to cast/expect the value to be an integer, but to maintain the existing backwards compatibility the above was the way chosen.

---

Thanks a million, it seems to work, so far no error files in the /logs directory, thanks again.

Hi, buddies,

after upgrade of my shop to version 1.5.5f and upgrade of PHP to 7.1, I recieved PHP Warning with "a non numeric value encountered" for categories_ul_generator.php and thanks to your updates was able to resolve it fast.

However now I´m stuck,

I recieved the same PHP warning here:

[01-Nov-2018 00:33:02 UTC] Request URI: /index.php?main_page=shopping_cart, IP address: xxx
#1 zones->quote() called at [/home/xxx/public_html/includes/classes/shipping.php:171]
#2 shipping->quote() called at [/home/xxx/public_html/includes/modules/shipping_estimator.php:140]
#3 require(/home/xxx/public_html/includes/modules/shipping_estimator.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php:194]
#4 require(/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:171]
#5 require(/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/xxx/public_html/index.php:97]

[01-Nov-2018 00:33:02 UTC] PHP Warning: A non-numeric value encountered in /home/xxx/public_html/includes/modules/shipping/zones.php on line 257


line 257 in zones.php looks like this:

$shipping_cost = ($shipping) + constant('MODULE_SHIPPING_ZONES_HANDLING_' . $dest_zone);

any help would be very much appreciated, guys

Quote:

---

Originally Posted by Doomm

Hi, buddies,

after upgrade of my shop to version 1.5.5f and upgrade of PHP to 7.1, I recieved PHP Warning with "a non numeric value encountered" for categories_ul_generator.php and thanks to your updates was able to resolve it fast.

However now I´m stuck,

I recieved the same PHP warning here:

[01-Nov-2018 00:33:02 UTC] Request URI: /index.php?main_page=shopping_cart, IP address: xxx
#1 zones->quote() called at [/home/xxx/public_html/includes/classes/shipping.php:171]
#2 shipping->quote() called at [/home/xxx/public_html/includes/modules/shipping_estimator.php:140]
#3 require(/home/xxx/public_html/includes/modules/shipping_estimator.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php:194]
#4 require(/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:171]
#5 require(/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/xxx/public_html/index.php:97]

[01-Nov-2018 00:33:02 UTC] PHP Warning: A non-numeric value encountered in /home/xxx/public_html/includes/modules/shipping/zones.php on line 257


line 257 in zones.php looks like this:

$shipping_cost = ($shipping) + constant('MODULE_SHIPPING_ZONES_HANDLING_' . $dest_zone);

any help would be very much appreciated, guys

---

Looks like in your zones shipping module that for each applicable zone that a value needs to be entered instead of an empty string. So, if there is no handling fee, then a value of 0 should be entered instead of leaving it blank.

So if I understand it correctly, this should be done from the admin and there is no need to change of the code.

Thank you very much for your time and help.

Quote:

---

Originally Posted by Doomm

So if I understand it correctly, this should be done from the admin and there is no need to change of the code.

Thank you very much for your time and help.

---

No *need*, but an improvement in the base code could be made to default to a 0 instead of empty, but typing in a value of 0 should resolve that warning.

Quote:

---

Originally Posted by mc12345678

No *need*, but an improvement in the base code could be made to default to a 0 instead of empty, but typing in a value of 0 should resolve that warning.

---

I´m so sorry, I´m not following you (not really a coder, here) and I´m very grateful for your patience.

Could you please direct me where in this php file (zones.php), should I be looking for this empty string?

Editing the zc155f version of /includes/modules/shipping/zones.php, find:

Code:

---

// class constructor
    function __construct() {
      $this->code = 'zones';
      $this->title = MODULE_SHIPPING_ZONES_TEXT_TITLE;
      $this->description = MODULE_SHIPPING_ZONES_TEXT_DESCRIPTION;
      $this->sort_order = MODULE_SHIPPING_ZONES_SORT_ORDER;
      $this->icon = '';
      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_basis = MODULE_SHIPPING_ZONES_TAX_BASIS;

---

and add the highlighted fragments:

Code:

---

// class constructor
    function __construct() {
      $this->code = 'zones';
      $this->title = MODULE_SHIPPING_ZONES_TEXT_TITLE;
      $this->description = MODULE_SHIPPING_ZONES_TEXT_DESCRIPTION;
      $this->sort_order = (int)MODULE_SHIPPING_ZONES_SORT_ORDER;
      $this->icon = '';
      $this->tax_class = (int)MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_basis = MODULE_SHIPPING_ZONES_TAX_BASIS;

---

Note that I've also applied that integer "cast" to the tax-class-id, just in case!

Quote:

---

Originally Posted by Doomm

I´m so sorry, I´m not following you (not really a coder, here) and I´m very grateful for your patience.

Could you please direct me where in this php file (zones.php), should I be looking for this empty string?

---

To address the specific warning message that was presented, the only thing necessary was to enter in a number into the handling fee area for each of the zones and not leave it blank. This entry is performed from admin->modules->shipping->zones.

It appears the code already contains a default value of '0' at least when first installing the additional zone(s).

Quote:

---

Originally Posted by mc12345678

To address the specific warning message that was presented, the only thing necessary was to enter in a number into the handling fee area for each of the zones and not leave it blank. This entry is performed from admin->modules->shipping->zones.

It appears the code already contains a default value of '0' at least when first installing the additional zone(s).

---

Great, that´s what I did in the first place, but was not sure, if it´s enough.

Thank you very much for your help and understanding,

cheers