Home :: Checkout - Step 1 :: Payment Method - Step 2 Display Problem

When checking out the main_page=checkout_payment does not not display the order totals on the screen properly. See attachment?

https://www.zen-cart.com/showthread....58#post1366958

post # 821 if this doesn't show up as I intended.

You can just use my PR to fix this:
https://github.com/zencart/zencart/pull/2972

The code that you are referring to does not look like my 156c code tpl_checkout_shipping_default.php

It looks like 156c code is different than your fix.

'<div id="checkoutBillto" class="floatingBox back">'
'<?php if (MAX_ADDRESS_BOOK_ENTRIES >= 2) { ?>
'<div class="buttonRow forward"><?php echo '<a href="' . zen_href_link(FILENAME_CHECKOUT_PAYMENT_ADDRESS, '', 'SSL') . '">' . 'zen_image_button(BUTTON_IMAGE_CHANGE_ADDRESS, BUTTON_CHANGE_ADDRESS_ALT) . '</a>'; ?></div>
'<?php } ?>
'<address><?php echo zen_address_label($_SESSION['customer_id'], $_SESSION['billto'], true, ' ', '<br />'); ?></address>
'</div>

The PR shows a one line change at line 33 of includes/templates/template_default/templates/tpl_checkout_shipping_default.php.
Stick in a <br /> right there.

Please disregard the previous post. It was a mistake.

Bottom line the tpl.checkout_shipping_default.php file does not exist in v156c?

What am i missing?

I assume you are using the responsive_classic template.

includes/templates/template_default/templates/tpl_checkout_shipping_default.php DOES exist
includes/templates/responsive_classic /templates/tpl_checkout_shipping_default.php DOES NOT exist

Copy first file to responsive_classic folder, creating second file.
Edit second file as explained above.

Quote:

---

Originally Posted by jodean

The code that you are referring to does not look like my 156c code tpl_checkout_shipping_default.php

It looks like 156c code is different than your fix.

'<div id="checkoutBillto" class="floatingBox back">'
'<?php if (MAX_ADDRESS_BOOK_ENTRIES >= 2) { ?>
'<div class="buttonRow forward"><?php echo '<a href="' . zen_href_link(FILENAME_CHECKOUT_PAYMENT_ADDRESS, '', 'SSL') . '">' . 'zen_image_button(BUTTON_IMAGE_CHANGE_ADDRESS, BUTTON_CHANGE_ADDRESS_ALT) . '</a>'; ?></div>
'<?php } ?>
'<address><?php echo zen_address_label($_SESSION['customer_id'], $_SESSION['billto'], true, ' ', '<br />'); ?></address>
'</div>

---

• little gratitude will go a long way
• hard to imagine that @swguy PR is wrong, and your code is correct
• very easy to miss things; i would double check before posting
• from what i can tell, your file has been modified; OR more likely you are looking at tpl_checkout_payment_default.php. which is not where the fix is located. but 1 of these 2 things is correct.

The file is not in the download zen-cart-v1.5.6c-07162019. Is this incorrect download?

Hang on ... I gave the wrong link ...
(There are multiple bugs in 1.5.6 checkout with responsive classic.)

Payment page PR:
https://github.com/zencart/zencart/pull/2856

This one change is the only difference between 1.5.6 and 1.5.7 for the file
includes/templates/template_default/templates/tpl_checkout_payment_default.php

I downloaded the 156c release again. It appears that the directory in question was cut off in the extract. That is why it is missing files. I will correct my release version with the newly downloaded release and that will probably fix the missing file.

Yes after adding the missing file I made the change that you requested. It fixed the page when running in Firefox but I still have the problem in Google Chrome.

<div class="floatingBox important forward"><?php echo TEXT_CHOOSE_SHIPPING_DESTINATION; ?></div>
<br class="clearBoth" />
<br />

Quote:

---

Originally Posted by swguy

Payment page PR:
https://github.com/zencart/zencart/pull/2856

This one change is the only difference between 1.5.6 and 1.5.7 for the file
includes/templates/template_default/templates/tpl_checkout_payment_default.php

---

The code in includes/templates/template_default/templates/tpl_checkout_payment_default.php is below and you can see that is included your correction on line #33, but that does not solve the problem.

Is there anything that I can do to further diagnose the problem?
Is there anyway i can get your copy of your file to see if it makes a difference?

/**
* Page Template
*
* Loaded automatically by index.php?main_page=checkout_shipping.<br />
* Displays allowed shipping modules for selection by customer.
*
* @package templateSystem
* @copyright Copyright 2003-2013 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version GIT: $Id: Author: Ian Wilson Mon Oct 28 17:54:33 2013 +0000 Modified in v1.5.2 $
*/
?>
<div class="centerColumn" id="checkoutShipping">


<?php echo zen_draw_form('checkout_address', zen_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')) . zen_draw_hidden_field('action', 'process'); ?>


<h1 id="checkoutShippingHeading"><?php echo HEADING_TITLE; ?></h1>


<?php if ($messageStack->size('checkout_shipping') > 0) echo $messageStack->output('checkout_shipping'); ?>

<h2 id="checkoutShippingHeadingAddress"><?php echo TITLE_SHIPPING_ADDRESS; ?></h2>

<div id="checkoutShipto" class="floatingBox back">
<?php if ($displayAddressEdit) { ?>
<div class="buttonRow forward"><?php echo '<a href="' . $editShippingButtonLink . '">' . zen_image_button(BUTTON_IMAGE_CHANGE_ADDRESS, BUTTON_CHANGE_ADDRESS_ALT) . '</a>'; ?></div>
<?php } ?>
<address class=""><?php echo zen_address_label($_SESSION['customer_id'], $_SESSION['sendto'], true, ' ', '<br />'); ?></address>
</div>
<div class="floatingBox important forward"><?php echo TEXT_CHOOSE_SHIPPING_DESTINATION; ?></div>
<br class="clearBoth" />
<br />

The code in includes/templates/template_default/templates/tpl_checkout_shipping_default.php is below and you can see that is included your correction on line #33, but that does not solve the problem.

Is there anything that I can do to further diagnose the problem?
Is there anyway i can get your copy of your file to see if it makes a difference?

/**
* Page Template
*
* Loaded automatically by index.php?main_page=checkout_shipping.<br />
* Displays allowed shipping modules for selection by customer.
*
* @package templateSystem
* @copyright Copyright 2003-2013 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version GIT: $Id: Author: Ian Wilson Mon Oct 28 17:54:33 2013 +0000 Modified in v1.5.2 $
*/
?>
<div class="centerColumn" id="checkoutShipping">


<?php echo zen_draw_form('checkout_address', zen_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')) . zen_draw_hidden_field('action', 'process'); ?>


<h1 id="checkoutShippingHeading"><?php echo HEADING_TITLE; ?></h1>


<?php if ($messageStack->size('checkout_shipping') > 0) echo $messageStack->output('checkout_shipping'); ?>

<h2 id="checkoutShippingHeadingAddress"><?php echo TITLE_SHIPPING_ADDRESS; ?></h2>

<div id="checkoutShipto" class="floatingBox back">
<?php if ($displayAddressEdit) { ?>
<div class="buttonRow forward"><?php echo '<a href="' . $editShippingButtonLink . '">' . zen_image_button(BUTTON_IMAGE_CHANGE_ADDRESS, BUTTON_CHANGE_ADDRESS_ALT) . '</a>'; ?></div>
<?php } ?>
<address class=""><?php echo zen_address_label($_SESSION['customer_id'], $_SESSION['sendto'], true, ' ', '<br />'); ?></address>
</div>
<div class="floatingBox important forward"><?php echo TEXT_CHOOSE_SHIPPING_DESTINATION; ?></div>
<br class="clearBoth" />
<br />

You need to correct both the checkout_shipping and checkout_payment pages. See both PRs.

Quote:

---

Originally Posted by swguy

Payment page PR:
https://github.com/zencart/zencart/pull/2856

This one change is the only difference between 1.5.6 and 1.5.7 for the file
includes/templates/template_default/templates/tpl_checkout_payment_default.php

---

I am not questioning that you feel that the problem is fixed. I see that you got the desirable results from your change on github, however it does not work on my computer using the Google Chrome browser. The page does work correctly using FireFox so it seems that t he cause of the problem is certainly related to the Google Chrome browser.

I have tried using the Classic Contemporary Green, and it worked. However when i use either the Responsive Classic Template or my cloned Responsive Classic Template the problem exists. The same tpl_checkout_shipping_default.php is in all three templates with your change to line #33.

I have rebuilt the \includes\templates\template_default\templates\ and \includes\templates\responsive_classic\templates\ folders from a new download of ZenCart 156c and i get the same results.

I have tried the page on five different computers. The problem is reproducible on all five different computers running Google Chrome.

I understand how difficult it is to fix a problem when you cannot reproduce it and even times when it can be reproduced by other people. It seems like the problem is code related but i just do not know what to try next. I would be happy to try anything you suggest or even to let you access the page on my hosting service.

Any guidance that you can provide would be greatly appreciated.

in tpl_checkout_payment_default.php find this line:

PHP Code:

---

// from
 <div class="floatingBox important forward"><?php echo TEXT_SELECTED_BILLING_DESTINATION; ?></div> 
// to
 <div class="floatingBox important"><?php echo TEXT_SELECTED_BILLING_DESTINATION; ?></div>

---

let me know if that works.

Quote:

---

Originally Posted by jodean

I am not questioning that you feel that the problem is fixed.

---

To clarify: I don't "feel" that the second PR I posted fixes the issue with the checkout payment page in Responsive Classic in Chrome.
It fixes the checkout payment page in Responsive Classic in Chrome. That's why it was merged into the core.

YOU have a different problem. Maybe you patched the wrong file. Maybe your upload failed. Maybe you've changed the CSS. I don't know. If you post a link to your site I (or one of the other contributors) can look at it and I might be able to tell you what's wrong.

I just tried an out of the box v156c installation using the response classic template. Absolutely no code changes it is a vanilla installation. I tried the <br /> change to the tpl_checkout_shipping_default.php in the template_default folder and copied it to the responsive_classic folder and the <br /> does not fix the page.

Quote:

---

Originally Posted by carlwhat

in tpl_checkout_payment_default.php find this line:

PHP Code:

---

// from
 <div class="floatingBox important forward"><?php echo TEXT_SELECTED_BILLING_DESTINATION; ?></div> 
// to
 <div class="floatingBox important"><?php echo TEXT_SELECTED_BILLING_DESTINATION; ?></div>

---

let me know if that works.

---

I removed Forward from payment and shipping, but the problem remains.

The change did not work, but i was just exploring around and started Google Inspector at the bottom of the page i see and error message.

index.php?main_page=checkout_payment:1 Unchecked runtime.lastError: The message port closed before a response was received.

Could that have anything to do with the problem?

Quote:

---

Originally Posted by jodean

The change did not work, but i was just exploring around and started Google Inspector at the bottom of the page i see and error message.

index.php?main_page=checkout_payment:1 Unchecked runtime.lastError: The message port closed before a response was received.

Could that have anything to do with the problem?

---

I do not think so....

here is my take on this situation:

• this is a problem that has been well documented
• this is a problem for which @swguy provided a fix and it is incorporated into the next release of ZC
• i myself have experienced this problem. chrome is my browser of choice.
• i am currently operating on a ZC v156c vanilla install, using the responsive_classic template
• i have implemented the fix provided by @swguy and it resolved my problem
• prior to that knowledge i removed the forward class as indicated above, and that also resolved the display issue on chrome
• if these fixes do not work for you, i am not sure that you are operating on the correct files.
• i would review all of the help provided in this thread and ensure that you have applied the fix to the correct template files; the template override system can be daunting when first experiencing it. but i would completely review everything here and make sure you are in the right place. and easy way to do that would be to add some extra text somewhere and ensure that comes up on the page.

good luck.

I have tried a new vanilla out of the box 156c installation. The page still does not work after modifying the tpl_checkout_shipping_default.php. I am curious how does the screen work when tpl_checkout_shipping_default.php is not in the responsive_classic/templates folder? It seems like any changes to tpl_checkout_shipping_default.php file has no impact on the Payment Method - Step 2 page?

This is correct - changing the SHIPPING PAGE template doesn't affect the PAYMENT PAGE.
If you want to change the PAYMENT PAGE, change the PAYMENT PAGE template.
The PAYMENT PAGE template is tpl_checkout_payment_default.php.