zc158a PHP 8.2
Has anyone got ideas on making the search box in Discount Coupons work? It has never working with any version of ZC I have used since 1.5.5?
Printable View
zc158a PHP 8.2
Has anyone got ideas on making the search box in Discount Coupons work? It has never working with any version of ZC I have used since 1.5.5?
Be awesome if the column headers where sortable ascending & descending as well =)
~Melanie
@OldNGrey can you be more specific?
I tested index.php?main_page=discount_coupon&action=lookup with a specific coupon code (the coupon code value, not the coupon name value) and it worked with 1.5.7/Bootstrap.
Then I tested admin/index.php?cmd=coupon_admin, used the search box with a specific coupon code and it also worked.
Note the search is not a substring match; you must provide the exact coupon code.
Yes testing with a specific coupon code works.
I assumed that it was like other searches in admin and worked on substrings.
I would rarely remember a Coupon Code but I do remember partial Coupon names based on my naming conventions.
so you like the various substring search methods that goes on in the admin?Quote:
Originally Posted by OldNGrey
Yes. Categories key word searches works well in 1.5.8 unlike 1.5.7 and earlier.
This would be a real bonus if applied to Coupons
glad to hear. it also works on products, customers, specials, and featured items...Quote:
Originally Posted by OldNGrey
when i have some time, i will take a look at coupons...
changing the search function was something i worked on for v158; glad someone is finding it useful (besides me!)
best.
> This would be a real bonus if applied to Coupons
Agreed. Thanks @carlwhat.
i took a quick look at it last night. it is not a trivial change. unfortunately.Quote:
Originally Posted by swguy
might be a bit before i can get to it.
best.
It's a nice to have. I looked at the code and can see that it's a major change.
ZC158a is such a quantum leap ahead of my early zc installs 15 yrs ago. I dips my lid to you all, it obviously was a mighty effort to get to the current build.
i did do a PR on this change. it has not yet been merged into the ZC repo at this time.Quote:
Originally Posted by OldNGrey
perhaps you might want to try it? it is just replacing 1 file.
you can see the PR here.
if you do try and replacing the file, please let us know how it goes.
best.
Wow! It works on just a partial word phrase eg "stone" finds AdamStone, David Stone; DavidStone01; PeterJohnstone01.
A brilliant change. Thank you very much.
Tested on zc158a PHP 8.2.4; 8.1;7.4.19
:thumbsup:Quote:
Originally Posted by OldNGrey