Reviews Link

Printable View

18 Nov 2023, 02:46 AM
Bruce1952

Reviews Link

Hi All,

Server Information:
Server Host: p3plzcpnl503484.prod.phx3.secureserver.net (xxxxxxxx)
Database: xxxx_live158Store
Home: /home/xxxxxxxx/public_html/Server
OS: Linux 4.18.0-477.27.2.lve.el8.x86_64
Server Date: 16/11/2023 13:01:38
Server Up Time: Disabled/UnavailableHTTP
Server: ApachePHP
Version: 8.0.30 (Zend: 4.0.30)PHP
File Uploads: OnUpload
Max Size: 1024MPHP
Memory Limit: -1POST
Max Size: 1024M
Database Engine: MySQL 10.6.14-MariaDB-cll-lveDatabase
Host: localhost (127.0.0.1)
Database Date: 16/11/2023 13:01:38
Database Data Size: 245,288 kBDatabase
Index Size: 36,309 kBMySQL Slow Query Log
Status: OffMySQL Slow Query
Log File: p3plzcpnl503484-slow.log
MySQL Mode: NO_ENGINE_SUBSTITUTIONView the database configuration variables

I am trying to find the link location for the reviews because on my live site that is running 1.5.5E the link in the side box is coming up as https://www.outdoorking.com/reviews?...dbmvded3vd6pn7 HTTP Error 500

I am wanting to put a link-up on the new site to the reviews, which has 1.5.8a version

Any help to the correct link for the 1.5.8a version would be a great help.
18 Nov 2023, 06:29 AM
Bruce1952

Re: Reviews Link

This is the error message that I am getting

[18-Nov-2023 12:49:24 Australia/Sydney] Request URI: /reviews?zenid=cmn3fsvroajkdbmvded3vd6pn7, IP address: 45.125.247.xxx
--> PHP Fatal error: Cannot redeclare securityPatchSanitizePostVariableId() (previously declared in /home/xxxx/public_html/includes/extra_configures/security_patch_v138_20080919.php:33) in /home/xxxx/public_html/includes/extra_configures/security_patch_v138_20080919.php on line 33.

That is for the 1.5.5e version of zencart
18 Nov 2023, 02:26 PM
lat9

Re: Reviews Link

I'll suggest searching for securityPatchSanitizePostVariableId using the zc155e admin's Tools :: Developer's Tool Kit. For zc155e, the only place that that function's definition is present is in the /includes/extra_configures/security_patch_v138_20080919.php file.

Whatever module that also shows up in should have that function removed ... possibly a copy of the above file?

P.S. Please don't intermix multiple unrelated questions in a single thread; it'll make it much more difficult for someone with the same problem to find matching reports.
18 Nov 2023, 03:03 PM
Bruce1952

Re: Reviews Link

Quote:

Originally Posted by lat9

I'll suggest searching for securityPatchSanitizePostVariableId using the zc155e admin's Tools :: Developer's Tool Kit. For zc155e, the only place that that function's definition is present is in the /includes/extra_configures/security_patch_v138_20080919.php file.

Whatever module that also shows up in should have that function removed ... possibly a copy of the above file?

P.S. Please don't intermix multiple unrelated questions in a single thread; it'll make it much more difficult for someone with the same problem to find matching reports.

I removed the other files and now I am getting a blank page here https://www.outdoorking.com/reviews

Am I missing something?
18 Nov 2023, 03:36 PM
lat9

Re: Reviews Link

You've got a myDEBUG*.log file that is waiting patiently to tell you what's going on with that whitescreen.
19 Nov 2023, 01:36 AM
Bruce1952

Re: Reviews Link

Quote:

Originally Posted by lat9

You've got a myDEBUG*.log file that is waiting patiently to tell you what's going on with that whitescreen.

This is the log
[19-Nov-2023 10:55:27 Australia/Sydney] Request URI: /reviews?zenid=cmn3fsvroajkdbmvded3vd6pn7, IP address: 66.249.83.196
--> PHP Fatal error: Cannot redeclare securityPatchSanitizePostVariableId() (previously declared in /home/xxxx/public_html/includes/extra_configures/security_patch_v138_20080919.php:33) in /home/xxxx/public_html/includes/extra_configures/security_patch_v138_20080919.php on line 33.

This is what is in the original file and I removed line 33 but still the same.
<?php
/**
* Security Patch v1.3.8 20080919
*
* @package initSystem
* @copyright Copyright 2003-2010 Zen Cart Development Team
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: security_patch_v138_20080919.php 15882 2010-04-11 16:37:54Z wilt $
*/
/**
* Security Patch
*
* Multiple Vulnerabilities
*
* SQL Injection - $_POST['products_id']
* SQL Injection - $_POST['id']
*
* Please Note : This file should be placed in includes/extra_configures and will automatically load.
*
*/
if (isset($_POST['id']) && is_array($_POST['id']) && count($_POST['id']) > 0)
{
$_POST['id'] = securityPatchSanitizePostVariableId($_POST['id']);
}
if (isset($_POST['products_id']) && is_array($_POST['products_id']) && count($_POST['products_id']) > 0)
{
$_POST['products_id'] = securityPatchSanitizePostVariableProductsId($_POST['products_id']);
}
if (isset($_POST['notify']) && is_array($_POST['notify']) && count($_POST['notify']) > 0)
{
$_POST['notify'] = securityPatchSanitizePostVariableProductsId($_POST['notify']);
}
function securityPatchSanitizePostVariableId ($arrayToSanitize)
{
foreach ($arrayToSanitize as $key => $variableToSanitize)
{
{
if (is_integer($key))
{
if (is_array($arrayToSanitize[$key]))
{
$arrayToSanitize[$key] = securityPatchSanitizePostVariableId($arrayToSanitize[$key]);
}
else
{
$arrayToSanitize[$key] = (int) $variableToSanitize;
}
}
}
if (preg_replace('/[0-9a-zA-z:_]/', '', $key) != '')
unset($arrayToSanitize[$key]);
}
return $arrayToSanitize;
}
function securityPatchSanitizePostVariableProductsId ($arrayToSanitize)
{
foreach ($arrayToSanitize as $key => $variableToSanitize)
{
{
$arrayToSanitize[$key] = preg_replace('/[^0-9a-fA-F:.]/', '', $variableToSanitize);
}
if (preg_replace('/[0-9a-zA-z_:.]/', '', $key) != '')
unset($arrayToSanitize[$key]);
}
return $arrayToSanitize;
}
21 Nov 2023, 09:01 AM
Bruce1952

Re: Reviews Link

?Does anyone have an answer to my last post
21 Nov 2023, 10:38 AM
balihr

Re: Reviews Link

Use the Developers Toolkit and search all files for "function securityPatchSanitizePostVariableId" (without quotation marks). It's probably being declared elsewhere. Depending on where, you can leave the "main" one as is, and the others could be wrapped in

Code:

if(!function_exists('securityPatchSanitizePostVariableId')) { // function here }
22 Nov 2023, 01:08 AM
Bruce1952

Re: Reviews Link

Quote:

Originally Posted by balihr

Use the Developers Toolkit and search all files for "function securityPatchSanitizePostVariableId" (without quotation marks). It's probably being declared elsewhere. Depending on where, you can leave the "main" one as is, and the others could be wrapped in

Code:

if(!function_exists('securityPatchSanitizePostVariableId')) { // function here }

That gave me a blank main page and the only file that came up was this one doing the search: /home/xxxx/public_html/includes/extra_configures/security_patch_v138_20080919.php

I changed line 33 and then got the blank main page. I then had to change back to get my main page to show.

This is proving to be a real pain in the but trying to fix the issue with the link to the reviews page.

Would it be better to just remove the security patch totally?
22 Nov 2023, 04:02 AM
lat9

Re: Reviews Link

Since that file is not part of the zc158 distribution, it can be safely removed.
22 Nov 2023, 05:42 AM
Bruce1952

Re: Reviews Link

Quote:

Originally Posted by lat9

Since that file is not part of the zc158 distribution, it can be safely removed.

Ok removed it and still getting a blank page also when clicking on one of the items that are in the side box it does not go to that item a lot of items show up.

It would appear that the side box has the issue and I am unable to locate it EZ Pages.

The only thing that I can locate is sideboxes/reviews in m_oz-en_temp which is in includes/modules/

This is what is in the reviews.php folder in includes/modules/sideboxes:

// if review must be approved or disabled do not show review
$review_status = " and r.status = 1 ";

$random_review_sidebox_select = "select r.reviews_id, r.reviews_rating, p.products_id, p.products_image, pd.products_name,
substring(reviews_text, 1, 70) as reviews_text
from " . TABLE_REVIEWS . " r, " . TABLE_REVIEWS_DESCRIPTION . " rd, "
. TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd
where p.products_status = '1'
and p.products_id = r.products_id
and r.reviews_id = rd.reviews_id
and rd.languages_id = '" . (int)$_SESSION['languages_id'] . "'
and p.products_id = pd.products_id
and pd.language_id = '" . (int)$_SESSION['languages_id'] . "'" .
$review_status;

if (isset($_GET['products_id'])) {
$random_review_sidebox_select .= " and p.products_id = '" . (int)$_GET['products_id'] . "'";
}

$random_review_sidebox_product = $db->ExecuteRandomMulti($random_review_sidebox_select, MAX_RANDOM_SELECT_REVIEWS);
if ($random_review_sidebox_product->RecordCount() > 0) {
require($template->get_template_dir('tpl_reviews_random.php',DIR_WS_TEMPLATE, $current_page_base,'sideboxes'). '/tpl_reviews_random.php');
} elseif (isset($_GET['products_id']) and zen_products_id_valid($_GET['products_id'])) {
// display 'write a review' box
require($template->get_template_dir('tpl_reviews_write.php',DIR_WS_TEMPLATE, $current_page_base,'sideboxes'). '/tpl_reviews_write.php');
} else {
// display 'no reviews' box
require($template->get_template_dir('tpl_reviews_none.php',DIR_WS_TEMPLATE, $current_page_base,'sideboxes'). '/tpl_reviews_none.php');
}
$title = BOX_HEADING_REVIEWS;
$title_link = FILENAME_REVIEWS;
require($template->get_template_dir($column_box_default, DIR_WS_TEMPLATE, $current_page_base,'common') . '/' . $column_box_default);
?>
22 Nov 2023, 10:15 AM
balihr

Re: Reviews Link

And what does the error log say?
22 Nov 2023, 11:30 AM
Bruce1952

Re: Reviews Link

Quote:

Originally Posted by balihr

And what does the error log say?

[22-Nov-2023 21:06:30 Australia/Sydney] Request URI: /reviews, IP address: 207.46.13.128
--> PHP Fatal error: Cannot redeclare zen_debug_error_handler() (previously declared in /home/XXXX/public_html/includes/extra_configures/enable_error_logging.php:18) in /home/XXXX/public_html/includes/extra_configures/enable_error_logging.php on line 18.
22 Nov 2023, 03:33 PM
balihr

Re: Reviews Link

I'd say something really strange is happening. Can you check your includes/functions/extra_functions/ directory and see if you have any files that shouldn't be there (or post the contents here)? I'm thinking maybe you've mistakenly uploaded/copied some files from includes/functions/ to includes/functions/extra_functions/ and now they are loading twice.

EDIT: also check includes/extra_configures/ to see if there's any duplicated files or "backup" files. Possibly post the contents of that directory here as well.