VAT-mod for European companies

We have made two mods, one for 1.2.7d and one for 1.3.0.1. Read Install in English for more info about the mod and how to install it.

What does this mod do?
This mod checks customer's VAT (Value Added Tax) number regarding his country and displays VAT on invoice and packingslip as well as removes tax when shipping to companies in countries within the EU.

- Add a text field during account registration and modification...
- Add shop VAT number on invoice and packing slip
- Add customer VAT number on invoice
- Removes tax in checkout (if configured correctly) if customer has entered VAT number and is in a country within EU but is in a country other than the Store.
- Check VAT number for registering companies (if implemented in admin) according to their country.
- Control of the VAT number is done in admin (for both customers and shop number)
- Enable/disable server verification in configuration (in admin).

This is a remake of the old VAT INTRACOM by Jean Gourdon. Read the old thread at http://www.zen-cart.com/forum/showthread.php?t=9620

We have put our new functions in order.php (catalog/includes/classes/order.php). Mainly because we didn't know where they "should" go :-)

If you have any comments, questions or suggestions - Feel free to let us know!

//Beez & vike

The files were to big to post here, but you can download them from:
http://www.sweetfabrik.se/ZC/VAT-mod_127.zip (version 1.2.7d)
http://www.sweetfabrik.se/ZC/VAT-mod_130.zip (version 1.3.0.1)

I'm sorry but I can't post the install files here either, so get the package :-)

hello world
finally also im able to post.. had some trouble with activation-mail being caught in the filter treated as junk :/ heh

but so, i am the other developer of this re-mod.. and to underline it once more but from me; feel free to comment, suggest or ask :)

i have yet only advertised this mod in the wiki under 3rd_party_contributions but if you feel it could need an own page feel free to let us know or start build one yourself :)
but for the time i surely think this thread could be sufficient
peace. vike

I am getting the following error when I set the option to check for valid VAT number.

Fatal error: Call to undefined function: zen_db_query() in /data01/fetters/public_html/shop/admin/customers.php on line 130

I get this error when I log into the admin, view the customers and try and update the details. The customer was entered before the check for VAT was turned on.

Is this just my error or can anyone else recreate this problem?

There was a problem in the admin/costumers.php file. That have now been fixed! It should work now and your problem should have been fixed.

Download the package again and look in the Install_130.txt file for the new code. The changes is in the code chunk that begins on line 119 in the modded file (after 112). You can of course take the file itself too...

The same problem were in the 1.2.7 package and have also been fixed.

Hello Beez,

thank you for the fine, essential mod.
I'm using it in 1.3.0.1

When trying to verify Greek Vat ID, it does not recognize the valid tax ID entered as ELXXXXXXXXX (EL+9 nummerics)
When adding a space between EL & numbers (what a customer could do...), the whole css style gets messed up, displaying the login site with overlarged fonts!

Any idea how to fixe that?

Dimi

It will work when changing the array 'GR'=>'EL', //Greece to 'EL'=>'EL', //Greece and the ISO Code from GR to EL as well....
But this would make neccessary, to edit all shipping relevant data as well

Could this be fixed?

Hi pivey and thank you liking the mod!

I'l look in to it, it might have to with that the mod checks VAT in frensh... forgot to change :-) But I'll look in to it!

No, it has nothing to do with that...

I'm not sure what is the problem... A Greek VAT number doesn't contain any spaces, right? At least according to http://ec.europa.eu/taxation_customs...en/faqvies.htm

If do the change to 'EL'=>'EL', what is that you must edit? Sorry if I seem slow, but I don't get what is wrong :-) Do you have a valid Greek VAT number that I can test with? What version of Zen Cart are you using? 1.2.7 if you have to make the changes in two places, right?

Hi Beez,

I'm using Version 1.3.0.1

No, the Tax number in Greece have no spaces...I just mentioned, that IF a customer would leave a space between EL & the Vat Number, it will demage the whole layout of the page. I did an explanation there for the customers not to leave spaces...hope they read it.

Regarding the change from GR->EL to EL->EL, if this is changed, there must be also the ISO code for Greece be changed (in Admin > Localisation > Countries)
as the array refers to the ISO code, right?

But then....several other changes have to be done, like changing all ISO GR to EL, in shipping Modules, Payment, and so on....
Hope this does not mess up anything. Well, I did test it, Payment & Shipping does work well so far with the ISO code changed from GR to EL

You might use this Greek VAT Nr. for testing : EL999943280

Dimi

Ok, I see what you mean! (Better late than never, hehe)

Try and change in the country to 'EL' for greece and see if it works... I will see if I can get some help for vike and hopefully can we fix it. But I don't really see why it's not working... It's kind of odd, but Greece is the only one that differs from the fist to the second...

As I said, I'll get back as soon as I can figure out why it's not working...

I see what you mean with the css, it doesn't seems to load... Will look in to that too... Strange is it though...

the whole scripting world is strange :sleep:
Thank you Beez....so far it works with GR->EL changed to EL->EL

Hi Beez,

I tested the Mod so far, works fine with EU states...
But it does show 00,00 EURO Tax even for Turkey or Uzbekistan Customers
I did enter Tax Classes & Tax Rates as you mention in your readme file...

But still not possible to have the Tax for non EU countries displayed.

Regards
Dimi

Hi again!

Thanx for trying out our mod so thoroughly. We have fixed the prob with spaces within the VAT number. And we have changed the mod so that you don't have to change the county code for Greece in the admin.

Download the package and do a file compare (or use the files in the package). The read me file is of course also updated so you can find the differences there to.

Quote:

---

Originally Posted by pivey

Hi Beez,

I tested the Mod so far, works fine with EU states...
But it does show 00,00 EURO Tax even for Turkey or Uzbekistan Customers
I did enter Tax Classes & Tax Rates as you mention in your readme file...

But still not possible to have the Tax for non EU countries displayed.

Regards
Dimi

---

I'm not sure what you want to do... Do want to add tax to a Turkish costumer, even though they are not within the EU? If so I'll guess you have to add Turkey in a new zone and specify a tax for that zone too. You can't use Turkey in this mod, because Turkey is not a EU country and the check of the VAT number can't be done.

Hello Beez,

thank you for the quick changes. The Greek verification & the CSS bug are fixed.

Now.....I am testing this mod to his limits :unsure:
Please have in mind, that it should still be possible to sale to countries which are not in the EU and to have TAX charged

There are some more bugs:

1. I configure ADMIN > MY STORE > Display Prices with Tax "TRUE"
Result: THE PRICES IN THE STORE ARE STILL TAX FREE

2. I set a new zone (non EU countries) and put in all countries which are not in the EU (like Turkey, Switzerland..) but there will be still no TAX displayed at the checkout. Even not when printing a invoice in Admin.
Generally, there is no Tax configuration possible for the store any more.

But I have to charge Tax for Non EU Customers..

Could you please check this?

Dimi

Ok, I see what you mean... We'll look in to it... Could take awhile though, I'm going away for a week or so... Hopefully vike can look at in the meantime, I'll talk to him.

Quote:

---

1. I configure ADMIN > MY STORE > Display Prices with Tax "TRUE"
Result: THE PRICES IN THE STORE ARE STILL TAX FREE

---

When I do the same the prices are shown with tax in the store but without tax in the checkuot... This shouldn't be happening... We will look in to it, the tax should be used in the checkout too... This is kind of a tricky mod so please bear with us :wink2:

Hi Beez,

yes, I know that it is always something to be done.
But so far, it is a fine MOD, gives a professional touch to wholesale companies, to have the VAT ID verified online.

Thank you so far

Cheers
Dimi

Hi, i will atempt to install this nice looking mod on my zen 3.0.1 :).

PS: in case i fail, are there any alternatives to this mod?

Yet another update!

Now it should work to assign taxes to countries outside EU, and prices are shown with the correct tax in the store... At least it does for me :-) I've added some instructions on how to configure the taxes at the end of the install_130.txt, at least that's how I configured it...

Quote:

---

Originally Posted by cdaugustin

Hi, i will atempt to install this nice looking mod on my zen 3.0.1 :).

PS: in case i fail, are there any alternatives to this mod?

---

Ok, good luck!

The only alternative I know of is to set up zones and taxes and create discount groups and handle the European companies that shouldn't have VAT added manually. I've got to work before I started with this mod, so it can be done, but not as neat as this mod :wink2:

Hi,

Back with news :). Ive succeded to install the mod (at least thats what i think). I am not sure where i can see the mod in action (but i was able to configure it from the admin). So now im testing payments with the protx module (i have also have installed a SEO module with some tweaks).

Thanks for the mod i hope everything works just right.

Augustin.

PS: if anyone is interested on how to make the SEO module (the Chemos) one work with everything send a message (i have modified it so that only the seo-pages actually get their links rewriten. This fixed my multiple image problem/login/checkout etc problem --> i was getting redirected to index).

cdaugustin: Glad you liked it! While you're at it down load the latest version 1.1, uploaded today. It adds some functionality...

Yello,


wheres the link ? :) if it has the file size is 127052 (of the zip) then its the one ive using now (ive downloaded it this morning).

Augustin

Hi,

One more thing: where do i see the VAT kick in? (ive set my user country to be in Finland (added all the tax rate and stuff)). But it seems it wont charge be the 10% extra.

thanks,

The latest version is 1.1, see the top of the txt-file... I've uploaded it around 12.20PM today... You can get it here: http://www.sweetfabrik.se/ZC/VAT-mod_130.zip Version 1.1 is 127118 bytes.

You should see the tax in the checkout, but it's crucial that the Tax Rates are configured right. You can look in the Install_130.txt (the 1.1 version) at the bottom to see how I configured mine. It's kind of tricky so try different settings and the priority of the Tax Rates seems to matter...

Beez, you are a Genius :yes:

Thank you

Hi,
I am using the latest version and Ive configured it exactly the way you told us in the text file (I will double and triple check that right now). But still the VAT is not appearing in the checkout nor on register new user altough it appears on the customer details in admin (i get a field to edit it).

:cry:

Hi,

I have rechecked the zone and tax rates they are in place. Actually if I enable show prices with tax included they show up with tax in catalog. Problem is even if they show up with the tax when i add them to cart the tax goes away from the price. Before this ive atached all products to the tax class into which are the EU countries ...

Any ideas ?

Thanks

Can you specify your settings in Admin->Locations / Taxes->Zones Definitions, Tax Classes and Tax Rates. Is it in checkout that the tax goes away? Wow does it looks like?

For me I got just one tax class with is assign the the products. I have 3 Zone Definitions (EU, Sweden and World) and 3 Tax Rates (EU, Sweden and World) with priority 1, 2 and 3 (EU 1, Sweden 2 and World 3). EU and Sweden has the same Tax Rate and World has another. The World in both Zone Definitions and Tax Rates can be removed, it will then fall back to "TAX_UNKNOWN" for the countries not in the Zone Definitions for EU or Sweden. Are you with me?

Hi,

Here are my zones definitions:
name: EU -- contains all countries in Eu except UK
United Kingdom contains only UK
Tax classes: EU tax

Tax rates: i have two of them: one for the EU zone, one for the United Kingdom zone. Both are under the EU tax class. The EU one has priority 3 the uk one has priority 1. First is 5% second is 10%.

If i have My Store: Display prices with TAX true --> prices will appear with their tax on the catalog. They will apear with the right tax value on the shopping cart and on the step 1 of the checkout. But the moment i get to step 2 the values go back to their untaxed values. (on step 3 Tax: 0 ).

Now the user im testing this with has both its shipping and billing address to Germany (which is under EU zone)

Also on the registration process and on my details on a user account the VAT field doesnt appear anywhere. Strangely it appears on the admin module when i edit a user.

Thanks for your patiance.

Hi,

I've just installed this mod (great work by the way) and it almost works perfectly.

What's happening is:

When a user registers and puts their VAT number in the registration field, the registration appears to work fine but when that user goes to checkout, the vat appears. However, when I look at that users details in admin, the VAT number box is empty. As soon as I put the vat number in through admin, it works fine for the user and the vat is removed.

Why wouldn't the VAT number be captured during registration? I'm presuming I copied all the file across correctly as apart from this it works fine.

Any ideas?

Thanks

Callum

Hi,
I have found the problem it seems you have a bug in the zen_tva_geo_tax() function in the /includes/classes/order.php file

here is the original function:

function zen_tva_geo_tax($tax_country_id, $billing_company, $billing_tva_intracom){
$tax_geo_zone_id = $this->zen_get_country_geo_zone_id($tax_country_id);
if($tax_country_id == STORE_COUNTRY ) return true; // store
if($tax_geo_zone_id == 0) return true; // no geo-zone
if($tax_geo_zone_id != 0 && !$billing_tva_intracom) return true; // geo-zone & no vat
elseif(!$billing_company && !$billing_tva_intracom) return false; // no vat
else return false;
}


Now i have observed that the function does not treat the case where there is actually a vat and a geo zone here is how i modified it and everything works perfect:

function zen_tva_geo_tax($tax_country_id, $billing_company, $billing_tva_intracom){
$tax_geo_zone_id = $this->zen_get_country_geo_zone_id($tax_country_id);
if($tax_country_id == STORE_COUNTRY ) return true; // store

/* geo-zone & vat --added by augustin */
if($tax_geo_zone_id != 0 && $billing_tva_intracom) return true;
/* end added by augustin*/

if($tax_geo_zone_id == 0) return true; // no geo-zone
if($tax_geo_zone_id != 0 && !$billing_tva_intracom) return true; // geo-zone & no vat
elseif(!$billing_company && !$billing_tva_intracom) return false; // no vat
else return false;
}


everything works just fine

hi callum.
i cant seem to be able to reproduce your bug and without being able to see your code i dont think im no good on making any qualified guesses.. but as i think of it i come up with one step of debuging. =]

but first, could you be a little more specific about where in the checkout:

Quote:

---

Originally Posted by callumgilhooly

the vat apears

---

anyway the file containing the mentioned error would be:

catalog/includes/modules/create_account.php

other files in the user-interface performing about the same is:

catalog/includes/modules/checkout_new_address.php and
catalog/includes/modules/pages/address_book_process/header_php.php

you should make sure also this code doesnt work in your current install by processing a vat-number (other than the one entered to be able to check the result) through the adressbook and adding a vat-number to a new adress through checkout.

but if that also doesnt work i can only ask, just be sure, about you using the 130 version of zencart? and if probably so the only idea i get is to try installing a zencart 130 distribution and then just simply replacing the installation files with the files from the modification and check if that works. if so you can somehow compare the installations and work from there.. =]

good luck!
vike

hi augustin (and anyone interested)
good you found the place and could change it to suite you. :yes:

i have though now rewritten that function to get it more optimized. it needs testing and some consultation with beez before it can be put in a new release of the mod, but hopefully its doing the same as before. =] ive chosen not to hard-implement your request quite there, as im thinking it may not be a common reqest of execution.
accordingly, the new code will (perhaps) take no consideration of zone-definitions by default, but will possibly do through un-commenting some lines of code, or perhaps configure via the admin-interface.

more work also needs to be done to the work ive sat with all night - much of that late nights around this mod btw :D

beez is on semester for the week, and perhaps also that is why id gladly get some feedback on my resent changes/additions to the mod:

i have made use of a yet internal configuration-constant to choose whether, an unknown tax rate of 0% should be used for customers from countries not in any zone-definition (as zencart default behavior), or if it else should fall back on the products tax-configuration.

i cant really understand that default behavior to suddenly skip tax totaly if an undefined country buys a product. but then im no zencart administrator as beez, who said to me it could be good of use as an indication of missconfiguration.. but then whats the purpose of product tax at all, as it will allways be overridden by tax-rate-configuration if thats done correct? ..any one explaning that to me will get a free copy of our next release! ;D

but thatd be all of zen fer tonite. peace in the mornin lite!
vike

Thanks Vike,

From the address book area, the adding of the VAT number worked so I have replaced the create_account pages and it appears to work fine now. Thanks for pointing me in the right direction (PHP/Zen novice here!)

Thanks again

Callum

Hello Beez,

I checked the VAT verification for Greece again...It does not work!
Works for all countries well.
Could you try it yourself? EL999943280 a valid TAX Number

I use your latest version.....

Cheers
Dimi

It seems like the validating server is down for Greece... http://ec.europa.eu/taxation_customs...&VAT=999943280 As it seems to work for other countries...

Try again later and if it still doesn't work, let me know!

Nice Work !!
Will test soon ..

ASp

Anyone who have tested this VAT-mod together with Super-Order????

Just a reminder: The latest version of the VAT-mod is 1.1 (look in the txt-file) and could be downloaded from here the file in the download section is still version 1.0, I've tried to upload it again...

Cheers!

Thnaks for the mod, this should make life easier when we are selling to other companies in the EU as we are just about to become VAT registered.

I set up the module as directed in the "Install_130.txt" file and it seems to work as described, though we don't have out VAT registration number yet so I can't try it out on a live transaction.

Last night I changed all of our products to tax class "VAT" and made modifications to the pricing so that the price including VAT should be at the price points (e.g. £9.95) we want rather than all over the place (e.g.£10.11). I have set "Admin -> Configuration ->My Store -> Display Prices with Tax" to "true" but none of the prices actually display with tax included to EU resident non-companies. The tax is added on checkout correctly.

Any ideas?

I notice this mod uses the function file_get_contents. My host has disabled the fopen wrappers so I get the following error if I try to verify the VAT number.

Warning: file_get_contents(): URL file-access is disabled in the server configuration in /xxxxxxxx/xxxxxxxx/public_html/shop/includes/functions/functions_email.php on line 529

Warning: file_get_contents(http://www.europa.eu.int/comm/taxati...AT=999943280): failed to open stream: no suitable wrapper could be found in /xxxxxxxx/xxxxxxxx/public_html/shop/includes/functions/functions_email.php on line 529

without fopen wrappers you will not be able to use file_get_contents for web services requests. does anyone have a work around for this? (Other than change hosts :P)

I replaced some of the code in the file "functions_email.php" to use cURL insted of the file_get_contents function. If you want to try to use this edit you can replace the code starting at line 522 ending 539 with the code you see below.



function zen_verif_tva($num_tva){
$num_tva=preg_replace('/ +/', "", $num_tva);
$prefix = substr($num_tva, 0, 2);
if (array_search($prefix, zen_get_tva_intracom_array() ) === false) {
return 'false';
}
$tva = substr($num_tva, 2);
// create a new curl resource
$ch = curl_init();

// set URL and other appropriate options
curl_setopt($ch, CURLOPT_URL, 'http://ec.europa.eu/taxation_customs/vies/cgi-bin/viesquer?MS=' . $prefix . '&Lang=FR&VAT=' . $tva);
curl_setopt ($ch, CURLOPT_HEADER, 0);
curl_setopt ($ch, CURLOPT_RETURNTRANSFER, 1);

// grab URL and pass it to a string
$monfd = curl_exec($ch);

// close curl resource, and free up system resources
curl_close($ch);

if ( eregi("TVA non valide", $monfd) ) {
return 'false';
} elseif ( eregi("TVA valide", $monfd) ){
return 'true';
} else {
$myVerif = 'no_verif';
}
return $myVerif;
}

That's handy.

Just a sidenote ... all the changes made to the functions_email.php in this mod .... should have been put into a separate file, in order to make impact on upgrades much simpler.
Since all the "changes" were really just the addition of some extra functions, they would be best placed into a new file at:
/includes/functions/extra_functions/tva_vat_lookup.php

It works fine as-is ... but would be more efficient done this other way.

Thanks. Great job. But in Turkey we have VAT numbers and Tax office.Only VAT numder in not enough. Both of them is a must for commercial sales. Means: On the invoice we have to write both of them. Do yıu have any ide to write two seperate items .Shortly: I need TWO separete inputs. 1- VAT Number and 2-Tax Office
Any help
:no:

High,
I have a problem. By check-out, I want change my adress . In the new form the VAT field is too small. Where can I change the the size of the VAT box for entry VAT number? The filed in the create account is OK. Only by changing / editing the adress, the new box is small!
Thanks

Quote:

---

Originally Posted by Remzi

High,
I have a problem. By check-out, I want change my adress . In the new form the VAT field is too small. Where can I change the the size of the VAT box for entry VAT number? The filed in the create account is OK. Only by changing / editing the adress, the new box is small!
Thanks

---

I added a picture . The same problem occures also by changing the invoice adress !

Quote:

---

Originally Posted by DrByte

Just a sidenote ... all the changes made to the functions_email.php in this mod .... should have been put into a separate file, in order to make impact on upgrades much simpler.
Since all the "changes" were really just the addition of some extra functions, they would be best placed into a new file at:
/includes/functions/extra_functions/tva_vat_lookup.php

It works fine as-is ... but would be more efficient done this other way.

---

we have been thinkin alot back and forth about that.. how to do with functions and additional files.. sometime in the begining we thought of not creaing to much new files and as aour modifications grew i guess we stuck to that thought.. but so thanks for pointing out the convention.. we will conform to your standard soon.. love standards - it makes stuff much easier in the future. thanks again. :)

Quote:

---

Originally Posted by Remzi

Thanks. Great job. But in Turkey we have VAT numbers and Tax office.Only VAT number is not enough. Both of them is a must for commercial sales. Means: On the invoice we have to write both of them. Do you have any ide to write two seperate items .Shortly: I need TWO separete inputs. 1- VAT Number and 2-Tax Office
Any help
:no:

---

what is the 'tax office' input for? how does it affect the tax? how do you want the mod to calculate with those two inputs and then with countries and such.. you probably must tell us some more about how the turkish vat-system/laws works.. and further since i gather you are not a member of the EU-VAT laws..
but besides that i can say im not sure how much work we are able to put into such country-specific matters.. sorry.. but again please feel free to let us know how your vat-laws works and maybe it is not too much work to be done..
i also wonder how the number-check is thought to be done and what server should be used..
thanks for shown intrest and good luck.. let us know..
/vike

Quote:

---

Originally Posted by vike

what is the 'tax office' input for? how does it affect the tax? how do you want the mod to calculate with those two inputs and then with countries and such.. you probably must tell us some more about how the turkish vat-system/laws works.. and further since i gather you are not a member of the EU-VAT laws..
but besides that i can say im not sure how much work we are able to put into such country-specific matters.. sorry.. but again please feel free to let us know how your vat-laws works and maybe it is not too much work to be done..
i also wonder how the number-check is thought to be done and what server should be used..
thanks for shown intrest and good luck.. let us know..
/vike

---

Thanks Vike,
Tax office is the name of the state-tax office, where the company is registered. For example my company has a tax office, which is GALATA (is a province in Istanbul) and the tax-number is 3445634900. Shortly: Tax office will be registered in the database with the tax-number for each customer. Both of them must be used together. The tax- office has NO effect to tax or to tax calcularion. Hope, ı could explain it. Thanks once more

Now, somebody PLEASE push me to the right direction.
All of the sudden I realized that (for example) a German tax number DE123456
and Country Italy or France let's you create the account :huh:
The MOD worked fine before...the only thing I changed was ....the server.

( I moved hosting provider)

Any thoughts how this can happen?

Dimi

Does the mod check the VAT-number against the server? You can enable/disable it in the admin... If it's enabled and you still can create an account with a German VAT-number and country France or Italy, then we have a problem... Please get back to me.

Quote:

---

Originally Posted by pivey

Now, somebody PLEASE push me to the right direction.
All of the sudden I realized that (for example) a German tax number DE123456
and Country Italy or France let's you create the account :huh:
The MOD worked fine before...the only thing I changed was ....the server.

---

Now I find that the same thing is happing to my.. I'm not sure if it worked before, but I we tested it good... Can someon verify if it did work before. That is, you shouldn't be abl eto enter a German VAT number and choose Country France.

Any way, We're working a fix for this and a general update to the new 1.3.5 version of Zen Cart as well as using more of the override system...

We'll be back soon! In the mean while, if you use this mod, watch out for the malfunction that pivey described...

Quote:

---

Originally Posted by Remzi

I added a picture . The same problem occures also by changing the invoice adress !

---

Sorry for the delay!

If, you havn't fixed it... On line 44 it should read:

Code:

---

<?php echo zen_draw_input_field('tva_intracom', '', zen_set_field_length(TABLE_ADDRESS_BOOK, 'entry_tva_intracom', '40') . ' id="tva_intracom"') . '&nbsp;' . (zen_not_null(ENTRY_TVA_INTRACOM_TEXT) ? '<span class="alert">' . ENTRY_TVA_INTRACOM_TEXT . '</span>': ''); ?>

---

Hi Beez,

it worked before...it was not possible to create an account with different country the VAT number belongs to. An alert returned to the customer. Was OK then..
I realized that since my upgrade to 1.3.02
Don't know if it is related to the upgrade....

There is now a new version (1.2) for Zen Cart 1.3.5 out. I've uploaded it to the Downloads section, but in the meanwhile it can be downloaded from http://www.sweetfabrik.se/ZC/VAT-mod_135.zip

There were some major flaws in the previous version, making it possible to have a VAT number from Germany and country set to France. Please update to the new version as soon can. The new version should work on 1.3.0.2, but is not tested!

Most of the changes is in /includes/modules/pages/address_book_process/header_php.php, but be sure to do a full file comparison. We've also made a new function file, located in /includes/functions/extra_functions/functions_vatmod.php and /admin/includes/functions/extra_functions/functions_vatmod.php

We've also corrected a bug in the /includes/templates/YOUR_TEMPLATE/template/tpl_modules_address_book_details.php where the company name wouldn't show correctly.

Good luck! And please, report any bug in this thread...

Hello,

I've installed the brand new version (1.2).
However I've a problem with taxes and shipping cost, witch are not considered in the total.
The shop is in France, there is 2 tax rates : 19.6 and 5.5%


Configuration :
Country : France.
Basis of product tax : Shipping
Basis of Shipping tax : Shipping
Display price with tax : true



Modules > Shipping :
Flat rate :
Shipping cost : 5 €
Taxe : 19.6 %
Tax basis : Shipping.



Location / taxes :
Country : France
Zones : all french "states"
Zones definitions : EU => France / All Zones.
Tax classe : Taxe 19.6 %
Taxe 5.5%

Tax Rates : Taxe 19.6 %
Taxe 5.5 %



What's happening during the checkout :
individual consummer (not professionnal) with french shipping address.


Example 1 :

In the basket :
1 Product 40.09 TTC (tva 5.5 %) -> tva 5.5 % = 2.09 €
1 Product 2.99 TTC (tva 19.6%) -> tva 19.6 % = 0.49 €



Sous-Total: €43,08 (ok)
shipping : €5,98 (ok, price includes 19.6% tax)
Tva 5.5%: €2,09 (ok)
Tva 19.6%: €0,49 (False, shipping tax are missing : 0.98 €)
Total : €48,08 (False,shipping tax are missing : 0.98 €)


Exemple 2 :

In the basket :
1 Product 2.99 TTC (tva 19.6 %) -> tva 19.6 % = 0.49 €


Sous total : 2.99 € (ok)
shipping: 5.98 € (ok, price includes 19.6% tax)
Tva 19.6 % : 0.49 (False, shipping tax are missing : 0.98 €)
Total : 7.99 (False, shipping tax are missing : 0.98 €)


Conclusion :
shipping Taxes seems not to be added. Before the module installation, that part was working


Sorry for my english, ask for explainations if some part are not clear

Hi,

Is this module also for zencart 1.3.5 or only for previous versions?

Ronald.

Quote:

---

Originally Posted by djimmy

I've installed the brand new version (1.2).

---

Have you done a fresh install of 1.2? The latest version of Zen Cart is 1.3.5...

As for the VAT-mod, we started development for 1.2.7, but as of now we're only distributing a version to 1.3.5. All version before the latest is to be considered BETA-releases, due to bugs that makes them not working as they should.

My Power tip of the day would be to make a (an other) fresh install of Zen Cart 1.3.5 :)

Quote:

---

Originally Posted by azrahn

Hi,

Is this module also for zencart 1.3.5 or only for previous versions?

Ronald.

---

The latest version 1.2 is for 1.3.5 but it should work on 1.3.x as well... Haven't done much testing on that...

If you don't have 1.3.5, I would recommend to update...

Quote:

---

Originally Posted by djimmy

I've installed the brand new version (1.2).

---

Quote:

---

Originally Posted by Beez

Have you done a fresh install of 1.2?

---

I must have been hungry or tired... or both... Of course you mean VAT-mod version 1.2 :D We will look in to it! see what might have gone wrong... We'll get back...

Quote:

---

Originally Posted by Beez

I must have been hungry or tired... or both... Of course you mean VAT-mod version 1.2 :D We will look in to it! see what might have gone wrong... We'll get back...

---

I think I found the bug, the fix was really simple:

--- includes/modules/order_total/ot_shipping.php.sav 2006-09-22 03:18:27.015818936 +0200
+++ includes/modules/order_total/ot_shipping.php 2006-09-22 03:26:02.403589472 +0200
@@ -94,7 +94,7 @@
}
}
$calculated_tax = zen_calculate_tax($order->info['shipping_cost'], $shipping_tax);
- if(!$tva_tax){
+ if($tva_tax){
$order->info['tax'] += $calculated_tax;
$order->info['tax_groups']["$shipping_tax_description"] += $calculated_tax;
$order->info['total'] += $calculated_tax;

(aka: remove the "not" from the second 'if(!$tva_tax){' in the file includes/modules/order_total/ot_shipping.php)

With this change the calculations look correct to me.

Have fun,
- Haegar

That's fine !!

Thanks.

Hello Beez,

thanks for the update.
I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

Also, the error "your VAT ID does not match the Country" is not showing up as well

Dimi

Hi developer,

I think I found a bug. After rechecking the mod 3 times I do not think it is a copy/paste error.
Into the adminsection the admin is able to change customer details.
When the customer details contains a VAT number, then with the update action the screen becomes blank. This is ONLY when VAT check is on in the parametersettings of this mod.
However the customer can change his details from the frontend without problem.

I have searched for a solution in the code but was not able to determine where the problem is.
I gues it should be in /admin/customers.php there where a check is done if the check should be done or not, arround line 116

if ( ENTRY_TVA_INTRACOM_CHECK == 'true') {
if (strlen($entry_tva_intracom) != 0) {
if ($entry_country_id != false) {
$countries_array = $db->Execute("select countries_iso_code_2 from " . TABLE_COUNTRIES . " where countries_id = '" . (int)$entry_country_id . "'");
if ( (array_search($countries_array->fields['countries_iso_code_2'], array_keys(zen_get_tva_intracom_array())) === false) || (array_search(substr(strtoupper(trim($entry_tva_intracom)),0,2), zen_get_tva_intracom_array()) === false) ) {
$error = true;
$entry_tva_intracom_error = 'true';

Quote:

---

Originally Posted by haegar

I think I found the bug, the fix was really simple:

---

Thanx haegar!
I'll try it too and add it to the next version.

Quote:

---

Originally Posted by Janneman

I think I found a bug. After rechecking the mod 3 times I do not think it is a copy/paste error.
Into the adminsection the admin is able to change customer details.
When the customer details contains a VAT number, then with the update action the screen becomes blank. This is ONLY when VAT check is on in the parametersettings of this mod.

---

That is correct, it doesn't work! And it's not a copy/paste error, at least not from you :)

To fix this copy the file: /includes/functions/extra_functions/functions_vatmod.php
To: /admin/includes/functions/extra_functions/functions_vatmod.php

That should do it, we just forgot that file :smile:

Quote:

---

Originally Posted by pivey

I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

---

What the f***! :shocking: this is strange! We'll look in to it as soon as we can!

Anybody els having this problem with the latest version (1.2)?

Cheers Mates!

Quote:

---

Originally Posted by pivey

I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

Also, the error "your VAT ID does not match the Country" is not showing up as well

---

You are right, it still doesn't work! I'll try to fix this upcoming week, when vike gets back...

Quote:

---

Originally Posted by pivey

I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

---

Ok, I've fixed it... Stupid me, when I "fixed" it last time I only fixed it in the address book, under My Account... :eek:

The Fix: In the file /includes/modules/create_account.php on line 125-126 change:

Code:

---

$country_code = zen_get_countries_with_iso_codes($country);
if ( (array_search($country_code['countries_iso_code_2'], array_keys(zen_get_tva_intracom_array())) === false) || (array_search(substr(strtoupper(trim($tva_intracom)),0,2), zen_get_tva_intracom_array()) === false) ) {

---

To:

Code:

---

$country_code =zen_get_countries_with_iso_codes($country); $intracom_array=zen_get_tva_intracom_array();
if(substr(strtoupper(trim($tva_intracom)),0,2) != $intracom_array[$country_code['countries_iso_code_2']]){

---

At least that works for me :smile: Could you please try it out before I upload it to the download section...

Quote:

---

Originally Posted by Janneman

I think I found a bug.

---

There are some other things that have been moved from admin/includes/functions/general.php to the new file admin/includes/functions/functions_vatmod.php

And in the latest install-file the changes for admin/includes/functions/general.php were missing. But I think the files were correct.

Please download the latest version of the VAT-mod (1.2.1) from here

NOTE: This is just a temporary package, the real one will be uploaded shortly to the download section. This package contains all fixes mentioned in this thread so far. But I haven't haegar's fix yet, though it's in the package. Just so you know...

Quote:

---

Originally Posted by Beez

Please download the latest version of the VAT-mod (1.2.1)

NOTE: This is just a temporary package, the real one will be uploaded shortly to the download section. This package contains all fixes mentioned in this thread so far. But I haven't haegar's fix yet, though it's in the package. Just so you know...

---

I have merged your changes in my testenvironment and it works great now :-) Thanks Beez

Hello Beez,

works now as it should.
Thanks for supperb support. You finally focus :laugh:

Dimi

to Beez & Vike

Thanks for the great mod
I've downloaded ver 1.2.1, which is the latest I think.
If it is then I've got a little suggestion

When viewing the login page, the textbox for the VAT entry is located next to the ENTRY_COMPANY_TEXT (defined in main language-file)

You should add the following to:
includes\templates\YOUR_TEMPLATE\templates\tpl_modules_create_account.php

just before: <!-- TVA_INTRACOM BEGIN //-->

add: <br class="clearBoth" />

Also in the zip I've downloaded the path to this file is
includes\templates\YOUR_TEMPLATE\template
which should be
includes\templates\YOUR_TEMPLATE\templates
(a least for ZC 1.3.5)


Hope this is helpful...
...if I'm right at all

Thank you ALHO!
Helpful indeed!

Haven't had the Company field enabled when were doing this mod :-)
Changed that!

You're right in should be templates - typo... Changed that!

I'm posting version 1.2.2 to the downoading section now, will be up soon.

Good luck with your site!

hi

I'm trying to use VAT-mod with Admin-Profiles . When I activate Admin-Profiles the VAT-mod boxes in the admin section don't show anymore. Admin-Profiles suggested modifying extra_boxes files for 3rd party mods but VAT-mod doesn't seem to use these.

Any ideas how to do this?

thanks

mark

Quote:

---

Originally Posted by creativetags

I'm trying to use VAT-mod with Admin-Profiles . When I activate Admin-Profiles the VAT-mod boxes in the admin section don't show anymore. Admin-Profiles suggested modifying extra_boxes files for 3rd party mods but VAT-mod doesn't seem to use these.

---

Actually I think I've just solved it - there's a setting at the bottom of the Admin Settings page -> Permissions for 3rd party mods and it was off on both my users accounts. Sorry for any wasted time

thanks

mark

No problem, glad it worked out!

Good luck with your site!

Hi,
I do not know if you can help me out. I have installed the VAT-mod for European companies version 1.2.2. I am based in the UK and when a customer from the UK purchases from me then there should be tax on both the product and the shipping. However, there is no VAT being added to the shipping costs. All my settings are correct and I installed following all the instructions given. Is the mistake on me making an error during the installation or could it be a bug.

The page which is causing the problem is
catalog/includes/modules/order_total/ot_shipping.php because when I revert back to the original zen cart script the VAT comes back on the shipping as it should be.

Can anyone please help

thanks

ml

Thanx for your intrest in our mod! Myself or vike will look in to it!

I'm bit busy at the moment, but if you give me a couple of days I'm sure we can fix it. It can most certainly be a bug, but if it is we'll squeeze it :smile:

No problems, I have solved it. You have placed a bug fix on page 6 of this thread for it.

thanks

ml

Great! Thanx for the update. Good luck with your store.

Hi, I tried to install VAT-mod_135.zip on Zen 1.37.

After fixing an error in SQL: Statement , '1' was missing at ('27', '1', 'VAT-Mod'.....) so i corrected it to:
INSERT INTO configuration_group VALUES ('27', '1', 'VAT-Mod', 'VAT-Mod options', '27', '1');

The VAT Mod was visible in the admin section, but nothing was displayed at the adress sections. This would not really be a problem, but /index.php?main_page=checkout_shipping didn't work anymore, so there was only an empty page when trying to check out.

Any help apreciated !!! :laugh:

Hi to all members,

for first, tnx very much for this useful MOD. You are great!!!

I've tried to install this mod in my zencart 1.37 but I have some problems and I think this mod works 60% on my website.

First problem: when I try to make new registration, no script give me the error if I leave blank the field VAT or the VAT number is wrong. Is that true?

Can I have for someone an address of their website for test, like customer, the script?

I don't understood very well how the script check, via server EU, if the VAT is correct or no.

Thank you very much for all the answers

Quote:

---

Originally Posted by csfound

Hi to all members,

for first, tnx very much for this useful MOD. You are great!!!

I've tried to install this mod in my zencart 1.37 but I have some problems and I think this mod works 60% on my website.

First problem: when I try to make new registration, no script give me the error if I leave blank the field VAT or the VAT number is wrong. Is that true?

Can I have for someone an address of their website for test, like customer, the script?

I don't understood very well how the script check, via server EU, if the VAT is correct or no.

Thank you very much for all the answers

---

Any suggestion?

Quote:

---

Originally Posted by juergen852

After fixing an error in SQL: Statement , '1' was missing at ('27', '1', 'VAT-Mod'.....) so i corrected it to:
INSERT INTO configuration_group VALUES ('27', '1', 'VAT-Mod', 'VAT-Mod options', '27', '1');

---

sorry but will you please give us a file and a row in where the error occurs? perhaps you can undo your change to retrieve the error-message..

Quote:

---

Originally Posted by juergen852

The VAT Mod was visible in the admin section, but nothing was displayed at the adress sections. This would not really be a problem,

---

good this problem is no real problem for you :] but still - to check what it can be telling about itself and other bugs - what do you mean by 'adress sections'?

Quote:

---

Originally Posted by juergen852

index.php?main_page=checkout_shipping didn't work anymore, so there was only an empty page when trying to check out.

---

can you see php-errors? (http://php.net/manual/en/ref.errorfu...display-errors, http://php.net/manual/en/function.error-reporting.php)
else try echoing at appropriate breakpoints..

Quote:

---

Originally Posted by juergen852

Any help apreciated !!! :laugh:

---

i trust we will solve this soon :yes:

Quote:

---

Originally Posted by csfound

when I try to make new registration, no script give me the error if I leave blank the field VAT or the VAT number is wrong. Is that true?

---

can you please give us the number to test at our implementations?

Quote:

---

Originally Posted by csfound

Can I have for someone an address of their website for test, like customer, the script?

---

mine is still in 135 and in bad shape.. erhrm.

Quote:

---

Originally Posted by csfound

I don't understood very well how the script check, via server EU, if the VAT is correct or no

---

i could perhaps explain it... ?

Quote:

---

Originally Posted by csfound

tnx very much for this useful MOD. You are great!!!

---

thank _you. allways great to be apriciated and see were filling a need with our work. thank you all.

Quote:

---

Originally Posted by vike

sorry but will you please give us a file and a row in where the error occurs? perhaps you can undo your change to retrieve the error-message..


good this problem is no real problem for you :] but still - to check what it can be telling about itself and other bugs - what do you mean by 'adress sections'?


can you see php-errors? (http://php.net/manual/en/ref.errorfu...display-errors, http://php.net/manual/en/function.error-reporting.php)
else try echoing at appropriate breakpoints..


i trust we will solve this soon :yes:

---

Hi,

Quote:
Originally Posted by juergen852 View Post
After fixing an error in SQL: Statement , '1' was missing at ('27', '1', 'VAT-Mod'.....) so i corrected it to:
INSERT INTO configuration_group VALUES ('27', '1', 'VAT-Mod', 'VAT-Mod options', '27', '1');
sorry but will you please give us a file and a row in where the error occurs? perhaps you can undo your change to retrieve the error-message..

---> This is in the first line of the SQL statements for the database.




Quote:
Originally Posted by juergen852 View Post
The VAT Mod was visible in the admin section, but nothing was displayed at the adress sections. This would not really be a problem,
good this problem is no real problem for you :] but still - to check what it can be telling about itself and other bugs - what do you mean by 'adress sections'?

----> Well, ok, it's a problem for me too. What I wanted to say:
In the user registration at the frontend side of the shop no VAT field was displayed. But I was still able to continue registration. That's why I said: "It's not a real problem" as the shop still worked fine to that point..... The real problem was, that, after buying something, the chekcout page was blank. So I had to remove the MOD and get back to my backup.


Quote:
Originally Posted by juergen852 View Post
index.php?main_page=checkout_shipping didn't work anymore, so there was only an empty page when trying to check out.
can you see php-errors? (http://php.net/manual/en/ref.errorfu...display-errors, http://php.net/manual/en/function.error-reporting.php)
else try echoing at appropriate breakpoints..

Well, too late for the logs, could not track it back...
Did you get it running on an 1.37?
Maybe it's easiest to set up a clean 1.37 and checkt it there...


Quote:
Originally Posted by juergen852 View Post
Any help apreciated !!!
i trust we will solve this soon

Thanks, Juergen

I've just finished to apply Beez mod to my store www.100asa.it, and it work very well. But I can't see the customer vat in admin: the filed is blank.

...and I can't see the VAT numer in the email order! It's very important for me to see the VAT number in the email order, because I entry the email order in another database.

Quote:

---

Originally Posted by csfound

First problem: when I try to make new registration, no script give me the error if I leave blank the field VAT or the VAT number is wrong. Is that true?

---

Sorry for the delayed answer.
You need to enable the mod to make it check the VAT-number with the server. You do that in the Admin->Configuration->VAT-mod->Check the VAT number->True

The mod is not set to make VAT-number mandatory, don't really know why one would do that...

The script works that it checks the VAT-number against a EU server and checks that the VAT-number and country is the same. If not ok from the server or if VAT-number and country matches you get an error displayed, works both in the shop and in Admin.

Quote:

---

Originally Posted by 100asa

But I can't see the customer vat in admin: the filed is blank.

---

It works for me on Zen Cart v. 1.3.7... Are you sure you got all the code?

Quote:

---

Originally Posted by 100asa

...and I can't see the VAT numer in the email order!

---

That's because it isn't there ;-) I think the file that sends that email is /includes/classes/order.php or maybe admin/order.php. The corresponding language files are includes/languages/english/checkout_process.php and admin/includes/languages/english/orders.php. You could get the VAT-number from any of these files... We can do it for you if you make it worth our while :-)

Quote:

---

Originally Posted by juergen852

Quote:

---

Originally Posted by juergen852

After fixing an error in SQL: Statement , '1' was missing at ('27', '1', 'VAT-Mod'.....) so i corrected it to:
INSERT INTO configuration_group VALUES ('27', '1', 'VAT-Mod', 'VAT-Mod options', '27', '1');

---

This is in the first line of the SQL statements for the database.

---

oh, dang. there it was.. didnt see it as i checked there when you asked.. hmeh..

yet: the table 'configuration_group' should contain the following column/cells acqoarding to my database:
configuration_group_id ('27')
configuration_group_title ('VAT-Mod')
configuration_group_description ('VAT-Mod options')
sort_order ('27')
visible ('TRUE')
what do you mean this extra '1' would refer to or describe and what column title is it supposed to belong to? i now know the sql-file (VAT-mod_English.sql) is correct.. :lookaroun
adding a '1' may rather create more errors..

Quote:

---

Originally Posted by juergen852

Quote:

---

Originally Posted by juergen852

The VAT Mod was visible in the admin section, but nothing was displayed at the adress sections.

---

In the user registration at the frontend side of the shop no VAT field was displayed. But I was still able to continue registration.
..
Maybe it's easiest to set up a clean 1.37 and checkt it there...

---

yes, how thoroughly did you install this mod? i suggest you give it a retry - even more since your further follow fatal errors and because if you dont see this field and also no errors - with risk for repetition, i say there must be something wrong in the installationprocess..

Quote:

---

Originally Posted by juergen852

Quote:

---

Originally Posted by juergen852

index.php?main_page=checkout_shipping didn't work anymore, so there was only an empty page when trying to check out.

---

The real problem was, that, after buying something, the chekcout page was blank. So I had to remove the MOD and get back to my backup.

---

awh, tough..

Quote:

---

Originally Posted by juergen852

too late for the logs, could not track it back...

---

ah. to bad.. but still, for the future:

Quote:

---

Originally Posted by vike

can you recieve php-errors? (http://php.net/manual/en/ref.errorfu...display-errors, http://php.net/manual/en/function.error-reporting.php)
else try echoing at appropriate breakpoints..

---

:yes:

Quote:

---

Originally Posted by juergen852

Did you get it running on an 1.37?

---

yes and we now have that confirmed by a new update to conform to zencart 137

beez will post more on thit soon.

thanks for your patience. good luck with your work. peace.

There is a new version of the VAT-mod on its way to the downloads section, the new version is 1.2.3 and is for Zen Cart 1.3.7.

We have made some fine tuning of the code and updated the distributed files to 1.3.7. We have changed some comments in the code to better distinguish the VAT-mod changes from more of general fixes we have found. A thread for these general fixes can be found here.

These general fixes are optional but recommended to make it more clearer for the user. The change in tpl_modules_address_book_details.php are however more essential...

The mod as it is now shows the prices without taxes (if logged in with valid VAT-number) on checkout_payment. We're working to get it to show price without taxes on checkout_shipping as well.

We also have plans to make the entire shop show prices without VAT if logged in with a valid VAT-number even when the shop is configured to show prices with tax. If you feel that you can contribute, please give a shout!

Quote:

---

Originally Posted by Beez

That's because it isn't there ;-) I think the file that sends that email is /includes/classes/order.php ...

---

It's right! I've try to add billing_tva_intracom on line 1101
$extra_info=email_collect_extra_info('','', $this->customer['firstname'] . ' ' . $this->customer['lastname'], $this->customer['email_address'], $this->customer['billing_tva_intracom'], $this->customer['telephone']);

with no success!

Quote:

---

We can do it for you if you make it worth our while :-)

---

:yes:

Hi,

I will set up a clean 1.37 for new trial and keep you posted on the results.

Greets
Juergen

Quote:

---

Originally Posted by Beez

Sorry for the delayed answer.
You need to enable the mod to make it check the VAT-number with the server. You do that in the Admin->Configuration->VAT-mod->Check the VAT number->True

The mod is not set to make VAT-number mandatory, don't really know why one would do that...

The script works that it checks the VAT-number against a EU server and checks that the VAT-number and country is the same. If not ok from the server or if VAT-number and country matches you get an error displayed, works both in the shop and in Admin.

---

Thank you very much for your reply Beez!

So, like I suppose, I have some problems with this mod.
Can you help about these functions?
First, when we make new registration, javascript doesn't works because i don't received no error if i leave blank field or i entry wrong VAT number.

In Admin configuration I've set TRUE ......

csfound: You are right, there was an error in create_account.php (catalog/includes/modules/create_account.php). Could you please try the file I've attached here and see if it works. The mod doesn't returns an error if you leave the VAT field blank. It returns an error if you enter a faulty VAT number or if it doesn't match your country.

I've also added that you must enter a company name if you've entered a VAT number even if it's not required in the admin settings.

If this works we'll update the package in the download section, so please report back.

Good luck!

Quote:

---

Originally Posted by Beez

csfound: You are right, there was an error in create_account.php (catalog/includes/modules/create_account.php). Could you please try the file I've attached here and see if it works. The mod doesn't returns an error if you leave the VAT field blank. It returns an error if you enter a faulty VAT number or if it doesn't match your country.

I've also added that you must enter a company name if you've entered a VAT number even if it's not required in the admin settings.

If this works we'll update the package in the download section, so please report back.

Good luck!

---

Great Beez, now works 100%, you can update in download section!!!

One question: it is possible to make mandatory the VAT field? Is it too difficult or is simple make this mod?

Tnx

New version (1.2.4) just uploaded.

Now the mod shows the prices without VAT in the checkout payment if logged in with valid VAT number. In the rest of the shop prices are displayed with VAT if chosen in admin.

We will work to get all prices displayed without VAT if a costumer is logged in with valid VAT number. The first step is to fix the prices in checkout shipping. Then we will move on to fix shopping cart and the rest of the shop. This will take some time. If you can contribute, please drop us a PM or post in the thread.

hi,

I'm having the same problem as juergen852 has

Quote:

---

----> Well, ok, it's a problem for me too. What I wanted to say:
In the user registration at the frontend side of the shop no VAT field was displayed. But I was still able to continue registration.

---

on a quasi new 1.3.7 Installation.

in the admin section, there is a VAT field for each customer



Any clues?

Martin