Printable View
I've upgraded the original 1.2.7 Subscribe! contribution, merged in the 1.2.7 newsletter_unsubscribe contribution, and added quite a number of new features of my own.
The end result is Newsletter Subscribe V2.0
Please let me know what you think and report any problems you may have.
-Ng_
The contribution is now in the downloads section, under 'Other Modules'. Updates will be placed there, so please download from that section.
Thank you for the quick approval!
-Ng_
Hello All,
This mod sounds brilliant, so I had to try it. So far, I am at the install stage on the Subscription Manager. This is what comes back when I press the button:
1146 Table 'thegemtr_zc2.query_builder' doesn't exist
in:
[DELETE FROM query_builder WHERE query_description = 'Returns name and email address of all Customer Account subscribers and all Newsletter-Only subscribers.']
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.
I am not sure what to do, I am guessing it could be a SQL setup thing. Any help would be gratefully received.
Regards,
Russ
It would have been a pleasant first to discover all the testing actually uncovered everything. *sigh* I forgot to hold update the database installation so it calls for the table name (prefix + query_builder). Give me 10 min and I'll post an upgrade.
I was about to install this add-on. I guess it is a good idea I checked the support forum first :) Thank-you Notgoddess for this add-on, it looks like a good module. When you say you're going to upload an update, is that going to be on the downloads page or this thread? Is there going to be a second file on the download page? Thanks again.
I've uploaded the updated contribution but updates have to be reviewed by the staff.
You can wait until you see version 2.0.1 or grab it from my website:
http://www.notgoddess.com/scripts/newsletter-subscribe
Hiya,
Thanks for getting back to me. Just to say it is working A.O.K and is chuffing brilliant!!
Regards,
Russ
I found one typo in this excellent contribution. A SQL error appeared when I deleted a customer account.
admin/customers.php
On line 343, change
where customer_id = '" . (int)$customers_id . "'");
to
where customers_id = '" . (int)$customers_id . "'");
(changed customer_id to customers_id)
Thank you for finding that!Quote:
Originally Posted by alanpace
I've added the correction and upgraded the version to 2.0.2
-Ng_
Thanks for the contribution NG. I am looking to do a mass import of newsletter only subscribers. Is there an easy way to do this?
Thanks
It would depend upon format of your list (sql, txt, xsl, csv, etc). if you email me a copy of the list (or part of it) I can build something for you.Quote:
Originally Posted by mocha
I'll end with this caveat -not because I think you are intending it, but others might.
admin-added subscriptions are auto-confirmed, but please please do not use this as a way to send people unsolicited spam (like using a list you bought somewhere).
-Ng_
Thanks for the offer NG. The list format is flexible, at the moment it is an excel file with just the username and the email address. Also with the sidebox, I cannot find where to change it so the sidebox title is just "Newsletter" and is not a link.
Okay, well the easiest way (other than having me code an interface :) would be to turn the excel into a sql file:
Copy the email address column and save as a txt file (separate with commas).
Open that file in your favorite text editor.
Add to the beginning of the file (replace tbl_name with your subscribers table name, including prefix):
INSERT INTO tbl_name (email_address) VALUES(
Use the find/replace command:
find: , [that's a comma]
replace with: '), ('
If the editor supports adding newlines you might use:
replace with: '),\n ('
At the end of the file you should have: lastemail@address
Add to end: '); so it is: lastemail@address');
You are trying to end up with:
INSERT INTO tbl_name (email_address)
VALUES([email protected]), ([email protected]),
([email protected]), ([email protected]);
Save the resulting file (as .sql or .txt) and use the sql patches feature in the Tools menu to upload/run it. If you have hundreds of names you may need to break into a few files.
-Ng_
? The 'Subscribe' sidebox title is not a link by default. Are your other sideboxesQuote:
Originally Posted by mocha
linked? It might be a feature you have enabled somewhere.
[edit: found it]
edit /includes/modules/sideboxes/YOUR_TEMPLATE/subscribe.php
and add this somewhere:
$title_link = false;
Let me know if that works and I'll include it in the next update.
-Ng_
Does this work on the latest version of Zen Cart?
I want to make sure I din't miss anything here.
Thanks,
Kelly
Yes, this runs with zencart 1.3.x (1.3.0 and 1.3.0.1).Quote:
Originally Posted by sleepless
Make sure you download the updated version from the contributions section, and you .might. need to apply the patch in the post above yours (I'm still seeing if it's needed before I update again).
Please let me know how you like it, if there's anything you'd like changed/added (even if it's a 'well it would be nice if...' because you can bet others are thinking the same thing).
-Ng_
Thanks for the quick reply.
I had the original and removed it a while back. One feature that I did like was adding a query to send emails to test account only before sending them to actual customers. Will this enable me to do that as well?
If not, that would be a nice addition.
Thank you in advance! :)
Kelly
I'm not .quite. sure if I understand you. You can of course create a subscription using an email address...you can email them directly, but there is no query set so you have the option to send the newsletter to one address first-I didn't see anything like that in the original, either, although perhaps I worked from a different version than you had.Quote:
Originally Posted by sleepless
Is this what you are wishing? I believe it should be easy enough to add-we'd just add a query to pull the admin email address and add that as an option in the 'send to' list.
Let me know if that's what you had in mind.
-Ng_
I have the sql for it somewhere. If I find it I will email or post it so you can see if it will work. It wasn't included in the original. It was something someone posted as an add on.
Thanks,
Kelly
Check out these posts. There are a number of various solutions for test accounts. I didn't want to post the code in case someone thought it was okay to use.
http://www.zen-cart.com/forum/showth...ewsletter+test
Thanks,
Kelly
I found it-this is the query someone used for a test group:
INSERT INTO query_builder ( query_id , query_category , query_name , query_description , query_string ) VALUES ( '', 'email,newsletters', 'Newsletter to Test Group Only', 'Send sample newsletter to Customer Test Group only', 'select customers_email_address, customers_lastname, customers_firstname from TABLE_CUSTOMERS WHERE customers_group_pricing = \'2\'');
However, it requires you to modify your group pricing group...not something I'd be in favor of, since it does mods to other things.
But you can do that...I'll see if I can create a cleaner way to make test emails work, perhaps you'll be able to signify addresses in the email configuration, like you do CC emails for so many other options.
-Ng_
I believe I used the one that gave options for three or so different groups. I only had to insert the code into mysql in the shop admin. I didn't use the one that has you create a pricing group. I preferred the other.
Thanks,
Kelly
Here is a copy of one of them.
Copied from original post:
Okay, this approach will work for you. Take a look at the list of Customers in the Admin panel. The customers_id for the test account you want to use will be displayed next to the last name.
Now copy this code into your SQL patch tool in Admin and change the customers_id to the correct id for the test account.
CODE:
INSERT INTO query_builder ( query_id , query_category , query_name , query_description , query_string ) VALUES ( '', 'email,newsletters', 'Newsletter to Test Account Only', 'Send sample newsletter to Customer Test Account only', 'select customers_email_address, customers_lastname, customers_firstname from TABLE_CUSTOMERS WHERE customers_id = \'4\'');
I'll have to think about it-you see I don't want people to have to hard code values (e.g. enter customer id directly in the query) as then they'd have to edit the database manually to change it.
I agree it's probably best to reference real customer accounts. I just have to figure out the proper query.
Alrighty, I think I've got it.
2 sql statements: First one to setup an Email configuration field to hold the test emails, and one for the query builder. This is set up to use email addresses, but you could adapt it to use customer id's if you'd rather.
If you use prefixes in your database, you'll want to change the tables accordingly (but don't change the TABLE_CUSTOMERS, etc ones...zencart replaces with proper table names).
After inserting, you'll want to enter email addresses that match your test accounts.Code:INSERT INTO configuration
(configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, last_modified, date_added, )
VALUES ('Newsletter Email Test Group', 'NEWSONLY_SUBSCRIPTION_TEST_GROUP', '', 'Enter email address, separated with a comma, of customers you would like to include in the test group.', 12, 40, now(), now() );
INSERT INTO query_builder
(query_category, query_name, query_description, query_string)
VALUES ('email,newsletters', 'Newsletter Test Group',
'Returns name and email address of Customer Accounts designated in Email configuration.',
'SELECT c.customers_firstname, c.customers_lastname, c.customers_email_address FROM TABLE_CUSTOMERS as c LEFT JOIN TABLE_CONFIGURATION as q on LOCATE( c.customers_email_address, q.configuration_value) >= 1 WHERE configuration_key = ''NEWSONLY_SUBSCRIPTION_TEST_GROUP'' ');
Hi NG,
I tried to install the code using the sql patch tool and it wouldn't work. I also tried to install it through phpmyadmin. The error is listed below.
The admin sql patch didn't specify what error, it just wouldn't work. :no:Code:Error
SQL query:
INSERT INTO configuration(
configuration_title,
configuration_key,
configuration_value,
configuration_description,
configuration_group_id,
sort_order,
last_modified,
date_added,
)
VALUES (
'Newsletter Email Test Group', 'NEWSONLY_SUBSCRIPTION_TEST_GROUP', '', 'Enter email address, separated with a comma, of customers you would like to include in the test group.', 12, 40, now( ) , now( )
)
MySQL said:
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')
VALUES ('Newsletter Email Test Group', 'NEWSONLY_SUBSCRIPTION_TEST_GROUP', ' at line 2
Thanks,
Kelly
Actually it did specify the error-it told you where to look. but if you weren't versed in mysql you wouldn't know what to look for. There was an extra , at the end of the set statement.
Try this. I've added delete statements to remove the old ones just in case one did go through.
Code:DELETE FROM configuration where configuration_key = 'NEWSONLY_SUBSCRIPTION_TEST_GROUP';
INSERT INTO configuration
(configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, last_modified, date_added )
VALUES ('Newsletter Email Test Group', 'NEWSONLY_SUBSCRIPTION_TEST_GROUP', '', 'Enter email address, separated with a comma, of customers you would like to include in the test group.', 12, 40, now(), now() );
DELETE FROM query_builder WHERE query_name = 'Newsletter Test Group';
INSERT INTO query_builder
(query_category, query_name, query_description, query_string)
VALUES ('email,newsletters', 'Newsletter Test Group',
'Returns name and email address of Customer Accounts designated in Email configuration.',
'SELECT c.customers_firstname, c.customers_lastname, c.customers_email_address FROM TABLE_CUSTOMERS as c LEFT JOIN TABLE_CONFIGURATION as q on LOCATE( c.customers_email_address, q.configuration_value) >= 1 WHERE configuration_key = ''NEWSONLY_SUBSCRIPTION_TEST_GROUP'' ');
Hello. I've just installed the add-on and now when I go to my home page, its blank. Any ideas?
Hi,
Thanks that seems to have worked.
I saw the error message for PHPMyadmin but not for the patch tool in my cart. If it showed it, i simply didn't see it before leaving the page.
Although not a pro at mysql, I do have some knowledge, at least enough to read the error statement. I only stated I didn't see it not that I didn't understand it. :wink2:
Thanks,
Kelly
I tried to send messages to you, only because this is a realtime problem, but no response so I'll give you what I think the problem is:Quote:
Originally Posted by duckydoodles.com
You copied tpl_header.php.example directly over your tpl_header.php file.
Now maybe you didn't but I'm guessing here.
The problem is that is only an example file...it just shows you where to make the edit to add the subscribe_header...since most people customize their header it's going to be different for everyone (so I couldn't have a file that overwrote).
Try putting your original header file back in.
If that doesn't work, or is in no way close to what you did, get back to me.
You can try disabling the subscriptions in admin->configuration->my store
and set Enable Newsletter-only subscriptions? to false.
Hi NG,
I was able to set this up and added my email addresses. It doesn't recognize newsletter only subscribers. Is that the way it should work? If so...it works great.
Thanks you, :smile:
Kelly
*sigh* what you posted is exactly what showed when I used the sql patch -so I [falsely] assumed you didn't understand the error message. Many people using the cart have only minimal knowledge of sql, tho I think it grows with every patch :0Quote:
Originally Posted by sleepless
I was not intending to imply..well anything...I just find it safer to work under the assumption that the person needs in-depth instruction rather than assume they know of what they speak and end up spending more time explaining. Especially since people will read the posts who don't have any knowlege and try to implement.
...and since you just posted again, I'll just respond here.
From your posts I thought you wanted to reference real customer accounts.
If you read the sql you'll see it only pulls from the customers table, not subscribers. I was planning on seeing if I could do both for the next update, but I'll try to do it now since I'm waiting for DD to respond.
-Ng_
No rush. I did notice that it was only pulling from the customer table. The ony reason it's a good idea to have both is that the original sent the emails in html or text nicely if the customer had an account. If it was an email for a subscriber only, it sent alot of code mixed with the text and no html. At least mine did. I actually pulled it off my site even before the later updates made it unusable.
So...it doesn't hurt to be able to check both.
Your assumption was the safest one to make. :smile:
It was for the same reason I was hesitant to post the code for fear someone may use it without checking to see if it worked first.
Thanks,
Kelly
Okay, I cannot get the three table join to work properly, so....
You'll still enter all email addresses in the single field in the Email configuration.
However when you select the groups to send to, you'll see the group you've already set up, which is only customer accounts that match the emails, and this group 'newsletter-only subscribers test group'. So to test you'll want to send to both.
If I knew the minimum MySQL versions people were running I could use subqueries or unions to combine both groups, but since I can't these would need to be separate groups.
Here's the sql for the patches page:
Code:INSERT INTO query_builder
(query_category, query_name, query_description, query_string)
VALUES ('email,newsletters', 'Newsletter-only subscribers Test Group',
'Returns email address of Newsletter-only subscribers designated in Email Newsletter Test Group configuration.',
'SELECT s.email_address as customers_email_address FROM TABLE_SUBSCRIBERS as s LEFT JOIN TABLE_CONFIGURATION as q on LOCATE( s.email_address, q.configuration_value) >= 1 WHERE configuration_key = ''NEWSONLY_SUBSCRIPTION_TEST_GROUP'' ');
I found an unrelated error while testing this-if you have HTML mail turned off the email format wasn't being set (not crucial, as it will always default to text), but it makes the admin section display a blank for preference, which I found annoying.
So I'll be fixing that and incorporate these test groups into the new release-I'll have update checks so you won't lose data.
No timetable on that release...it'll take a while to ensure updates are safe.
-Ng_
Now you lost me. I know I had a hard time trying to get the query to pull from the subscribe table. Obviously it is over my head. :blink:
So...I will wait for your next release. :smile:
Thanks,
Kelly
Is there a way to set the width of the newsletter subscribe box? It's really wide. I have the rest of my side boxes at 175 px.
Thanks!
Well it should size with the rest of the boxes-nothing's hardcoded other than to set the width of the email field as 30px less than the width of the field (15px on either side).
I looked at your site and it looks to all fit, so I'm guessing you got it figured out? If it was wider and you did something to fix it, can you let us know in case someone else runs into the problem?
Thx,
-Ng_
@duckydoodles.com:
I tried to mess up the cart by changing the header around, deleting files, etc...at most I got part of the header then errors (because the file didn't exist, etc).
If I disabled the newsonly-subscriptions in admin those errors vanished and the cart loaded normally.
It might be the contribution-but I think it's more likely a typo in the file.
Now I did manage to get a blank page by doing the following:
Inserting the full code (with enclosing tags) inside an area already marked with tags, e.g:
or by omitting the closing ?> and inserting the code in an html area (one not enclosed in tags), e.g.:Code:<?php require(DIR_WS_MODULES . 'sideboxes/search_header.php');
<?php
// BEGIN newsletter_subscribe mod 1/1
.... the code ...
// END newsletter_subscribe mod 1/1
?>
?>
Actually I did get an error : parse error, unexpected '<' but I might have more error reporting on that you do. It's common for production servers to suppress them for security reasons, tho they should be enabled in application_top.php (around line 47: error_reporting(E_ALL); )Code:<?php require(DIR_WS_MODULES . 'sideboxes/search_header.php'); ?>
<?php
// BEGIN newsletter_subscribe mod 1/1
.... the code ...
// END newsletter_subscribe mod 1/1
</div>
This is actually the most common cause of 'blank' pages-one that confounds me on occasion even tho I know it's something to look for.
I suggest you review any pages you've done manual changes to (special attn to tpl_header.php) and see if the is a typo/syntax error as mentioned above. If you have a text editor that colors to differentiate between php and html areas (like SciTE or Crimson) it might make it easier if you don't see it. Or you are free to email the file to me and I can check it on my system to see if that's the problem child.
Barring more info, that's the best advice I can offer. I see your site is still blank, so I wish you the best of luck in figuring it out.
-Ng_
Thanks NG, That's fixed the heading link!Quote:
Originally Posted by NotGoddess
Is there a way to set the width of the newsletter subscribe box? When i view my test site using firefox its ok and is the same size as my other right hand boxes, BUT in IE its way larger - any ideas how to fix this?
Can you post or pm your website? If I see it I can tell if it's a keyed, styled, or IE problem and better propose a solution.Quote:
Originally Posted by jayson.gurney
-Ng_
Hi, I have a problem with my zencart. When insert the email address in the box the browser send me an errror: "Error e-mail sending not success to "" with subject ""Please confirm Rigen Service newsletter subscription" SMTP Error: the recipient email generate this error..."
This is my site
http://www.rigenservice.it
Is in italian language. Can you help me?
Thanks a lot
That looks like an error in your smtp settings.
That error is generated from the mail class.
Are you able to send normal emails out? I've created an account on your site (email: sarazcATnotgoddess.com) -you can feel free to try to send test emails to me from ZenCart.
I just tested this using sendmail, smtp and smtpauth and the emails are going through, so I don't think it's the actual contrib itself. I'll be happy to help you as I can, though.
-Ng_
Ok, I have sended the email from the original panel of zen-cart and this function ok. I have installed the "newsletter Subscribe" v. 2.0.2
I have to config the email sending in this contrib?
No, you shouldn't have to....the newsletter confirmation uses the same functions to email as the welcome message, etc.
Although, you know I just noticed that I never received a 'Welcome' email from creating an account at your site. Can you try sending email to me from zencart?
On the customers page, click on my account and there's a button to 'email'.
(I was just heading to bed-but I'll try to stay up for a bit....it's awkward to do support when we are a world apart).
-Ng_
I have sended the email first. The message of zen-cart tell me thath the message is correctly sended.
Well I received the email from this forum thread...no email from you yet, although that might take a few minutes. Can you send one to yourself (or to another email address that you can check) ?
-Ng_
I have send the email to another my account. Not function!!! I think that I have a problem with my smtp account
If I send the email to my account of domain rigenservice.it this function
So within the domain it functions okay.
Yes, it is your smtp settings then.
Are you using regular smtp or smtpauth ?
I know I have to use smtpauth and set the username [[email protected]] and my password in order to send smtp mail.
I have set in smtp
Your ISP/host may require smtpauth Can you try that and send the email to your other account again to test?
Otherwise you can try using sendmail.
-Ng_
Yeeeessss. Ok I have just reapair my setting. Thank you. You are very very good. Excuse me for my english, I have only study at school.
Bye Bye
Wonderful! I'll sign up for your newsletter to test.
If you do an Italian translation of the contribution, I would love to have a copy to include in releases.
3am here-time for bed (a few hours ago. :)
-Ng_
Of course!
In the contrib there is a problem for the alignment of the sideboxes elements. Have you the same problem?
You mean the 'html text-only lines?
Some people with table layouts had problems with the box being too big-there's a patch for that on my site until I get the next release out:
http://www.notgoddess.com/scripts/ne...bscribe#issues
But if you are talking about
HTML TESTO
solo
....you can edit that same file and insert a '<br />' in between the two radio buttons so you'll see:
HTML
TESTO solo
file: includes/templates/your_template/sideboxes/tpl_subscribe.php
Like this: (lines 21-24)
I'll be off now...but hope that fixes it.Code:if(EMAIL_USE_HTML == 'true') {
$content .= '<label>' . zen_draw_radio_field('email_format', 'HTML', true) . ENTRY_EMAIL_HTML_DISPLAY . '</label>';
$content .= '<br />';
$content .= '<label>' . zen_draw_radio_field('email_format', 'TEXT', false) . ENTRY_EMAIL_TEXT_DISPLAY . '</label>';
}
-Ng_
I have traduced the mod's in italian language. You can take it here
http://www.rigenservice.it/File/news...e_2.0.2ITA.zip
bye
Hi NG,
Is there any way to notify admin when someone subscribes or when they unsubscribe? The original had an add on that allowed this but the new, and definitely improved version, has a totally different header_php and that was the file that needed to be altered.
Original thread: http://www.zen-cart.com/forum/showth...ght=Newsletter
Also, is there any way to not have the customer need to confirm?
Thank you,
Kelly :smile:
Thanks for the link/suggestion.
I'll add it in & do a on/off config setting for it.
-Ng_
Oh, in case anyone is wondering, the wishlist so far is:
Additional query groups for testing newsletters.
Ability to import/export subscribers (so if you want to use zen for subscriptions, but want to use a more flexible newsletter program to actually send them).
Adjust unsubscribe so it will prefill email field when email is sent (user still has to confirm).
Fix the newsletter script itself (occassionally errors out sending large groups) or at least note what emails were sent so manual fixes can avoid duplication.
Add cc to admin email + config. maybe a 'new' list on index page or manager page.
I have installed the newsletter subscribe add on and it's been working well so far but I was trying to create a test account using the install patch. Anyway I was getting a syntax error with my code and clever me (!) with no knowledge of mySQL went into phpmyadmin and deleted the whole query_builder row thinking this would solve my problem but now i'm getting an error message saying:
1146 Table 'wildgard_shop.shop_query_builder' doesn't exist
in:
[select query_name, query_string from shop_query_builder where query_category like '%email%']
So i'm thinking I need to restore this table but how do i do that? HELP PLEASE!
Don't worry about the above. I figured it out on my own. I just had to insert a create table query :$ crisis adverted!
Good to hear you came through it okay.
-Ng_
sorry for the repost. server lag.
Does anyone know where all the emails are stored when a new subscriber subscribes. I mean in the ftp server, is there a particular txt file, etc that logs all the emais down onto 1 sheet.
thanks!
Niele
Hi.... i am using zencart 1.3x and newletter only ....2.2 but i get an sql error when eidting and saving something in the clients information ( admin/customers.php )
Error is:
I have no clue...what is wrong here..Code:1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'confirmed = 1 WHERE customers_id = '2'' at line 4
in:
[UPDATE soemprefix_subscribers SET email_address = '[email protected]', email_format = 'TEXT' confirmed = 1 WHERE customers_id = '2' ]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.
The email template itself is in email/email_template_newsletter_subscription.htmlQuote:
Originally Posted by nielest
The english text for the template is in includeds/languages/english/(your_template)/subscribe.php
There is a comma missing. :(Quote:
Originally Posted by kookiewookie
Edit customers.php at at the end of line 274, add a comma:
The entire query:Code:email_format = '" . $customers_email_format . "', <----
Sorry!Code:$db->Execute("UPDATE " . TABLE_SUBSCRIBERS . "
SET email_address = '" . $customers_email_address . "',
email_format = '" . $customers_email_format . "',
confirmed = 1
WHERE customers_id = '" . (int)$customers_id . "' ");
-Ng_
Thanks for your reply Not Goddess, although i think i've not explained myself clearly enough. Alow me to try once more, i sincerely thank you for your time.Quote:
Originally Posted by NotGoddess
What i wanna know is where the emails from the newsletter subscribers get stored on the ftp server? Like if i enter my email in the subscribe list where does it get written to on the FTP, i ask this in hopes of editing that file to add more emails from an external email set i've accumulated over the years of my clients.
I hope this helps.
thank a million!
Niele
See post 15 in this thread: http://www.zen-cart.com/forum/showpo...0&postcount=15
But since then I've added the confirmation requirement, so you'd follow the same basics, but add a 'confirmed' field so the sql would look like this:
I'm going to get another update out that has import from/export to a file (and the other wishlist items), but it's going to be this weekend (Sunday) at the earliest as I've got to earn gas/food money this week or I'm sunk :0 I'll try to work on it and get it out earlier, but no guarantees.Code:INSERT INTO tbl_name (email_address, confirmed)
VALUES('[email protected]' , 1), ('[email protected]' , 1),
('[email protected]', 1), ('[email protected]' , 1);
-Ng_
how to disable the email confirmation ??
besides, i receeved the confirmation link broken. i had to copy paste it to the address bar..
Regarding the uri in the email, by 'broken' I assume you mean on two lines? Most email programs will still link properly even if they wrap the line, but there's not much I can do about that- there's no way to shorten it.
Regarding turning off the confirmation:
Short answer: you don't - it's there for your security and their peace of mind.
Longer answer:
You would have to edit the header.php file for the subscribe page and comment out the email,
and change the sql query inserting the subscription to have it as '1' instead of the confirmation code,
then edit the language file to remove any mention that a confirmation is sent,
then you'd have to manually confirm each in admin (or run a sql query via the sql patch: update table_subscribers set confirmed = '1'; ) for any existing emails.
You are more than welcome to do this, but I won't make it an on/off option because I get so much spam every day where it says 'well according to our records you signed up for this' and most people feel more secure when they know a company cares that it does not spam (with or without intent to do so).
-Ng_
u know, i liked the short answer more. hahahahaha. thanks for the help
*laugh* anytime.Quote:
Originally Posted by chac416
this is great i can't wait for the next update as i have a list of a few thousand emails i've compiled over the years that i desperately need to put into the auto mailer. thank you so much. Your work is so appreciated. It's people like you that keep us moving forward. Respect.Quote:
Originally Posted by NotGoddess
OEF.. i should have seen that one myself really.Quote:
Originally Posted by NotGoddess
Strnagly enough IT only seems to occur when i am using Group Discount.
when i switched it off all worked well again.
NOW with this small "bugfix" it works wuth Discount Groups activated as well!
thank you NG
I just installed image handler over this mod. Before if I but in an entry that wasn't an email address I would bet an error message, but now that I installed the new image handler mod I am getting a success message no matter what. What files might have been overwrittein with the installation of image handler that could have caused this?
My bad, this is my test site:
http://www.books-japan-online.com/test/
I assume you are using Image Handler 2.0 for v1.3 (Tim Kroeger) ?Quote:
Originally Posted by ctcentralinfo
Taking a quick look I don't see any overlap.
I'll check when I get to my dev machine in a few hours, but I don't see the connect. I have IH2 on a cart and haven't run into issues.
The function that checks for a valid email is:
zen_validate_email() which is in includes/functions/functions_email.php
Are you familiar with using WinMerge or similar file diff utility? If so you can try comparing the contrib to the existing files to see if any has changed.
Pay special attention to the file includes/modules/pages/subscribe/header_php.php as that is where the check is performed.
Unfortunately it's not something I can diagnose from here. :(
-Ng_
[oann- looks like you'll want the sidebox width patch. on my site or outlined in this thread (just need a few spaces or br's before input/submit)]
Quote:
Originally Posted by NotGoddess
I am wondering if this might be the cause of the issues I am having with the mod. I installed a products type mod that Moku created.
He said:
This might be causing the issue instead of image handler.Quote:
You may have to change the default ID for "product_type_id". The default I used
is "7", but please manually check that this ID is not already used on your
"zc_product_types" table!
I have another question, I don't have HTML TEXT-Only in my newsletter subscription sidebox. How do I get those to show up?
I'd advise you to compare these to files:Quote:
Originally Posted by ctcentralinfo
/includes/modules/pages/subscribe/header_php.php
/includes/functions/functions_email.php
and compare them to what is included in the contribution (use WinMerge or your fave diff utility).
The first file does all the validation, and the second has the function (zen_validate_email) that the first calls. Either the function is not being called, or it was changed somewhere.
Something I did notice is that I failed to add a 'default' fallback-ie you go to main_page=subscribe and don't have the post value 'act' set, the email won't get added to the database, but you do get the 'thanks for subscribing' message.
(*bonk*) I will fix this in the next release (out Sunday-ish).
Check your subscription manager to see if they fake emails are actually being added. If they aren't this is most likely the issue (tho if it is then you get to investigate why you suddenly are sending some, but not all post info, since the page is also sent via post).
Check your email settings. The option only shows up if you enable HTML mail in your admin settings (if you choose not to send HTML mail, then it defaults to text).Quote:
Originally Posted by ctcentralinfo
-Ng_
First of all I would like to say you create a great mod. That being said I have know idea why this the function is not being called. These are the files. I used both winmerge and textpad and Nothing seems to be wrong. Here are the files:
includes/modules/pages/subscribe/header_php.php
Quote:
} elseif (zen_validate_email($email_address) == false) {
$error = true;
$messageStack->add('subscribe', ENTRY_EMAIL_ADDRESS_CHECK_ERROR);
} else {
// check if email address exists in CUSTOMERS table or in SUBSCRIBERS table
$check_cust_email_query = "select count(*) as total from " . TABLE_CUSTOMERS .
" where customers_email_address = '" . zen_db_input($email_address) . "'";
$check_cust_email = $db->Execute($check_cust_email_query);
$check_news_email_query = "select count(*) as total from " . TABLE_SUBSCRIBERS .
" where email_address = '" . zen_db_input($email_address) . "'";
$check_news_email = $db->Execute($check_news_email_query);
if ($check_cust_email->fields['total'] > 0) {
$error = true;
$messageStack->add('subscribe', SUBSCRIBE_DUPLICATE_CUSTOMERS_ERROR);
} elseif ($check_news_email->fields['total'] > 0) {
$error = true;
$messageStack->add('subscribe', SUBSCRIBE_DUPLICATE_NEWSONLY_ERROR);
} else {
// we generate a random confirmation code so we can use it as an
// extra security measure to prevent spoofs/scams.
$confirm_code = substr(base64_encode(crypt(str_shuffle(time()))),4,6);
$db->Execute('insert into ' . TABLE_SUBSCRIBERS .
' (email_address, email_format, subscribed_date, confirmed) ' .
"VALUES ('".$email_address."', '".$email_format."', now(), '".$confirm_code."')"
);
// Send confirmation request.
// get the proper uri
$confirm_uri = zen_href_link(FILENAME_SUBSCRIBE_CONFIRM, 'confirm='.$confirm_code.'&email=' . $email_address, 'NONSSL');
// initial welcome
$email_text .= EMAIL_WELCOME;
$html_msg['EMAIL_WELCOME'] = str_replace('\n','',EMAIL_WELCOME);
// add in regular email welcome text
$email_text .= "\n\n" . EMAIL_TEXT . sprintf(EMAIL_CONFIRMATION_TEXT, $confirm_uri ). EMAIL_CONTACT . EMAIL_CLOSURE;
$html_msg['EMAIL_MESSAGE_HTML'] = str_replace('\n','',EMAIL_TEXT );
$html_msg['EMAIL_CONFIRMATION_LINK'] = str_replace('\n','', sprintf(EMAIL_CONFIRMATION_TEXT, '<a href="'.$confirm_uri.'">'.$confirm_uri.'</a>' ));
$html_msg['EMAIL_CONTACT_OWNER'] = str_replace('\n','',EMAIL_CONTACT);
$html_msg['EMAIL_CLOSURE'] = nl2br(EMAIL_CLOSURE);
// include create-account-specific disclaimer
$email_text .= "\n\n" . sprintf(EMAIL_DISCLAIMER_NEW_CUSTOMER, STORE_OWNER_EMAIL_ADDRESS). "\n\n";
$html_msg['EMAIL_DISCLAIMER'] = sprintf(EMAIL_DISCLAIMER_NEW_CUSTOMER, '<a href="mailto:' . STORE_OWNER_EMAIL_ADDRESS . '">'. STORE_OWNER_EMAIL_ADDRESS .' </a>');
// send welcome email
zen_mail($name, $email_address, EMAIL_SUBJECT, $email_text, STORE_NAME, EMAIL_FROM, $html_msg, 'newsletter_subscription');
}
}
}
$breadcrumb->add(NAVBAR_TITLE);
?>
includes/functions/functions_email.php
Quote:
function zen_validate_email($email) {
$valid_address = true;
// fail if contains no @ symbol
if (!strstr($email,'@')) return false;
// split the email address into user and domain parts
// need to update to trap for addresses in the format of "first@last"@someplace.com
// this method will most likely break in that case
list( $user, $domain ) = explode( "@", $email );
$valid_ip_form = '[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}';
$valid_email_pattern = '^[a-z0-9]+[a-z0-9_\.\'\-]*@[a-z0-9]+[a-z0-9\.\-]*\.(([a-z]{2,6})|([0-9]{1,3}))$';
//preg_match('/^([a-zA-Z0-9])+([a-zA-Z0-9\._-])*@([a-zA-Z0-9_-])+(\.[a-zA-Z0-9\._-]+)+$/', $email))
//preg_match('/^[a-z0-9&\'\.\-_\+]+@[a-z0-9\-]+\.([a-z0-9\-]+\.)*?[a-z]+$/is');
$space_check = '[ ]';
// strip beginning and ending quotes, if and only if both present
if( (ereg('^["]', $user) && ereg('["]$', $user)) ){
$user = ereg_replace ( '^["]', '', $user );
$user = ereg_replace ( '["]$', '', $user );
$user = ereg_replace ( $space_check, '', $user ); //spaces in quoted addresses OK per RFC (?)
$email = $user."@".$domain; // contine with stripped quotes for remainder
}
// fail if contains spaces in domain name
if (strstr($domain,' ')) return false;
// if email domain part is an IP address, check each part for a value under 256
if (ereg($valid_ip_form, $domain)) {
$digit = explode( ".", $domain );
for($i=0; $i<4; $i++) {
if ($digit[$i] > 255) {
$valid_address = false;
return $valid_address;
exit;
}
// stop crafty people from using internal IP addresses
if (($digit[0] == 192) || ($digit[0] == 10)) {
$valid_address = false;
return $valid_address;
exit;
}
}
}
if (!ereg($space_check, $email)) { // trap for spaces in
if ( eregi($valid_email_pattern, $email)) { // validate against valid email patterns
$valid_address = true;
} else {
$valid_address = false;
return $valid_address;
exit;
}
}
return $valid_address;
}
?>
okay. do this to confirm if it might be the issue I described above (act='subscribe' post field not passing):
edit the subscribe/header_php.php file:
Comment out line 31 and add if(1) { below it like so:
If it now gives an error about the email, reply back w/ which error.Code:// if (isset($_POST['act']) && ($_POST['act'] == 'subscribe')) {
if(1) {
-Ng_
I just clicked subscribe without adding anything,Quote:
Originally Posted by NotGoddess
This is the error I am getting
Quote:
Is your email address correct? It should contain at least 6 characters. Please try again.
What that indicates is that the 'act' and 'email' etc aren't getting passed at all.
I just noticed that you have 'nice' urls. I'm wondering if the sefu is doing it...
edit the sidebar template and change the 'post' to 'get'
includes/templates/yourTemplate/sideboxes/tpl_subscribe.php ::
You should then see the email/act in the browser address bar.Code:$content .= zen_draw_form('subscribe', zen_href_link(FILENAME_SUBSCRIBE, '', 'SSL'), 'get', '');
-Ng_
You are right, I turned off the sefu urls and changed the files you originally told me to mod back and it started to work fine.Quote:
Originally Posted by NotGoddess
This is the URL I got when I changed 'post' tp 'get'
but I still didn't get the error I wanted.
Hi, I have set up the newsletter subscribe and it seems to be storing the emails correctly which is great! Now I am wanting to send an email newsletter to these subscribers only but the newsletter manager doesn't seem to recognise them, only the customers that have signed up. From what I understand, this isn't possible with the addon and I can only email them individually? or am I missing something?Quote:
Originally Posted by sleepless
You should see two newsletter groups in the newsletter dropdown list:
Customer Account Newsletter Subscribers
and
All Newsletter Subscribers
They should have numbers behind them e.g. (4)
The 'all' list should have a higher number than the customer account list (if you have newsletter only subscribers). That's the one you use to mail to everyone.
fFr anyone using this mod in conjunction with dream-scape's ultimated sefu and Image handler 2 should follow these instructions:
http://www.zen-cart.com/forum/showpo...4&postcount=43
I think something is wrong with mine cos I'm only getting 'All newsletter subscribers' which seems to be pulling from customer database only. Even though I can see Newsletter subscribers in the Subscription Management. Any ideas what might be wrong?Quote:
Originally Posted by NotGoddess
Once again I worked it out on my own! I removed and reinstalled the subscription manager and it's now showing all newsletter subscribersQuote:
Originally Posted by wildgarden
It sounds like the query_builder didn't get updated.
Try putting this in from your sql patches page:
(remember to add your db prefix to the query_builder bit if you have one):
Note that I purposely changed the name of the new query, removing the 'All' bit just in case the query is already in there.Code:UPDATE query_builder SET
query_name='Customer Account Newsletter Subscribers',
query_description='Returns name and email address of newsletter subscribers who have a customer account.'
WHERE query_string='select customers_firstname, customers_lastname, customers_email_address from TABLE_CUSTOMERS where customers_newsletter = \'1\'';
INSERT INTO query_builder
(query_category, query_name, query_description, query_string, query_keys_list)
VALUES ('email,newsletters', 'Newsletter Subscribers',
'Returns name and email address of all Customer Account subscribers and all Newsletter-Only subscribers.',
'select c.customers_firstname, c.customers_lastname, s.email_address as customers_email_address from TABLE_SUBSCRIBERS as s left join TABLE_CUSTOMERS as c on c.customers_id = s.customers_id ', '');
I'm still a few hours out from the next update-doesn't look like I'll make it tonight, so try that solution.
-Ng_
Has anyone noticed that there is a limit to the size of the email address entered in the subscribe box? I counted out to be 30 characters, well I have a customer that has a 31 character email address. so she could not sign up through the subscribe box, in her case she just subscribed when creating her account, but it doesn't solve the problem for newsletter only subscribers with long email addresses.
I'm not quite ready to release the update yet, but it should be in the next couple days.
In the meantime I've added another patch on my site to fix the subscription manager-it wasn't properly saving/setting the email format.
http://notgoddess.com/scripts/newsletter-subscribe (scroll down to 'known issues'..the patch is there).
Thank you to Wildgarden for noticing this.
-Ng_
Just edit the templates to take out the maxlength.Quote:
Originally Posted by barco57
includes/templates/yourtemplate/sideboxes/tpl_subscribe.php
and
includes/templates/yourtemplate/templates/tpl_subscribe_header.php
-Ng_
Thanks for the quick response. I just went in and changed it to 35 characters and I'll wait and see if I have any problems with that.
Hi,
I love your mod it works very well. My only difficulty is cosmetic. I use firefox so didn't notice at first but in IE I was told that the subscribe box is 2x as wide as the the other boxes and sure enough it was. I checked the size in the layout menu and the boxes and columns are all set to 150px so I can't figure out how IE is figureing it scince I there is no specific size reference in the template or mod. Do you have any idea how I might fix this if it is fiaable? Thanks for any help