No-longer-valid shipping method carried through to checkout_success
Running zc157c, using built-in shipping modules and standard 3-page checkout.
Initially, set up the admin's Modules :: Shipping to enable flat, item and storepickup shipping methods as well as the moneyorder payment method (for ease in issue reproduction). Log into a customer's account, add a non-virtual product (i.e. one that needs shipping) to the customer's cart and start the checkout process.
On the checkout_shipping page, choose the Flat/Best Way method and continue to the checkout_payment page. Now, head back to the admin and disable the flat shipping module.
Refresh the page. You'll see that the (no-longer-valid) Flat-rate shipping is still in use. Choose the moneyorder payment method and continue to checkout_confirmation -- the flat-rate shipping is still valid. Click the order-confirmation button and the order's now placed with an invalid shipping method.
This is the easiest way to see this issue. In the real world, it's possible that the shipping-method that the customer chose during the shipping phase of checkout is no longer valid by the time they hit the checkout_confirmation page (or worst, checkout_process). Think "Next Day Air, Early Morning" and the drop-off window with UPS has just expired.
Re: No-longer-valid shipping method carried through to checkout_success
Sounds like another check is needed in
includes/modules/checkout_process.php
to detect this condition.
Re: No-longer-valid shipping method carried through to checkout_success
Quote:
Originally Posted by
swguy
Sounds like another check is needed in
includes/modules/checkout_process.php
to detect this condition.
I'd suggest that checks are needed on all of the post-shipping-selection checkout pages.
Update: Noting, too, that this causes many 'hissy fits' (i.e. PHP notices) to be issued by the ot_shipping.php module on each page for this case.
I'm also remembering a comment from @design75 that indicated that some of the sites he manages have all virtual products so there are no shipping modules enabled.
Re: No-longer-valid shipping method carried through to checkout_success
Quote:
Originally Posted by
lat9
I'd suggest that checks are needed on all of the post-shipping-selection checkout pages.
Update: Noting, too, that this causes many 'hissy fits' (i.e. PHP notices) to be issued by the ot_shipping.php module on each page for this case.
I'm also remembering a comment from @design75 that indicated that some of the sites he manages have all virtual products so there are no shipping modules enabled.
Not even free shipping which I thought I remembered as being a minimum shipping method to be available in such a condition. E.g. Expectation/requirement was that at least one shipping method be enabled.
Re: No-longer-valid shipping method carried through to checkout_success
Quote:
Originally Posted by
mc12345678
Not even free shipping which I thought I remembered as being a minimum shipping method to be available in such a condition. E.g. Expectation/requirement was that at least one shipping method be enabled.
Sorry, I don't understand your comment.
Re: No-longer-valid shipping method carried through to checkout_success
Quote:
Originally Posted by
lat9
Sorry, I don't understand your comment.
In resolution to this issue where the outside world available shipping options (either as the outside world has determined or the store owner has made unavailable) while an individual is in the process of checkout, an issue identified above to "keep in mind" was the way that someone else has claimed that they operate their store. The statement was that in an all virtual product store that *NO* shipping module was enabled. That reads to mean that as a solution is proposed forwards that some consideration should be given to permit/support checkout where literally no shipping module is involved.
I was saying that I thought this expectation would be a completely different approach than has been a central design consideration for the Zen Cart checkout process as it has historically always required at least one shipping module to be enabled. Of course I could be mentally stuck in a very old concept, but I don't recall seeing a "hooray, the software now does not require a shipping module enabled when checking out"... Further to that end I was stating that I thought even in a situation where a store only offered virtual product that the central design (obviously open source where it could be modified) was that free shipping would need to be enabled to support checkout without a shipping charge and therefore would be an enabled shipping module. Having free shipping enabled (as expressed in past ZC instruction) would not align with the statement of having *NO* shipping module enabled...
So much for trying to address an issue with minimal relevant words. :P
On another note, shipping modules are not the only thing affected by such an admin change during checkout. If considering addressing shipping, would think other such items should be considered/addressed but by way of one or more other threads...
