Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
robbie269
I cannot find where I can comment in GITHUB sorry.
Click the "Issues" tab, and if your issue isn't in the list of open issues (or in the list of closed issues, by clicking the Closed tab), then click the New Issue button to create one.
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
robbie269
Testing the new COWOA for v1.5.5 today. I cannot find where I can comment in GITHUB sorry.
One thing I did notice is that the sidebox off option during checkout includes the Logged of page. When I logoff the confirmation page fills half the screen and the rest is white. It has a "broken" look about it and I think the sideboxes should be on for the log off confirmation page as who cares if they go back to browsing.
If you'd prefer the logoff page with sideboxes, edit your \includes\templates\YOUR_TEMPLATE\common\tpl_main_page.php by removing logoff from the following list:
Code:
if (COWOA_SIDEBOX_OFF == 'true') {
if (in_array($current_page_base,explode(",",'no_account,create_account,account,account_password,account_edit,address_book,account_history_info,account_newsletters,account_notifications,account_history,login,logoff,checkout_shipping,checkout_shipping_address,checkout_payment,checkout_payment_address,checkout_confirmation,checkout_process,shopping_cart,address_book_process')) ) {
$flag_disable_right = true;
$flag_disable_left = true;
}
}
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
jeking
If you'd prefer the logoff page with sideboxes, edit your \includes\templates\YOUR_TEMPLATE\common\tpl_main_page.php by removing logoff from the following list:
Code:
if (COWOA_SIDEBOX_OFF == 'true') {
if (in_array($current_page_base,explode(",",'no_account,create_account,account,account_password,account_edit,address_book,account_history_info,account_newsletters,account_notifications,account_history,login,logoff,checkout_shipping,checkout_shipping_address,checkout_payment,checkout_payment_address,checkout_confirmation,checkout_process,shopping_cart,address_book_process')) ) {
$flag_disable_right = true;
$flag_disable_left = true;
}
}
Which is exactly what I was going to state as well..
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
ianhg
Thanks Guys for the links and speedy reply. Happy to test but which GitHub link is the best option?
Thanks.
BIG THANKS really goes to jeking who made up for my lack of free time..
1 Attachment(s)
Re: COWOA Updated and Combined for ZC v1.5.x
I thought we added observers to COWOA! Maybe I missed something...
I've been busy converting mine which is not to bad, has some new interesting code in 1.5.5 that should make things interesting.. With the way COWOA is setup now, it behaves more like a standard account without the customer knowing it.. which leaves more control for admin and leaves many of the normal behaviour of ZC as is.
With this comes other issues such as accessing the account pages when one should not be able to. This issues occurs during checkout when the customer enters shipping/billing addresses and then email address. Once the checkout processes receives an email address, the session now has a customer ID.. If the customer drops the cart and does something else, like hard enters the url for the account pages, they then have access to areas they shouldn't get to as guests. The observer should catch that and redirect them back to the login page. Also at this time, the dropped cart is saved in the database. When the same email address is used again during checkout the saved cart is retrieved and then added to the new cart... normal for standard accounts, not for guest. another observer to catch and delete saved carts during the checkout process for COWOA accounts only..
Testing with COWOA v2.7 on a clean install of ZC 1.5.5 using the responsive template.
Attaching the observer and loader used in ZC 1.5.4 and 1.5.5 and COWOA 2.4 - 2.7 for testing.
Re: COWOA Updated and Combined for ZC v1.5.x
Hi
I'm seeing that lines 69-86 of index_dashboard.php have a misspelling for the "class=right", such as :
Code:
echo '<div class="row"><span class="left">' . BOX_ENTRY_COUNTER_DATE . '</span><span class="rigth"> ' . $counter_startdate_formatted . '</span></div>';
The code seems to have been corrected at least once and then reverted to "class="rigth" (commit: c4a35894a14d371c65ef90c13df1adba2016db38). I've searched the latest version of both v155 and COWOA 2.6/7 on github and can find definitions in many places (e.g. stylesheet.css) and usages for class="right" but class="rigth" appears only in index_dashboard.php and has no corresponding definition anywhere.
So, maybe another attempt to correct the spelling is in order?
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
davewest
I thought we added observers to COWOA! Maybe I missed something...
I've been busy converting mine which is not to bad, has some new interesting code in 1.5.5 that should make things interesting.. With the way COWOA is setup now, it behaves more like a standard account without the customer knowing it.. which leaves more control for admin and leaves many of the normal behaviour of ZC as is.
With this comes other issues such as accessing the account pages when one should not be able to. This issues occurs during checkout when the customer enters shipping/billing addresses and then email address. Once the checkout processes receives an email address, the session now has a customer ID.. If the customer drops the cart and does something else, like hard enters the url for the account pages, they then have access to areas they shouldn't get to as guests. The observer should catch that and redirect them back to the login page. Also at this time, the dropped cart is saved in the database. When the same email address is used again during checkout the saved cart is retrieved and then added to the new cart... normal for standard accounts, not for guest. another observer to catch and delete saved carts during the checkout process for COWOA accounts only..
Testing with COWOA v2.7 on a clean install of ZC 1.5.5 using the responsive template.
Attaching the observer and loader used in ZC 1.5.4 and 1.5.5 and COWOA 2.4 - 2.7 for testing.
Pushed to master in Github.
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
DivaVocals
Merged your PR this morning to my master repo. (
https://github.com/DivaVocals/zen_COWOA) Made a few minor changes to both the v2.6 and 2.7 versions as well:
- Apply the usability updates present in COWOA v2.6 to v2.7 (changes to template and language files)
- MINOR updates to v2.6
This all needs to be tested.. I would LOVE to submit this puppy to the downloads, but before I will submit it I REALLY need the community to install it.. test it and provide REAL feedback so I know it that this has been thoroughly tested.
Diva and others. I've installed and tested this on 1.5.5 (minus the changes mentioned and and not seen any issues). I'll download the merged copy and see what's changed since I sent Jim my updates.
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
lucidlee
Hi
I'm seeing that lines 69-86 of index_dashboard.php have a misspelling for the "class=right", such as :
Code:
echo '<div class="row"><span class="left">' . BOX_ENTRY_COUNTER_DATE . '</span><span class="rigth"> ' . $counter_startdate_formatted . '</span></div>';
The code seems to have been corrected at least once and then reverted to "class="rigth" (commit: c4a35894a14d371c65ef90c13df1adba2016db38). I've searched the latest version of both v155 and COWOA 2.6/7 on github and can find definitions in many places (e.g. stylesheet.css) and usages for class="right" but class="rigth" appears only in index_dashboard.php and has no corresponding definition anywhere.
So, maybe another attempt to correct the spelling is in order?
The mispelling of this class has been present in Zen Cart going back to at least v1.3.8 or v1.3.9. I corrected it in COWOA because it simply drove me NUTS..:laugh: Looks like I missed correcting it in the new v1.5.5 index_dashboard.php file. I just submitted a pull request to the repo to make this correction. Please download and confirm.
Also I want to make some additional updates to index_dashboard.php to pull the search form out of the table it's nested in. Forms inside of tables is invalid HTML, and I made similar corrections to the index.php file in the v1.5.4 compatible version of COWOA.
Re: COWOA Updated and Combined for ZC v1.5.x
Quote:
Originally Posted by
DivaVocals
Also I want to make some additional updates to index_dashboard.php to pull the search form out of the table it's nested in. Forms inside of tables is invalid HTML, and I made similar corrections to the index.php file in the v1.5.4 compatible version of COWOA.
Sorry I meant to say orders.php. I want to move the search form out of the table as was done in the v1.5.4 compatible version of COWOA.