shipping tax calculation error after upgrade to v155

Hi,

I just recently completed an upgrade for a client from v.1.5.4 to 1.5.5a. Everything seems totally fine except a weird little problem that I can't seem to track down. The problem is that tax should be calculated including the shipping cost but upon final checkout, the tax doesn't include this. The correct amount of tax shows during the checkout process but not at the final confirmation and not the amount that actually gets recorded with the order (charged to PayPal or Auth.net). Here's an example:

I place an item for $100 in my cart and begin checkout.
I select a shipping address to which sales tax applies.
order totals show as:

item - $100
shipping - $10.95
tax - $9.85 [tax rate is 8.875%]

This same total appears throughout the checkout steps until the final order review step. Then when I click the button to confirm, suddenly the tax recalculates and only shows and charges $8.88 which does not include the shipping.

I don't know if this is a bug in this version or if it's a stray line of code that got lost or changed when I copied modifications during the upgrade. I didn't have any modifications to this particular functionality in the previous version and the tax definitely calculated correctly pre-upgrade. Maybe someone can point me to which file and where I should look for the cause of the problem.

Thanks in advance!

See https://www.zen-cart.com/showthread....61#post1312461

https://github.com/zencart/zencart/pull/1034

Thanks Dr. Byte. I'll give that a try and see if it solves the problem. I suspect it will since my problem seems to match very closely (or even completely) to the those described in that thread.

Just confirming that yes, moving the one line of code suggested by Dr, Byte solved the problem. :):clap: