Re: Winchester Responsive
Nice. Love the quick setup. Glitches seen have been minimal. I really don't know how you do it, given all the possible combinations of hardware & browsers. Still working through the setup instructions but a few hiccups that I noticed below:
Catalog Category Buttons which are functional @ max desktop width are non-functional as shown in the screenprint below. I had expected the non-functional button to yield the same result as the teeny down arrow.
Attachment 14035
Alignment of DETAILS button on product pages a tad off.
Attachment 14036
Custom Left Slide out works on desktop but not functional on landscape tablet (Samsung 8" Galaxy Tab3). Can the double-arrow button be turned off, disabled or removed? It does disappear on Portrait tablet, probably as designed.
Down for Maintenance notification bar has an effect on alignment.
Re: Winchester Responsive
Fix for the contact us subject line. Back up your includes/modules/pages/contact_us/header_php.php file. Then replace it with this one:
Code:
<?php
/**
* Contact Us Page
*
* @package page
* @copyright Copyright 2003-2012 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version GIT: $Id: Author: DrByte Sat Jul 21 16:05:31 2012 -0400 Modified in v1.5.1 $
* Updated Contact Us Subject for v1.5.1 by Judy Gunderson (stellarweb) 2013-08-16
*/
// This should be first line of the script:
$zco_notifier->notify('NOTIFY_HEADER_START_CONTACT_US');
require(DIR_WS_MODULES . zen_get_module_directory('require_languages.php'));
$error = false;
if (isset($_GET['action']) && ($_GET['action'] == 'send')) {
$name = zen_db_prepare_input($_POST['contactname']);
$email_address = zen_db_prepare_input($_POST['email']);
$subject = zen_db_prepare_input($_POST['subject']);
$enquiry = zen_db_prepare_input(strip_tags($_POST['enquiry']));
$antiSpam = isset($_POST['should_be_empty']) ? zen_db_prepare_input($_POST['should_be_empty']) : '';
$zco_notifier->notify('NOTIFY_CONTACT_US_CAPTCHA_CHECK');
$zc_validate_email = zen_validate_email($email_address);
if ($zc_validate_email and !empty($enquiry) and !empty($name) and !empty($subject) && $error == FALSE) {
// if anti-spam is not triggered, prepare and send email:
if ($antiSpam != '') {
$zco_notifier->notify('NOTIFY_SPAM_DETECTED_USING_CONTACT_US');
} elseif ($antiSpam == '') {
// auto complete when logged in
if($_SESSION['customer_id']) {
$sql = "SELECT customers_id, customers_firstname, customers_lastname, customers_password, customers_email_address, customers_default_address_id
FROM " . TABLE_CUSTOMERS . "
WHERE customers_id = :customersID";
$sql = $db->bindVars($sql, ':customersID', $_SESSION['customer_id'], 'integer');
$check_customer = $db->Execute($sql);
$customer_email= $check_customer->fields['customers_email_address'];
$customer_name= $check_customer->fields['customers_firstname'] . ' ' . $check_customer->fields['customers_lastname'];
} else {
$customer_email = NOT_LOGGED_IN_TEXT;
$customer_name = NOT_LOGGED_IN_TEXT;
}
// use contact us dropdown if defined
if (CONTACT_US_LIST !=''){
$send_to_array=explode("," ,CONTACT_US_LIST);
preg_match('/\<[^>]+\>/', $send_to_array[$_POST['send_to']], $send_email_array);
$send_to_email= preg_replace ("/>/", "", $send_email_array[0]);
$send_to_email= trim(preg_replace("/</", "", $send_to_email));
$send_to_name = trim(preg_replace('/\<[^*]*/', '', $send_to_array[$_POST['send_to']]));
} else { //otherwise default to EMAIL_FROM and store name
$send_to_email = trim(EMAIL_FROM);
$send_to_name = trim(STORE_NAME);
}
// Prepare extra-info details
$extra_info = email_collect_extra_info($name, $email_address, $customer_name, $customer_email);
// Prepare Text-only portion of message
$text_message = OFFICE_FROM . "\t" . $name . "\n" .
OFFICE_EMAIL . "\t" . $email_address . "\n\n" .
'------------------------------------------------------' . "\n\n" .
strip_tags($_POST['enquiry']) . "\n\n" .
'------------------------------------------------------' . "\n\n" .
$extra_info['TEXT'];
// Prepare HTML-portion of message
$html_msg['EMAIL_MESSAGE_HTML'] = strip_tags($_POST['enquiry']);
$html_msg['CONTACT_US_OFFICE_FROM'] = OFFICE_FROM . ' ' . $name . '<br />' . OFFICE_EMAIL . '(' . $email_address . ')';
$html_msg['EXTRA_INFO'] = $extra_info['HTML'];
// Send message
zen_mail($send_to_name, $send_to_email, $subject, $text_message, $name, $email_address, $html_msg,'contact_us');
}
zen_redirect(zen_href_link(FILENAME_CONTACT_US, 'action=success'));
} else {
$error = true;
if (empty($name)) {
$messageStack->add('contact', ENTRY_EMAIL_NAME_CHECK_ERROR);
}
if (empty($subject)) {
$messageStack->add('contact', ENTRY_EMAIL_SUBJECT_CHECK_ERROR);
}
if ($zc_validate_email == false) {
$messageStack->add('contact', ENTRY_EMAIL_ADDRESS_CHECK_ERROR);
}
if (empty($enquiry)) {
$messageStack->add('contact', ENTRY_EMAIL_CONTENT_CHECK_ERROR);
}
}
} // end action==send
// default email and name if customer is logged in
if($_SESSION['customer_id']) {
$sql = "SELECT customers_id, customers_firstname, customers_lastname, customers_password, customers_email_address, customers_default_address_id
FROM " . TABLE_CUSTOMERS . "
WHERE customers_id = :customersID";
$sql = $db->bindVars($sql, ':customersID', $_SESSION['customer_id'], 'integer');
$check_customer = $db->Execute($sql);
$email_address = $check_customer->fields['customers_email_address'];
$name= $check_customer->fields['customers_firstname'] . ' ' . $check_customer->fields['customers_lastname'];
}
$send_to_array = array();
if (CONTACT_US_LIST !=''){
foreach(explode(",", CONTACT_US_LIST) as $k => $v) {
$send_to_array[] = array('id' => $k, 'text' => preg_replace('/\<[^*]*/', '', $v));
}
}
// include template specific file name defines
$define_page = zen_get_file_directory(DIR_WS_LANGUAGES . $_SESSION['language'] . '/html_includes/', FILENAME_DEFINE_CONTACT_US, 'false');
$breadcrumb->add(NAVBAR_TITLE);
// This should be the last line of the script:
$zco_notifier->notify('NOTIFY_HEADER_END_CONTACT_US');
Thanks,
Anne
Re: Winchester Responsive
Quote:
Originally Posted by
RixStix
Nice. Love the quick setup. Glitches seen have been minimal. I really don't know how you do it, given all the possible combinations of hardware & browsers. Still working through the setup instructions but a few hiccups that I noticed below:
Catalog Category Buttons which are functional @ max desktop width are non-functional as shown in the screenprint below. I had expected the non-functional button to yield the same result as the teeny down arrow.
Attachment 14035
Alignment of DETAILS button on product pages a tad off.
Attachment 14036
Custom Left Slide out works on desktop but not functional on landscape tablet (Samsung 8" Galaxy Tab3). Can the double-arrow button be turned off, disabled or removed? It does disappear on Portrait tablet, probably as designed.
Down for Maintenance notification bar has an effect on alignment.
Thanks for pointing out the menu. It looks like this is a feature of the menu since it is also behaving this way on the demo:
http://adnantopal.github.io/slimmenu/
Thank you so much for your feedback :)
I see how it is confusing. I will try out some other responsive menus ;)
To fix the details button in includes/modules/winchester_responsive/product_listing.php change this:
Code:
if (zen_has_product_attributes($listing->fields['products_id']) or PRODUCT_LIST_PRICE_BUY_NOW == '0') {
$lc_button = '<a href="' . zen_href_link(zen_get_info_page($listing->fields['products_id']), 'cPath=' . (($_GET['manufacturers_id'] > 0 and $_GET['filter_id']) > 0 ? zen_get_generated_category_path_rev($_GET['filter_id']) : ($_GET['cPath'] > 0 ? $_GET['cPath'] : zen_get_generated_category_path_rev($listing->fields['master_categories_id']))) . '&products_id=' . $listing->fields['products_id']) . '">' . zen_image_button(BUTTON_IMAGE_GOTO_PROD_DETAILS, BUTTON_GOTO_PROD_DETAILS_ALT, 'class="listingBuyNowButton"') . '</a>';
to this:
Code:
if (zen_has_product_attributes($listing->fields['products_id']) or PRODUCT_LIST_PRICE_BUY_NOW == '0') {
$lc_button = '<div class="pl-details"><a href="' . zen_href_link(zen_get_info_page($listing->fields['products_id']), 'cPath=' . (($_GET['manufacturers_id'] > 0 and $_GET['filter_id']) > 0 ? zen_get_generated_category_path_rev($_GET['filter_id']) : ($_GET['cPath'] > 0 ? $_GET['cPath'] : zen_get_generated_category_path_rev($listing->fields['master_categories_id']))) . '&products_id=' . $listing->fields['products_id']) . '">' . zen_image_button(BUTTON_IMAGE_GOTO_PROD_DETAILS, BUTTON_GOTO_PROD_DETAILS_ALT, 'class="listingBuyNowButton"') . '</a></div>';
Then add this to the stylesheet.css file around line 252:
Code:
.pl-details{margin-bottom:0px;}.slide-out-div
If you want to hide the slide out you can add this to the lanscape tablet portion of the responsive_tablets.css file:
Code:
.slide-out-div{display:none;}
I didn't spend any time on the down for maintenance pages. I'll make a note to test them on the next update ;)
Thanks,
Anne
Re: Winchester Responsive
Quote:
Originally Posted by
picaflor-azul
Fix for the contact us subject line. Back up your includes/modules/pages/contact_us/header_php.php file. Then replace it with this one:
Thanks,
Anne
It worked, thanks!
Re: Winchester Responsive
That did the trick. TNX Anne.
Quote:
Originally Posted by
picaflor-azul
To fix the details button in includes/modules/winchester_responsive/product_listing.php change this:
Code:
if (zen_has_product_attributes($listing->fields['products_id']) or PRODUCT_LIST_PRICE_BUY_NOW == '0') {
$lc_button = '<a href="' . zen_href_link(zen_get_info_page($listing->fields['products_id']), 'cPath=' . (($_GET['manufacturers_id'] > 0 and $_GET['filter_id']) > 0 ? zen_get_generated_category_path_rev($_GET['filter_id']) : ($_GET['cPath'] > 0 ? $_GET['cPath'] : zen_get_generated_category_path_rev($listing->fields['master_categories_id']))) . '&products_id=' . $listing->fields['products_id']) . '">' . zen_image_button(BUTTON_IMAGE_GOTO_PROD_DETAILS, BUTTON_GOTO_PROD_DETAILS_ALT, 'class="listingBuyNowButton"') . '</a>';
to this:
Code:
if (zen_has_product_attributes($listing->fields['products_id']) or PRODUCT_LIST_PRICE_BUY_NOW == '0') {
$lc_button = '<div class="pl-details"><a href="' . zen_href_link(zen_get_info_page($listing->fields['products_id']), 'cPath=' . (($_GET['manufacturers_id'] > 0 and $_GET['filter_id']) > 0 ? zen_get_generated_category_path_rev($_GET['filter_id']) : ($_GET['cPath'] > 0 ? $_GET['cPath'] : zen_get_generated_category_path_rev($listing->fields['master_categories_id']))) . '&products_id=' . $listing->fields['products_id']) . '">' . zen_image_button(BUTTON_IMAGE_GOTO_PROD_DETAILS, BUTTON_GOTO_PROD_DETAILS_ALT, 'class="listingBuyNowButton"') . '</a></div>';
Then add this to the stylesheet.css file around line 252:
Code:
.pl-details{margin-bottom:0px;}.slide-out-div
Re: Winchester Responsive
I have trouble posting these comments because it always sounds more like a gripe than constructive no matter how much I think about it or how many times I re-type it.
Attachment 14039
Information menu tab => Customer Service & General Info fly out to the right, off-screen on Samsung 8" tablets, landscape mode. Image above is a full, unedited screenprint. Waiting for some 7" and 10" Android tablet time later today.
Why does MSFT have to be so different? There's probably not much you can do about it and I have more checking to do but MSFT touch implementation on the first Windows tablet make the template difficult, at best for functionality. Many buttons which function perfectly with a mouse do nothing on Windows touch devices. Windows Surface RT and Windows Pro tomorrow.
Left side flyout actually opens a Windows right-click menu probably because it is touching the left screen edge and detecting it as a left swipe.
We don't speak Apple.
Re: Winchester Responsive
Quote:
Originally Posted by
RixStix
I have trouble posting these comments because it always sounds more like a gripe than constructive no matter how much I think about it or how many times I re-type it.
Attachment 14039
Information menu tab => Customer Service & General Info fly out to the right, off-screen on Samsung 8" tablets, landscape mode. Image above is a full, unedited screenprint. Waiting for some 7" and 10" Android tablet time later today.
Why does MSFT have to be so different? There's probably not much you can do about it and I have more checking to do but MSFT touch implementation on the first Windows tablet make the template difficult, at best for functionality. Many buttons which function perfectly with a mouse do nothing on Windows touch devices. Windows Surface RT and Windows Pro tomorrow.
Left side flyout actually opens a Windows right-click menu probably because it is touching the left screen edge and detecting it as a left swipe.
We don't speak Apple.
Thank you so much for the feedback. I did not test on any windows tablets.
Thanks,
Anne
1 Attachment(s)
Re: Winchester Responsive
Hi Anne,
Using your demo site, on a desktop pc with a window width around 768px the drop-down menu titles are aligned right - sitting on top pf the drop arrows, as in this image
Attachment 14041
Quote:
Left side flyout actually opens a Windows right-click menu probably because it is touching the left screen edge and detecting it as a left swipe.
On my Windows touch device, 13.3" HP Split x2 1366 x 768, the left side flyout does not stay out (pops out and immediately back again). Any subsequent taps on the flyout button do nothing unless the page is refreshed.
Re: Winchester Responsive
Quote:
Originally Posted by
RixStix
Information menu tab => Customer Service & General Info fly out to the right, off-screen on Samsung 8" tablets, landscape mode. Image above is a full, unedited screenprint. Waiting for some 7" and 10" Android tablet time later today.
Why does MSFT have to be so different? There's probably not much you can do about it and I have more checking to do but MSFT touch implementation on the first Windows tablet make the template difficult, at best for functionality. Many buttons which function perfectly with a mouse do nothing on Windows touch devices. Windows Surface RT and Windows Pro tomorrow.
Noticed that this occurs on a Windows desktop (non-touch) on a window width between approx 800px and 950px
Re: Winchester Responsive
Quote:
Originally Posted by
simon1066
Hi Anne,
Using your demo site, on a desktop pc with a window width around 768px the drop-down menu titles are aligned right - sitting on top pf the drop arrows, as in this image
Attachment 14041
On my Windows touch device, 13.3" HP Split x2 1366 x 768, the left side flyout does not stay out (pops out and immediately back again). Any subsequent taps on the flyout button do nothing unless the page is refreshed.
This template is using a php mobile detect script to recognize devices and deliver the appropriate layout to that device. When a device is not detected, which happens on a desktop, or on these windows tablets the fall back responsive_default.css stylesheet is served. I did not spend a lot of time on the responsive_default.css as a large majority of devices will work correctly and have the appropriate layout served to them. If you want to view the tablet layout on a desktop you can use the url:
http://www.zenlyzen.com/responsive-z..._mode=isTablet
and if you want to view the mobile layout on the desktop you can use:
http://www.zenlyzen.com/responsive-z..._mode=isMobile
then you can resize your window to the device width to view portrait or landscape layouts.
Thanks,
Anne