Re: Drop Shipping Purchase Orders Module for v1.3.8
Thanks Diva for merging my changes. One more small PR submitted.
Outstanding items which some nice person might take would be:
a) Adding in the CSRF protections
b) Adding in Input sanitization.
Re: Drop Shipping Purchase Orders Module for v1.3.8
Quote:
Originally Posted by
DivaVocals
If I commented it out (and it's been a while so I don't remember) it would have been because the version of FPDF was too old..
Ahhhhh I see now what I did.. I commented out much of what was in the original module to align the FPDF with the version installed in Super Orders
Re: Drop Shipping Purchase Orders Module for v1.3.8
Quote:
Originally Posted by
swguy
Thanks Diva for merging my changes. One more small PR submitted.
Outstanding items which some nice person might take would be:
a) Adding in the CSRF protections
b) Adding in Input sanitization.
Sure.. Thanks for the much needed update!!! Now that I see what you've done I can LEARN from your code.. :smile:
Making moves to try to remove the TREMENDOUS amount of Polish still in this module.. started with a few functions and many of the comment lines.. there's a LOT more to be done though..
Re: Drop Shipping Purchase Orders Module for v1.3.8
Quote:
Originally Posted by
DivaVocals
Making moves to try to remove the TREMENDOUS amount of Polish still in this module.. started with a few functions and many of the comment lines.. there's a LOT more to be done though..
I agree this is frustrating but this is a much lower priority than the items I mentioned, both of which impact site security.
Re: Drop Shipping Purchase Orders Module for v1.3.8
Quote:
Originally Posted by
swguy
I agree this is frustrating but this is a much lower priority than the items I mentioned, both of which impact site security.
Yes, but I contribute where/when I CAN.. It helps me if I can at least READ the code.. :smile:
Re: Drop Shipping Purchase Orders Module for v1.3.8
Any ideas why Admin: Customers->Orders->Send/Resend POs->View old POs doesn't work?
Re: Drop Shipping Purchase Orders Module for v1.3.8
Just added fixes for this issue.
Re: Drop Shipping Purchase Orders Module for v1.3.8
Many fixes for confirm_track_sub.php submitted.
Re: Drop Shipping Purchase Orders Module for v1.3.8
Yet more fixes submitted! Anxious to hear your feedback on these and how they are working.
Re: Drop Shipping Purchase Orders Module for v1.3.8
And even more fixes. The parms x and y were a bad choice since they were stripped out before login by zen admin. New parms survive login so the supplier can login and go to their order.