Back In Stock Notifications

[conor]

Hi,

Just before line 154 of the admin/includes/functions/

($email_addresses_result->MoveNext();)

You could add the following code:

$num_emails_in_batch++

if ($num_emails_in_batch > 100) {
  $num_emails_in_batch = 0;
  
  sleep(10);
} 

You should also add the following before the while loop on line 65:

$num_emails_in_batch = 0; 

Just good coding practice! :)

I might make this simple functionality an option in the next version with a configurable number of e-mails in a batch and sleep time.

All the best...

Conor
Ceon

[brushwoodnursery]

Conor,
You've been very patient with my persistent badgering about this little detail. Once again, thank you very much!

[brushwoodnursery]

Hmm...got trouble:
Parse error: syntax error, unexpected T_IF in /home/xxxxxx/xxx/xxx/admin/includes/functions/back_in_stock_notifications_functions.php on line 158

do i need the batch counter or can I just try the sleep?

[brushwoodnursery]

I commented out everything but the sleep(10);

I have not entered inventory except a little testing bit. There would be 43 emails sent. At 10 seconds it stalls out and goes to a blank page. At 2 seconds, same thing. At 1 second, it takes just over 43 seconds (guesstimate) to return the successful results of a test mailing. In all 3 cases, the sample email was successfully sent out.

[conor]

Hi,

Hmm...got trouble:
Parse error: syntax error, unexpected T_IF in /home/xxxxxx/xxx/xxx/admin/includes/functions/back_in_stock_notifications_functions.php on line 158

do i need the batch counter or can I just try the sleep?

Oops, there's a missing semicolon after

$num_emails_in_batch++ 

It should be:

$num_emails_in_batch++; 

Sorry! :)

I have not entered inventory except a little testing bit. There would be 43 emails sent. At 10 seconds it stalls out and goes to a blank page. At 2 seconds, same thing. At 1 second, it takes just over 43 seconds (guesstimate) to return the successful results of a test mailing. In all 3 cases, the sample email was successfully sent out.

Sounds like PHP is timing out.

You must have safe mode on, otherwise the script would set the maximum execution time/timeout for PHP to 0 ("Don't time out").

If you don't have access to your server to change the safe_mode setting or the max_execution setting then I'm afraid the sleep() command will be useless for you!

All the best..

Conor

[brushwoodnursery]

Safe Mode is Off.
The notification panel pulls up just fine now.
Test run works fine. There's no delay, though, since it's only 43 emails and they batch up as one.
So, i ran the test with the batch size at 10 and the sleep at 20 seconds. Goes to blank page in just over 1 minute.
maybe it's my database connection?
I've decided to try to run it without the delay. I'll just do it after the phplist newsletter goes out and hope for the best. Looking through the list, most of the serious customers are waiting for multiple items. Also, not all of the items will be restocked at this time. It might be fine.

[conor]

Hi,

So, i ran the test with the batch size at 10 and the sleep at 20 seconds. Goes to blank page in just over 1 minute.
maybe it's my database connection?

Hmm, something's definitely timing out. It could be the DB connection. I'm afraid I don't know enough about this area. If it is the DB connection though then the function would have to be changed to store all of the results and then send the e-mail batches.

I'll try to look at it in the future when I've some time on my hands!

Sorry I can't give a better response than that!

All the best...

Conor

[brushwoodnursery]

OK, you have until August before I begin pestering you again!

Thanks for trying!

[brushwoodnursery]

server delay double post -edited out

[brushwoodnursery]

Conor,
Could your batch script be used to execute only x emails and stop? Would it clean them out properly or would it wipe the entire table clean after the first batch?
I wouldn't mind hanging out with the admin panel for an hour hitting the button 40 times if it meant saving myself from spam purgatory with the likes of aol and others.