Custom serial display help

[DrByte]

Try this:

function getSetial($productID)
  {
  	global $db; 
	$code = 'No serial required for this product. If you do need a serial and did not receive one please contact our staff.';
	$dbres = $db->Execute("SELECT codeID, code FROM zen_codes WHERE viewed = 0 AND itemID = '" . $productID . "' LIMIT 1");
	
	if ($dbres->RecordCount() == 1)
	{
		$code = $dbres->fields['code'];
	
		$db->Execute("UPDATE zen_codes SET viewed = 1 WHERE codeID = " . $dbres->fields['codeID']);
	}
	
	return $code;
  }

It's only slightly different. You don't really need a "while" loop on something that can only ever get maximum of 1 result.
If you *were* using a "while" loop, you'd need to do a MoveNext() inside the loop in order to cycle through the results. But, again, in this case you don't need to use a while loop.

[Zlatko.Lakisic]

still the same result (no serial needed message), its like its not even finding those serials in there....

[Zlatko.Lakisic]

ok i figured out that the problem was with the product ID, its the productID:session thats how it was formatted so i edited the script to look like this:

        global $db; 
    
      $productArray = explode(":", $productID);
    
    $code = 'No serial required for this product. If you do need a serial and did not recieve one please contact our staff.';
    $dbres = $db->Execute("SELECT codeID, code FROM zen_codes WHERE viewed = 0 AND itemID = '" . $productArray[0] . "' LIMIT 1");
    
    $i = 0;
    while($dbres->RecordCount() == 1 && $i < 1)
    {
        $code = $dbres->fields['code'];
    
        $db->Execute("UPDATE zen_codes SET viewed = 1 WHERE codeID = " . $dbres->fields['codeID']);
        $i++;
    }
    
    return $code; 

now that should work because its pulling the number from the array but when i go to check out (the 3rd step) it just keeps loading, no error message or anything, like its on an infinite loop...

but the i should stop it from looping right?

[Zlatko.Lakisic]

ok another edit i got it to work with this:

global $db; 
    
      $productArray = explode(":", $productID);
    
    $code = 'No serial required for this product. If you do need a serial and did not recieve one please contact our staff.';
    $dbres = $db->Execute("SELECT codeID, code FROM zen_codes WHERE viewed = 0 AND itemID = '" . $productArray[0] . "' LIMIT 1");
    
    if($dbres->RecordCount() > 0)
    {
        $i = 0;
        while($i < 1)
        {
            $code = $dbres->fields['code'];
        
            $db->Execute("UPDATE zen_codes SET viewed = 1 WHERE codeID = " . $dbres->fields['codeID']);
            $i++;
        }
    }
    
    return $code; 

but it loads sooo slowly, could it be database performance?

there are only 13095 records in the zen_codes table

[DrByte]

I don't see any need for the $i variable, nor the while loop.
As to performance, I can't speak for how you've optimized your table. You might want to put an index on the fields you're using.