Create popup for button

[miles]

I'm struggling to create a popup window not from a text link but an image button. I want to be able to click on that button and open up a popup window. I have tried this method here but doesn't work for me. Maybe because of 2 reasons.

1- It's a button link not a text link.
2- The button is located in the header tagline which is here includes/languages/english/mytemplate/header.php

Either way, I'm not sure about all that. Just guessing.

The code for my header 'tagline',

// added defines for header alt and text
  define('HEADER_ALT_TEXT', 'Company Logo');
  define('HEADER_SALES_TEXT', '<a href="http://www.mysite.com/gallery.php" target="new"><img alt="button" src="http://www.mysite.com/images/blue_button.jpg"></a>');
  define('HEADER_LOGO_WIDTH', '150px');
  define('HEADER_LOGO_HEIGHT', '100px');
  define('HEADER_LOGO_IMAGE', 'companylogo.gif'); 

So far I tried to change the code to something like this,

define('HEADER_SALES_TEXT', '<a href="javascript:popupWindow('http://www.mysite.com/gallery.php')" target="new"><img alt="button" src="http://www.mysite.com/images/blue_button.jpg"></a>'); 

Tried this also,

define('HEADER_SALES_TEXT', '<a href="javascript:popupWindow(\'http://www.mysite.com/gallery.php\')" target="new"><img alt="button" src="http://www.mysite.com/images/blue_button.jpg"></a>'); 

But still can't seems to work. Can somebody help me on this? Thanks.

[DrByte]

Is the popupWindow javascript function already defined on the page?
What's the URL where it can be seen in action?
Does your browser report any javascript errors when you click on the button?
Why do you have target="new" in there?

[miles]

I have placed this js code in includes/modules/pages/index/jscript_details_popup.php.

<script language="javascript" type="text/javascript"><!-- 
function popupDetails(url) { 
  window.open(url,'newWin','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=yes,resizable=yes,copyhistory=no,width=649,height=404,screenX=150,screenY=150,top=150,left=40') 
} 
--></script> 

I noticed that on other page than the home page, the popup didn't work.

Do I have to include the js code to all pages?

[DrByte]

If you want a particular jscript file to run on every page, it's easiest to put the file into your /includes/templates/YOUR_TEMPLATE/jscript folder (creating it if needed).

Documentation for how the jscript folder overrides work is here: http://www.zen-cart.com/wiki/index.p...s_-_Javascript

If you move the file to the template's jscript folder, don't put that same file in the modules/pages folder, or you'll end up with duplicate javascript on the page, which may give additional errors.

[miles]

Thanks Doc,

That's solve it.