Results 1 to 5 of 5
  1. #1
    Join Date
    Jan 2006
    Posts
    117
    Plugin Contributions
    0

    Default [Not a bug] language define conflict

    The Admin page modules.php has a Switch which, depending on whether you select the Payment, Shipping, etc. modules, the php sets:
    define('HEADING_TITLE', HEADING_TITLE_MODULES_SHIPPING); - or whatever title is relevant.

    However, while an "echo HEADING_TITLE;" right after that line causes the proper title to appear on the page, the actual header spot is incorrect if you have any Extra language definitions which include a define('HEADER_TITLE'...) in them. Right now my Shipping Module/etc. pages have a header title of "Email Address Export for Newsletters".

    IF I delete that extra language file, I end up with "E-mail Archive Manager", etc. for every extra language file with that define in it.

    I'm not sure why this occurs, but that's the only page I've noticed it on so far. I assume it has to do with the HEADER_TITLE being defined in the module.php file, rather than a separate langage file like most other Admin pages, but I'm not sure why, after it is defined in the header (and my echo properly shows the right title), it then resets to the external definition in the body.

  2. #2
    Join Date
    Jan 2004
    Posts
    66,443
    Plugin Contributions
    279

    Default Re: Not crucial, but a bug, it seems.

    That's not a bug. That's just the way things work.
    If you don't want things to load out of order, put your language files in the appropriate folders ... noting that the extra_definitions folder's files *all* get loaded, hence impacting the order.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #3
    Join Date
    Jan 2006
    Posts
    117
    Plugin Contributions
    0

    Default Re: Not crucial, but a bug, it seems.

    So you're saying that extra_definitions is not where definitions for extra pages should go? (bearing in mind that I just put the files where the add-ons/plugins had them).

    Is this different than extra_configures, extra_datafiles, extra_functions, and extra_boxes? Or should those files be somewhere else as well? Thanks

  4. #4
    Join Date
    Jan 2004
    Posts
    66,443
    Plugin Contributions
    279

    Default Re: Not crucial, but a bug, it seems.

    If you're referring to the Email Address Exporter mod, it doesn't tell you to put anything into an "extra_definitions" folder. The language file for that mod goes directly into the language folder, exactly as it's included in the zip.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  5. #5
    Join Date
    Jan 2006
    Posts
    117
    Plugin Contributions
    0

    Default Re: [Not a bug] language define conflict

    I appologize for my own error. I guess when I installed these plugins, having seen so many other plugins put files in that folder (legitimately, I assume? I'm not sure), I got into the assumption that the folder was simply there for organization purposes (as a place for add-on files to keep them separate from core files), such as the custom template folders on the front-end side. I must have thus put a those three languages files (as it turns out, only three) in that folder, assuming the designer of the plugin simply chose not to use the folder for organization.

    My bad, thanks for taking the time to clear up my mistake :)

 

 

Similar Threads

  1. Replies: 3
    Last Post: 13 Oct 2010, 10:53 PM
  2. [Not a bug] Language overwrite bug?
    By yellow1912 in forum Bug Reports
    Replies: 2
    Last Post: 23 Jan 2008, 01:00 PM
  3. [not a bug] Define Pages Editor Error
    By netforce in forum Bug Reports
    Replies: 1
    Last Post: 10 Mar 2007, 03:23 AM
  4. Replies: 4
    Last Post: 28 Oct 2006, 12:05 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg