[Done 1.4.0] typo "determin" (1.3.8a)

[thunderrabbit]

HI all,

I'm setting up for the first time, so I may not know all the terminology yet, but

In admin, under Shipping Modules -> Per Unit, the descriptive text says, in part, "The shipping cost will be used to determin shipping charges"

As far as I know, "determin" should be "determine"

Thanks!
- Rob

[thunderrabbit]

I thought the fix would be an easy template change, but I was wrong.

The file to be fixed is ./includes/modules/shipping/perweightunit.php

Just search for "determin" and add an e. It's in the middle of SQL commands to populate the table, so just this code fix will not fix it in people's installations. Fixing the entry in the DB tables is beyond the scope of this bug report. ;-)

For the record, there are some occurrences of "determin" in comments in other files. For those files, here is the result of my grep (including line numbers for your spell-correction pleasure):

./includes/functions/functions_prices.php:803:// this gets the discount amount this does not determin when to apply the discount
./includes/functions/functions_prices.php:895:// this gets the discount amount this does not determin when to apply the discount
./includes/functions/functions_lookups.php:233: // don't include READONLY attributes to determin if attributes must be selected to add to cart
./admin/includes/functions/general.php:1832: // don't include READONLY attributes to determin if attributes must be selected to add to cart
./admin/includes/functions/functions_prices.php:783:// this gets the discount amount this does not determin when to apply the discount
./admin/includes/functions/functions_prices.php:875:// this gets the discount amount this does not determin when to apply the discount

[DrByte]

The minor typo in the 'comments' you quoted is essentially trivial.
Fixing the one in the shipping module requires editing the file, then uninstallling and reinstalling the module. You might want to write down all your settings for that module before removing and re-installing.

[thunderrabbit]

Thanks for fixing it in 1.4.0! I just corrected the code and then edited the DB record with PHPmySQL.

Thanks
- Rob!

--
Now how do we close this ticket??
[ BOOM!!! ]
Nope, that's not it!