Gift Certificates causing fatal error when applying a coupon to them

[jrstaatsiii]

We were testing to see that our coupon code would work, and when applying it to a gift certificate, and after entering all CC info and advancing from step 2 to step 3 it brings up this fatal error:

Warning: Division by zero in /mnt/target02/342199/342988/www.fleurdepup.com/web/content/includes/modules/order_total/ot_coupon.php on line 364

within the screen. The site is not totally broken, but the font sizes get huge, and this bit of fatal error code is displayed in the header as well as in the body above the subtotal.

if you click on confirm anyway, you are brought to an error screen that says the same fatal error from above twice and then this:

Warning: Cannot modify header information - header already sent by (output started at /mnt/target02/342199/342988/www.fleurdepup.com/web/content/includes/modules/order_total/ot_coupon.php:364)
in (/mnt/target02/342199/342988/www.fleurdepup.com/web/content/includes/functions/functions_general.php on line 44

However when we apply the same coupon code to a product other than the gift certificate, the coupon code works as expected.

What could the problem be?

Rich

[Kim]

Well - first - Gift Certificates are set up so that you cannot apply discounts to them ...

[jrstaatsiii]

are you saying that by default they wont except them? Because when you are in the process of purchasing one, (step 2) there is an option field to insert a coupon code. And when you do so, it returns that error

Any further thoughts.

BTW. Thank you so much for that quick reply!

Rich

[jrstaatsiii]

Should we consider this a bug?

[wilt]

There is a bug in the coupon code, which was posted elsewhere. This generates the division by zero error, and is not just related to use with Gift Vouchers.

You can fix that by changing the line in question (line 364) from

$ratioTax = $adjustedTax/$order->info['tax']; 

to

$ratioTax = (isset($order->info['tax']) && $order->info['tax'] != 0) ? $adjustedTax/$order->info['tax'] : 0; 

in includes/modules/order_totals/ot_coupon.php

However as Kim noted, their is logic in place to disallow Gift Vouchers from the order total that Coupons are applied against.

[coolscrapbook]

Thank you so much for this fix. It worked. Don't know what side effect it will have on gift certificates, but at least for me, I have the gift cert feature turned off...and now it's all back in order.