Free Gifts-Dangling Carrot support

[lankeeyankee]

Are you using this module on your live site?

I was about to until you pointed out that bug with customer cart/guest cart merging!

[twdhosting]

I've managed to integrate this cool looking mod into an already heavily modified zencart install - the frontend seems to be working flawlessly BUT the admin side is whacked...

I can make a product "a carrot" from the individual listings but when I go to catalog> Free Gifts - I don't see the list of assigned free gifts, I only get the "Add a new free gift" drop down box. So I can add new free gifts but cannot delete / edit existing ones?

Any ideas as I have checked and double cheked that I have integrated every line of code and re uploaded the gift_add.php file in the admin root

I am running 1.3.8a

[lankeeyankee]

I've managed to integrate this cool looking mod into an already heavily modified zencart install - the frontend seems to be working flawlessly BUT the admin side is whacked...

I can make a product "a carrot" from the individual listings but when I go to catalog> Free Gifts - I don't see the list of assigned free gifts, I only get the "Add a new free gift" drop down box. So I can add new free gifts but cannot delete / edit existing ones?

Any ideas as I have checked and double cheked that I have integrated every line of code and re uploaded the gift_add.php file in the admin root

I am running 1.3.8a

Did you delete the sql line from add_gift.php on line 107 and 108? Not the whole line, just

pd.language_id = '".$languages_id."'
AND 

If you didn't, try deleting that and see if it fixes it. If you already have deleted it, put it back in and see if that works. This is a known problem and I am going to work on a permanent solution for it.

Let me know if that works and what you did to get it to work.

[strelitzia]

This isn't an issue that was found in earlier versions of the port.

Lankeeyankee, i will compare earlier versions of this file to see if the error was introduced somehow during file modification.

I've been checking through the zip you sent me and there are a few files that are older versions. I am now updating these to current versions which may well fix some of the issues still present. Hopefully i will have this done tomorrow and i'll do some more testing on it.

Regards
Steve

[Fireflyz]

I'm having an issue with blank page. Here is the scenario when the problem happens:

Customer adds 2 items to the cart, one above the price limit for gift and one below. Then adds the free gift.

Customer try to removes the item above the price limit. That's when the page loads half blank.

I did a debug and this is what I get:


PHP Warning: Missing argument 2 for currencies::display_price(), called in ..../includes/languages/english/extra_definitions/My_Template/free_gifts.php on line 28 (and line 29) and defined in /includes/classes/currencies.php on line 99


Anyone has an idea what is wrong?

Thanks!

[paul3648]

I'm having an issue with blank page. Here is the scenario when the problem happens:

Customer adds 2 items to the cart, one above the price limit for gift and one below. Then adds the free gift.

Customer try to removes the item above the price limit. That's when the page loads half blank.

I can't duplicate this on 1.38a, using compare/merge method to install this module.

[Fireflyz]

I'm having an issue with blank page. Here is the scenario when the problem happens:
.......

Here are the codes mentioned in debug:

lines 28 and 29 on free_gifts.php

define('TEXT_FREE_GIFT', 'Free gift with ' . $currencies->display_price($product_gift->fields['threshold']) . ' purchase.');
define('TEXT_DISCOUNT_GIFT', 'Only ' . $currencies->display_price($gift->fields['products_price'], zen_get_tax_rate($gift->fields['products_tax_class_id'])) . ' with ' . $currencies->display_price($product_gift->fields['threshold']) . ' purchase.');

And here is line 99 on currencies.php:

function display_price($products_price, $products_tax, $quantity = 1) {
    return $this->format(zen_add_tax($products_price, $products_tax) * $quantity);

I'll take any help I can get.. throw me a bone!

[strelitzia]

Fireflyz,

I have noticed this bug in testing of the newest version, as well as a bug that causes a blank page if you remove items from the cart and leave the free gift in, which then causes a partially blank page to load. I am looking for a solution to the problem at the moment. Lankeeyankee may be able to offer some further help as he's done quite a bit of work on this mod whilst i've been unavailable.

Sorry I can't be any more helpful at the moment.

Regards
Steve