Free Gifts-Dangling Carrot support

[lankeeyankee]

I've managed to integrate this cool looking mod into an already heavily modified zencart install - the frontend seems to be working flawlessly BUT the admin side is whacked...

I can make a product "a carrot" from the individual listings but when I go to catalog> Free Gifts - I don't see the list of assigned free gifts, I only get the "Add a new free gift" drop down box. So I can add new free gifts but cannot delete / edit existing ones?

Any ideas as I have checked and double cheked that I have integrated every line of code and re uploaded the gift_add.php file in the admin root

I am running 1.3.8a

Did you delete the sql line from add_gift.php on line 107 and 108? Not the whole line, just

pd.language_id = '".$languages_id."'
AND 

If you didn't, try deleting that and see if it fixes it. If you already have deleted it, put it back in and see if that works. This is a known problem and I am going to work on a permanent solution for it.

Let me know if that works and what you did to get it to work.

[strelitzia]

This isn't an issue that was found in earlier versions of the port.

Lankeeyankee, i will compare earlier versions of this file to see if the error was introduced somehow during file modification.

I've been checking through the zip you sent me and there are a few files that are older versions. I am now updating these to current versions which may well fix some of the issues still present. Hopefully i will have this done tomorrow and i'll do some more testing on it.

Regards
Steve

[Fireflyz]

I'm having an issue with blank page. Here is the scenario when the problem happens:

Customer adds 2 items to the cart, one above the price limit for gift and one below. Then adds the free gift.

Customer try to removes the item above the price limit. That's when the page loads half blank.

I did a debug and this is what I get:


PHP Warning: Missing argument 2 for currencies::display_price(), called in ..../includes/languages/english/extra_definitions/My_Template/free_gifts.php on line 28 (and line 29) and defined in /includes/classes/currencies.php on line 99


Anyone has an idea what is wrong?

Thanks!

[paul3648]

I'm having an issue with blank page. Here is the scenario when the problem happens:

Customer adds 2 items to the cart, one above the price limit for gift and one below. Then adds the free gift.

Customer try to removes the item above the price limit. That's when the page loads half blank.

I can't duplicate this on 1.38a, using compare/merge method to install this module.

[Fireflyz]

I'm having an issue with blank page. Here is the scenario when the problem happens:
.......

Here are the codes mentioned in debug:

lines 28 and 29 on free_gifts.php

define('TEXT_FREE_GIFT', 'Free gift with ' . $currencies->display_price($product_gift->fields['threshold']) . ' purchase.');
define('TEXT_DISCOUNT_GIFT', 'Only ' . $currencies->display_price($gift->fields['products_price'], zen_get_tax_rate($gift->fields['products_tax_class_id'])) . ' with ' . $currencies->display_price($product_gift->fields['threshold']) . ' purchase.');

And here is line 99 on currencies.php:

function display_price($products_price, $products_tax, $quantity = 1) {
    return $this->format(zen_add_tax($products_price, $products_tax) * $quantity);

I'll take any help I can get.. throw me a bone!

[strelitzia]

Fireflyz,

I have noticed this bug in testing of the newest version, as well as a bug that causes a blank page if you remove items from the cart and leave the free gift in, which then causes a partially blank page to load. I am looking for a solution to the problem at the moment. Lankeeyankee may be able to offer some further help as he's done quite a bit of work on this mod whilst i've been unavailable.

Sorry I can't be any more helpful at the moment.

Regards
Steve

[Fireflyz]

Fireflyz,

I have noticed this bug in testing of the newest version, as well ....

Thanks, for the reply Steve! I understand. You have already done a lot and I'm grateful for it. Hopefully someone will find a solution soon.

Have a nice holiday!
James

[Tapper]

Thank you for this mod!! It's just lovely.

Except for one thing: my products and shopping cart take much, much longer to load than before. I had to run the SQL a few times to get it to insert properly. My tables do have the zen prefix but I got errors when I ran it with the prefix so I had to do it without. This is a new site that's being hosted on GoDaddy. I know, I know, they're horrible for zen but that's where my client's acct is so I don't have an option.

Anyway, is there a way for me to troubleshoot this lag? I'd really like to use this on a live site but if it kills the product display I can't.

Thanks

[lankeeyankee]

I can't replicate this error in 1.3.8a or 1.3.7.1. If you remove the item that is above the threshold and they have a gift in the cart, both the above threshold item and the gift are removed, and there is no blank area.

There is no way for the gift to be left in the cart with the modifications that I have done. I have just checked it with 1 item in cart above threshold and gift added, remove item and gift is automatically removed; 2 items in cart, 1 above and 1 below threshold, add gift, remove above threshold item and gift is automatically removed; add 1 item to cart, change quantity to get above threshold, add gift, change quantity below threshold and gift is automatically removed.

There is no way that only the gift can be left in the cart, so there must be an error in the installation/merging and not in the code.

There must be an error somewhere with your comparing and merging if you have followed my directions. This sounds like one of the bugs that is present in the current version in the downloads, the one I submitted hasn't been published yet. I would suggest to look through the files that you have compared/merged to find the error, you cannot simply use the files that are in the downloads section but must compare and merge until the latest version is published.

[Fireflyz]

I can't replicate this error in 1.3.8a ...
.. There is no way for the gift to be left in the cart with the modifications that I have done.

Lankeeyankee,
Thanks for the reply. The gift doesn't stay in the cart. Well, it is hard to tell when the page section showing the cart is blank. However, when I reload the page (click refresh on browser), the page loads completely and the gift is removed.

Most people freak out and don't like to click refresh when in a cart.

I installed this on 1.3.7 first and didn't do much after I upgraded to 1.3.8a. I guess I just wait for your version to show up in the download section and reinstall this mod.

Thanks again!
James