I think that the local taxes are not applied for store pickup orders. When notify_order_cart_external_tax_rate_lookup() is called, $taxZoneId is the shipping address zone_id, not the store's zone_id. I do have "Store Pickup Tax Basis" in the local sales tax config set to the zone of the store.
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
I have posted a possible fix in the repo for this plugin's Issues section.
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
v3.0.1 of "Local Sales Tax" is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=422
This release contains changes associated with these GitHub issues:
#5: Include state's base tax-rate in the local sales tax.
#6: Correct previous plugin removal; the base admin tool's name was local_sales_taxes.php.
#8: Incorrect tax-rate charged for storepickup orders.
v3.0.2 of "Local Sales Tax" is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=422
This version "really" corrects the calculation for storepickup orders (thanks @proseLA for the update).
Before I make a suggestion, the "state" sales tax is supposed to be added into the shipping tax rate, correct?
What I noticed is the regions tax isn't applied or added into the shipping tax rate? I have a way to fix but I wanted to be sure that was intended or not before I push something through.
But that's what I mean, my shipping method has the tax class set and it calculates the local sales tax portion... but for some reason the state sales tax isn't added on.
For example, say a shipping method sent to NYC was $1.00. State tax is 4% and local (NYC) tax is 4.875%. I can see that the tax rate of 4.875% is set but for some reason, the state tax isn't. If I disable the local sales tax module, it's the inverse (the state tax of 4% would apply). But it should be both.