Quote Originally Posted by rued View Post
Just got time to test your module Philip, excellent work - well done. :)

But a few issues is there in it:

define for FILENAME_WORLDPAY is missing in admin, causing the file not to be found.
The only solution for this one is to sort out a language for your own admin installation, as previously mentioned, there is a define for FILENAME_WORLDPAY in ./admin/includes/languages/english/worldpay_response.php so it's a matter of creating the folder and copying the file across, tell me and translate anything and I'll put an admin language file in the next release.

Quote Originally Posted by rued View Post
email template for email_template_wp_callback.html missing, giving big nasty error twice on top of sites when returning to shop:
That was caused by the lack of an email template for HTML messages, strangely that shouldn't have got through the system as it must be very configuration specific as although I can trace it (and have fixed it), I've never seen that myself and my default test user is set to receive HTML emails. My guess is that your version is displaying the error->messagestack and for some reason mine has this disabled to the "public". That's curious as I've installed this module on at least 9 servers for people from this forum and I've not seen it on any installation.

Quote Originally Posted by rued View Post
Modules core files and language files is in UTF-8, causing problems for most shops with t.ex. latin languages, since Zen Cart up to 1.3.8 is iso-8859-1 as default (will change in 1.4 to UTF-8).
I have saved the templates into IS0-8859-1 BUT I think it will make no difference. I did a byte count of the pages and in UTF-8 and ISO-8859-1 they came up identical and I can see massive implications for the future (not just in this module). My theory is that in this case when the page is pulled from the shop and displayed at WorldPay, then worldpay is setting a header for UTF-8 but the shop's main text is in ISO-8859-1 and so some characters are getting mangled. I would need a VOLUNTEER (I do not need direct access to a merchant account or to admin or to having the site in test mode as I can fake all that) to prove this, but the big implications are that for years people have been editing the pages and storing all the information in a MySQL Latin-1 charset database (or getting paypal info back into the DB as a windows charset) and all that information is going to be pulled out in ZC 1.4 and displayed on a UTF-8 page.

Anyway, the fix for the email issue has been done along with the conversion to ISO... though I don't think it will make much of a difference. It's been submitted to the downloads page, but early adopters can get it here:

http://########################.co.uk/WorldPay_ZC1.3.x_v2.05.zip

I shall await a volunteer to see if there's anything I can do about the character set display.

Philip.