Stock by Attributes failure on add value for *All* atrributes

[trentham]

I've installed Stock by Attributes (4.7) into my Zencart (1.3.8a) and mostly it's working fine except that when I click on 'Add quantity for product variant' and leave the attribute set to 'All', enter a stock value and then click on 'Submit' I get the error message

"Warning: Cannot modify header information - headers already sent by ..... functions/general.php on line 21"

The line which was sent (and so stopping headers being sent was something like "att: 467|482|497|512|451" (maybe a piece of debug information???).

It looks like this occurs in admin/products_with_attributes_stock.php on line 193.

The operation works correctly, it just can't get back to the proper page.

Does anyone know if this is indeed a remnant of development debugging and whether it can be safely removed?

[trentham]

I'll take that as a "no" then!

I've commented out the line with no apparent problems. It simply works now.

I assume that it was simply never tested fully.

Mind you, I do think that this addon should be part of the core product. What;s the point of having stock levels if they can't be controlled at attribute level?!

[bigbadboy]

I reported the exact same problem/ bug/ error but had no reply.

I'll try your solution and see if it works for me.

edit: yup, worked for me as well.
One thing to check - Have you got any read only attributes set, something like 'Please select' (so that it shows on the list)?
I noticed that this also gets added to and might be the problem.

[kuroi]

I'll take that as a "no" then!

Actually it's a yes, but you looked in the wrong place. There's a long support thread for the mod and the answer was in there. Posting away from the support threads for this type of module has a high risk that your question will get overlooked by the people who use and know the mod.

I've commented out the line with no apparent problems. It simply works now. I assume that it was simply never tested fully.

That's safe to do. You're actually using the 4.7MULTIADD variant, which did appear to be submitted in a rather raw form, in contrast to 4.7 and preceding versions, which were very heavily tested (I have to declare a bias on that).

Mind you, I do think that this addon should be part of the core product. What;s the point of having stock levels if they can't be controlled at attribute level?!

That has long formed an important part of the next major release of Zen Cart.