Discreet Order "office only" comments Module

[philip_clarke]

Hi Philip,

Hope your well.

I installed this new SBD Discreet but i seem to have a problem. Is this written for 1.3.8a ? because i'm running 1.3.7.1 and i get the following message in the orders.php page under
Customer
Comments


Fatal error: Call to undefined function: zen_get_orders_comments() in /public_html/shop/admin/orders.php on line 863

And yes i went into Tools/ SBD Discreet and installed it :)

This is line 863 in orders.php

<td class="dataTableContent" align="center"><?php echo (zen_get_orders_comments($orders->fields['orders_id']) == '' ? '' : zen_image(DIR_WS_IMAGES . 'icon_yellow_on.gif', TEXT_COMMENTS_YES, 16, 16)); ?></td>

The script stops running right there and doesn't write anymore of the page.

Thanks , Lake

Great debugging and analysis as normal, it's been fixed and an extra function added to bring the ordering side of things of 1.3.7.1 up to 1.3.8.a (displays a little yellow square if a customer had left a comment !).

File is here:

http://########################.co.uk/SBD_Discreet_ZC1.3.x_v0.6.zip

Thank you.

[Merlinpa1969]

I wasnt degrading your mod at all,
just explaining how and why.....

[philip_clarke]

I wasnt degrading your mod at all,
just explaining how and why.....

Likewise, you obviously saw a need too and way before me, I called mine discreet because as a shop owner, I had been exceptionally indiscreet on my order comments.

The fix I just made for bigenuf raises an interesting point though, the difference in order page between 1.3.7.1 andZC 1.3.8 is that there is a little yellow gif stating that there are customer comments, and then on the packing slip and invoice the first comment from TABLE_ORDERS_STATUS_HISTORY is displayed. But whatis missing in 1.3.8 is in the infobox, the Comments section is empty, at lest on my version of 1.3.8 it is, when I feel sure that at some point with the spread of the rest of the comments, that it should be filled out.

Also with regards to your mod, I don't know what people install, I only know what I would like for the add-ons that I am responsible for (I ended up taking over WorldPay after the blessing of the original developer when I found an exploit, and going through the thread, everyone wanted a comparison between billing address sent to worldpay and what was actually typed in, as well as the various extra fraud warnings thats are given.) and so I'll be adding super_order compatibility to mine as well. I'm not looking to replace anything, just to enhance things my way and in the same manner as my workflow.

[philip_clarke]

I believe that when zencart was upgraded from 1.3.7 to 1.3.8 that there was an omission. Customer order comments are makred in admin/orders.php with a yellow square, the comments appear on the order, they appear on the invoices and packing slips. but although half set up, they don't appeared on the page where the yellow square is displayed even though the comments in the page suggest that this was the purpose. From orders.php line 874 I have:

// indicate if comments exist
      $orders_history_query = $db->Execute("select orders_status_id, date_added, customer_notified, comments from " . TABLE_ORDERS_STATUS_HISTORY . " where orders_id = '" . $oInfo->orders_id . "' and comments !='" . "'" );
      if ($orders_history_query->RecordCount() > 0) {
        $contents[] = array('align' => 'left', 'text' => '<br />' . TABLE_HEADING_COMMENTS);
      }

whereas I believe it should be this in 1.3.8+

// indicate if comments exist
      $orders_history_query = zen_get_orders_comments($oInfo->orders_id);
      if ($orders_history_query!='') {
        $contents[] = array('align' => 'left', 'text' => '<br />' . TABLE_HEADING_COMMENTS.':');
        $contents[] = array('align' => 'left', 'text' => zen_get_orders_comments($oInfo->orders_id));
      }

Which would match the rest of the upgrades and justify the existence of the new function.
Thank you
Philip.

[Bigenuf]

Great debugging and analysis as normal, it's been fixed and an extra function added to bring the ordering side of things of 1.3.7.1 up to 1.3.8.a (displays a little yellow square if a customer had left a comment !).

File is here:

http://########################.co.uk/SBD_Discreet_ZC1.3.x_v0.6.zip

Thank you.

Philip,

Seems to work like a dream

Cheers ,
Lake

[philip_clarke]

As promised I have added Super Orders 2.0 rev 46 compatibility and reported a bug, plus fixed it on this version. This versions is ZC 1.3.7.1 and 1.3.8(a) compatible, with it bringing the orders.php of 1.3.7.1 up to 1.3.8 specification. Thank you

http://########################.co.uk/SBD_Discreet_ZC1.3.x_v0.7.zip

This does not really need a remove and install if upgrading, it would just show the wrong version number, since overwriting the files is enough. Same instructions for any modules I make, the documentation is stored in the docs folder to save overwriting any ZC installation files.

Philip.

[brushwoodnursery]

I also spent a long time including comments that ended up in customers' order history on my shop. Guess I never read the instructions carefully! I'd like to fix this with my new zen store. However, I really prefer Edit Orders over Super Orders since I can update more. (many of my customers change lots of info between order and shipping dates)
I'd also prefer your solution to keep it simple.

Is there a chance you can whip up a file for this like you've done with Super? I'd really appreciate it!

[philip_clarke]

Is there a chance you can whip up a file for this like you've done with Super? I'd really appreciate it!

I'll see what I can do.

[brushwoodnursery]

Very kind of you!

[philip_clarke]

This is the states of play so far.

On my installation 1.3.8a, (the first time I have used edit orders and I may have mis-installed something), I access edit_order.php (after having done the readme) by going through ADMIN> CUSTOMERS> ORDERS clicking on the "details" button, BUT I can access the old orders.php page (where the "discreet" module currently works) by clicking on the row on the little "e". so "discreet" comments can still be added while I knock up an optional version of "Edit Orders" (which interestingly appears to have a javascript bug that I'll fix too).